homebridge-melcloud-control 4.0.0-beta.446 → 4.0.0-beta.447

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.0.0-beta.446",
+  "version": "4.0.0-beta.447",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/functions.js

@@ -2,7 +2,6 @@ import fs from 'fs';
 import util from 'util';
 import { exec } from 'child_process';
 import { promises as fsPromises } from 'fs';
-import puppeteer from 'puppeteer';
 import EventEmitter from 'events';
 const access = util.promisify(fs.access);
 const execPromise = util.promisify(exec);
@@ -59,31 +58,31 @@ class Functions extends EventEmitter {
         let chromiumPath = '/usr/bin/chromium-browser';
 
         try {
-            // --- Detect architecture ---
+            // Detect architecture
             const { stdout: archOut } = await execPromise('uname -m');
             const arch = archOut.trim();
             if (this.logDebug) this.emit('debug', `Detected architecture: ${arch}`);
 
-            // --- Detect OS ---
+            // Detect OS
             const { stdout: osOut } = await execPromise('uname -s');
             const osName = osOut.trim();
             if (this.logDebug) this.emit('debug', `Detected OS: ${osName}`);
 
-            // --- macOS fallback ---
+            // macOS fallback
             if (osName === 'Darwin') {
                 chromiumPath = '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome';
 
                 try {
                     await access(chromiumPath, fs.constants.X_OK);
                     if (this.logDebug) this.emit('debug', `Using system Chrome at ${chromiumPath}`);
+                    return chromiumPath;
                 } catch {
-                    if (this.logError) this.emit('error', 'System Chrome not found. Falling back to Puppeteer bundled Chromium.');
-                    chromiumPath = puppeteer.executablePath();
+                    if (this.logError) this.emit('error', 'System Chrome not found, using builtin chrome.');
+                    return null;
                 }
-                return chromiumPath;
             }
 
-            // --- Linux distro detection ---
+            // Linux distro detection
             let linuxDistro = 'unknown';
             try {
                 const { stdout: distroOut } = await execPromise('cat /etc/os-release');
@@ -93,7 +92,7 @@ class Functions extends EventEmitter {
             }
             if (this.logDebug) this.emit('debug', `Linux distro: ${linuxDistro}`);
 
-            // --- Check if Chromium exists ---
+            // Check if Chromium exists
             let chromiumCheck = '';
             try {
                 const { stdout: checkOut } = await execPromise('which chromium || which chromium-browser || true');
@@ -107,7 +106,7 @@ class Functions extends EventEmitter {
 
             if (this.logWarn) this.emit('warn', 'Chromium not found. Attempting installation...');
 
-            // --- apt-get ---
+            // apt-get
             try {
                 await execPromise('sudo apt-get update -y && sudo apt-get install -y chromium-browser chromium-codecs-ffmpeg');
                 if (this.logDebug) this.emit('debug', 'Chromium installed successfully via apt-get.');
@@ -116,7 +115,7 @@ class Functions extends EventEmitter {
                 if (this.logError) this.emit('error', 'apt-get install failed. Trying apk or yum...');
             }
 
-            // --- apk (Alpine) ---
+            // apk (Alpine)
             try {
                 await execPromise('sudo apk add --no-cache chromium ffmpeg');
                 if (this.logDebug) this.emit('debug', 'Chromium installed successfully via apk.');
@@ -125,7 +124,7 @@ class Functions extends EventEmitter {
                 if (this.logError) this.emit('error', 'apk install failed. Trying yum...');
             }
 
-            // --- yum (RHEL/CentOS) ---
+            // yum (RHEL/CentOS)
             try {
                 await execPromise('sudo yum install -y chromium chromium-codecs-ffmpeg');
                 if (this.logDebug) this.emit('debug', 'Chromium installed successfully via yum.');
@@ -134,25 +133,10 @@ class Functions extends EventEmitter {
                 if (this.logError) this.emit('error', 'yum install failed. Falling back to Puppeteer bundled Chromium.');
             }
 
-            // --- Fallback Puppeteer ---
-            chromiumPath = puppeteer.executablePath();
-            if (this.logDebug) this.emit('debug', `Using bundled Puppeteer Chromium at ${chromiumPath || 'not found'}`);
             return chromiumPath;
-
         } catch (error) {
             throw new Error(`Chromium detection/install error: ${error.message}`);
         }
     }
-
-
-    async isRunningInDocker() {
-        try {
-            if (fs.existsSync('/.dockerenv')) return true;
-            const cgroup = fs.readFileSync('/proc/1/cgroup', 'utf8');
-            return cgroup.includes('docker') || cgroup.includes('kubepods');
-        } catch {
-            return false;
-        }
-    }
 }
 export default Functions

package/src/melcloud.js

@@ -333,7 +333,7 @@ class MelCloud extends EventEmitter {
             const chromiumPath = await this.functions.ensureChromiumInstalled();
             browser = await puppeteer.launch({
                 headless: true,
-                executablePath: chromiumPath,
+                executablePath: chromiumPath || puppeteer.executablePath(),
                 args: [
                     '--no-sandbox',
                     '--disable-setuid-sandbox',
@@ -427,7 +427,6 @@ class MelCloud extends EventEmitter {
 
             if (!refresh) this.emit('success', 'Connect to MELCloud Home Success');
             return accountInfo;
-
         } catch (error) {
             throw new Error(`Connect error: ${error.message}`);
         } finally {