homebridge-melcloud-control 4.0.0-beta.412 → 4.0.0-beta.414

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.0.0-beta.412",
+  "version": "4.0.0-beta.414",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/melcloud.js

@@ -73,7 +73,7 @@ class MelCloud extends EventEmitter {
             const listDevicesData = await axiosInstance.get(ApiUrls.ListDevices);
 
             if (!listDevicesData || !listDevicesData.data) {
-                this.emit('warn', `Invalid or empty response from MELCloud API`);
+                if (this.logWarn) this.emit('warn', `Invalid or empty response from MELCloud API`);
                 return null;
             }
 
@@ -83,7 +83,7 @@ class MelCloud extends EventEmitter {
                 this.emit('debug', `Buildings: ${JSON.stringify(buildingsList, null, 2)}`);
 
             if (!Array.isArray(buildingsList) || buildingsList.length === 0) {
-                this.emit('warn', `No buildings found in MELCloud account`);
+                if (this.logWarn) this.emit('warn', `No buildings found in MELCloud account`);
                 return null;
             }
 
@@ -129,7 +129,7 @@ class MelCloud extends EventEmitter {
             }
 
             if (devices.length === 0) {
-                this.emit('warn', `No devices found in any building`);
+                if (this.logWarn) this.emit('warn', `No devices found in any building`);
                 return null;
             }
 
@@ -331,25 +331,29 @@ class MelCloud extends EventEmitter {
         try {
             browser = await puppeteer.launch({
                 headless: true,
-                args: ['--no-sandbox', '--disable-setuid-sandbox']
+                args: [
+                    '--no-sandbox',
+                    '--disable-setuid-sandbox',
+                    '--disable-dev-shm-usage',
+                    '--single-process',
+                    '--no-zygote'
+                ]
             });
 
             const page = await browser.newPage();
 
-            // Emit page errors to logs
-            page.on('error', err => this.emit('warn', `Page crashed: ${err.message}`));
-            page.on('pageerror', err => this.emit('warn', `Browser error: ${err.message}`));
+            page.on('error', err => this.emit('error', `Page crashed: ${err.message}`));
+            page.on('pageerror', err => this.emit('error', `Browser error: ${err.message}`));
+            page.on('close', () => this.emit('debug', 'Page was closed unexpectedly'));
+            browser.on('disconnected', () => this.emit('debug', 'Browser disconnected unexpectedly'));
 
-            await page.goto(ApiUrlsHome.BaseURL, { waitUntil: ['domcontentloaded', 'networkidle2'] });
+            page.setDefaultTimeout(30000);
+            page.setDefaultNavigationTimeout(30000);
 
-            // Ensure login button is visible
-            await page.waitForSelector('button.btn--blue', { timeout: 10000 }).catch(() => {
-                throw new Error('Login button not found on MELCloud Home');
-            });
+            await page.goto(ApiUrlsHome.BaseURL, { waitUntil: ['domcontentloaded', 'networkidle2'] });
 
             const buttons = await page.$$('button.btn--blue');
             let loginBtn = null;
-
             for (const btn of buttons) {
                 const text = await page.evaluate(el => el.textContent.trim(), btn);
                 if (['Zaloguj', 'Sign In', 'Login'].includes(text)) {
@@ -357,44 +361,70 @@ class MelCloud extends EventEmitter {
                     break;
                 }
             }
+            if (!loginBtn) {
+                if (this.logWarn) this.emit('warn', 'Login button not found');
+                return null;
+            }
 
-            if (!loginBtn) throw new Error('Login button not found (no matching text)');
-
-            if (this.logDebug) this.emit('debug', `Clicking login button...`);
+            if (page.isClosed()) {
+                if (this.logWarn) this.emit('warn', 'Page closed before login click');
+                return null;
+            }
 
-            await Promise.all([
-                loginBtn.click(),
-                page.waitForNavigation({ waitUntil: ['domcontentloaded', 'networkidle2'], timeout: 15000 })
+            await Promise.race([
+                Promise.all([
+                    loginBtn.click(),
+                    page.waitForNavigation({ waitUntil: ['domcontentloaded', 'networkidle2'], timeout: 15000 })
+                ]),
+                new Promise(r => setTimeout(r, 12000))
             ]);
 
-            await page.waitForSelector('input[name="username"]', { timeout: 10000 });
+            const usernameInput = await page.$('input[name="username"]');
+            const passwordInput = await page.$('input[name="password"]');
+            if (!usernameInput || !passwordInput) {
+                if (this.logWarn) this.emit('warn', 'Username or password input not found');
+                return null;
+            }
+
+            if (page.isClosed()) {
+                if (this.logWarn) this.emit('warn', 'Page closed before typing credentials');
+                return null;
+            }
+
             await page.type('input[name="username"]', this.user, { delay: 50 });
             await page.type('input[name="password"]', this.passwd, { delay: 50 });
 
-            // Handle possible "Show password" overlays
             const submitButton = await page.$('input[type="submit"], button[type="submit"]');
-            if (!submitButton) throw new Error('Submit button not found on login form');
+            if (!submitButton) {
+                if (this.logWarn) this.emit('warn', 'Submit button not found on login form');
+                return null;
+            }
 
-            if (this.logDebug) this.emit('debug', `Submitting credentials...`);
+            if (page.isClosed()) {
+                if (this.logWarn) this.emit('warn', 'Page closed before submitting form');
+                return null;
+            }
 
-            await Promise.all([
-                submitButton.click(),
-                page.waitForNavigation({ waitUntil: ['domcontentloaded', 'networkidle2'], timeout: 20000 })
+            await Promise.race([
+                Promise.all([
+                    submitButton.click(),
+                    page.waitForNavigation({ waitUntil: ['domcontentloaded', 'networkidle2'], timeout: 20000 })
+                ]),
+                new Promise(r => setTimeout(r, 15000))
             ]);
 
-            // Check for login errors
             const pageText = await page.content();
             if (pageText.includes('incorrect') || pageText.includes('Invalid') || pageText.includes('nieprawidłowe')) {
-                throw new Error('Login failed: incorrect email or password');
+                if (this.logWarn) this.emit('warn', 'Login failed: incorrect email or password');
+                return null;
             }
 
-            // Check for CAPTCHA
             const captchaPresent = await page.$('iframe[src*="captcha"], div[class*="captcha"]');
             if (captchaPresent) {
-                throw new Error('Login blocked by CAPTCHA. Manual verification required.');
+                if (this.logWarn) this.emit('warn', 'Login blocked by CAPTCHA. Manual verification required.');
+                return null;
             }
 
-            // Extract cookies with retry mechanism
             let c1 = null, c2 = null;
             const start = Date.now();
             while ((!c1 || !c2) && Date.now() - start < 20000) {
@@ -404,7 +434,10 @@ class MelCloud extends EventEmitter {
                 if (!c1 || !c2) await new Promise(r => setTimeout(r, 500));
             }
 
-            if (!c1 || !c2) throw new Error('Cookies C1/C2 missing after login');
+            if (!c1 || !c2) {
+                if (this.logWarn) this.emit('warn', 'Cookies C1/C2 missing after login');
+                return null;
+            }
 
             const contextKey = [
                 '__Secure-monitorandcontrol=chunks-2',
@@ -420,10 +453,10 @@ class MelCloud extends EventEmitter {
 
             return accountInfo;
         } catch (error) {
-            // Handle Puppeteer system dependency errors
+            // Puppeteer / system error handling
             if (error.message.includes('libnspr4.so') || error.message.includes('Failed to launch the browser process')) {
                 const inDocker = await this.functions.isRunningInDocker();
-                this.emit('warn', `Missing system libraries detected.`);
+                if (this.logError) this.emit('error', `Missing system libraries detected.`);
 
                 const installCmd =
                     'apt-get update && apt-get install -y ' +
@@ -432,8 +465,9 @@ class MelCloud extends EventEmitter {
                     'libgbm1 libasound2 libxshmfence1 fonts-liberation libappindicator3-1 libu2f-udev';
 
                 if (inDocker) {
-                    this.emit('warn', `Running in Docker — attempting automatic fix...`);
+                    if (this.logWarn) this.emit('warn', `Running in Docker — attempting automatic fix...`);
                     try {
+                        const { execSync } = require('child_process');
                         execSync(installCmd, { stdio: 'inherit' });
                         this.emit('success', `System libraries installed. Retry the connection.`);
                         return true;
@@ -445,14 +479,14 @@ class MelCloud extends EventEmitter {
                 }
             }
 
-            // Generic Puppeteer error
+            // Only throw for real technical errors
             throw new Error(`Connect error: ${error.message}`);
         } finally {
             if (browser) {
                 try {
                     await browser.close();
                 } catch (closeErr) {
-                    this.emit('warn', `Failed to close Puppeteer browser: ${closeErr.message}`);
+                    if (this.logError) this.emit('error', `Failed to close Puppeteer browser: ${closeErr.message}`);
                 }
             }
         }

package/src/melcloudhometoken.js

@@ -59,7 +59,7 @@ class MelCloudHomeToken extends EventEmitter {
             const csrf = dom.window.document.querySelector('input[name="_csrf"]')?.value;
 
             if (!csrf) {
-                this.emit('warn', 'CSRF token not found');
+                if (this.logWarn) this.emit('warn', 'CSRF token not found');
                 return null;
             }
 
@@ -85,7 +85,7 @@ class MelCloudHomeToken extends EventEmitter {
             });
 
             if (response.status === 400) {
-                this.emit('warn', `Login failed: ${response.data}`);
+                if (this.logWarn) this.emit('warn', `Login failed: ${response.data}`);
                 return null;
             }
 
@@ -106,7 +106,7 @@ class MelCloudHomeToken extends EventEmitter {
             return code || null;
 
         } catch (err) {
-            this.emit('warn', `loginToMelCloudHome error: ${err}`);
+            if (this.logWarn) this.emit('warn', `loginToMelCloudHome error: ${err}`);
             return null;
         }
     }
@@ -120,7 +120,7 @@ class MelCloudHomeToken extends EventEmitter {
                 if (locationHeader && locationHeader.startsWith('melcloudhome://')) {
                     const match = locationHeader.match(/[?&]code=([^&]+)/);
                     if (match) {
-                        this.emit('warn', `Found code in Location header: ${match[1]}`);
+                        if (this.logWarn) this.emit('warn', `Found code in Location header: ${match[1]}`);
                         resolve(match[1]);
                         return;
                     }
@@ -132,14 +132,14 @@ class MelCloudHomeToken extends EventEmitter {
                 const formActionMatch = data.match(/action="([^"]+)"/);
 
                 if (formCodeMatch && formStateMatch && formActionMatch) {
-                    this.emit('warn', 'Found form_post, submitting...');
+                    if (this.logWarn) this.emit('warn', 'Found form_post, submitting...');
                     try {
                         const code = await this.submitFormPost(formActionMatch[1], formCodeMatch[1], formStateMatch[1]);
-                        this.emit('warn', `submitFormPost returned code: ${code}`);
+                        if (this.logWarn) this.emit('warn', `submitFormPost returned code: ${code}`);
                         resolve(code);
                         return;
                     } catch (err) {
-                        this.emit('warn', `submitFormPost failed: ${err}`);
+                        if (this.logWarn) this.emit('warn', `submitFormPost failed: ${err}`);
                         reject(err);
                         return;
                     }
@@ -148,29 +148,29 @@ class MelCloudHomeToken extends EventEmitter {
                 // 3️⃣ JS redirect in body
                 const bodyCodeMatch = data.match(/melcloudhome:\/\/[^"'\s]*[?&]code=([^&"'\s]+)/);
                 if (bodyCodeMatch) {
-                    this.emit('warn', `Found code in body: ${bodyCodeMatch[1]}`);
+                    if (this.logWarn) this.emit('warn', `Found code in body: ${bodyCodeMatch[1]}`);
                     resolve(bodyCodeMatch[1]);
                     return;
                 }
 
                 // 4️⃣ Follow redirect
                 if (locationHeader && ['301', '302', '303'].includes(headers['status'] || '')) {
-                    this.emit('warn', `Following redirect to ${locationHeader}`);
+                    if (this.logWarn) this.emit('warn', `Following redirect to ${locationHeader}`);
                     try {
                         const code = await followRedirect(locationHeader);
                         resolve(code);
                         return;
                     } catch (err) {
-                        this.emit('warn', `Follow redirect failed: ${err}`);
+                        if (this.logWarn) this.emit('warn', `Follow redirect failed: ${err}`);
                         reject(err);
                         return;
                     }
                 }
 
-                this.emit('warn', 'Authorization code not found in response');
+                if (this.logWarn) this.emit('warn', 'Authorization code not found in response');
                 reject(new Error('Authorization code not found'));
             } catch (err) {
-                this.emit('warn', `extractCodeFromResponse error: ${err}`);
+                if (this.logWarn) this.emit('warn', `extractCodeFromResponse error: ${err}`);
                 reject(err);
             }
         });
@@ -178,7 +178,7 @@ class MelCloudHomeToken extends EventEmitter {
 
     async submitFormPost(actionUrl, code, state) {
         const formData = new URLSearchParams({ code, state });
-        this.emit('warn', `Submitting form_post to ${actionUrl}`);
+        if (this.logWarn) this.emit('warn', `Submitting form_post to ${actionUrl}`);
         const res = await this.client.post(actionUrl, formData.toString(), {
             headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
             maxRedirects: 0,
@@ -191,7 +191,7 @@ class MelCloudHomeToken extends EventEmitter {
             if (match) return match[1];
         }
 
-        this.emit('warn', 'Code not found after form_post submission');
+        if (this.logWarn) this.emit('warn', 'Code not found after form_post submission');
         throw new Error('Code not found after form_post submission');
     }
 
@@ -213,7 +213,7 @@ class MelCloudHomeToken extends EventEmitter {
             });
 
             const tokens = tokenResponse.data;
-            this.emit('warn', `Token obtained: ${JSON.stringify(tokens)}`);
+            if (this.logWarn) this.emit('warn', `Token obtained: ${JSON.stringify(tokens)}`);
             return tokens;
 
         } catch (err) {

package/src/restful.js

@@ -65,7 +65,7 @@ class RestFul extends EventEmitter {
 
             // Start the server
             app.listen(this.port, () => {
-                this.emit('connected', `RESTful started on port: ${this.restFulPort}`);
+                this.emit('connected', `RESTful started on port: ${this.port}`);
             });
         } catch (error) {
             if (this.logWarn) this.emit('warn', `RESTful Connect error: ${error}`);