homebridge-melcloud-control 3.9.4 → 3.9.6

package/CHANGELOG.md

@@ -16,6 +16,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - do not configure it manually, always using Config UI X
   - required Homebridge v2.0.0 and above
 
+## [3.9.5] - (02.09.2025)
+
+## Changes
+
+- fix ERV start error
+
+## [3.9.4] - (02.09.2025)
+
+## Changes
+
+- fix [#213](https://github.com/grzegorz914/homebridge-melcloud-control/issues/213)
+
 ## [3.9.0] - (18.08.2025)
 
 ## Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.9.4",
+  "version": "3.9.6",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -46,8 +46,8 @@ class DeviceAta extends EventEmitter {
         //presets configured
         this.presetsConfigured = [];
         for (const preset of this.presets) {
-            const displayType = preset.displayType ?? 0;
-            if (displayType === 0) {
+            const displayType = preset.displayType;
+            if (!displayType) {
                 continue;
             };
 
@@ -65,8 +65,8 @@ class DeviceAta extends EventEmitter {
         //buttons configured
         this.buttonsConfigured = [];
         for (const button of this.buttons) {
-            const displayType = button.displayType ?? 0;
-            if (displayType === 0) {
+            const displayType = button.displayType;
+            if (!displayType) {
                 continue;
             };
 
@@ -1128,19 +1128,17 @@ class DeviceAta extends EventEmitter {
                             };
 
                             //update characteristics
-                            if (this.melCloudService) {
-                                this.melCloudService
-                                    .updateCharacteristic(Characteristic.Active, power ? 1 : 0)
-                                    .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, obj.currentOperationMode)
-                                    .updateCharacteristic(Characteristic.TargetHeaterCoolerState, obj.targetOperationMode)
-                                    .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                                    .updateCharacteristic(Characteristic.LockPhysicalControls, obj.lockPhysicalControl)
-                                    .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit)
-                                    .updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature);
-                                const updateDefHeat = modelSupportsHeat ? this.melCloudService.updateCharacteristic(Characteristic.HeatingThresholdTemperature, defaultHeatingSetTemperature) : false;
-                                const updateRS = modelSupportsFanSpeed ? this.melCloudService.updateCharacteristic(Characteristic.RotationSpeed, obj.fanSpeed) : false;
-                                const updateSM = swingFunction ? this.melCloudService.updateCharacteristic(Characteristic.SwingMode, obj.swingMode) : false;
-                            };
+                            this.melCloudService
+                                ?.updateCharacteristic(Characteristic.Active, power ? 1 : 0)
+                                .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, obj.currentOperationMode)
+                                .updateCharacteristic(Characteristic.TargetHeaterCoolerState, obj.targetOperationMode)
+                                .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
+                                .updateCharacteristic(Characteristic.LockPhysicalControls, obj.lockPhysicalControl)
+                                .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit)
+                                .updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature);
+                            const updateDefHeat = modelSupportsHeat ? this.melCloudService?.updateCharacteristic(Characteristic.HeatingThresholdTemperature, defaultHeatingSetTemperature) : false;
+                            const updateRS = modelSupportsFanSpeed ? this.melCloudService?.updateCharacteristic(Characteristic.RotationSpeed, obj.fanSpeed) : false;
+                            const updateSM = swingFunction ? this.melCloudService?.updateCharacteristic(Characteristic.SwingMode, obj.swingMode) : false;
                             break;
                         case 2: //Thermostat
                             switch (operationMode) {
@@ -1188,27 +1186,18 @@ class DeviceAta extends EventEmitter {
                             obj.operationModeSetPropsValidValues = modelSupportsAuto && modelSupportsHeat ? [0, 1, 2, 3] : !modelSupportsAuto && modelSupportsHeat ? [0, 1, 2] : modelSupportsAuto && !modelSupportsHeat ? [0, 2, 3] : [0, 2];
 
                             //update characteristics
-                            if (this.melCloudService) {
-                                this.melCloudService
-                                    .updateCharacteristic(Characteristic.CurrentHeatingCoolingState, obj.currentOperationMode)
-                                    .updateCharacteristic(Characteristic.TargetHeatingCoolingState, obj.targetOperationMode)
-                                    .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                                    .updateCharacteristic(Characteristic.TargetTemperature, setTemperature)
-                                    .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
-                            };
+                            this.melCloudService
+                                ?.updateCharacteristic(Characteristic.CurrentHeatingCoolingState, obj.currentOperationMode)
+                                .updateCharacteristic(Characteristic.TargetHeatingCoolingState, obj.targetOperationMode)
+                                .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
+                                .updateCharacteristic(Characteristic.TargetTemperature, setTemperature)
+                                .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
                             break;
                     };
                     this.accessory = obj;
 
-                    if (this.roomTemperatureSensorService) {
-                        this.roomTemperatureSensorService
-                            .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                    };
-
-                    if (this.outdoorTemperatureSensorService) {
-                        this.outdoorTemperatureSensorService
-                            .updateCharacteristic(Characteristic.CurrentTemperature, outdoorTemperature)
-                    };
+                    this.roomTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature);
+                    this.outdoorTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, outdoorTemperature);
 
                     //update presets state
                     if (this.presetsConfigured.length > 0) {
@@ -1222,11 +1211,8 @@ class DeviceAta extends EventEmitter {
                                 && presetData.VaneVertical === vaneVerticalDirection
                                 && presetData.FanSpeed === fanSpeed) : false;
 
-                            if (this.presetsServices) {
-                                const characteristicType = preset.characteristicType;
-                                this.presetsServices[i]
-                                    .updateCharacteristic(characteristicType, preset.state)
-                            };
+                            const characteristicType = preset.characteristicType;
+                            this.presetsServices?.[i]?.updateCharacteristic(characteristicType, preset.state);
                         });
                     };
 
@@ -1346,11 +1332,8 @@ class DeviceAta extends EventEmitter {
                             };
 
                             //update services
-                            if (this.buttonsServices) {
-                                const characteristicType = button.characteristicType;
-                                this.buttonsServices[i]
-                                    .updateCharacteristic(characteristicType, button.state)
-                            };
+                            const characteristicType = button.characteristicType;
+                            this.buttonsServices?.[i]?.updateCharacteristic(characteristicType, button.state);
                         });
                     };
 

package/src/deviceatw.js

@@ -51,8 +51,8 @@ class DeviceAtw extends EventEmitter {
         //presets configured
         this.presetsConfigured = [];
         for (const preset of this.presets) {
-            const displayType = preset.displayType ?? 0;
-            if (displayType === 0) {
+            const displayType = preset.displayType;
+            if (!displayType) {
                 continue;
             };
 
@@ -70,8 +70,8 @@ class DeviceAtw extends EventEmitter {
         //buttons configured
         this.buttonsConfigured = [];
         for (const button of this.buttons) {
-            const displayType = button.displayType ?? 0;
-            if (displayType === 0) {
+            const displayType = button.displayType;
+            if (!displayType) {
                 continue;
             };
 
@@ -271,7 +271,6 @@ class DeviceAtw extends EventEmitter {
         };
     }
 
-
     async startImpulseGenerator() {
         try {
             //start impule generator
@@ -1564,17 +1563,14 @@ class DeviceAtw extends EventEmitter {
                                 };
 
                                 //update characteristics
-                                if (this.melCloudServices) {
-                                    this.melCloudServices[i]
-                                        .updateCharacteristic(Characteristic.Active, power)
-                                        .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, currentOperationMode)
-                                        .updateCharacteristic(Characteristic.TargetHeaterCoolerState, targetOperationMode)
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                                        .updateCharacteristic(Characteristic.LockPhysicalControls, lockPhysicalControl)
-                                        .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
-                                    const updateDefCool = heatCoolModes === 0 || heatCoolModes === 2 ? this.melCloudServices[i].updateCharacteristic(Characteristic.CoolingThresholdTemperature, setTemperature) : false;
-                                    const updateDefHeat = heatCoolModes === 0 || heatCoolModes === 1 ? this.melCloudServices[i].updateCharacteristic(Characteristic.HeatingThresholdTemperature, setTemperature) : false;
-                                }
+                                this.melCloudServices?.[i]
+                                    ?.updateCharacteristic(Characteristic.Active, power)
+                                    .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, currentOperationMode)
+                                    .updateCharacteristic(Characteristic.TargetHeaterCoolerState, targetOperationMode)
+                                    .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
+                                    .updateCharacteristic(Characteristic.LockPhysicalControls, lockPhysicalControl)
+                                    .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
+                                const updateDefCool = heatCoolModes === 0 || heatCoolModes === 2 ? this.melCloudServices?.[i]?.updateCharacteristic(Characteristic.CoolingThresholdTemperature, setTemperature) : false;
                                 break;
                             case 2: //Thermostat
                                 switch (i) {
@@ -1671,14 +1667,12 @@ class DeviceAtw extends EventEmitter {
                                 };
 
                                 //update characteristics
-                                if (this.melCloudServices) {
-                                    this.melCloudServices[i]
-                                        .updateCharacteristic(Characteristic.CurrentHeatingCoolingState, currentOperationMode)
-                                        .updateCharacteristic(Characteristic.TargetHeatingCoolingState, targetOperationMode)
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                                        .updateCharacteristic(Characteristic.TargetTemperature, setTemperature)
-                                        .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
-                                }
+                                this.melCloudServices?.[i]
+                                    ?.updateCharacteristic(Characteristic.CurrentHeatingCoolingState, currentOperationMode)
+                                    .updateCharacteristic(Characteristic.TargetHeatingCoolingState, targetOperationMode)
+                                    .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
+                                    .updateCharacteristic(Characteristic.TargetTemperature, setTemperature)
+                                    .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
                                 break;
                         };
 
@@ -1748,20 +1742,9 @@ class DeviceAtw extends EventEmitter {
                                 returnTemperature = returnTemperatureHeatPump;
 
                                 //updte characteristics
-                                if (this.roomTemperatureSensorService) {
-                                    this.roomTemperatureSensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, outdoorTemperature)
-                                };
-
-                                if (this.flowTemperatureSensorService) {
-                                    this.flowTemperatureSensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureHeatPump)
-                                };
-
-                                if (this.returnTemperatureSensorService) {
-                                    this.returnTemperatureSensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureHeatPump)
-                                };
+                                this.roomTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, outdoorTemperature);
+                                this.flowTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureHeatPump);
+                                this.returnTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureHeatPump);
                                 break;
                             case caseZone1Sensor: //Zone 1
                                 name = zone1Name;
@@ -1770,20 +1753,9 @@ class DeviceAtw extends EventEmitter {
                                 returnTemperature = returnTemperatureZone1;
 
                                 //updte characteristics
-                                if (this.roomTemperatureZone1SensorService) {
-                                    this.roomTemperatureZone1SensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperatureZone1)
-                                };
-
-                                if (this.flowTemperatureZone1SensorService) {
-                                    this.flowTemperatureZone1SensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureZone1)
-                                };
-
-                                if (this.returnTemperatureZone1SensorService) {
-                                    this.returnTemperatureZone1SensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureZone1)
-                                };
+                                this.roomTemperatureZone1SensorService?.updateCharacteristic(Characteristic.CurrentTemperature, roomTemperatureZone1);
+                                this.flowTemperatureZone1SensorService?.updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureZone1);
+                                this.returnTemperatureZone1SensorService?.updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureZone1);
                                 break;
                             case caseHotWaterSensor: //Hot Water
                                 name = hotWaterName;
@@ -1792,20 +1764,9 @@ class DeviceAtw extends EventEmitter {
                                 returnTemperature = returnTemperatureWaterTank;
 
                                 //updte characteristics
-                                if (this.roomTemperatureWaterTankSensorService) {
-                                    this.roomTemperatureWaterTankSensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, tankWaterTemperature)
-                                };
-
-                                if (this.flowTemperatureWaterTankSensorService) {
-                                    this.flowTemperatureWaterTankSensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureWaterTank)
-                                };
-
-                                if (this.returnTemperatureWaterTankSensorService) {
-                                    this.returnTemperatureWaterTankSensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureWaterTank)
-                                };
+                                this.roomTemperatureWaterTankSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, tankWaterTemperature);
+                                this.flowTemperatureWaterTankSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureWaterTank);
+                                this.returnTemperatureWaterTankSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureWaterTank);
                                 break;
                             case caseZone2Sensor: //Zone 2
                                 name = zone2Name;
@@ -1814,20 +1775,9 @@ class DeviceAtw extends EventEmitter {
                                 returnTemperature = returnTemperatureZone2;
 
                                 //updte characteristics
-                                if (this.roomTemperatureZone2SensorService) {
-                                    this.roomTemperatureZone2SensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperatureZone2)
-                                };
-
-                                if (this.flowTemperatureZone2SensorService) {
-                                    this.flowTemperatureZone2SensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureZone2)
-                                };
-
-                                if (this.returnTemperatureZone2SensorService) {
-                                    this.returnTemperatureZone2SensorService
-                                        .updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureZone2)
-                                };
+                                this.roomTemperatureZone2SensorService?.updateCharacteristic(Characteristic.CurrentTemperature, roomTemperatureZone2);
+                                this.flowTemperatureZone2SensorService?.updateCharacteristic(Characteristic.CurrentTemperature, flowTemperatureZone2);
+                                this.returnTemperatureZone2SensorService?.updateCharacteristic(Characteristic.CurrentTemperature, returnTemperatureZone2);
                                 break;
                         };
 
@@ -1886,18 +1836,14 @@ class DeviceAtw extends EventEmitter {
                                 && presetData.SetCoolFlowTemperatureZone1 === setCoolFlowTemperatureZone1
                                 && presetData.SetCoolFlowTemperatureZone2 === setCoolFlowTemperatureZone2) : false;
 
-                            if (this.presetsServices) {
-                                const characteristicType = preset.characteristicType;
-                                this.presetsServices[i]
-                                    .updateCharacteristic(characteristicType, preset.state)
-                            };
+                            const characteristicType = preset.characteristicType;
+                            this.presetsServices?.[i]?.updateCharacteristic(characteristicType, preset.state);
                         });
                     };
 
                     //update buttons state
                     if (this.buttonsConfiguredCount > 0) {
-                        for (let i = 0; i < this.buttonsConfiguredCount; i++) {
-                            const button = this.buttonsConfigured[i];
+                        this.buttonsConfigured.forEach((button, i) => {
                             const mode = button.mode;
                             switch (mode) {
                                 case 0: //POWER ON,OFF
@@ -1973,7 +1919,11 @@ class DeviceAtw extends EventEmitter {
                                     this.emit('warn', `Unknown button mode: ${mode} detected`);
                                     break;
                             };
-                        };
+
+                            //update services
+                            const characteristicType = button.characteristicType;
+                            this.buttonsServices?.[i]?.updateCharacteristic(characteristicType, button.state);
+                        });
                     };
                 })
                 .on('success', (success) => this.emit('success', success))

package/src/deviceerv.js

@@ -44,8 +44,8 @@ class DeviceErv extends EventEmitter {
         //presets configured
         this.presetsConfigured = [];
         for (const preset of this.presets) {
-            const displayType = preset.displayType ?? 0;
-            if (displayType === 0) {
+            const displayType = preset.displayType;
+            if (!displayType) {
                 continue;
             };
 
@@ -63,8 +63,8 @@ class DeviceErv extends EventEmitter {
         //buttons configured
         this.buttonsConfigured = [];
         for (const button of this.buttons) {
-            const displayType = button.displayType ?? 0;
-            if (displayType === 0) {
+            const displayType = button.displayType;
+            if (!displayType) {
                 continue;
             };
 
@@ -1038,18 +1038,16 @@ class DeviceErv extends EventEmitter {
                             };
 
                             //update characteristics
-                            if (this.melCloudService) {
-                                this.melCloudService
-                                    .updateCharacteristic(Characteristic.Active, power)
-                                    .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, obj.currentOperationMode)
-                                    .updateCharacteristic(Characteristic.TargetHeaterCoolerState, obj.targetOperationMode)
-                                    .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                                    .updateCharacteristic(Characteristic.RotationSpeed, obj.fanSpeed)
-                                    .updateCharacteristic(Characteristic.LockPhysicalControls, obj.lockPhysicalControl)
-                                    .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
-                                const updateDefCool = hasCoolOperationMode ? this.melCloudService.updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature) : false;
-                                const updateDefHeat = hasHeatOperationMode ? this.melCloudService.updateCharacteristic(Characteristic.HeatingThresholdTemperature, defaultHeatingSetTemperature) : false;
-                            };
+                            this.melCloudService
+                                ?.updateCharacteristic(Characteristic.Active, power)
+                                .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, obj.currentOperationMode)
+                                .updateCharacteristic(Characteristic.TargetHeaterCoolerState, obj.targetOperationMode)
+                                .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
+                                .updateCharacteristic(Characteristic.RotationSpeed, obj.fanSpeed)
+                                .updateCharacteristic(Characteristic.LockPhysicalControls, obj.lockPhysicalControl)
+                                .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
+                            const updateDefCool = hasCoolOperationMode ? this.melCloudService?.updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature) : false;
+                            const updateDefHeat = hasHeatOperationMode ? this.melCloudService?.updateCharacteristic(Characteristic.HeatingThresholdTemperature, defaultHeatingSetTemperature) : false;
                             break;
                         case 2: //Thermostat
                             //operation mode - 0, HEAT, 2, COOL, 4, 5, 6, FAN, AUTO
@@ -1088,59 +1086,36 @@ class DeviceErv extends EventEmitter {
                             obj.operationModeSetPropsValidValues = hasAutoVentilationMode ? (hasBypassVentilationMode ? [0, 1, 2, 3] : [0, 2, 3]) : (hasBypassVentilationMode ? [0, 1, 2] : [0, 2]);
 
                             //update characteristics
-                            if (this.melCloudService) {
-                                this.melCloudService
-                                    .updateCharacteristic(Characteristic.CurrentHeatingCoolingState, obj.currentOperationMode)
-                                    .updateCharacteristic(Characteristic.TargetHeatingCoolingState, obj.targetOperationMode)
-                                    .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                                    .updateCharacteristic(Characteristic.TargetTemperature, setTemperature)
-                                    .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
-                            };
+                            this.melCloudService
+                                ?.updateCharacteristic(Characteristic.CurrentHeatingCoolingState, obj.currentOperationMode)
+                                .updateCharacteristic(Characteristic.TargetHeatingCoolingState, obj.targetOperationMode)
+                                .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
+                                .updateCharacteristic(Characteristic.TargetTemperature, setTemperature)
+                                .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
                             break;
                     };
                     this.accessory = obj;
 
                     //update temperature sensors
-                    if (this.roomTemperatureSensorService) {
-                        this.roomTemperatureSensorService
-                            .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                    };
-
-                    if (this.outdoorTemperatureSensorService) {
-                        this.outdoorTemperatureSensorService
-                            .updateCharacteristic(Characteristic.CurrentTemperature, outdoorTemperature)
-                    };
-
-                    if (this.supplyTemperatureSensorService) {
-                        this.supplyTemperatureSensorService
-                            .updateCharacteristic(Characteristic.CurrentTemperature, supplyTemperature)
-                    };
+                    this.roomTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature);
+                    this.outdoorTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, outdoorTemperature);
+                    this.supplyTemperatureSensorService?.updateCharacteristic(Characteristic.CurrentTemperature, supplyTemperature);
 
                     //update core maintenance
-                    if (this.coreMaintenanceService) {
-                        this.coreMaintenanceService
-                            .updateCharacteristic(Characteristic.FilterChangeIndication, coreMaintenanceRequired)
-                    }
+                    this.coreMaintenanceService?.updateCharacteristic(Characteristic.FilterChangeIndication, coreMaintenanceRequired);
 
                     //update filter maintenance
-                    if (this.filterMaintenanceService) {
-                        this.filterMaintenanceService
-                            .updateCharacteristic(Characteristic.FilterChangeIndication, filterMaintenanceRequired)
-                    }
+                    this.filterMaintenanceService?.updateCharacteristic(Characteristic.FilterChangeIndication, filterMaintenanceRequired);
 
                     //update CO2 sensor
-                    if (this.carbonDioxideSensorService) {
-                        this.carbonDioxideSensorService
-                            .updateCharacteristic(Characteristic.CarbonDioxideDetected, roomCO2Detected)
-                            .updateCharacteristic(Characteristic.CarbonDioxideLevel, roomCO2Level)
-                    }
+                    this.carbonDioxideSensorService
+                        ?.updateCharacteristic(Characteristic.CarbonDioxideDetected, roomCO2Detected)
+                        .updateCharacteristic(Characteristic.CarbonDioxideLevel, roomCO2Level);
 
                     //update PM2.5 sensor
-                    if (this.airQualitySensorService) {
-                        this.airQualitySensorService
-                            .updateCharacteristic(Characteristic.AirQuality, pM25AirQuality)
-                            .updateCharacteristic(Characteristic.PM2_5Density, pM25Level)
-                    }
+                    this.airQualitySensorService
+                        ?.updateCharacteristic(Characteristic.AirQuality, pM25AirQuality)
+                        .updateCharacteristic(Characteristic.PM2_5Density, pM25Level);
 
                     //update presets state
                     if (this.presetsConfigured.length > 0) {
@@ -1153,11 +1128,8 @@ class DeviceErv extends EventEmitter {
                                 && presetData.VentilationMode === ventilationMode
                                 && presetData.FanSpeed === setFanSpeed) : false;
 
-                            if (this.presetsServices) {
-                                const characteristicType = preset.characteristicType;
-                                this.presetsServices[i]
-                                    .updateCharacteristic(characteristicType, preset.state)
-                            };
+                            const characteristicType = preset.characteristicType;
+                            this.presetsServices?.[i]?.updateCharacteristic(characteristicType, preset.state);
                         });
                     };
 
@@ -1214,11 +1186,8 @@ class DeviceErv extends EventEmitter {
                             };
 
                             //update services
-                            if (this.buttonsServices) {
-                                const characteristicType = button.characteristicType;
-                                this.buttonsServices[i]
-                                    .updateCharacteristic(characteristicType, button.state)
-                            };
+                            const characteristicType = button.characteristicType;
+                            this.buttonsServices?.[i]?.updateCharacteristic(characteristicType, button.state);
                         });
                     };
 
@@ -1260,7 +1229,7 @@ class DeviceErv extends EventEmitter {
             await this.melCloudErv.checkState();
 
             //prepare accessory
-            const accessory = await this.prepareAccessory(deviceData);
+            const accessory = await this.prepareAccessory();
             return accessory;
         } catch (error) {
             throw new Error(`Start error: ${error}`);

package/src/functions.js

@@ -0,0 +1,31 @@
+import { promises as fsPromises } from 'fs';
+
+class Functions {
+    constructor(config) {
+    }
+
+    async saveData(path, data) {
+        try {
+            data = JSON.stringify(data, null, 2);
+            await fsPromises.writeFile(path, data);
+            return true;
+        } catch (error) {
+            throw new Error(`Save data error: ${error}`);
+        }
+    }
+
+    async readData(path) {
+        try {
+            const data = await fsPromises.readFile(path);
+            return data;
+        } catch (error) {
+            throw new Error(`Read data error: ${error}`);
+        }
+    }
+
+    async scaleValue(value, inMin, inMax, outMin, outMax) {
+        const scaledValue = parseFloat((((Math.max(inMin, Math.min(inMax, value)) - inMin) * (outMax - outMin)) / (inMax - inMin) + outMin).toFixed(0));
+        return scaledValue;
+    }
+}
+export default Functions

package/src/melcloud.js

@@ -1,8 +1,8 @@
-import { promises as fsPromises } from 'fs';
 import { Agent } from 'https';
 import axios from 'axios';
 import EventEmitter from 'events';
 import ImpulseGenerator from './impulsegenerator.js';
+import Functions from './functions.js';
 import { ApiUrls } from './constants.js';
 
 class MelCloud extends EventEmitter {
@@ -15,6 +15,7 @@ class MelCloud extends EventEmitter {
         this.requestConfig = requestConfig;
         this.devicesId = [];
         this.contextKey = '';
+        this.functions = new Functions();
 
         this.options = {
             data: {
@@ -42,8 +43,73 @@ class MelCloud extends EventEmitter {
         };
     };
 
+    async chackDevicesList(contextKey) {
+        try {
+            //create axios instance get
+            const axiosInstanceGet = axios.create({
+                method: 'GET',
+                baseURL: ApiUrls.BaseURL,
+                timeout: 10000,
+                headers: {
+                    'X-MitsContextKey': contextKey
+                },
+                maxContentLength: 100000000,
+                maxBodyLength: 1000000000,
+                withCredentials: true,
+                httpsAgent: new Agent({
+                    keepAlive: false,
+                    rejectUnauthorized: false
+                })
+            });
+
+            if (this.enableDebugMode) this.emit('debug', `Scanning for devices`);
+            const listDevicesData = await axiosInstanceGet(ApiUrls.ListDevices);
+            const buildingsList = listDevicesData.data;
+            if (this.enableDebugMode) this.emit('debug', `Buildings: ${JSON.stringify(buildingsList, null, 2)}`);
+
+            if (!buildingsList) {
+                this.emit('warn', `No building found`);
+                return null;
+            }
+
+            //save buildings to the file
+            await this.functions.saveData(this.buildingsFile, buildingsList);
+            if (this.enableDebugMode) this.emit('debug', `Buildings list saved`);
+
+            //read buildings structure and get the devices
+            const devices = [];
+            for (const building of buildingsList) {
+                const buildingStructure = building.Structure;
+
+                //get all devices from the building structure
+                const allDevices = [
+                    ...buildingStructure.Floors.flatMap(floor => [...floor.Areas.flatMap(area => area.Devices), ...floor.Devices]),
+                    ...buildingStructure.Areas.flatMap(area => area.Devices),
+                    ...buildingStructure.Devices
+                ];
+
+                //add all devices to the devices array
+                devices.push(...allDevices);
+            }
+
+            const devicesCount = devices.length;
+            if (devicesCount === 0) {
+                this.emit('warn', `No devices found`);
+                return null;
+            }
+
+            //save buildings to the file
+            await this.functions.saveData(this.devicesFile, devices);
+            if (this.enableDebugMode) this.emit('debug', `${devicesCount} devices saved`);
+
+            return devices;
+        } catch (error) {
+            throw new Error(`Check devices list error: ${error}`);
+        };
+    }
+
     async connect() {
-       if (this.enableDebugMode) this.emit('debug', `Connecting to MELCloud`);
+        if (this.enableDebugMode) this.emit('debug', `Connecting to MELCloud`);
 
         try {
             const axiosInstanceLogin = axios.create({
@@ -75,7 +141,7 @@ class MelCloud extends EventEmitter {
                 MapLongitude: 'removed',
                 MapLatitude: 'removed'
             };
-           if (this.enableDebugMode) this.emit('debug', `MELCloud Info: ${JSON.stringify(debugData, null, 2)}`);
+            if (this.enableDebugMode) this.emit('debug', `MELCloud Info: ${JSON.stringify(debugData, null, 2)}`);
 
             if (contextKey === undefined || contextKey === null) {
                 this.emit('warn', `Context key: ${contextKey}, missing`)
@@ -101,7 +167,7 @@ class MelCloud extends EventEmitter {
             });
 
             //save melcloud info to the file
-            await this.saveData(this.accountFile, accountInfo);
+            await this.functions.saveData(this.accountFile, accountInfo);
 
             //emit connect success
             this.emit('success', `Connect to MELCloud Success`)
@@ -118,81 +184,6 @@ class MelCloud extends EventEmitter {
         };
     }
 
-    async chackDevicesList(contextKey) {
-        try {
-            //create axios instance get
-            const axiosInstanceGet = axios.create({
-                method: 'GET',
-                baseURL: ApiUrls.BaseURL,
-                timeout: 10000,
-                headers: {
-                    'X-MitsContextKey': contextKey
-                },
-                maxContentLength: 100000000,
-                maxBodyLength: 1000000000,
-                withCredentials: true,
-                httpsAgent: new Agent({
-                    keepAlive: false,
-                    rejectUnauthorized: false
-                })
-            });
-
-           if (this.enableDebugMode) this.emit('debug', `Scanning for devices`);
-            const listDevicesData = await axiosInstanceGet(ApiUrls.ListDevices);
-            const buildingsList = listDevicesData.data;
-           if (this.enableDebugMode) this.emit('debug', `Buildings: ${JSON.stringify(buildingsList, null, 2)}`);
-
-            if (!buildingsList) {
-                this.emit('warn', `No building found`);
-                return null;
-            }
-
-            //save buildings to the file
-            await this.saveData(this.buildingsFile, buildingsList);
-           if (this.enableDebugMode) this.emit('debug', `Buildings list saved`);
-
-            //read buildings structure and get the devices
-            const devices = [];
-            for (const building of buildingsList) {
-                const buildingStructure = building.Structure;
-
-                //get all devices from the building structure
-                const allDevices = [
-                    ...buildingStructure.Floors.flatMap(floor => [...floor.Areas.flatMap(area => area.Devices), ...floor.Devices]),
-                    ...buildingStructure.Areas.flatMap(area => area.Devices),
-                    ...buildingStructure.Devices
-                ];
-
-                //add all devices to the devices array
-                devices.push(...allDevices);
-            }
-
-            const devicesCount = devices.length;
-            if (devicesCount === 0) {
-                this.emit('warn', `No devices found`);
-                return null;
-            }
-
-            //save buildings to the file
-            await this.saveData(this.devicesFile, devices);
-           if (this.enableDebugMode) this.emit('debug', `${devicesCount} devices saved`);
-
-            return devices;
-        } catch (error) {
-            throw new Error(`Check devices list error: ${error}`);
-        };
-    }
-
-    async saveData(path, data) {
-        try {
-            await fsPromises.writeFile(path, JSON.stringify(data, null, 2));
-           if (this.enableDebugMode) this.emit('debug', `Data saved to: ${path}`);
-            return true;
-        } catch (error) {
-            throw new Error(`Save data error: ${error}`);
-        }
-    }
-
     async send(accountInfo) {
         try {
             const options = {
@@ -200,7 +191,7 @@ class MelCloud extends EventEmitter {
             };
 
             await this.axiosInstancePost(ApiUrls.UpdateApplicationOptions, options);
-            await this.saveData(this.accountFile, accountInfo);
+            await this.functions.saveData(this.accountFile, accountInfo);
             return true;
         } catch (error) {
             throw new Error(`Send data error: ${error}`);

package/src/melcloudata.js

@@ -1,8 +1,8 @@
-import { promises as fsPromises } from 'fs';
 import { Agent } from 'https';
 import axios from 'axios';
 import EventEmitter from 'events';
 import ImpulseGenerator from './impulsegenerator.js';
+import Functions from './functions.js';
 import { ApiUrls } from './constants.js';
 
 class MelCloudAta extends EventEmitter {
@@ -11,6 +11,7 @@ class MelCloudAta extends EventEmitter {
         this.devicesFile = config.devicesFile;
         this.deviceId = config.deviceId;
         this.enableDebugMode = config.enableDebugMode;
+        this.functions = new Functions();
 
         //set default values
         this.deviceState = {};
@@ -30,22 +31,36 @@ class MelCloudAta extends EventEmitter {
             })
         });
 
-        this.impulseGenerator = new ImpulseGenerator();
-        this.impulseGenerator.on('checkState', async () => {
-            try {
+        //lock flags
+        this.locks = {
+            checkState: false,
+        };
+        this.impulseGenerator = new ImpulseGenerator()
+            .on('checkState', () => this.handleWithLock('checkState', async () => {
                 await this.checkState();
-            } catch (error) {
-                this.emit('error', `Impulse generator error: ${error}`);
-            };
-        }).on('state', (state) => {
-            this.emit('success', `Impulse generator ${state ? 'started' : 'stopped'}`);
-        });
-    };
+            }))
+            .on('state', (state) => {
+                this.emit('success', `Impulse generator ${state ? 'started' : 'stopped'}.`);
+            });
+    }
+
+    async handleWithLock(lockKey, fn) {
+        if (this.locks[lockKey]) return;
+
+        this.locks[lockKey] = true;
+        try {
+            await fn();
+        } catch (error) {
+            this.emit('error', `Inpulse generator error: ${error}`);
+        } finally {
+            this.locks[lockKey] = false;
+        }
+    }
 
     async checkState() {
         try {
             //read device info from file
-            const devicesData = await this.readData(this.devicesFile);
+            const devicesData = await this.functions.readData(this.devicesFile);
 
             if (!Array.isArray(devicesData)) {
                 this.emit('warn', `Device data not found`);
@@ -361,25 +376,6 @@ class MelCloudAta extends EventEmitter {
         };
     };
 
-
-    async readData(path) {
-        try {
-            const savedData = await fsPromises.readFile(path)
-            if (savedData.toString().trim().length === 0) {
-                return null;
-            }
-
-            try {
-                const data = JSON.parse(savedData);
-                return data;
-            } catch (error) {
-                throw new Error(`Parse JSON error: ${error}`);
-            }
-        } catch (error) {
-            throw new Error(`Read data error: ${error}`);
-        }
-    }
-
     async send(deviceData, displayMode) {
         try {
             //set target temp based on display mode and operation mode

package/src/melcloudatw.js

@@ -1,8 +1,8 @@
-import { promises as fsPromises } from 'fs';
 import { Agent } from 'https';
 import axios from 'axios';
 import EventEmitter from 'events';
 import ImpulseGenerator from './impulsegenerator.js';
+import Functions from './functions.js';
 import { ApiUrls } from './constants.js';
 
 class MelCloudAtw extends EventEmitter {
@@ -11,6 +11,7 @@ class MelCloudAtw extends EventEmitter {
         this.devicesFile = config.devicesFile;
         this.deviceId = config.deviceId;
         this.enableDebugMode = config.enableDebugMode;
+        this.functions = new Functions();
 
         //set default values
         this.deviceState = {};
@@ -30,22 +31,36 @@ class MelCloudAtw extends EventEmitter {
             })
         });
 
-        this.impulseGenerator = new ImpulseGenerator();
-        this.impulseGenerator.on('checkState', async () => {
-            try {
+        //lock flags
+        this.locks = {
+            checkState: false,
+        };
+        this.impulseGenerator = new ImpulseGenerator()
+            .on('checkState', () => this.handleWithLock('checkState', async () => {
                 await this.checkState();
-            } catch (error) {
-                this.emit('error', `Impulse generator error: ${error}`);
-            };
-        }).on('state', (state) => {
-            this.emit('success', `Impulse generator ${state ? 'started' : 'stopped'}`);
-        });
-    };
+            }))
+            .on('state', (state) => {
+                this.emit('success', `Impulse generator ${state ? 'started' : 'stopped'}.`);
+            });
+    }
+
+    async handleWithLock(lockKey, fn) {
+        if (this.locks[lockKey]) return;
+
+        this.locks[lockKey] = true;
+        try {
+            await fn();
+        } catch (error) {
+            this.emit('error', `Inpulse generator error: ${error}`);
+        } finally {
+            this.locks[lockKey] = false;
+        }
+    }
 
     async checkState() {
         try {
             //read device info from file
-            const devicesData = await this.readData(this.devicesFile);
+            const devicesData = await this.functions.readData(this.devicesFile);
 
             if (!Array.isArray(devicesData)) {
                 this.emit('warn', `Device data not found`);
@@ -425,24 +440,6 @@ class MelCloudAtw extends EventEmitter {
         };
     };
 
-    async readData(path) {
-        try {
-            const savedData = await fsPromises.readFile(path)
-            if (savedData.toString().trim().length === 0) {
-                return null;
-            }
-
-            try {
-                const data = JSON.parse(savedData);
-                return data;
-            } catch (error) {
-                throw new Error(`Parse JSON error: ${error}`);
-            }
-        } catch (error) {
-            throw new Error(`Read data error: ${error}`);
-        }
-    }
-
     async send(deviceData) {
         try {
             //prevent to set out of range temp

package/src/melclouderv.js

@@ -1,8 +1,8 @@
-import { promises as fsPromises } from 'fs';
 import { Agent } from 'https';
 import axios from 'axios';
 import EventEmitter from 'events';
 import ImpulseGenerator from './impulsegenerator.js';
+import Functions from './functions.js';
 import { ApiUrls } from './constants.js';
 
 class MelCloudErv extends EventEmitter {
@@ -11,6 +11,7 @@ class MelCloudErv extends EventEmitter {
         this.devicesFile = config.devicesFile;
         this.deviceId = config.deviceId;
         this.enableDebugMode = config.enableDebugMode;
+        this.functions = new Functions();
 
         //set default values
         this.deviceState = {};
@@ -30,22 +31,36 @@ class MelCloudErv extends EventEmitter {
             })
         });
 
-        this.impulseGenerator = new ImpulseGenerator();
-        this.impulseGenerator.on('checkState', async () => {
-            try {
+        //lock flags
+        this.locks = {
+            checkState: false,
+        };
+        this.impulseGenerator = new ImpulseGenerator()
+            .on('checkState', () => this.handleWithLock('checkState', async () => {
                 await this.checkState();
-            } catch (error) {
-                this.emit('error', `Impulse generator error: ${error}`);
-            };
-        }).on('state', (state) => {
-            this.emit('success', `Impulse generator ${state ? 'started' : 'stopped'}`);
-        });
-    };
+            }))
+            .on('state', (state) => {
+                this.emit('success', `Impulse generator ${state ? 'started' : 'stopped'}.`);
+            });
+    }
+
+    async handleWithLock(lockKey, fn) {
+        if (this.locks[lockKey]) return;
+
+        this.locks[lockKey] = true;
+        try {
+            await fn();
+        } catch (error) {
+            this.emit('error', `Inpulse generator error: ${error}`);
+        } finally {
+            this.locks[lockKey] = false;
+        }
+    }
 
     async checkState() {
         try {
             //read device info from file
-            const devicesData = await this.readData(this.devicesFile);
+            const devicesData = await this.functions.readData(this.devicesFile);
 
             if (!Array.isArray(devicesData)) {
                 this.emit('warn', `Device data not found`);
@@ -349,24 +364,6 @@ class MelCloudErv extends EventEmitter {
         };
     };
 
-    async readData(path) {
-        try {
-            const savedData = await fsPromises.readFile(path)
-            if (savedData.toString().trim().length === 0) {
-                return null;
-            }
-
-            try {
-                const data = JSON.parse(savedData);
-                return data;
-            } catch (error) {
-                throw new Error(`Parse JSON error: ${error}`);
-            }
-        } catch (error) {
-            throw new Error(`Read data error: ${error}`);
-        }
-    }
-
     async send(deviceData, displayMode) {
         try {
             //set target temp based on display mode and ventilation mode