homebridge-melcloud-control 3.9.2 → 3.9.4

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.9.2",
+  "version": "3.9.4",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceatw.js

@@ -1995,7 +1995,7 @@ class DeviceAtw extends EventEmitter {
             await this.melCloudAtw.checkState();
 
             //prepare accessory
-            const accessory = await this.prepareAccessory(deviceData);
+            const accessory = await this.prepareAccessory();
             return accessory;
         } catch (error) {
             throw new Error(`Start error: ${error}`);

package/src/impulsegenerator.js

@@ -4,6 +4,7 @@ class ImpulseGenerator extends EventEmitter {
     constructor() {
         super();
         this.timersState = false;
+        this.timers = [];
     }
 
     async start(timers) {
@@ -12,20 +13,19 @@ class ImpulseGenerator extends EventEmitter {
             return true;
         }
 
-        //update state
-        const updateState = timers.length > 0 ? this.state(true) : false;
-
-        //add timers
         this.timers = [];
+
         for (const timer of timers) {
             this.emit(timer.name);
 
-            const newTimer = setInterval(() => {
+            const interval = setInterval(() => {
                 this.emit(timer.name);
             }, timer.sampling);
-            this.timers.push(newTimer);
-        };
 
+            this.timers.push(interval);
+        }
+
+        this.state(true);
         return true;
     }
 
@@ -35,12 +35,13 @@ class ImpulseGenerator extends EventEmitter {
             return true;
         }
 
-        //update state
-        this.timers.forEach(timer => clearInterval(timer));
-        this.timers = [];
+        for (const timer of this.timers) {
+            clearInterval(timer);
+        }
 
+        this.timers = [];
         this.state(false);
-        return true
+        return true;
     }
 
     state(state) {
@@ -48,4 +49,5 @@ class ImpulseGenerator extends EventEmitter {
         this.emit('state', state);
     }
 }
+
 export default ImpulseGenerator;