homebridge-melcloud-control 3.9.2-beta.1 → 3.9.3

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.9.2-beta.1",
+  "version": "3.9.3",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/impulsegenerator.js

@@ -4,6 +4,7 @@ class ImpulseGenerator extends EventEmitter {
     constructor() {
         super();
         this.timersState = false;
+        this.timers = [];
     }
 
     async start(timers) {
@@ -12,20 +13,19 @@ class ImpulseGenerator extends EventEmitter {
             return true;
         }
 
-        //update state
-        const updateState = timers.length > 0 ? this.state(true) : false;
-
-        //add timers
         this.timers = [];
+
         for (const timer of timers) {
             this.emit(timer.name);
 
-            const newTimer = setInterval(() => {
+            const interval = setInterval(() => {
                 this.emit(timer.name);
             }, timer.sampling);
-            this.timers.push(newTimer);
-        };
 
+            this.timers.push(interval);
+        }
+
+        this.state(true);
         return true;
     }
 
@@ -35,12 +35,13 @@ class ImpulseGenerator extends EventEmitter {
             return true;
         }
 
-        //update state
-        this.timers.forEach(timer => clearInterval(timer));
-        this.timers = [];
+        for (const timer of this.timers) {
+            clearInterval(timer);
+        }
 
+        this.timers = [];
         this.state(false);
-        return true
+        return true;
     }
 
     state(state) {
@@ -48,4 +49,5 @@ class ImpulseGenerator extends EventEmitter {
         this.emit('state', state);
     }
 }
+
 export default ImpulseGenerator;

package/src/mqtt.js

@@ -27,7 +27,7 @@ class Mqtt extends EventEmitter {
                 this.mqttClient.on('message', (topic, message) => {
                     try {
                         const obj = JSON.parse(message.toString());
-                        const emitDebug = config.debug ? this.emit('debug', `MQTT Received topic: ${topic}, message: ${JSON.stringify(obj, null, 2)}`) : false;
+                        if (config.debug) this.emit('debug', `MQTT Received topic: ${topic}, message: ${JSON.stringify(obj, null, 2)}`);
                         const key = Object.keys(obj)[0];
                         const value = Object.values(obj)[0];
                         this.emit('set', key, value);
@@ -43,7 +43,7 @@ class Mqtt extends EventEmitter {
                 const fullTopic = `${config.prefix}/${topic}`;
                 const publishMessage = JSON.stringify(message, null, 2);
                 await this.mqttClient.publish(fullTopic, publishMessage);
-                const emitDebug = config.debug ? this.emit('debug', `MQTT Publish topic: ${fullTopic}, message: ${publishMessage}`) : false;
+                if (config.debug) this.emit('debug', `MQTT Publish topic: ${fullTopic}, message: ${publishMessage}`);
             } catch (error) {
                 this.emit('warn', `MQTT Publish error: ${error}`);
             };

package/src/restful.js

@@ -53,9 +53,7 @@ class RestFul extends EventEmitter {
                     this.emit('set', key, value);
                     this.update(key, value);
 
-                    if (this.restFulDebug) {
-                        this.emit('debug', `RESTFul post data: ${JSON.stringify(obj, null, 2)}`);
-                    }
+                    if (this.restFulDebug) this.emit('debug', `RESTFul post data: ${JSON.stringify(obj, null, 2)}`);
 
                     res.json({ success: true, received: obj });
                 } catch (error) {
@@ -81,9 +79,7 @@ class RestFul extends EventEmitter {
             return;
         }
 
-        if (this.restFulDebug) {
-            this.emit('debug', `RESTFul update path: ${path}, data: ${JSON.stringify(data)}`);
-        }
+        if (this.restFulDebug) this.emit('debug', `RESTFul update path: ${path}, data: ${JSON.stringify(data)}`);
     }
 }