homebridge-melcloud-control 3.8.5-beta.4 → 3.8.5

package/CHANGELOG.md

@@ -16,6 +16,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - do not configure it manually, always using Config UI X
   - required Homebridge v2.0.0 and above
 
+## [3.8.5] - (24.05.2025)
+
+## Changes
+
+- fix [#199](https://github.com/grzegorz914/homebridge-melcloud-control/issues/199)
+- cleanup
+
 ## [3.8.3] - (20.05.2025)
 
 ## Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.8.5-beta.4",
+  "version": "3.8.5",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -1396,8 +1396,8 @@ class DeviceAta extends EventEmitter {
                 .on('restFul', (path, data) => {
                     const restFul = this.restFulConnected ? this.restFul1.update(path, data) : false;
                 })
-                .on('mqtt', async (topic, message) => {
-                    const mqtt = this.mqttConnected ? await this.mqtt1.publish(topic, message) : false;
+                .on('mqtt', (topic, message) => {
+                    const mqtt = this.mqttConnected ? this.mqtt1.emit('publish', topic, message) : false;
                 });
 
             //start external integrations

package/src/melcloudatw.js

@@ -397,14 +397,6 @@ class MelCloudAtw extends EventEmitter {
                 ProhibitHotWater: prohibitHotWater
             }
 
-            //check state changes
-            const deviceDataHasNotChanged = JSON.stringify(deviceState) === JSON.stringify(this.deviceState);
-            if (deviceDataHasNotChanged) {
-                const debug = this.enableDebugMode ? this.emit('debug', `Device state not changed`) : false;
-                return;
-            }
-            this.deviceState = deviceState;
-
             //restFul
             this.emit('restFul', 'info', deviceData);
             this.emit('restFul', 'state', deviceData.Device);
@@ -413,6 +405,14 @@ class MelCloudAtw extends EventEmitter {
             this.emit('mqtt', 'Info', deviceData);
             this.emit('mqtt', 'State', deviceData.Device);
 
+            //check state changes
+            const deviceDataHasNotChanged = JSON.stringify(deviceState) === JSON.stringify(this.deviceState);
+            if (deviceDataHasNotChanged) {
+                const debug = this.enableDebugMode ? this.emit('debug', `Device state not changed`) : false;
+                return;
+            }
+            this.deviceState = deviceState;
+
             //emit info
             this.emit('deviceInfo', manufacturer, modelIndoor, modelOutdoor, serialNumber, firmwareAppVersion, hasHotWaterTank, hasZone2);
 

package/src/melclouderv.js

@@ -321,14 +321,6 @@ class MelCloudErv extends EventEmitter {
                 HideOutdoorTemperature: hideOutdoorTemperature
             }
 
-            //check state changes
-            const deviceDataHasNotChanged = JSON.stringify(deviceState) === JSON.stringify(this.deviceState);
-            if (deviceDataHasNotChanged) {
-                const debug = this.enableDebugMode ? this.emit('debug', `Device state not changed`) : false;
-                return;
-            }
-            this.deviceState = deviceState;
-
             //restFul
             this.emit('restFul', 'info', deviceData);
             this.emit('restFul', 'state', deviceData.Device);
@@ -337,6 +329,14 @@ class MelCloudErv extends EventEmitter {
             this.emit('mqtt', 'Info', deviceData);
             this.emit('mqtt', 'State', deviceData.Device);
 
+            //check state changes
+            const deviceDataHasNotChanged = JSON.stringify(deviceState) === JSON.stringify(this.deviceState);
+            if (deviceDataHasNotChanged) {
+                const debug = this.enableDebugMode ? this.emit('debug', `Device state not changed`) : false;
+                return;
+            }
+            this.deviceState = deviceState;
+
             //emit info
             this.emit('deviceInfo', manufacturer, modelIndoor, modelOutdoor, serialNumber, firmwareAppVersion);
 

package/src/mqtt.js

@@ -12,7 +12,6 @@ class Mqtt extends EventEmitter {
         }
         const url = `mqtt://${config.host}:${config.port}`;
         const subscribeTopic = `${config.prefix}/Set`;
-        this.topic = config.prefix;
 
         this.on('connect', async () => {
             try {
@@ -52,17 +51,5 @@ class Mqtt extends EventEmitter {
 
         this.emit('connect');
     };
-
-    async publish(topic, message) {
-        try {
-            const fullTopic = `${this.topic}/${topic}`;
-            const publishMessage = JSON.stringify(message, null, 2);
-            await this.mqttClient.publish(fullTopic, publishMessage);
-            const emitDebug = config.debug ? this.emit('debug', `MQTT Publish topic: ${fullTopic}, message: ${publishMessage}`) : false;
-            return;
-        } catch (error) {
-            this.emit('warn', `MQTT Publish error: ${error}`);
-        };
-    }
 };
 export default Mqtt;