homebridge-melcloud-control 3.8.12 → 3.8.14

package/CHANGELOG.md

@@ -16,6 +16,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - do not configure it manually, always using Config UI X
   - required Homebridge v2.0.0 and above
 
+## [3.8.14] - (26.06.2025)
+
+## Changes
+
+- fix [#199](https://github.com/grzegorz914/homebridge-melcloud-control/issues/199)
+- fix [#205](https://github.com/grzegorz914/homebridge-melcloud-control/issues/205)
+- RESTFul code refactor
+
+ ## [3.8.13] - (26.06.2025)
+
+## Changes
+
+- fix [#206](https://github.com/grzegorz914/homebridge-melcloud-control/issues/206)
+
 ## [3.8.6] - (24.05.2025)
 
 ## Changes

package/README.md

@@ -299,10 +299,11 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
 * Port: last 4 numbers of `device Id`, displayed in HB log during start.
 * POST data as a JSON Object `{OperationMode: 8}`.
 * Header content type must be `application/json`.
+* Path `status` response all available paths.
 
 | Method | URL | Path | Response | Type |
 | --- | --- | --- | --- | --- |
-| GET | `http//ip:port` | `Info`, `State` | `{"Power": true, "SetTemperature": 21.5}` | JSON object. |
+| GET | `http//ip:port` | `info`, `state` | `{"Power": true, "SetTemperature": 21.5}` | JSON object. |
 
 | Method | URL | Key | Value | Type | Description |
 | --- | --- | --- | --- | --- | --- |

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.8.12",
+  "version": "3.8.14",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -130,10 +130,10 @@ class DeviceAta extends EventEmitter {
                     this.mqtt1 = new Mqtt({
                         host: this.mqtt.host,
                         port: this.mqtt.port || 1883,
-                        clientId: this.mqtt.clientId || `melcloud_${Math.random().toString(16).slice(3)}`,
-                        prefix: this.mqtt.prefix || `melcloud/${this.deviceTypeText}/${this.deviceName}`,
+                        clientId: this.mqtt.clientId ? `melcloud_${this.mqtt.clientId}_${Math.random().toString(16).slice(3)}` : `melcloud_${Math.random().toString(16).slice(3)}`,
+                        prefix: this.mqtt.prefix ? `melcloud/${this.mqtt.prefix}${this.deviceTypeText}/${this.deviceName}` : `melcloud/${this.deviceTypeText}/${this.deviceName}`,
                         user: this.mqtt.user,
-                        passwd: this.mqtt.pass,
+                        passwd: this.mqtt.passwd,
                         debug: this.mqtt.debug || false
                     });
 

package/src/deviceatw.js

@@ -135,10 +135,10 @@ class DeviceAtw extends EventEmitter {
                     this.mqtt1 = new Mqtt({
                         host: this.mqtt.host,
                         port: this.mqtt.port || 1883,
-                        clientId: this.mqtt.clientId || `melcloud_${Math.random().toString(16).slice(3)}`,
-                        prefix: this.mqtt.prefix || `melcloud/${this.deviceTypeText}/${this.deviceName}`,
+                        clientId: this.mqtt.clientId ? `melcloud_${this.mqtt.clientId}_${Math.random().toString(16).slice(3)}` : `melcloud_${Math.random().toString(16).slice(3)}`,
+                        prefix: this.mqtt.prefix ? `melcloud/${this.mqtt.prefix}${this.deviceTypeText}/${this.deviceName}` : `melcloud/${this.deviceTypeText}/${this.deviceName}`,
                         user: this.mqtt.user,
-                        passwd: this.mqtt.pass,
+                        passwd: this.mqtt.passwd,
                         debug: this.mqtt.debug || false
                     });
 

package/src/deviceerv.js

@@ -128,10 +128,10 @@ class DeviceErv extends EventEmitter {
                     this.mqtt1 = new Mqtt({
                         host: this.mqtt.host,
                         port: this.mqtt.port || 1883,
-                        clientId: this.mqtt.clientId || `melcloud_${Math.random().toString(16).slice(3)}`,
-                        prefix: this.mqtt.prefix || `melcloud/${this.deviceTypeText}/${this.deviceName}`,
+                        clientId: this.mqtt.clientId ? `melcloud_${this.mqtt.clientId}_${Math.random().toString(16).slice(3)}` : `melcloud_${Math.random().toString(16).slice(3)}`,
+                        prefix: this.mqtt.prefix ? `melcloud/${this.mqtt.prefix}${this.deviceTypeText}/${this.deviceName}` : `melcloud/${this.deviceTypeText}/${this.deviceName}`,
                         user: this.mqtt.user,
-                        passwd: this.mqtt.pass,
+                        passwd: this.mqtt.passwd,
                         debug: this.mqtt.debug || false
                     });
 

package/src/restful.js

@@ -1,6 +1,8 @@
 import express, { json } from 'express';
 import EventEmitter from 'events';
 
+const DEFAULT_MESSAGE = 'This data is not available at this time.';
+
 class RestFul extends EventEmitter {
     constructor(config) {
         super();
@@ -8,36 +10,53 @@ class RestFul extends EventEmitter {
         this.restFulDebug = config.debug;
 
         this.restFulData = {
-            info: 'This data is not available at this time.',
-            state: 'This data is not available at this time.'
+            info: DEFAULT_MESSAGE,
+            state: DEFAULT_MESSAGE
         };
 
         this.connect();
-    };
+    }
 
     connect() {
         try {
-            const restFul = express();
-            restFul.set('json spaces', 2);
-            restFul.use(json());
+            const app = express();
+            app.set('json spaces', 2);
+            app.use(json());
+
+            // Register GET routes for all keys
+            for (const key of Object.keys(this.restFulData)) {
+                app.get(`/${key}`, (req, res) => {
+                    res.json(this.restFulData[key]);
+                });
+            }
 
-            // GET Routes
-            restFul.get('/info', (req, res) => { res.json(this.restFulData.info) });
-            restFul.get('/state', (req, res) => { res.json(this.restFulData.state) });
+            // Health check route
+            app.get('/status', (req, res) => {
+                res.json({
+                    status: 'online',
+                    uptime: process.uptime(),
+                    available_paths: Object.keys(this.restFulData).map(k => `/${k}`)
+                });
+            });
 
-            // POST Route
-            restFul.post('/', (req, res) => {
+            // POST route to update values
+            app.post('/', (req, res) => {
                 try {
                     const obj = req.body;
                     if (!obj || typeof obj !== 'object' || Object.keys(obj).length === 0) {
-                        this.emit('warn', `RESTFul Invalid JSON payload`);
+                        this.emit('warn', 'RESTFul Invalid JSON payload');
                         return res.status(400).json({ error: 'RESTFul Invalid JSON payload' });
                     }
+
                     const key = Object.keys(obj)[0];
                     const value = obj[key];
                     this.emit('set', key, value);
+                    this.update(key, value);
+
+                    if (this.restFulDebug) {
+                        this.emit('debug', `RESTFul post data: ${JSON.stringify(obj, null, 2)}`);
+                    }
 
-                    const emitDebug = this.restFulDebug ? this.emit('debug', `RESTFul post data: ${JSON.stringify(obj, null, 2)}`) : false;
                     res.json({ success: true, received: obj });
                 } catch (error) {
                     this.emit('warn', `RESTFul Parse error: ${error}`);
@@ -45,28 +64,27 @@ class RestFul extends EventEmitter {
                 }
             });
 
-            // Start server
-            restFul.listen(this.restFulPort, () => {
+            // Start the server
+            app.listen(this.restFulPort, () => {
                 this.emit('connected', `RESTful started on port: ${this.restFulPort}`);
             });
         } catch (error) {
-            this.emit('warn', `RESTful Connect error: ${error}`)
+            this.emit('warn', `RESTful Connect error: ${error}`);
         }
-    };
+    }
 
     update(path, data) {
-        switch (path) {
-            case 'info':
-                this.restFulData.info = data;
-                break;
-            case 'state':
-                this.restFulData.state = data;
-                break;
-            default:
-                this.emit('warn', `Unknown RESTFul update path: ${path}, data: ${data}`)
-                break;
-        };
-        const emitDebug = this.restFulDebug ? this.emit('debug', `RESTFul update path: ${path}, data: ${data}`) : false;
-    };
-};
-export default RestFul;
+        if (this.restFulData.hasOwnProperty(path)) {
+            this.restFulData[path] = data;
+        } else {
+            this.emit('warn', `Unknown RESTFul update path: ${path}, data: ${JSON.stringify(data)}`);
+            return;
+        }
+
+        if (this.restFulDebug) {
+            this.emit('debug', `RESTFul update path: ${path}, data: ${JSON.stringify(data)}`);
+        }
+    }
+}
+
+export default RestFul;