homebridge-melcloud-control 3.8.11 → 3.8.13

package/CHANGELOG.md

@@ -16,6 +16,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - do not configure it manually, always using Config UI X
   - required Homebridge v2.0.0 and above
 
+ ## [3.8.13] - (26.06.2025)
+
+## Changes
+
+- fix [#206](https://github.com/grzegorz914/homebridge-melcloud-control/issues/206)
+
 ## [3.8.6] - (24.05.2025)
 
 ## Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.8.11",
+  "version": "3.8.13",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -130,8 +130,8 @@ class DeviceAta extends EventEmitter {
                     this.mqtt1 = new Mqtt({
                         host: this.mqtt.host,
                         port: this.mqtt.port || 1883,
-                        clientId: this.mqtt.clientId || `melcloud_${Math.random().toString(16).slice(3)}`,
-                        prefix: this.mqtt.prefix || `melcloud/${this.deviceTypeText}/${this.deviceName}`,
+                        clientId: this.mqtt.clientId ? `melcloud_${this.mqtt.clientId}_${Math.random().toString(16).slice(3)}` : `melcloud_${Math.random().toString(16).slice(3)}`,
+                        prefix: this.mqtt.prefix ? `melcloud/${this.mqtt.prefix}${this.deviceTypeText}/${this.deviceName}` : `melcloud/${this.deviceTypeText}/${this.deviceName}`,
                         user: this.mqtt.user,
                         passwd: this.mqtt.pass,
                         debug: this.mqtt.debug || false

package/src/deviceatw.js

@@ -135,8 +135,8 @@ class DeviceAtw extends EventEmitter {
                     this.mqtt1 = new Mqtt({
                         host: this.mqtt.host,
                         port: this.mqtt.port || 1883,
-                        clientId: this.mqtt.clientId || `melcloud_${Math.random().toString(16).slice(3)}`,
-                        prefix: this.mqtt.prefix || `melcloud/${this.deviceTypeText}/${this.deviceName}`,
+                        clientId: this.mqtt.clientId ? `melcloud_${this.mqtt.clientId}_${Math.random().toString(16).slice(3)}` : `melcloud_${Math.random().toString(16).slice(3)}`,
+                        prefix: this.mqtt.prefix ? `melcloud/${this.mqtt.prefix}${this.deviceTypeText}/${this.deviceName}` : `melcloud/${this.deviceTypeText}/${this.deviceName}`,
                         user: this.mqtt.user,
                         passwd: this.mqtt.pass,
                         debug: this.mqtt.debug || false
@@ -1443,8 +1443,8 @@ class DeviceAtw extends EventEmitter {
                         sensorsCount: zonesSensorsCount,
                         useFahrenheit: this.useFahrenheit,
                         temperatureUnit: TemperatureDisplayUnits[this.useFahrenheit],
-                        zones: [{}, {}, {}, {}],
-                        zonesSensors: [{}, {}, {}, {}]
+                        zones: [],
+                        zonesSensors: []
                     };
 
                     //default values
@@ -1682,19 +1682,22 @@ class DeviceAtw extends EventEmitter {
                                 break;
                         };
 
-                        //add value to zones arrays
-                        obj.zones[i].name = name;
-                        obj.zones[i].operationMode = operationModeZone;
-                        obj.zones[i].currentOperationMode = currentOperationMode;
-                        obj.zones[i].targetOperationMode = targetOperationMode;
-                        obj.zones[i].roomTemperature = roomTemperature;
-                        obj.zones[i].setTemperature = setTemperature;
-                        obj.zones[i].lockPhysicalControl = lockPhysicalControl;
-                        obj.zones[i].temperaturesSetPropsMinValue = temperatureSetPropsMinValue;
-                        obj.zones[i].temperaturesSetPropsMaxValue = temperatureSetPropsMaxValue;
-                        const setPropsMinValue = this.startPrepareAccessory ? obj.zones[i].operationModesSetPropsMinValue = operationModeSetPropsMinValue : false;
-                        const setPropsMaxValue = this.startPrepareAccessory ? obj.zones[i].operationModesSetPropsMaxValue = operationModeSetPropsMaxValue : false;
-                        const setPropsValidValues = this.startPrepareAccessory ? obj.zones[i].operationModesSetPropsValidValues = operationModeSetPropsValidValues : false;
+                        //add every zone to array
+                        const zone = {
+                            name: name,
+                            operationMode: operationModeZone,
+                            currentOperationMode: currentOperationMode,
+                            targetOperationMode: targetOperationMode,
+                            roomTemperature: roomTemperature,
+                            setTemperature: setTemperature,
+                            lockPhysicalControl: lockPhysicalControl,
+                            temperaturesSetPropsMinValue: temperatureSetPropsMinValue,
+                            temperaturesSetPropsMaxValue: temperatureSetPropsMaxValue,
+                            operationModesSetPropsMinValue: operationModeSetPropsMinValue,
+                            operationModesSetPropsMaxValue: operationModeSetPropsMaxValue,
+                            operationModesSetPropsValidValues: operationModeSetPropsValidValues
+                        };
+                        obj.zones.push(zone);
 
                         //log current state
                         if (!this.disableLogInfo) {
@@ -1828,11 +1831,14 @@ class DeviceAtw extends EventEmitter {
                                 break;
                         };
 
-                        //add value to sensors arrays
-                        obj.zonesSensors[i].name = name;
-                        obj.zonesSensors[i].roomTemperature = roomTemperature;
-                        obj.zonesSensors[i].flowTemperature = flowTemperature;
-                        obj.zonesSensors[i].returnTemperature = returnTemperature;
+                        //add every sensor to array
+                        const sensor = {
+                            name: name,
+                            roomTemperature: roomTemperature,
+                            flowTemperature: flowTemperature,
+                            returnTemperature: returnTemperature
+                        };
+                        obj.zonesSensors.push(sensor);
 
                         //log current state
                         if (!this.disableLogInfo) {

package/src/deviceerv.js

@@ -128,8 +128,8 @@ class DeviceErv extends EventEmitter {
                     this.mqtt1 = new Mqtt({
                         host: this.mqtt.host,
                         port: this.mqtt.port || 1883,
-                        clientId: this.mqtt.clientId || `melcloud_${Math.random().toString(16).slice(3)}`,
-                        prefix: this.mqtt.prefix || `melcloud/${this.deviceTypeText}/${this.deviceName}`,
+                        clientId: this.mqtt.clientId ? `melcloud_${this.mqtt.clientId}_${Math.random().toString(16).slice(3)}` : `melcloud_${Math.random().toString(16).slice(3)}`,
+                        prefix: this.mqtt.prefix ? `melcloud/${this.mqtt.prefix}${this.deviceTypeText}/${this.deviceName}` : `melcloud/${this.deviceTypeText}/${this.deviceName}`,
                         user: this.mqtt.user,
                         passwd: this.mqtt.pass,
                         debug: this.mqtt.debug || false