npm - homebridge-melcloud-control - Versions diffs - 3.8.0-beta.2 → 3.8.0-beta.21 - Mend

homebridge-melcloud-control 3.8.0-beta.2 → 3.8.0-beta.21

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (9) hide show

package/config.schema.json CHANGED Viewed

@@ -833,7 +833,7 @@
                     "title": "Hide zone",
                     "type": "integer",
                     "minimum": 0,
-                    "maximum": 7,
+                    "maximum": 13,
                     "default": 0,
                     "oneOf": [
                       {
@@ -843,46 +843,82 @@
                         ]
                       },
                       {
-                        "title": "Zone 1",
+                        "title": "Heat Pump",
                         "enum": [
                           1
                         ]
                       },
                       {
-                        "title": "Zone 2",
+                        "title": "Heat Pump / Zone 1",
                         "enum": [
                           2
                         ]
                       },
                       {
-                        "title": "Zone 1/2",
+                        "title": "Heat Pump / Zone 1 / Hot Water",
                         "enum": [
                           3
                         ]
                       },
                       {
-                        "title": "Hot Water",
+                        "title": "Heat Pump / Zone 1 / Zone 2",
                         "enum": [
                           4
                         ]
                       },
                       {
-                        "title": "Zone 1/Hot Water",
+                        "title": "Heat Pump / Hot Water",
                         "enum": [
                           5
                         ]
                       },
                       {
-                        "title": "Zone 2/Hot Water",
+                        "title": "Heat Pump / Hot Water / Zone 2",
                         "enum": [
                           6
                         ]
                       },
                       {
-                        "title": "Zone 1/2/Hot Water",
+                        "title": "Zone 1",
                         "enum": [
                           7
                         ]
+                      },
+                      {
+                        "title": "Zone 1 / Hot Water",
+                        "enum": [
+                          8
+                        ]
+                      },
+                      {
+                        "title": "Zone 1 / Hot Water / Zone 2",
+                        "enum": [
+                          9
+                        ]
+                      },
+                      {
+                        "title": "Hot Water",
+                        "enum": [
+                          10
+                        ]
+                      },
+                      {
+                        "title": "Hot Water / Zone 2",
+                        "enum": [
+                          11
+                        ]
+                      },
+                      {
+                        "title": "Zone 2",
+                        "enum": [
+                          12
+                        ]
+                      },
+                      {
+                        "title": "All",
+                        "enum": [
+                          13
+                        ]
                       }
                     ],
                     "description": "Select which zone need to be hidden in HomeKit app, if present.",
@@ -1865,7 +1901,19 @@
                         }
                       ]
                     }
-                  ]
+                  ],
+                  "condition": {
+                    "functionBody": "return model.accounts[arrayIndices].ataDevices.length > 0;"
+                  }
+                },
+                {
+                  "key": "accounts[]",
+                  "type": "tabarray",
+                  "title": "{{ value.title }}",
+                  "items": [],
+                  "condition": {
+                    "functionBody": "return model.accounts[arrayIndices].ataDevices.length === 0;"
+                  }
                 }
               ]
             },
@@ -1887,6 +1935,7 @@
                       "readonly": true
                     },
                     "accounts[].atwDevices[].displayMode",
+                    "accounts[].atwDevices[].hideZone",
                     {
                       "key": "accounts[].atwDevices[]",
                       "type": "section",
@@ -1895,7 +1944,6 @@
                       "expanded": false,
                       "items": [
                         "accounts[].atwDevices[].name",
-                        "accounts[].atwDevices[].hideZone",
                         "accounts[].atwDevices[].refreshInterval"
                       ]
                     },
@@ -1960,7 +2008,19 @@
                         }
                       ]
                     }
-                  ]
+                  ],
+                  "condition": {
+                    "functionBody": "return model.accounts[arrayIndices].atwDevices.length > 0;"
+                  }
+                },
+                {
+                  "key": "accounts[]",
+                  "type": "tabarray",
+                  "title": "{{ value.title }}",
+                  "items": [],
+                  "condition": {
+                    "functionBody": "return model.accounts[arrayIndices].atwDevices.length === 0;"
+                  }
                 }
               ]
             },
@@ -2048,7 +2108,19 @@
                         }
                       ]
                     }
-                  ]
+                  ],
+                  "condition": {
+                    "functionBody": "return model.accounts[arrayIndices].ervDevices.length > 0;"
+                  }
+                },
+                {
+                  "key": "accounts[]",
+                  "type": "tabarray",
+                  "title": "{{ value.title }}",
+                  "items": [],
+                  "condition": {
+                    "functionBody": "return model.accounts[arrayIndices].ervDevices.length === 0;"
+                  }
                 }
               ]
             }

package/index.js CHANGED Viewed

@@ -169,7 +169,7 @@ class MelCloudPlatform {
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
 									//start impulse generator
-									const startImpulseGenerator = startDone ? await airConditioner.startImpulseGenerator() : false
+									const startImpulseGenerator = stopImpulseGenerator ? await airConditioner.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
 								};
@@ -235,7 +235,7 @@ class MelCloudPlatform {
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
 									//start impulse generator
-									const startImpulseGenerator = startDone ? await heatPump.startImpulseGenerator() : false
+									const startImpulseGenerator = stopImpulseGenerator ? await heatPump.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
 								};
@@ -247,7 +247,7 @@ class MelCloudPlatform {
 							await impulseGenerator.start([{ name: 'start', sampling: 45000 }]);
 						};
 					} catch (error) {
-						const emitLog = disableLogError ? false : log.error(`${accountName}, ATE did finish launching error: ${error}.`);
+						const emitLog = disableLogError ? false : log.error(`${accountName}, ATW did finish launching error: ${error}.`);
 					}
 					//Energy Recovery Ventilation 3
@@ -301,7 +301,7 @@ class MelCloudPlatform {
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
 									//start impulse generator
-									const startImpulseGenerator = startDone ? await energyRecoveryVentilation.startImpulseGenerator() : false
+									const startImpulseGenerator = stopImpulseGenerator ? await energyRecoveryVentilation.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
 								};

package/package.json CHANGED Viewed

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.8.0-beta.2",
+  "version": "3.8.0-beta.21",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js CHANGED Viewed

@@ -249,6 +249,7 @@ class DeviceAta extends EventEmitter {
     async startImpulseGenerator() {
         try {
             //start impule generator
+            await new Promise(resolve => setTimeout(resolve, 1000));
             await this.melCloudAta.impulseGenerator.start([{ name: 'checkState', sampling: this.refreshInterval }]);
             return true;
         } catch (error) {
@@ -971,7 +972,7 @@ class DeviceAta extends EventEmitter {
                     this.firmwareRevision = firmwareAppVersion;
                     this.displayDeviceInfo = false;
                 })
-                .on('deviceState', (deviceData) => {
+                .on('deviceState', async (deviceData) => {
                     this.deviceData = deviceData;
                     //presets
@@ -1369,6 +1370,13 @@ class DeviceAta extends EventEmitter {
                         this.emit('message', `Temperature display unit: ${this.accessory.temperatureUnit}`);
                         this.emit('message', `Lock physical controls: ${this.accessory.lockPhysicalControl ? 'LOCKED' : 'UNLOCKED'}`);
                     };
+                    //prepare accessory
+                    if (this.startPrepareAccessory) {
+                        const accessory = await this.prepareAccessory(this.accountInfo, deviceData, this.deviceId, this.deviceTypeText, this.deviceName, this.accountName);
+                        this.emit('publishAccessory', accessory);
+                        this.startPrepareAccessory = false;
+                    }
                 })
                 .on('success', (success) => {
                     this.emit('success', success);
@@ -1396,18 +1404,7 @@ class DeviceAta extends EventEmitter {
             const startExternalIntegrations = this.restFul.enable || this.mqtt.enable ? await this.externalIntegrations() : false;
             //check state
-            const deviceData = await this.melCloudAta.checkState();
-            if (deviceData === false) {
-                return null;
-            }
-            //prepare accessory
-            if (this.startPrepareAccessory) {
-                const accessory = await this.prepareAccessory(this.accountInfo, deviceData, this.deviceId, this.deviceTypeText, this.deviceName, this.accountName);
-                this.emit('publishAccessory', accessory);
-                this.startPrepareAccessory = false;
-            }
+            await this.melCloudAta.checkState();
             return true;
         } catch (error) {