homebridge-melcloud-control 3.8.0-beta.14 → 3.8.0-beta.16

package/index.js

@@ -169,6 +169,7 @@ class MelCloudPlatform {
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
 
 									//start impulse generator 
+									const wait = stopImpulseGenerator ? await new Promise(resolve => setTimeout(resolve, 1500)) : false;
 									const startImpulseGenerator = stopImpulseGenerator ? await airConditioner.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
@@ -235,6 +236,7 @@ class MelCloudPlatform {
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
 
 									//start impulse generator 
+									const wait = stopImpulseGenerator ? await new Promise(resolve => setTimeout(resolve, 1500)) : false;
 									const startImpulseGenerator = stopImpulseGenerator ? await heatPump.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
@@ -301,6 +303,7 @@ class MelCloudPlatform {
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
 
 									//start impulse generator 
+									const wait = stopImpulseGenerator ? await new Promise(resolve => setTimeout(resolve, 1500)) : false;
 									const startImpulseGenerator = stopImpulseGenerator ? await energyRecoveryVentilation.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.8.0-beta.14",
+  "version": "3.8.0-beta.16",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -1404,7 +1404,6 @@ class DeviceAta extends EventEmitter {
 
             //check state
             await this.melCloudAta.checkState();
-            await new Promise(resolve => setTimeout(resolve, 1000));
 
             return true;
         } catch (error) {

package/src/deviceatw.js

@@ -1338,27 +1338,23 @@ class DeviceAtw extends EventEmitter {
                     const presetsOnServer = deviceData.Presets ?? [];
 
                     //device info
-                    const hasZone1 = this.hideZone === 1 || this.hideZone === 3 || this.hideZone === 5 || this.hideZone === 7 ? false : true;
-                    const hasHotWaterTank = this.hideZone === 4 || this.hideZone === 5 || this.hideZone === 6 || this.hideZone === 7 || !deviceData.Device.HasHotWaterTank ? false : true;
-                    const hasZone2 = this.hideZone === 2 || this.hideZone === 3 || this.hideZone === 6 || this.hideZone === 7 || !deviceData.Device.HasZone2 ? false : true;
+                    const hasZone1 = ![1, 3, 5, 7].includes(this.hideZone);
+                    const hasHotWaterTank = ![4, 5, 6, 7].includes(this.hideZone) && deviceData.Device.HasHotWaterTank;
+                    const hasZone2 = ![2, 3, 6, 7].includes(this.hideZone) && deviceData.Device.HasZone2;
                     const canHeat = deviceData.Device.CanHeat ?? false;
                     const canCool = deviceData.Device.CanCool ?? false;
                     const heatCoolModes = canHeat && canCool ? 0 : canHeat ? 1 : canCool ? 2 : 3;
                     const temperatureIncrement = deviceData.Device.TemperatureIncrement ?? 1;
                     const minSetTemperature = deviceData.Device.MinSetTemperature ?? 10;
                     const maxSetTemperature = deviceData.Device.MaxSetTemperature ?? 30;
-                    const maxTankTemperature = deviceData.Device.MaxTankTemperature ?? 70
+                    const maxTankTemperature = deviceData.Device.MaxTankTemperature ?? 70;
 
                     //zones
-                    const zone1 = hasZone1 ? 1 : 0;
-                    const hotWater = hasHotWaterTank ? 1 : 0;
-                    const zone2 = hasZone2 ? 1 : 0;
-                    const zonesCount = 1 + zone1 + hotWater + zone2;
-
-                    //zone cases
-                    const caseZone1 = hasZone1 ? 1 : -1;
-                    const caseHotWater = hasHotWaterTank ? 2 : -1;
-                    const caseZone2 = hasZone2 ? hasHotWaterTank ? 3 : 2 : -1;
+                    let currentCase = 1;
+                    const caseZone1 = hasZone1 ? currentCase++ : -1;
+                    const caseHotWater = hasHotWaterTank ? currentCase++ : -1;
+                    const caseZone2 = hasZone2 ? currentCase++ : -1;
+                    const zonesCount = currentCase - 1;
 
                     //heat pump
                     const heatPumpName = 'Heat Pump';
@@ -1949,7 +1945,6 @@ class DeviceAtw extends EventEmitter {
 
             //check state
             await this.melCloudAtw.checkState();
-            await new Promise(resolve => setTimeout(resolve, 1000));
 
             return true;
         } catch (error) {

package/src/deviceerv.js

@@ -1269,7 +1269,6 @@ class DeviceErv extends EventEmitter {
 
             //check state
             await this.melCloudErv.checkState();
-            await new Promise(resolve => setTimeout(resolve, 1000));
 
             return true;
         } catch (error) {