homebridge-melcloud-control 3.8.0-beta.12 → 3.8.0-beta.14

package/index.js

@@ -247,7 +247,7 @@ class MelCloudPlatform {
 							await impulseGenerator.start([{ name: 'start', sampling: 45000 }]);
 						};
 					} catch (error) {
-						const emitLog = disableLogError ? false : log.error(`${accountName}, ATE did finish launching error: ${error}.`);
+						const emitLog = disableLogError ? false : log.error(`${accountName}, ATW did finish launching error: ${error}.`);
 					}
 
 					//Energy Recovery Ventilation 3

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.8.0-beta.12",
+  "version": "3.8.0-beta.14",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceatw.js

@@ -1338,9 +1338,9 @@ class DeviceAtw extends EventEmitter {
                     const presetsOnServer = deviceData.Presets ?? [];
 
                     //device info
-                    const hasZone1 = this.hideZone !== 1 || this.hideZone !== 5 || this.hideZone !== 7 ? true : false;
-                    const hasHotWaterTank = (this.hideZone !== 4 || this.hideZone !== 5 || this.hideZone !== 6 || this.hideZone !== 7) && deviceData.Device.HasHotWaterTank ? true : false;
-                    const hasZone2 = (this.hideZone !== 2 || this.hideZone !== 3 || this.hideZone !== 6 || this.hideZone !== 7) && deviceData.Device.HasZone2 ? true : false;
+                    const hasZone1 = this.hideZone === 1 || this.hideZone === 3 || this.hideZone === 5 || this.hideZone === 7 ? false : true;
+                    const hasHotWaterTank = this.hideZone === 4 || this.hideZone === 5 || this.hideZone === 6 || this.hideZone === 7 || !deviceData.Device.HasHotWaterTank ? false : true;
+                    const hasZone2 = this.hideZone === 2 || this.hideZone === 3 || this.hideZone === 6 || this.hideZone === 7 || !deviceData.Device.HasZone2 ? false : true;
                     const canHeat = deviceData.Device.CanHeat ?? false;
                     const canCool = deviceData.Device.CanCool ?? false;
                     const heatCoolModes = canHeat && canCool ? 0 : canHeat ? 1 : canCool ? 2 : 3;
@@ -1543,9 +1543,6 @@ class DeviceAtw extends EventEmitter {
                                         operationModeSetPropsMaxValue = [2, 2, 2, 0][heatCoolModes];
                                         operationModeSetPropsValidValues = [[0, 1, 2], [0, 1, 2], [1, 2], [0]][heatCoolModes];
                                         break;
-                                    default: //unknown zone detected
-                                        this.emit('message', `Unknown zone: ${i} detected`);
-                                        break;
                                 };
 
                                 //update characteristics
@@ -1653,9 +1650,6 @@ class DeviceAtw extends EventEmitter {
                                         operationModeSetPropsMaxValue = [3, 3, 2, 0][heatCoolModes];
                                         operationModeSetPropsValidValues = [[1, 2, 3], [1, 2, 3], [1, 2], [0]][heatCoolModes];
                                         break;
-                                    default: //unknown zone detected
-                                        this.emit('message', `Unknown zone: ${i} detected`);
-                                        break;
                                 };
 
                                 //update characteristics
@@ -1708,7 +1702,7 @@ class DeviceAtw extends EventEmitter {
                                         .updateCharacteristic(Characteristic.CurrentTemperature, returnTemperature)
                                 };
                                 break;
-                            case 1: //Zone 1
+                            case caseZone1: //Zone 1
                                 if (this.roomTemperatureZone1SensorService) {
                                     this.roomTemperatureZone1SensorService
                                         .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
@@ -1771,7 +1765,7 @@ class DeviceAtw extends EventEmitter {
                                     this.emit('message', `${heatPumpName}, Temperature display unit: ${this.accessory.temperatureUnit}`);
                                     this.emit('message', `${heatPumpName}, Lock physical controls: ${lockPhysicalControl ? 'LOCKED' : 'UNLOCKED'}`);
                                     break;
-                                case 1: //Zone 1 - HEAT THERMOSTAT, HEAT FLOW, HEAT CURVE, COOL THERMOSTAT, COOL FLOW, FLOOR DRY UP
+                                case caseZone1: //Zone 1 - HEAT THERMOSTAT, HEAT FLOW, HEAT CURVE, COOL THERMOSTAT, COOL FLOW, FLOOR DRY UP
                                     operationModeText = idleZone1 ? HeatPump.ZoneOperation[6] : HeatPump.ZoneOperation[operationModeZone1];
                                     this.emit('message', `${zone1Name}, Operation mode: ${operationModeText}`);
                                     this.emit('message', `${zone1Name}, Temperature: ${roomTemperature}${this.accessory.temperatureUnit}`);