homebridge-melcloud-control 3.6.8 → 3.6.9-beta.0

package/CHANGELOG.md

@@ -16,6 +16,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - do not configure it manually, always using Config UI X
   - required Homebridge v2.0.0 and above
 
+## [3.6.9] - (28.02.2025)
+
+## Changes
+
+- fix[#191](https://github.com/grzegorz914/homebridge-melcloud-control/issues/191)
+- cleanup
+
 ## [3.6.7] - (26.02.2025)
 
 ## Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.6.8",
+  "version": "3.6.9-beta.0",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -932,7 +932,7 @@ class DeviceAta extends EventEmitter {
 
             return accessory;
         } catch (error) {
-            throw new Error(`Prepare accessory error: ${error.message || error}`);
+            throw new Error(`Prepare accessory error: ${error}`);
         };
     };
 
@@ -1401,7 +1401,7 @@ class DeviceAta extends EventEmitter {
             const deviceData = await this.melCloudAta.checkState();
 
             if (deviceData === false) {
-                return false;
+                return null;
             }
 
             //prepare accessory

package/src/deviceatw.js

@@ -1290,7 +1290,7 @@ class DeviceAtw extends EventEmitter {
 
             return accessory;
         } catch (error) {
-            throw new Error(`Prepare accessory error: ${error.message || error}`);
+            throw new Error(`Prepare accessory error: ${error}`);
         };
     };
 
@@ -1944,7 +1944,7 @@ class DeviceAtw extends EventEmitter {
             const deviceData = await this.melCloudAtw.checkState();
 
             if (deviceData === false) {
-                return false;
+                return null;
             }
 
             //prepare accessory

package/src/deviceerv.js

@@ -853,7 +853,7 @@ class DeviceErv extends EventEmitter {
 
             return accessory;
         } catch (error) {
-            throw new Error(`Prepare accessory error: ${error.message || error}`);
+            throw new Error(`Prepare accessory error: ${error}`);
         };
     };
 
@@ -1266,7 +1266,7 @@ class DeviceErv extends EventEmitter {
             const deviceData = await this.melCloudErv.checkState();
 
             if (deviceData === false) {
-                return false;
+                return null;
             }
 
             //prepare accessory

package/src/melcloud.js

@@ -79,7 +79,7 @@ class MelCloud extends EventEmitter {
 
             if (contextKey === undefined || contextKey === null) {
                 this.emit('warn', `Context key: ${contextKey}, missing`)
-                return false;
+                return null;
             };
 
             //create axios instance post
@@ -114,7 +114,7 @@ class MelCloud extends EventEmitter {
 
             return obj;
         } catch (error) {
-            throw new Error(`Connect to MELCloud error: ${error.message || error}`);
+            throw new Error(`Connect to MELCloud error: ${error}`);
         };
     }
 
@@ -144,7 +144,7 @@ class MelCloud extends EventEmitter {
 
             if (!buildingsList) {
                 this.emit('warn', `No building found`);
-                return false;
+                return null;
             }
 
             //save buildings to the file
@@ -170,7 +170,7 @@ class MelCloud extends EventEmitter {
             const devicesCount = devices.length;
             if (devicesCount === 0) {
                 this.emit('warn', `No devices found`);
-                return false;
+                return null;
             }
 
             //save buildings to the file
@@ -179,7 +179,7 @@ class MelCloud extends EventEmitter {
 
             return devices;
         } catch (error) {
-            throw new Error(`Check devices list error: ${error.message || error}`);
+            throw new Error(`Check devices list error: ${error}`);
         };
     }
 
@@ -189,7 +189,7 @@ class MelCloud extends EventEmitter {
             const debug3 = this.enableDebugMode ? this.emit('debug', `Data saved to: ${path}`) : false;
             return true;
         } catch (error) {
-            throw new Error(`Save data error: ${error.message || error}`);
+            throw new Error(`Save data error: ${error}`);
         }
     }
 
@@ -203,7 +203,7 @@ class MelCloud extends EventEmitter {
             await this.saveData(this.accountFile, accountInfo);
             return true;
         } catch (error) {
-            throw new Error(`Send data error: ${error.message || error}`);
+            throw new Error(`Send data error: ${error}`);
         };
     };
 };

package/src/melcloudata.js

@@ -49,7 +49,7 @@ class MelCloudAta extends EventEmitter {
 
             if (!Array.isArray(devicesData)) {
                 this.emit('warn', `Device data not found`);
-                return false;
+                return null;
             }
             const deviceData = devicesData.find(device => device.DeviceID === this.deviceId);
             const debug = this.enableDebugMode ? this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`) : false;
@@ -356,7 +356,7 @@ class MelCloudAta extends EventEmitter {
 
             return deviceData;
         } catch (error) {
-            throw new Error(`Check state error: ${error.message || error}`);
+            throw new Error(`Check state error: ${error}`);
         };
     };
 
@@ -364,10 +364,18 @@ class MelCloudAta extends EventEmitter {
     async readData(path) {
         try {
             const savedData = await fsPromises.readFile(path)
-            const data = savedData.length > 0 ? JSON.parse(savedData) : false;
-            return data;
+            if (savedData.trim().length === 0) {
+                return null;
+            }
+
+            try {
+                const data = JSON.parse(savedData);
+                return data;
+            } catch (error) {
+                throw new Error(`Parse JSON error: ${error}`);
+            }
         } catch (error) {
-            throw new Error(`Read data error: ${error.message || error}`);
+            throw new Error(`Read data error: ${error}`);
         }
     }
 
@@ -433,7 +441,7 @@ class MelCloudAta extends EventEmitter {
             this.updateData(deviceData);
             return true;
         } catch (error) {
-            throw new Error(`Send data error: ${error.message || error}`);
+            throw new Error(`Send data error: ${error}`);
         };
     };
 

package/src/melcloudatw.js

@@ -49,7 +49,7 @@ class MelCloudAtw extends EventEmitter {
 
             if (!Array.isArray(devicesData)) {
                 this.emit('warn', `Device data not found`);
-                return false;
+                return null;
             }
             const deviceData = devicesData.find(device => device.DeviceID === this.deviceId);
             const debug = this.enableDebugMode ? this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`) : false;
@@ -420,17 +420,25 @@ class MelCloudAtw extends EventEmitter {
 
             return deviceData;
         } catch (error) {
-            throw new Error(`Check state error: ${error.message || error}`);
+            throw new Error(`Check state error: ${error}`);
         };
     };
 
     async readData(path) {
         try {
             const savedData = await fsPromises.readFile(path)
-            const data = savedData.length > 0 ? JSON.parse(savedData) : false;
-            return data;
+            if (savedData.trim().length === 0) {
+                return null;
+            }
+
+            try {
+                const data = JSON.parse(savedData);
+                return data;
+            } catch (error) {
+                throw new Error(`Parse JSON error: ${error}`);
+            }
         } catch (error) {
-            throw new Error(`Read data error: ${error.message || error}`);
+            throw new Error(`Read data error: ${error}`);
         }
     }
 
@@ -478,7 +486,7 @@ class MelCloudAtw extends EventEmitter {
             this.updateData(deviceData);
             return true;
         } catch (error) {
-            throw new Error(`Send data error: ${error.message || error}`);
+            throw new Error(`Send data error: ${error}`);
         };
     };
 

package/src/melclouderv.js

@@ -49,7 +49,7 @@ class MelCloudErv extends EventEmitter {
 
             if (!Array.isArray(devicesData)) {
                 this.emit('warn', `Device data not found`);
-                return false;
+                return null;
             }
             const deviceData = devicesData.find(device => device.DeviceID === this.deviceId);
             const debug = this.enableDebugMode ? this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`) : false;
@@ -344,17 +344,25 @@ class MelCloudErv extends EventEmitter {
 
             return deviceData;
         } catch (error) {
-            throw new Error(`Check state error: ${error.message || error}`);
+            throw new Error(`Check state error: ${error}`);
         };
     };
 
     async readData(path) {
         try {
             const savedData = await fsPromises.readFile(path)
-            const data = savedData.length > 0 ? JSON.parse(savedData) : false;
-            return data;;
+            if (savedData.trim().length === 0) {
+                return null;
+            }
+
+            try {
+                const data = JSON.parse(savedData);
+                return data;
+            } catch (error) {
+                throw new Error(`Parse JSON error: ${error}`);
+            }
         } catch (error) {
-            throw new Error(`Read data error: ${error.message || error}`);
+            throw new Error(`Read data error: ${error}`);
         }
     }
 
@@ -404,7 +412,7 @@ class MelCloudErv extends EventEmitter {
             this.updateData(deviceData);
             return true;
         } catch (error) {
-            throw new Error(`Send data error: ${error.message || error}`);
+            throw new Error(`Send data error: ${error}`);
         };
     };