homebridge-melcloud-control 3.6.2 → 3.6.4

package/CHANGELOG.md

@@ -16,6 +16,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - do not configure it manually, always using Config UI X
   - required Homebridge v2.0.0 and above
 
+## [3.6.4] - (09.02.2025)
+
+## Changes
+
+- fix plugin crash if config dosnt contain devices
+
+## [3.6.3] - (07.02.2025)
+
+## Changes
+
+- stability and improvements
+
 ## [3.6.2] - (04.03.2025)
 
 ## Changes

package/LICENSE

@@ -1,4 +1,4 @@
-MIT License
+# MIT License
 
 Copyright (c) 2022 Grzegorz
 

package/README.md

@@ -297,7 +297,7 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
 ### RESTful Integration
 
 * Port: last 4 numbers of `device Id`, displayed in HB log during start.
-* POST data as a JSON Object `{OperationMode: 8}`
+* POST data as a JSON Object `{OperationMode: 8}`, content type must be `application/json`
 
 | Method | URL | Path | Response | Type |
 | --- | --- | --- | --- | --- |

package/index.js

@@ -112,12 +112,13 @@ class MelCloudPlatform {
 					}
 
 					//start impulse generator
-					const timers = [{ name: 'checkDevicesList', sampling: refreshInterval }];
-					await melCloud.impulseGenerator.start(timers);
+					await melCloud.impulseGenerator.start([{ name: 'checkDevicesList', sampling: refreshInterval }]);
 
 					//Air Conditioner 0
 					try {
-						for (const device of account.ataDevices) {
+						const ataDevices = account.ataDevices ?? [];
+						const emitLog = !enableDebugMode ? false : log.info(`Found configured ATA devices: ${ataDevices.length}.`);
+						for (const device of ataDevices) {
 							//chack device from config exist on melcloud
 							const deviceId = device.id;
 							const displayMode = device.displayMode > 0 ?? false;
@@ -161,6 +162,9 @@ class MelCloudPlatform {
 								try {
 									const startDone = await airConditioner.start();
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
+
+									//start impulse generator 
+									const startImpulseGenerator = startDone ? await airConditioner.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
 								};
@@ -177,7 +181,9 @@ class MelCloudPlatform {
 
 					//Heat Pump 1
 					try {
-						for (const device of account.atwDevices) {
+						const atwDevices = account.atwDevices ?? [];
+						const emitLog = !enableDebugMode ? false : log.info(`Found configured ATW devices: ${atwDevices.length}.`);
+						for (const device of atwDevices) {
 							//chack device from config exist on melcloud
 							const deviceId = device.id;
 							const displayMode = device.displayMode > 0 ?? false;
@@ -221,6 +227,9 @@ class MelCloudPlatform {
 								try {
 									const startDone = await heatPump.start();
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
+
+									//start impulse generator 
+									const startImpulseGenerator = startDone ? await heatPump.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
 								};
@@ -237,7 +246,9 @@ class MelCloudPlatform {
 
 					//Energy Recovery Ventilation 3
 					try {
-						for (const device of account.ervDevices) {
+						const ervDevices = account.ervDevices ?? [];
+						const emitLog = !enableDebugMode ? false : log.info(`Found configured ERV devices: ${ervDevices.length}.`);
+						for (const device of ervDevices) {
 							//chack device from config exist on melcloud
 							const deviceId = device.id;
 							const displayMode = device.displayMode > 0 ?? false;
@@ -281,6 +292,9 @@ class MelCloudPlatform {
 								try {
 									const startDone = await energyRecoveryVentilation.start();
 									const stopImpulseGenerator = startDone ? await impulseGenerator.stop() : false;
+
+									//start impulse generator 
+									const startImpulseGenerator = startDone ? await energyRecoveryVentilation.startImpulseGenerator() : false
 								} catch (error) {
 									const emitLog = disableLogError ? false : log.error(`${accountName}, ${deviceTypeText}, ${deviceName}, ${error}, trying again.`);
 								};

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.6.2",
+  "version": "3.6.4",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -250,6 +250,16 @@ class DeviceAta extends EventEmitter {
         };
     }
 
+    async startImpulseGenerator() {
+        try {
+            //start impule generator
+            await this.melCloudAta.impulseGenerator.start([{ name: 'checkState', sampling: this.refreshInterval }]);
+            return true;
+        } catch (error) {
+            throw new Error(`Impulse generator start error: ${error}`);
+        };
+    }
+
     //prepare accessory
     async prepareAccessory(accountInfo, deviceData, deviceId, deviceTypeText, deviceName, accountName) {
         try {
@@ -1399,9 +1409,6 @@ class DeviceAta extends EventEmitter {
                 const accessory = await this.prepareAccessory(this.accountInfo, deviceData, this.deviceId, this.deviceTypeText, this.deviceName, this.accountName);
                 this.emit('publishAccessory', accessory);
                 this.startPrepareAccessory = false;
-
-                //start impule generator
-                await this.melCloudAta.impulseGenerator.start([{ name: 'checkState', sampling: this.refreshInterval }]);
             }
 
             return true;

package/src/deviceatw.js

@@ -274,6 +274,16 @@ class DeviceAtw extends EventEmitter {
         };
     }
 
+    async startImpulseGenerator() {
+        try {
+            //start impule generator
+            await this.melCloudAtw.impulseGenerator.start([{ name: 'checkState', sampling: this.refreshInterval }]);
+            return true;
+        } catch (error) {
+            throw new Error(`Impulse generator start error: ${error}`);
+        };
+    }
+
     //prepare accessory
     async prepareAccessory(accountInfo, deviceData, deviceId, deviceTypeText, deviceName, accountName) {
         try {
@@ -1941,9 +1951,6 @@ class DeviceAtw extends EventEmitter {
                 const accessory = await this.prepareAccessory(this.accountInfo, deviceData, this.deviceId, this.deviceTypeText, this.deviceName, this.accountName);
                 this.emit('publishAccessory', accessory);
                 this.startPrepareAccessory = false;
-
-                //start impule generator
-                await this.melCloudAtw.impulseGenerator.start([{ name: 'checkState', sampling: this.refreshInterval }]);
             }
 
             return true;

package/src/deviceerv.js

@@ -166,6 +166,16 @@ class DeviceErv extends EventEmitter {
         };
     }
 
+    async startImpulseGenerator() {
+        try {
+            //start impule generator
+            await this.melCloudErv.impulseGenerator.start([{ name: 'checkState', sampling: this.refreshInterval }]);
+            return true;
+        } catch (error) {
+            throw new Error(`Impulse generator start error: ${error}`);
+        };
+    }
+
     //prepare accessory
     async prepareAccessory(accountInfo, deviceData, deviceId, deviceTypeText, deviceName, accountName) {
         try {
@@ -1192,9 +1202,6 @@ class DeviceErv extends EventEmitter {
                 const accessory = await this.prepareAccessory(this.accountInfo, deviceData, this.deviceId, this.deviceTypeText, this.deviceName, this.accountName);
                 this.emit('publishAccessory', accessory);
                 this.startPrepareAccessory = false;
-
-                //start impule generator
-                await this.melCloudErv.impulseGenerator.start([{ name: 'checkState', sampling: this.refreshInterval }]);
             }
 
             return true;

package/src/restful.js

@@ -20,27 +20,35 @@ class RestFul extends EventEmitter {
             const restFul = express();
             restFul.set('json spaces', 2);
             restFul.use(json());
+
+            // GET Routes
             restFul.get('/info', (req, res) => { res.json(this.restFulData.info) });
             restFul.get('/state', (req, res) => { res.json(this.restFulData.state) });
 
-            //post data
+            // POST Route
             restFul.post('/', (req, res) => {
                 try {
                     const obj = req.body;
-                    const emitDebug = this.restFulDebug ? this.emit('debug', `RESTFul post data: ${JSON.stringify(obj, null, 2)}`) : false;
+                    if (!obj || typeof obj !== 'object' || Object.keys(obj).length === 0) {
+                        this.emit('warn', `RESTFul Invalid JSON payload`);
+                        return res.status(400).json({ error: 'RESTFul Invalid JSON payload' });
+                    }
                     const key = Object.keys(obj)[0];
-                    const value = Object.values(obj)[0];
+                    const value = obj[key];
                     this.emit('set', key, value);
-                    res.send('OK');
+
+                    const emitDebug = this.restFulDebug ? this.emit('debug', `RESTFul post data: ${JSON.stringify(obj, null, 2)}`) : false;
+                    res.json({ success: true, received: obj });
                 } catch (error) {
-                    this.emit('warn', `RESTFul Parse object error: ${error}`);
-                };
+                    this.emit('warn', `RESTFul Parse error: ${error}`);
+                    res.status(500).json({ error: 'RESTFul Internal Server Error' });
+                }
             });
 
+            // Start server
             restFul.listen(this.restFulPort, () => {
-                this.emit('connected', `RESTful started on port: ${this.restFulPort}`)
+                this.emit('connected', `RESTful started on port: ${this.restFulPort}`);
             });
-
         } catch (error) {
             this.emit('warn', `RESTful Connect error: ${error}`)
         }