homebridge-melcloud-control 3.3.2 → 3.3.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (6) hide show
  1. package/CHANGELOG.md +8 -0
  2. package/index.js +1 -1
  3. package/package.json +1 -1
  4. package/src/deviceata.js +6 -9
  5. package/src/deviceatw.js +2 -5
  6. package/src/deviceerv.js +1 -4
package/CHANGELOG.md CHANGED
@@ -16,6 +16,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
16
16
  - do not configure it manually, always using Config UI X
17
17
  - required Homebridge v2.0.0 and above
18
18
 
19
+ ## [3.3.3] - (13.09.2024)
20
+
21
+ ## Changes
22
+
23
+ - fix[#159](https://github.com/grzegorz914/homebridge-melcloud-control/issues/159)
24
+ - fix [#158](https://github.com/grzegorz914/homebridge-melcloud-control/issues/158)
25
+ - cleanup
26
+
19
27
  ## [3.3.2] - (13.09.2024)
20
28
 
21
29
  ## Changes
package/index.js CHANGED
@@ -162,7 +162,7 @@ class MelCloudPlatform {
162
162
 
163
163
  const deviceName = device.name;
164
164
  const deviceTypeText = device.typeString;
165
- const heatPump = new DeviceAtw(api, account, melCloud, device, accountInfo, contextKey, accountName, deviceId, deviceName, deviceTypeText, devicesFile, deviceRefreshInterval, useFahrenheit)
165
+ const heatPump = new DeviceAtw(api, account, device, melCloud, accountInfo, contextKey, accountName, deviceId, deviceName, deviceTypeText, devicesFile, deviceRefreshInterval, useFahrenheit)
166
166
  heatPump.on('publishAccessory', (accessory) => {
167
167
 
168
168
  //publish device
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "displayName": "MELCloud Control",
3
3
  "name": "homebridge-melcloud-control",
4
- "version": "3.3.2",
4
+ "version": "3.3.4",
5
5
  "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
6
6
  "license": "MIT",
7
7
  "author": "grzegorz914",
package/src/deviceata.js CHANGED
@@ -291,7 +291,7 @@ class DeviceAta extends EventEmitter {
291
291
  break;
292
292
  case 2: //DRY
293
293
  this.accessory.currentOperationMode = roomTemperature < setTemperature ? 1 : 3;
294
- this.accessory.targetOperationMode = this.autoDryFanMode === 2 ? 0 : this.heatDryFanMode === 1 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
294
+ this.accessory.targetOperationMode = this.autoDryFanMode === 2 ? 0 : this.heatDryFanMode === 2 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
295
295
  break;
296
296
  case 3: //COOL
297
297
  this.accessory.currentOperationMode = roomTemperature < setTemperature ? 1 : 3;
@@ -311,7 +311,7 @@ class DeviceAta extends EventEmitter {
311
311
  break;
312
312
  case 10: //ISEE DRY
313
313
  this.accessory.currentOperationMode = roomTemperature < setTemperature ? 1 : 3;
314
- this.accessory.targetOperationMode = this.autoDryFanMode === 2 ? 0 : this.heatDryFanMode === 1 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
314
+ this.accessory.targetOperationMode = this.autoDryFanMode === 2 ? 0 : this.heatDryFanMode === 2 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
315
315
  break;
316
316
  case 11: //ISEE COOL;
317
317
  this.accessory.currentOperationMode = roomTemperature < setTemperature ? 1 : 3;
@@ -389,7 +389,7 @@ class DeviceAta extends EventEmitter {
389
389
  break;
390
390
  case 2: //DRY
391
391
  this.accessory.currentOperationMode = 2;
392
- this.accessory.targetOperationMode = this.autoDryFanMode === 3 ? 3 : this.heatDryFanMode === 1 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
392
+ this.accessory.targetOperationMode = this.autoDryFanMode === 2 ? 3 : this.heatDryFanMode === 2 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
393
393
  break;
394
394
  case 3: //COOL
395
395
  this.accessory.currentOperationMode = 2;
@@ -397,7 +397,7 @@ class DeviceAta extends EventEmitter {
397
397
  break;
398
398
  case 7: //FAN
399
399
  this.accessory.currentOperationMode = 2;
400
- this.accessory.targetOperationMode = this.autoDryFanMode === 3 ? 0 : this.heatDryFanMode === 3 ? 1 : this.coolDryFanMode === 3 ? 2 : this.accessory.targetOperationMode;
400
+ this.accessory.targetOperationMode = this.autoDryFanMode === 3 ? 3 : this.heatDryFanMode === 3 ? 1 : this.coolDryFanMode === 3 ? 2 : this.accessory.targetOperationMode;
401
401
  break;
402
402
  case 8: //AUTO
403
403
  this.accessory.currentOperationMode = roomTemperature > defaultHeatingSetTemperature && roomTemperature < defaultCoolingSetTemperature ? this.accessory.currentOperationMode : roomTemperature <= defaultHeatingSetTemperature ? 1 : roomTemperature >= defaultCoolingSetTemperature ? 2 : 0;
@@ -409,7 +409,7 @@ class DeviceAta extends EventEmitter {
409
409
  break;
410
410
  case 10: //ISEE DRY
411
411
  this.accessory.currentOperationMode = 2;
412
- this.accessory.targetOperationMode = this.autoDryFanMode === 3 ? 3 : this.heatDryFanMode === 1 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
412
+ this.accessory.targetOperationMode = this.autoDryFanMode === 2 ? 3 : this.heatDryFanMode === 2 ? 1 : this.coolDryFanMode === 2 ? 2 : this.accessory.targetOperationMode;
413
413
  break;
414
414
  case 11: //ISEE COOL;
415
415
  this.accessory.currentOperationMode = 2;
@@ -446,9 +446,6 @@ class DeviceAta extends EventEmitter {
446
446
  const updateDefCool = modelSupportsAuto && modelSupportsCool ? this.melCloudService.updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature) : false;
447
447
  };
448
448
  break;
449
- default:
450
- this.emit('warn', `Unknown display mode: ${displayMode}`);
451
- return;
452
449
  };
453
450
 
454
451
  if (this.roomTemperatureSensorService) {
@@ -1040,7 +1037,7 @@ class DeviceAta extends EventEmitter {
1040
1037
  });
1041
1038
  this.melCloudService.getCharacteristic(Characteristic.TargetTemperature)
1042
1039
  .setProps({
1043
- minValue: 0,
1040
+ minValue: 10,
1044
1041
  maxValue: 31,
1045
1042
  minStep: this.accessory.temperatureIncrement
1046
1043
  })
package/src/deviceatw.js CHANGED
@@ -381,7 +381,7 @@ class DeviceAtw extends EventEmitter {
381
381
  };
382
382
 
383
383
  //update characteristics
384
- if (this.melCloudServices && currentOperationMode !== undefined && targetOperationMode !== undefined) {
384
+ if (this.melCloudServices) {
385
385
  this.melCloudServices[i]
386
386
  .updateCharacteristic(Characteristic.Active, power ? 1 : 0)
387
387
  .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, currentOperationMode)
@@ -453,7 +453,7 @@ class DeviceAtw extends EventEmitter {
453
453
  };
454
454
 
455
455
  //update characteristics
456
- if (this.melCloudServices && currentOperationMode !== undefined && targetOperationMode !== undefined) {
456
+ if (this.melCloudServices) {
457
457
  this.melCloudServices[i]
458
458
  .updateCharacteristic(Characteristic.CurrentHeatingCoolingState, currentOperationMode)
459
459
  .updateCharacteristic(Characteristic.TargetHeatingCoolingState, targetOperationMode)
@@ -462,9 +462,6 @@ class DeviceAtw extends EventEmitter {
462
462
  .updateCharacteristic(Characteristic.TemperatureDisplayUnits, this.accessory.useFahrenheit);
463
463
  }
464
464
  break;
465
- default:
466
- this.emit('warn', `Unknown display mode: ${displayMode}`);
467
- return;
468
465
  };
469
466
 
470
467
  //push value to arrays
package/src/deviceerv.js CHANGED
@@ -417,9 +417,6 @@ class DeviceErv extends EventEmitter {
417
417
  const updateDefCool = hasAutoVentilationMode && hasCoolOperationMode ? this.melCloudService.updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature) : false;
418
418
  };
419
419
  break;
420
- default:
421
- this.emit('warn', `Unknown display mode: ${displayMode}`);
422
- return;
423
420
  };
424
421
 
425
422
  //update temperature sensors
@@ -939,7 +936,7 @@ class DeviceErv extends EventEmitter {
939
936
  });
940
937
  this.melCloudService.getCharacteristic(Characteristic.TargetTemperature)
941
938
  .setProps({
942
- minValue: 0,
939
+ minValue: 10,
943
940
  maxValue: 31,
944
941
  minStep: this.accessory.temperatureIncrement
945
942
  })