homebridge-melcloud-control 3.3.2 → 3.3.3

package/CHANGELOG.md

@@ -16,6 +16,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - do not configure it manually, always using Config UI X
   - required Homebridge v2.0.0 and above
 
+## [3.3.3] - (13.09.2024)
+
+## Changes
+
+- fix[#159](https://github.com/grzegorz914/homebridge-melcloud-control/issues/159)
+- fix [#158](https://github.com/grzegorz914/homebridge-melcloud-control/issues/158)
+- cleanup
+
 ## [3.3.2] - (13.09.2024)
 
 ## Changes

package/index.js

@@ -162,7 +162,7 @@ class MelCloudPlatform {
 
 							const deviceName = device.name;
 							const deviceTypeText = device.typeString;
-							const heatPump = new DeviceAtw(api, account, melCloud, device, accountInfo, contextKey, accountName, deviceId, deviceName, deviceTypeText, devicesFile, deviceRefreshInterval, useFahrenheit)
+							const heatPump = new DeviceAtw(api, account, device, melCloud, accountInfo, contextKey, accountName, deviceId, deviceName, deviceTypeText, devicesFile, deviceRefreshInterval, useFahrenheit)
 							heatPump.on('publishAccessory', (accessory) => {
 
 								//publish device

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "3.3.2",
+  "version": "3.3.3",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -446,9 +446,6 @@ class DeviceAta extends EventEmitter {
                                 const updateDefCool = modelSupportsAuto && modelSupportsCool ? this.melCloudService.updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature) : false;
                             };
                             break;
-                        default:
-                            this.emit('warn', `Unknown display mode: ${displayMode}`);
-                            return;
                     };
 
                     if (this.roomTemperatureSensorService) {
@@ -1040,7 +1037,7 @@ class DeviceAta extends EventEmitter {
                         });
                     this.melCloudService.getCharacteristic(Characteristic.TargetTemperature)
                         .setProps({
-                            minValue: 0,
+                            minValue: 10,
                             maxValue: 31,
                             minStep: this.accessory.temperatureIncrement
                         })

package/src/deviceatw.js

@@ -381,7 +381,7 @@ class DeviceAtw extends EventEmitter {
                                 };
 
                                 //update characteristics
-                                if (this.melCloudServices && currentOperationMode !== undefined && targetOperationMode !== undefined) {
+                                if (this.melCloudServices) {
                                     this.melCloudServices[i]
                                         .updateCharacteristic(Characteristic.Active, power ? 1 : 0)
                                         .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, currentOperationMode)
@@ -453,7 +453,7 @@ class DeviceAtw extends EventEmitter {
                                 };
 
                                 //update characteristics
-                                if (this.melCloudServices && currentOperationMode !== undefined && targetOperationMode !== undefined) {
+                                if (this.melCloudServices) {
                                     this.melCloudServices[i]
                                         .updateCharacteristic(Characteristic.CurrentHeatingCoolingState, currentOperationMode)
                                         .updateCharacteristic(Characteristic.TargetHeatingCoolingState, targetOperationMode)
@@ -462,9 +462,6 @@ class DeviceAtw extends EventEmitter {
                                         .updateCharacteristic(Characteristic.TemperatureDisplayUnits, this.accessory.useFahrenheit);
                                 }
                                 break;
-                            default:
-                                this.emit('warn', `Unknown display mode: ${displayMode}`);
-                                return;
                         };
 
                         //push value to arrays

package/src/deviceerv.js

@@ -417,9 +417,6 @@ class DeviceErv extends EventEmitter {
                                 const updateDefCool = hasAutoVentilationMode && hasCoolOperationMode ? this.melCloudService.updateCharacteristic(Characteristic.CoolingThresholdTemperature, defaultCoolingSetTemperature) : false;
                             };
                             break;
-                        default:
-                            this.emit('warn', `Unknown display mode: ${displayMode}`);
-                            return;
                     };
 
                     //update temperature sensors
@@ -939,7 +936,7 @@ class DeviceErv extends EventEmitter {
                         });
                     this.melCloudService.getCharacteristic(Characteristic.TargetTemperature)
                         .setProps({
-                            minValue: 0,
+                            minValue: 10,
                             maxValue: 31,
                             minStep: this.accessory.temperatureIncrement
                         })