homebridge-melcloud-control 2.5.0-beta.40 → 2.5.0-beta.42

package/config.schema.json

@@ -205,7 +205,7 @@
               "description": "Here select the language used in MELCloud account.",
               "required": true
             },
-            "devicesAta": {
+            "ataDevices": {
               "title": "Devices ATA",
               "type": "array",
               "items": {
@@ -258,7 +258,7 @@
               },
               "required": false
             },
-            "devicesAtw": {
+            "atwDevices": {
               "title": "Devices ATW",
               "type": "array",
               "items": {
@@ -312,7 +312,7 @@
               },
               "required": false
             },
-            "devicesErv": {
+            "ervDevices": {
               "title": "Devices ERV",
               "type": "array",
               "items": {
@@ -1591,15 +1591,15 @@
                   "title": "Air Conditioner",
                   "items": [
                     {
-                      "key": "accounts[].devicesAta",
+                      "key": "accounts[].ataDevices",
                       "type": "tabarray",
                       "title": "{{ value.name }}",
                       "items": [
-                        "accounts[].devicesAta[].displayMode"
-                      ],
-                      "condition": {
-                        "functionBody": "return model.accounts[arrayIndices].devicesAta.length > 0"
-                      }
+                        "accounts[].ataDevices[].name",
+                        "accounts[].ataDevices[].id",
+                        "accounts[].ataDevices[].type",
+                        "accounts[].ataDevices[].displayMode"
+                      ]
                     },
                     "accounts[].ataDisplayMode",
                     "accounts[].ataPresets",
@@ -1671,18 +1671,15 @@
                   "title": "Heat Pump",
                   "items": [
                     {
-                      "key": "accounts[].devicesAtw",
+                      "key": "accounts[].atwDevices",
                       "type": "tabarray",
                       "title": "{{ value.name }}",
                       "items": [
-                        "accounts[].devicesAtw[].name",
-                        "accounts[].devicesAtw[].id",
-                        "accounts[].devicesAtw[].type",
-                        "accounts[].devicesAtw[].displayMode"
-                      ],
-                      "condition": {
-                        "functionBody": "return model.accounts[arrayIndices].devicesAtw.length > 0"
-                      }
+                        "accounts[].atwDevices[].name",
+                        "accounts[].atwDevices[].id",
+                        "accounts[].atwDevices[].type",
+                        "accounts[].atwDevices[].displayMode"
+                      ]
                     },
                     "accounts[].atwDisplayMode",
                     "accounts[].atwPresets",
@@ -1749,18 +1746,15 @@
                   "title": "Energy Recovery Ventilation",
                   "items": [
                     {
-                      "key": "accounts[].devicesErv",
+                      "key": "accounts[].ervDevices",
                       "type": "tabarray",
                       "title": "{{ value.name }}",
                       "items": [
-                        "accounts[].devicesErv[].name",
-                        "accounts[].devicesErv[].id",
-                        "accounts[].devicesErv[].type",
-                        "accounts[].devicesErv[].displayMode"
-                      ],
-                      "condition": {
-                        "functionBody": "return model.accounts[arrayIndices].devicesErv.length > 0"
-                      }
+                        "accounts[].ervDevices[].name",
+                        "accounts[].ervDevices[].id",
+                        "accounts[].ervDevices[].type",
+                        "accounts[].ervDevices[].displayMode"
+                      ]
                     },
                     "accounts[].ervDisplayMode",
                     "accounts[].ervPresets",

package/homebridge-ui/public/index.html

@@ -147,31 +147,32 @@
         const info = response.info ?? '';
         const status = response.status;
         const devices = response.data ?? [];
-        const typeAta = [];
-        const typeAtw = [];
-        const typeErv = [];
+        const newDevices = [];
 
         switch (status) {
           case 0:
-            const devicesCount = devices.length;
-            document.getElementById('info').innerHTML = `Success, found ${devicesCount} ${devicesCount !== 1 ? 'devices' : 'device'}. Now You can start to configure it.`;
-            document.getElementById('info').style.color = 'green';
-
             //get device info fom devices
             devices.forEach((deviceInfo, index) => {
               const deviceType = deviceInfo.Type;
               const deviceId = deviceInfo.DeviceID;
               const deviceName = deviceInfo.DeviceName;
+              const ataDevices = pluginConfig[0].accounts[this.deviceIndex].ataDevices;
+              const atwDevices = pluginConfig[0].accounts[this.deviceIndex].atwDevices;
+              const ervDevices = pluginConfig[0].accounts[this.deviceIndex].ervDevices;
+              const ataDeviceIdExist = ataDevices.some(device => device.id === deviceId)
+              const atwDeviceIdExist = atwDevices.some(device => device.id === deviceId)
+              const ervDeviceIdExist = ervDevices.some(device => device.id === deviceId)
+              const pushNewDevice = !deviceIdExist ? newDevices.push(deviceId) : false;
 
               const device = { name: deviceName, id: deviceId, type: deviceType, displayMode: 0 };
-              const pushTypeAta = deviceType === 0 ? typeAta.push(device) : false;
-              const pushTypeAtw = deviceType === 1 ? typeAtw.push(device) : false;
-              const pushTypeErv = deviceType === 3 ? typeErv.push(device) : false;
+              const pushTypeAta = deviceType === 0 && !ataDeviceIdExist ? ataDevices.push(device) : false;
+              const pushTypeAtw = deviceType === 1 && !atwDeviceIdExist ? atwDevices.push(device) : false;
+              const pushTypeErv = deviceType === 3 && !ervDeviceIdExist ? ervDevices.push(device) : false;
             });
 
-            pluginConfig[0].accounts[this.deviceIndex].devicesAta = typeAta;
-            pluginConfig[0].accounts[this.deviceIndex].devicesAtw = typeAtw;
-            pluginConfig[0].accounts[this.deviceIndex].devicesErv = typeErv;
+            const devicesCount = newDevices.length;
+            document.getElementById('info').innerHTML = `Success, found ${devicesCount} ${devicesCount !== 1 ? 'new devices' : 'new device'}. Now You can start to configure it.`;
+            document.getElementById('info').style.color = 'green';
 
             await homebridge.updatePluginConfig(pluginConfig);
             await homebridge.savePluginConfig(pluginConfig);

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "2.5.0-beta.40",
+  "version": "2.5.0-beta.42",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",