homebridge-lib 5.8.0 → 6.0.1

package/lib/ServiceDelegate/History/Weather.js

@@ -48,7 +48,7 @@ class Weather extends ServiceDelegate.History {
     * @param {?CharacteristicDelegate} params.humidityDelegate - A reference
     * to the delegate of the associated
     * `Characteristics.hap.CurrentRelativeHumidity` characteristic.
-    * @param {?CharacteristicDelegate} params.pressureDelegate - A reference to
+    * @param {?CharacteristicDelegate} params.airPressureDelegate - A reference to
     * the delegate of the associated `Characteristics.eve.AirPressure`
     * characteristic.
     */
@@ -61,13 +61,13 @@ class Weather extends ServiceDelegate.History {
       params.humidityDelegate != null &&
       !(params.humidityDelegate instanceof homebridgeLib.CharacteristicDelegate)
     ) {
-      throw new TypeError('humidityDelegate: not a CharacteristicDelegate')
+      throw new TypeError('params.humidityDelegate: not a CharacteristicDelegate')
     }
     if (
-      params.pressureDelegate != null &&
-      !(params.pressureDelegate instanceof homebridgeLib.CharacteristicDelegate)
+      params.airPressureDelegate != null &&
+      !(params.airPressureDelegate instanceof homebridgeLib.CharacteristicDelegate)
     ) {
-      throw new TypeError('pressureDelegate: not a CharacteristicDelegate')
+      throw new TypeError('params.airPressureDelegate: not a CharacteristicDelegate')
     }
     this._entry = {
       time: 0,
@@ -81,9 +81,9 @@ class Weather extends ServiceDelegate.History {
       params.humidityDelegate.on('didSet', (value) => {
         this._entry.humidity = value
       })
-      if (params.pressureDelegate != null) {
-        this._entry.pressure = params.pressureDelegate.value
-        params.pressureDelegate.on('didSet', (value) => {
+      if (params.airPressureDelegate != null) {
+        this._entry.pressure = params.airPressureDelegate.value
+        params.airPressureDelegate.on('didSet', (value) => {
           this._entry.pressure = value
         })
       }

package/lib/ServiceDelegate/History/index.js

@@ -310,7 +310,9 @@ class History extends ServiceDelegate {
 
     let dataStream = ''
     for (let i = 0; i < 11; i++) {
-      const address = this._h.currentEntry % this._memorySize
+      const address = this._memorySize === 0
+        ? 0
+        : this._h.currentEntry % this._memorySize
       if (
         this._h.history[address].setRefTime === 1 ||
         this._h.currentEntry === this._h.firstEntry + 1

package/lib/ServiceDelegate/index.js

@@ -47,6 +47,9 @@ class ServiceDelegate extends homebridgeLib.Delegate {
     * @params {?ServiceDelegate} params.linkedServiceDelegate - The delegate
     * of the service this service links to.
     * @params {?boolean} params.hidden - Hidden service.
+    * @params {?boolean} params.exposeConfiguredName - Expose
+    * `Characteristics.hap.ConfiguredName`, so device name can be synced with
+    * HomeKit service name.
     */
   constructor (accessoryDelegate, params = {}) {
     if (!(accessoryDelegate instanceof homebridgeLib.AccessoryDelegate)) {
@@ -117,24 +120,26 @@ class ServiceDelegate extends homebridgeLib.Delegate {
       value: params.name
     })
 
-    this.addCharacteristicDelegate({
-      key: 'configuredName',
-      Characteristic: this.Characteristics.hap.ConfiguredName,
-      value: params.name,
-      setter: (value) => {
-        if (value == null || value === '') {
-          throw new Error('cannot be empty')
+    if (params.exposeConfiguredName) {
+      this.addCharacteristicDelegate({
+        key: 'configuredName',
+        Characteristic: this.Characteristics.hap.ConfiguredName,
+        value: params.name,
+        setter: (value) => {
+          if (value == null || value === '') {
+            throw new Error('cannot be empty')
+          }
         }
-      }
-    }).on('didSet', (value) => {
-      this.name = value
-      for (const key in this._characteristicDelegates) {
-        this._characteristicDelegates[key].name = value
-      }
-      if (params.primaryService) {
-        accessoryDelegate.values.name = value
-      }
-    })
+      }).on('didSet', (value) => {
+        this.name = value
+        for (const key in this._characteristicDelegates) {
+          this._characteristicDelegates[key].name = value
+        }
+        if (params.primaryService) {
+          accessoryDelegate.values.name = value
+        }
+      })
+    }
 
     this.once('initialised', () => {
       this.values.configuredName = this.name

package/package.json

@@ -3,7 +3,7 @@
   "description": "Library for homebridge plugins",
   "author": "Erik Baauw",
   "license": "Apache-2.0",
-  "version": "5.8.0",
+  "version": "6.0.1",
   "keywords": [
     "homekit",
     "homebridge"