homebridge-intratone 0.5.0 → 0.5.1

package/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 All notable changes to `homebridge-intratone`. Versions follow [semver](https://semver.org/).
 
+## [0.5.1] - 2026-11-12
+
+### Fixed
+
+- The **Regenerate device ID** button did nothing: the settings UI runs in a sandboxed iframe
+  without `allow-modals`, so the `window.confirm()` it used was blocked. It now confirms inline.
+- The settings page left a large empty area and a prominent "Device identity" block. The device-ID
+  tools are now a compact, collapsed **Device ID (advanced)** section, and the page resizes to its
+  content so there is no empty space.
+
 ## [0.5.0] - 2026-11-12
 
 ### Added
@@ -165,6 +175,7 @@ two-way audio are out of scope.
   masked.
 - MIT license.
 
+[0.5.1]: https://github.com/jtoucas-DIMO/Homebridge-Intratone/releases/tag/v0.5.1
 [0.5.0]: https://github.com/jtoucas-DIMO/Homebridge-Intratone/releases/tag/v0.5.0
 [0.4.2]: https://github.com/jtoucas-DIMO/Homebridge-Intratone/releases/tag/v0.4.2
 [0.4.1]: https://github.com/jtoucas-DIMO/Homebridge-Intratone/releases/tag/v0.4.1

package/homebridge-ui/public/index.html

@@ -1,13 +1,22 @@
 <!-- Custom settings page for homebridge-config-ui-x.
-     Keeps the standard form (phone number, service, Advanced) and adds two user-facing helpers:
-     a rename-your-doors list and a "Regenerate device ID" button. The technical connection values
-     live in the Advanced fields (Device ID is pre-filled with the effective value). The form is
-     shown via showSchemaForm() only once a config block exists (config-ui-x gates it on that). -->
-<div id="intratone-doors" class="mb-3"></div>
-<div id="intratone-device" class="mb-3"></div>
+     Adds a rename-your-doors list, and a collapsed "Device ID" advanced area with a Regenerate
+     button. The standard form (phone number, service, Advanced) is shown via showSchemaForm().
+     Note: the UI runs in a sandboxed iframe without allow-modals, so window.confirm/alert are
+     blocked — confirmation is done inline. -->
+<div id="intratone-doors" class="mb-2"></div>
+<div id="intratone-device"></div>
 
 <script>
   let started = false;
+  let block = { platform: 'Intratone', name: 'Intratone' };
+
+  function fit() {
+    try {
+      if (typeof homebridge.fixScrollHeight === 'function') {
+        homebridge.fixScrollHeight();
+      }
+    } catch (e) { /* ignore */ }
+  }
 
   async function init() {
     if (started) {
@@ -18,11 +27,9 @@
     const doors = document.getElementById('intratone-doors');
     const device = document.getElementById('intratone-device');
 
-    let block;
     try {
       let configs = await homebridge.getPluginConfig();
       if (!configs.length) {
-        // config-ui-x renders the schema form only once a config block exists.
         await homebridge.updatePluginConfig([{ platform: 'Intratone', name: 'Intratone' }]);
         configs = await homebridge.getPluginConfig();
       }
@@ -32,8 +39,8 @@
       return;
     }
 
-    // Fill the Advanced "Device ID" field with the effective id so it is not blank. Needs the
-    // phone number set (to resolve the account); harmless to skip before then.
+    // Fill the Advanced "Device ID" field with the effective id so it is not blank (needs the
+    // phone number set; harmless to skip before then).
     try {
       if (!block.device_id) {
         const info = await homebridge.request('/device', { config: block });
@@ -43,7 +50,7 @@
         }
       }
     } catch (error) {
-      // No phone number yet, or not resolvable — leave Device ID blank for now.
+      // No phone number yet — leave Device ID blank for now.
     }
 
     try {
@@ -52,8 +59,6 @@
       console.error('showSchemaForm failed', error);
     }
 
-    renderDeviceTools(device, block);
-
     let accesses;
     try {
       homebridge.showSpinner();
@@ -63,15 +68,17 @@
     } finally {
       homebridge.hideSpinner();
     }
-    renderDoors(doors, block, accesses);
+    renderDoors(doors, accesses);
+    renderDeviceTools(device);
+    fit();
   }
 
   homebridge.addEventListener('ready', init);
   setTimeout(init, 1500);
 
-  function note(parent, text) {
+  function note(parent, text, cls) {
     const p = document.createElement('p');
-    p.className = 'help-block text-muted';
+    p.className = (cls || 'help-block text-muted') + ' mb-1';
     p.textContent = text;
     parent.appendChild(p);
   }
@@ -86,30 +93,53 @@
     }).toUpperCase();
   }
 
-  function renderDeviceTools(container, block) {
+  function renderDeviceTools(container) {
     container.innerHTML = '';
-    const title = document.createElement('h5');
-    title.textContent = 'Device identity';
-    container.appendChild(title);
-    note(container, 'The device ID the plugin uses is shown in Advanced → Device ID. Regenerate it to log in as a brand-new device. A new device does NOT hold the 4G key until you claim it (which revokes the phone); put the old ID back to restore the current setup.');
-
-    const button = document.createElement('button');
-    button.type = 'button';
-    button.className = 'btn btn-secondary btn-sm';
-    button.textContent = 'Regenerate device ID';
-    button.addEventListener('click', () => {
-      if (!window.confirm('Generate a new device ID? The new device will not open the 4G doors until you claim the key (which revokes your phone), or until you set the ID back. Continue?')) {
-        return;
-      }
+    const details = document.createElement('details');
+    details.addEventListener('toggle', fit);
+
+    const summary = document.createElement('summary');
+    summary.textContent = 'Device ID (advanced)';
+    summary.style.cursor = 'pointer';
+    details.appendChild(summary);
+
+    note(details, 'Generate a new device identity. A new device will NOT open the 4G doors until you claim the key (which revokes the phone) or set the ID back. The ID in use is shown in Advanced → Device ID.');
+
+    const bar = document.createElement('div');
+    const regen = document.createElement('button');
+    regen.type = 'button';
+    regen.className = 'btn btn-secondary btn-sm';
+    regen.textContent = 'Regenerate device ID';
+    regen.addEventListener('click', () => {
       const id = newUuid();
-      block.device_id = id;
-      homebridge.updatePluginConfig([block]);
-      homebridge.toast.success('New device ID: ' + id + '. Press Save, then restart the Intratone child bridge.', 'Device ID');
+      bar.innerHTML = '';
+      note(bar, 'Set new device ID ' + id + '?', 'text-danger');
+      const yes = document.createElement('button');
+      yes.type = 'button';
+      yes.className = 'btn btn-danger btn-sm mr-2';
+      yes.textContent = 'Confirm';
+      yes.addEventListener('click', () => {
+        block.device_id = id;
+        homebridge.updatePluginConfig([block]);
+        homebridge.toast.success('New device ID set. Press Save, then restart the Intratone child bridge.', 'Device ID');
+        renderDeviceTools(container);
+        fit();
+      });
+      const no = document.createElement('button');
+      no.type = 'button';
+      no.className = 'btn btn-link btn-sm';
+      no.textContent = 'Cancel';
+      no.addEventListener('click', () => { renderDeviceTools(container); fit(); });
+      bar.appendChild(yes);
+      bar.appendChild(no);
+      fit();
     });
-    container.appendChild(button);
+    bar.appendChild(regen);
+    details.appendChild(bar);
+    container.appendChild(details);
   }
 
-  function overridesFromConfig(block) {
+  function overridesFromConfig() {
     const map = {};
     for (const entry of (block.access_names || [])) {
       if (entry && entry.access_id) {
@@ -119,7 +149,7 @@
     return map;
   }
 
-  function saveOverrides(block, map) {
+  function saveOverrides(map) {
     const list = Object.keys(map)
       .filter((id) => (map[id] || '').trim())
       .map((id) => ({ access_id: id, name: map[id].trim() }));
@@ -131,30 +161,32 @@
     homebridge.updatePluginConfig([block]);
   }
 
-  function renderDoors(container, block, accesses) {
+  function renderDoors(container, accesses) {
     container.innerHTML = '';
     const title = document.createElement('h5');
     title.textContent = 'Your doors';
+    title.className = 'mb-1';
     container.appendChild(title);
 
     if (!accesses || accesses.error) {
       const reason = accesses && accesses.error ? accesses.error : 'unavailable';
-      note(container, 'Could not list your doors (' + reason + '). Set the phone number below and Save first. You can also rename doors in Advanced via the config; unnamed doors keep their detected names in the Home app.');
+      note(container, 'Could not list your doors (' + reason + '). Set the phone number below and Save first; unnamed doors keep their detected names in the Home app.');
       return;
     }
 
     const list = accesses.openable || [];
-    const map = overridesFromConfig(block);
+    const map = overridesFromConfig();
 
     note(container, list.length
-      ? 'Type a name to show it in the Home app, then press Save. Renaming an existing door re-adds it in Home (it may briefly lose its room/automations). Leave blank to keep the detected name.'
-      : 'No openable doors detected yet. Once they appear, you can rename them here.');
+      ? 'Type a name to show it in the Home app, then press Save. Renaming an existing door re-adds it (it may briefly lose its room/automations).'
+      : 'No openable doors detected yet.');
 
     for (const door of list) {
       const group = document.createElement('div');
-      group.className = 'form-group';
+      group.className = 'form-group mb-2';
 
       const label = document.createElement('label');
+      label.className = 'mb-1';
       const where = door.residence ? door.residence + ' / ' : '';
       label.textContent = where + door.name + '  (id ' + door.id + ')';
       group.appendChild(label);
@@ -166,7 +198,7 @@
       input.value = map[door.id] || '';
       input.addEventListener('input', () => {
         map[door.id] = input.value;
-        saveOverrides(block, map);
+        saveOverrides(map);
       });
       group.appendChild(input);
       container.appendChild(group);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-intratone",
   "displayName": "Intratone",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Unofficial Homebridge plugin to open Intratone / Cogelec doors and gates from HomeKit and Matter (remote open, no doorbell).",
   "license": "MIT",
   "author": "jtoucas-DIMO",