homebridge-gree-ac 2.1.4 → 2.1.6

package/dist/platformAccessory.js

@@ -63,16 +63,23 @@ class GreeAirConditioner {
                         break;
                     case 'dat': // package type is device status
                         if (this.accessory.bound) {
+                            let invalidTempFromDevice = false;
                             pack.cols.forEach((col, i) => {
-                                if (!(col === commands_1.default.temperature.code && i === 0)) { // temperature value 0 should be ignored (means: no sensor data)
+                                if (col === commands_1.default.temperature.code && (pack.dat[i] <= 0 || pack.dat[i] >= 100)) {
+                                    // temperature value outside of valid range (1-99 -> -39°C - +59°C) should be ignored (means: no sensor data)
+                                    invalidTempFromDevice = true;
+                                }
+                                else {
                                     this.status[col] = pack.dat[i];
                                 }
                             });
                             this.platform.log.debug(`[${this.getDeviceLabel()}] Device status -> %j`, this.status);
-                            if (!pack.cols.includes(commands_1.default.temperature.code) &&
-                                pack.cols.includes(commands_1.default.targetTemperature.code)) {
+                            if (!pack.cols.includes(commands_1.default.temperature.code) || invalidTempFromDevice) {
                                 // temperature is not accessible -> use targetTemperature
-                                this.status[commands_1.default.temperature.code] = this.status[commands_1.default.targetTemperature.code] + this.deviceConfig.sensorOffset;
+                                const targetTemp = this.status[commands_1.default.targetTemperature.code] !== undefined ?
+                                    this.status[commands_1.default.targetTemperature.code] : 25; // use default if target temperature is also unknown
+                                this.status[commands_1.default.temperature.code] = targetTemp + this.deviceConfig.sensorOffset;
+                                this.platform.log.debug(`[${this.getDeviceLabel()}] Current temperature not available`, '- Threshold temperature is used as current (' + commands_1.default.targetTemperature.code + '->' + commands_1.default.temperature.code + ')');
                                 if (this.TemperatureSensor !== undefined) {
                                     this.accessory.removeService(this.TemperatureSensor);
                                     this.TemperatureSensor = undefined;
@@ -133,34 +140,79 @@ class GreeAirConditioner {
             setTimeout(this.checkBindingStatus.bind(this, 1), settings_1.BINDING_TIMEOUT);
         });
     }
+    initCharacteristics() {
+        // these characteristic properties are not updated by HomeKit, they are initialized only once
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w;
+        // Cooling Threshold Temperature Characteristic
+        // minValue / maxValue usually generates error messages in debug log:
+        // "Characteristic 'Cooling Threshold Temperature': characteristic was supplied illegal value ..."
+        // this is not a problem, this is information only that GREE is more restricitive than Apple's default
+        (_a = this.HeaterCooler) === null || _a === void 0 ? void 0 : _a.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).setProps({
+            minStep: this.deviceConfig.temperatureStepSize,
+            minValue: Math.max(this.deviceConfig.minimumTargetTemperature, settings_1.TEMPERATURE_LIMITS.coolingMinimum),
+            maxValue: Math.min(this.deviceConfig.maximumTargetTemperature, settings_1.TEMPERATURE_LIMITS.coolingMaximum),
+        });
+        this.platform.log.debug(`[${this.getDeviceLabel()}] CoolingThresholdTemperature - minValue: %s, maxValue: %s, minStep: %s`, (_c = (_b = this.HeaterCooler) === null || _b === void 0 ? void 0 : _b.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).props.minValue) === null || _c === void 0 ? void 0 : _c.toString(), (_e = (_d = this.HeaterCooler) === null || _d === void 0 ? void 0 : _d.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).props.maxValue) === null || _e === void 0 ? void 0 : _e.toString(), (_g = (_f = this.HeaterCooler) === null || _f === void 0 ? void 0 : _f.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).props.minStep) === null || _g === void 0 ? void 0 : _g.toString());
+        // Heating Threshold Temperature Characteristic
+        // minValue / maxValue usually generates error messages in debug log:
+        // "Characteristic 'Heating Threshold Temperature': characteristic was supplied illegal value ..."
+        // this is not a problem, this is information only that GREE is more restricitive than Apple's default
+        (_h = this.HeaterCooler) === null || _h === void 0 ? void 0 : _h.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).setProps({
+            minStep: this.deviceConfig.temperatureStepSize,
+            minValue: Math.max(this.deviceConfig.minimumTargetTemperature, settings_1.TEMPERATURE_LIMITS.heatingMinimum),
+            maxValue: Math.min(this.deviceConfig.maximumTargetTemperature, settings_1.TEMPERATURE_LIMITS.heatingMaximum),
+        });
+        this.platform.log.debug(`[${this.getDeviceLabel()}] HeatingThresholdTemperature - minValue: %s, maxValue: %s, minStep: %s`, (_k = (_j = this.HeaterCooler) === null || _j === void 0 ? void 0 : _j.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.minValue) === null || _k === void 0 ? void 0 : _k.toString(), (_m = (_l = this.HeaterCooler) === null || _l === void 0 ? void 0 : _l.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.maxValue) === null || _m === void 0 ? void 0 : _m.toString(), (_p = (_o = this.HeaterCooler) === null || _o === void 0 ? void 0 : _o.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.minStep) === null || _p === void 0 ? void 0 : _p.toString());
+        // Rotation Speed Characteristic
+        (_q = this.HeaterCooler) === null || _q === void 0 ? void 0 : _q.getCharacteristic(this.platform.Characteristic.RotationSpeed).setProps({
+            minValue: 0,
+            maxValue: this.deviceConfig.speedSteps + 3,
+            minStep: 1
+        });
+        this.platform.log.debug(`[${this.getDeviceLabel()}] RotationSpeed - minValue: %s, maxValue: %s, minStep: %s`, (_s = (_r = this.HeaterCooler) === null || _r === void 0 ? void 0 : _r.getCharacteristic(this.platform.Characteristic.RotationSpeed).props.minValue) === null || _s === void 0 ? void 0 : _s.toString(), (_u = (_t = this.HeaterCooler) === null || _t === void 0 ? void 0 : _t.getCharacteristic(this.platform.Characteristic.RotationSpeed).props.maxValue) === null || _u === void 0 ? void 0 : _u.toString(), (_w = (_v = this.HeaterCooler) === null || _v === void 0 ? void 0 : _v.getCharacteristic(this.platform.Characteristic.RotationSpeed).props.minStep) === null || _w === void 0 ? void 0 : _w.toString());
+    }
     // All platform, accessory and service initialization is made in initAccessory function
     initAccessory() {
         var _a, _b, _c;
         // register accessory in homebridge by api if not registered before
         if (!this.accessory.registered) {
-            this.platform.log.debug(`[${this.getDeviceLabel()}] registering new accessory in homebridge:`, this.accessory.context.device.mac, this.accessory.UUID);
+            this.platform.log.debug(`[${this.getDeviceLabel()}] Registering new accessory in homebridge:`, this.accessory.context.device.mac, this.accessory.UUID);
             this.platform.api.registerPlatformAccessories(settings_1.PLUGIN_NAME, settings_1.PLATFORM_NAME, [this.accessory]);
+            // set static accessory information
+            this.accessory.getService(this.platform.Service.AccessoryInformation)
+                .setCharacteristic(this.platform.Characteristic.Manufacturer, this.accessory.context.device.brand || 'Gree')
+                .setCharacteristic(this.platform.Characteristic.SerialNumber, this.accessory.context.device.mac)
+                .setCharacteristic(this.platform.Characteristic.Model, ((_a = this.deviceConfig) === null || _a === void 0 ? void 0 : _a.model) || this.accessory.context.device.model || this.accessory.context.device.name || 'Air Conditioner')
+                .setCharacteristic(this.platform.Characteristic.HardwareRevision, this.accessory.context.device.ver ?
+                this.accessory.context.device.ver.substring(this.accessory.context.device.ver.lastIndexOf('V') + 1) : '1.0.0')
+                .setCharacteristic(this.platform.Characteristic.Name, this.accessory.displayName);
+            // get the HeaterCooler service if it exists, otherwise create a new  HeaterCooler service
+            // we don't use subtype because we add only one service with this type
+            this.HeaterCooler = this.accessory.getService(this.platform.Service.HeaterCooler) ||
+                this.accessory.addService(this.platform.Service.HeaterCooler, this.accessory.displayName, undefined);
+            // set static characeristics
+            this.initCharacteristics();
         }
-        this.platform.api.updatePlatformAccessories([this.accessory]);
         if (this.tsAccessoryMac) {
             this.tsAccessory = new tsAccessory_1.GreeAirConditionerTS(this.platform, this.platform.getAccessory(this.accessory.context.device.mac + '_ts'));
         }
         // set accessory information
         this.accessory.getService(this.platform.Service.AccessoryInformation)
-            .setCharacteristic(this.platform.Characteristic.Manufacturer, this.accessory.context.device.brand || 'Gree')
-            .setCharacteristic(this.platform.Characteristic.Model, ((_a = this.deviceConfig) === null || _a === void 0 ? void 0 : _a.model) || this.accessory.context.device.model || this.accessory.context.device.name || 'Air Conditioner')
-            .setCharacteristic(this.platform.Characteristic.SerialNumber, this.accessory.context.device.mac)
             .setCharacteristic(this.platform.Characteristic.FirmwareRevision, this.accessory.context.device.hid && this.accessory.context.device.hid.lastIndexOf('V') >= 0 &&
             this.accessory.context.device.hid.lastIndexOf('V') < this.accessory.context.device.hid.lastIndexOf('.') ?
-            this.accessory.context.device.hid.substring(this.accessory.context.device.hid.lastIndexOf('V') + 1, this.accessory.context.device.hid.lastIndexOf('.')) : '1.0.0')
-            .setCharacteristic(this.platform.Characteristic.HardwareRevision, this.accessory.context.device.ver ?
-            this.accessory.context.device.ver.substring(this.accessory.context.device.ver.lastIndexOf('V') + 1) : '1.0.0')
-            .setCharacteristic(this.platform.Characteristic.Name, this.accessory.displayName);
+            this.accessory.context.device.hid.substring(this.accessory.context.device.hid.lastIndexOf('V') + 1, this.accessory.context.device.hid.lastIndexOf('.')) : '1.0.0');
         // get the HeaterCooler service if it exists, otherwise create a new  HeaterCooler service
         // we don't use subtype because we add only one service with this type
-        this.HeaterCooler = this.accessory.getService(this.platform.Service.HeaterCooler) ||
-            this.accessory.addService(this.platform.Service.HeaterCooler, this.accessory.displayName, undefined);
-        this.HeaterCooler.displayName = this.accessory.displayName;
+        if (!this.HeaterCooler) {
+            this.HeaterCooler = this.accessory.getService(this.platform.Service.HeaterCooler);
+            if (!this.HeaterCooler) {
+                this.platform.log.debug(`[${this.getDeviceLabel()}] HeaterCooler service doesn't exist - adding service`);
+                this.HeaterCooler = this.accessory.addService(this.platform.Service.HeaterCooler, this.accessory.displayName, undefined);
+                // set static characeristics
+                this.initCharacteristics();
+            }
+        }
+        // TemperatureSensor service
         if (this.deviceConfig.temperatureSensor === settings_1.TS_TYPE.child) {
             this.platform.log.debug(`[${this.getDeviceLabel()}] Add Temperature Sensor child service`);
             this.TemperatureSensor = this.accessory.getService(this.platform.Service.TemperatureSensor) ||
@@ -177,6 +229,7 @@ class GreeAirConditioner {
         }
         this.HeaterCooler.setPrimaryService(true);
         (_b = this.TemperatureSensor) === null || _b === void 0 ? void 0 : _b.setPrimaryService(false);
+        this.platform.api.updatePlatformAccessories([this.accessory]);
         // each service must implement at-minimum the "required characteristics" for the given service type
         // see https://developers.homebridge.io/#/service/HeaterCooler
         // register handlers for the Active Characteristic
@@ -195,15 +248,11 @@ class GreeAirConditioner {
             .onGet(this.getCurrentTemperature.bind(this, 'Heater Cooler'));
         (_c = this.TemperatureSensor) === null || _c === void 0 ? void 0 : _c.getCharacteristic(this.platform.Characteristic.CurrentTemperature).onGet(this.getCurrentTemperature.bind(this, 'Temperature Sensor'));
         // register handlers for the Cooling Threshold Temperature Characteristic
-        // (minValue and maxValue can't be set here, they need an active accessory in cooling sate to set)
         this.HeaterCooler.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature)
-            .setProps({ minStep: 0.5 })
             .onGet(this.getTargetTemperature.bind(this, 'CoolingThresholdTemperature'))
             .onSet(this.setTargetTemperature.bind(this));
         // register handlers for the Heating Threshold Temperature Characteristic
-        // (minValue and maxValue can't be set here, they need an active accessory in heating sate to set)
         this.HeaterCooler.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature)
-            .setProps({ minStep: 0.5 })
             .onGet(this.getTargetTemperature.bind(this, 'HeatingThresholdTemperature'))
             .onSet(this.setTargetTemperature.bind(this));
         // register handlers for the Temperature Display Units Characteristic
@@ -216,11 +265,6 @@ class GreeAirConditioner {
             .onSet(this.setSwingMode.bind(this));
         // register handlers for the Rotation Speed Characteristic
         this.HeaterCooler.getCharacteristic(this.platform.Characteristic.RotationSpeed)
-            .setProps({
-            minValue: 0,
-            maxValue: this.deviceConfig.speedSteps + 3,
-            minStep: 1
-        })
             .onGet(this.getRotationSpeed.bind(this))
             .onSet(this.setRotationSpeed.bind(this));
     }
@@ -371,11 +415,9 @@ class GreeAirConditioner {
             switch (this.mode) {
                 case commands_1.default.mode.value.cool:
                     this.platform.log.debug(`[${this.getDeviceLabel()}] Get CurrentHeaterCoolerState -> COOLING`);
-                    setTimeout(() => this.initThresholdTemperature(this.platform.Characteristic.CurrentHeaterCoolerState.COOLING), settings_1.INIT_TEMP_TRESHOLD_TIMEOUT);
                     return this.platform.Characteristic.CurrentHeaterCoolerState.COOLING;
                 case commands_1.default.mode.value.heat:
                     this.platform.log.debug(`[${this.getDeviceLabel()}] Get CurrentHeaterCoolerState -> HEATING`);
-                    setTimeout(() => this.initThresholdTemperature(this.platform.Characteristic.CurrentHeaterCoolerState.HEATING), settings_1.INIT_TEMP_TRESHOLD_TIMEOUT);
                     return this.platform.Characteristic.CurrentHeaterCoolerState.HEATING;
                 case commands_1.default.mode.value.fan:
                 case commands_1.default.mode.value.dry:
@@ -384,12 +426,10 @@ class GreeAirConditioner {
                 case commands_1.default.mode.value.auto:
                     if (this.currentTemperature > this.status[commands_1.default.targetTemperature.code]) {
                         this.platform.log.debug(`[${this.getDeviceLabel()}] Get CurrentHeaterCoolerState -> COOLING`);
-                        setTimeout(() => this.initThresholdTemperature(this.platform.Characteristic.CurrentHeaterCoolerState.COOLING), settings_1.INIT_TEMP_TRESHOLD_TIMEOUT);
                         return this.platform.Characteristic.CurrentHeaterCoolerState.COOLING;
                     }
                     if (this.currentTemperature < this.status[commands_1.default.targetTemperature.code]) {
                         this.platform.log.debug(`[${this.getDeviceLabel()}] Get CurrentHeaterCoolerState -> HEATING`);
-                        setTimeout(() => this.initThresholdTemperature(this.platform.Characteristic.CurrentHeaterCoolerState.HEATING), settings_1.INIT_TEMP_TRESHOLD_TIMEOUT);
                         return this.platform.Characteristic.CurrentHeaterCoolerState.HEATING;
                     }
                     this.platform.log.debug(`[${this.getDeviceLabel()}] Get CurrentHeaterCoolerState -> IDLE`);
@@ -478,36 +518,6 @@ class GreeAirConditioner {
         return value;
     }
     // helper functions
-    initThresholdTemperature(HeaterCoolerState) {
-        var _a, _b, _c, _d, _e, _f;
-        switch (HeaterCoolerState) {
-            case this.platform.Characteristic.CurrentHeaterCoolerState.COOLING:
-                if (((_a = this.HeaterCooler) === null || _a === void 0 ? void 0 : _a.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).props.minValue) !==
-                    this.deviceConfig.minimumTargetTemperature ||
-                    ((_b = this.HeaterCooler) === null || _b === void 0 ? void 0 : _b.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).props.maxValue) !==
-                        this.deviceConfig.maximumTargetTemperature) {
-                    this.platform.log.debug(`[${this.getDeviceLabel()}] Set CoolingThresholdTemperature minValue -> %i, maxValue -> %i`, this.deviceConfig.minimumTargetTemperature, this.deviceConfig.maximumTargetTemperature);
-                    (_c = this.HeaterCooler) === null || _c === void 0 ? void 0 : _c.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).setProps({
-                        minValue: this.deviceConfig.minimumTargetTemperature,
-                        maxValue: this.deviceConfig.maximumTargetTemperature
-                    });
-                }
-                break;
-            case this.platform.Characteristic.CurrentHeaterCoolerState.HEATING:
-                if (((_d = this.HeaterCooler) === null || _d === void 0 ? void 0 : _d.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.minValue) !==
-                    this.deviceConfig.minimumTargetTemperature ||
-                    ((_e = this.HeaterCooler) === null || _e === void 0 ? void 0 : _e.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.maxValue) !==
-                        this.deviceConfig.maximumTargetTemperature) {
-                    this.platform.log.debug(`[${this.getDeviceLabel()}] Set HeatingThresholdTemperature minValue -> %i, maxValue -> %i`, this.deviceConfig.minimumTargetTemperature, this.deviceConfig.maximumTargetTemperature);
-                    (_f = this.HeaterCooler) === null || _f === void 0 ? void 0 : _f.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).setProps({
-                        minValue: this.deviceConfig.minimumTargetTemperature,
-                        maxValue: this.deviceConfig.maximumTargetTemperature
-                    });
-                }
-                break;
-        }
-        this.platform.api.updatePlatformAccessories([this.accessory]);
-    }
     getDeviceLabel() {
         return `${this.accessory.displayName} -- ${this.accessory.context.device.address}:${this.accessory.context.device.port}`;
     }
@@ -542,7 +552,17 @@ class GreeAirConditioner {
         }
         return name;
     }
-    calcDeviceTargetTemp(temp) {
+    calcDeviceTargetTemp(temp, unit) {
+        var _a;
+        if (unit === commands_1.default.units.value.celsius ||
+            (unit === undefined && ((_a = this.HeaterCooler) === null || _a === void 0 ? void 0 : _a.getCharacteristic(this.platform.Characteristic.TemperatureDisplayUnits).value) ===
+                this.platform.Characteristic.TemperatureDisplayUnits.CELSIUS)) {
+            return Math.floor(temp);
+        }
+        if (temp >= 15.25 && temp < 15.75) {
+            // execption
+            return 15;
+        }
         const baseTemp = Math.round(temp);
         const baseFahrenheit = temp * 9 / 5 + 32;
         const baseFahrenheitDecimalPart = baseFahrenheit - Math.floor(baseFahrenheit);
@@ -550,31 +570,58 @@ class GreeAirConditioner {
             (baseFahrenheitDecimalPart >= 0.25 && baseFahrenheitDecimalPart < 0.35) ? 1 : 0;
         return baseTemp - correction;
     }
-    calcDeviceTargetOffset(temp) {
+    calcDeviceTargetOffset(temp, unit) {
+        var _a;
+        if (unit === commands_1.default.units.value.celsius ||
+            (unit === undefined && ((_a = this.HeaterCooler) === null || _a === void 0 ? void 0 : _a.getCharacteristic(this.platform.Characteristic.TemperatureDisplayUnits).value) ===
+                this.platform.Characteristic.TemperatureDisplayUnits.CELSIUS)) {
+            return 0;
+        }
         if (temp === 16) {
+            // exception
             return 0;
         }
         const baseFahrenheit = temp * 9 / 5 + 32;
         const baseFahrenheitDecimalPart = baseFahrenheit - Math.floor(baseFahrenheit);
-        return (((baseFahrenheitDecimalPart >= 0.05 && baseFahrenheitDecimalPart < 0.15) ||
+        const offset = (((baseFahrenheitDecimalPart >= 0.05 && baseFahrenheitDecimalPart < 0.15) ||
             (baseFahrenheitDecimalPart >= 0.25 && baseFahrenheitDecimalPart < 0.35) ||
             (baseFahrenheitDecimalPart >= 0.55 && baseFahrenheitDecimalPart < 0.65) ||
             (baseFahrenheitDecimalPart >= 0.75 && baseFahrenheitDecimalPart < 0.85)) ? 1 : 0);
+        return temp >= 15.25 && temp < 16.25 ? 1 - offset : offset;
     }
-    getTargetTempFromDevice(temp, offset) {
+    getTargetTempFromDevice(temp, offset, unit) {
         var _a, _b;
+        let targetValue;
+        const heatingTargetValue = ((_a = this.HeaterCooler) === null || _a === void 0 ? void 0 : _a.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).value) || 25;
+        const coolingTargetValue = ((_b = this.HeaterCooler) === null || _b === void 0 ? void 0 : _b.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).value) || 25;
+        switch (this.status[commands_1.default.mode.code]) {
+            case commands_1.default.mode.value.heat:
+                targetValue = heatingTargetValue;
+                break;
+            case commands_1.default.mode.value.cool:
+                targetValue = coolingTargetValue;
+                break;
+            default:
+                targetValue = (coolingTargetValue + heatingTargetValue) / 2;
+                break;
+        }
+        if (unit === commands_1.default.units.value.celsius) {
+            if (Math.floor(targetValue) === +temp && targetValue !== +temp) {
+                this.platform.log.debug(`[${this.getDeviceLabel()}] TargetTemperature FIX: %f -> %f`, +temp, targetValue);
+                return targetValue;
+            }
+            return +temp;
+        }
         const key = temp.toString() + ',' + offset.toString();
         const value = settings_1.TEMPERATURE_TABLE[key];
         if (value === undefined) {
-            return 25; // default value if invalid data received from device
+            this.platform.log.debug(`[${this.getDeviceLabel()}] TargetTemperature FIX: invalid -> %f`, +temp);
+            return +temp; // invalid temperature-offset pair received from device -> return temperature value
         }
         // some temperature values are the same on the physical AC unit -> fix this issue:
-        const targetValue = ((_a = this.HeaterCooler) === null || _a === void 0 ? void 0 : _a.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).value) ||
-            ((_b = this.HeaterCooler) === null || _b === void 0 ? void 0 : _b.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).value);
-        if ((targetValue === 17.5 && value === 18) ||
-            (targetValue === 22.5 && value === 23) ||
-            (targetValue === 27.5 && value === 28)) {
-            this.platform.log.debug(`[${this.getDeviceLabel()}] TargetTemperature FIX: %d -> %d`, value, targetValue);
+        if ((targetValue === 12.5 && value === 13) || (targetValue === 17.5 && value === 18) ||
+            (targetValue === 22.5 && value === 23) || (targetValue === 27.5 && value === 28)) {
+            this.platform.log.debug(`[${this.getDeviceLabel()}] TargetTemperature FIX: %f -> %f`, value, targetValue);
             return targetValue;
         }
         // no fix needed, return original value
@@ -656,7 +703,7 @@ class GreeAirConditioner {
         return this.status[commands_1.default.temperature.code] - (this.deviceConfig.sensorOffset) || 25;
     }
     get targetTemperature() {
-        var _a, _b, _c, _d;
+        var _a, _b, _c, _d, _e, _f, _g, _h;
         let minValue = this.deviceConfig.minimumTargetTemperature;
         let maxValue = this.deviceConfig.maximumTargetTemperature;
         switch (this.status[commands_1.default.mode.code]) {
@@ -668,8 +715,11 @@ class GreeAirConditioner {
                 minValue = Math.max(this.deviceConfig.minimumTargetTemperature, ((_c = this.HeaterCooler) === null || _c === void 0 ? void 0 : _c.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.minValue) || 0);
                 maxValue = Math.min(this.deviceConfig.maximumTargetTemperature, ((_d = this.HeaterCooler) === null || _d === void 0 ? void 0 : _d.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.maxValue) || 25);
                 break;
+            case commands_1.default.mode.value.auto:
+                minValue = Math.max(this.deviceConfig.minimumTargetTemperature, Math.min(((_e = this.HeaterCooler) === null || _e === void 0 ? void 0 : _e.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).props.minValue) || 10, ((_f = this.HeaterCooler) === null || _f === void 0 ? void 0 : _f.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.minValue) || 0));
+                maxValue = Math.min(this.deviceConfig.maximumTargetTemperature, Math.max(((_g = this.HeaterCooler) === null || _g === void 0 ? void 0 : _g.getCharacteristic(this.platform.Characteristic.CoolingThresholdTemperature).props.maxValue) || 35, ((_h = this.HeaterCooler) === null || _h === void 0 ? void 0 : _h.getCharacteristic(this.platform.Characteristic.HeatingThresholdTemperature).props.maxValue) || 25));
         }
-        return Math.max(Math.min(this.getTargetTempFromDevice(this.status[commands_1.default.targetTemperature.code] || 25, this.status[commands_1.default.temperatureOffset.code] || 0), (maxValue)), (minValue));
+        return Math.max(Math.min(this.getTargetTempFromDevice(this.status[commands_1.default.targetTemperature.code] || 25, this.status[commands_1.default.temperatureOffset.code] || 0, this.status[commands_1.default.units.code]), (maxValue)), (minValue));
     }
     set targetTemperature(value) {
         var _a;
@@ -706,7 +756,20 @@ class GreeAirConditioner {
             return;
         }
         const command = { [commands_1.default.units.code]: value };
-        this.platform.log.info(`[${this.getDeviceLabel()}] units ->`, this.getKeyName(commands_1.default.units.value, value));
+        let logValue = 'units -> ' + this.getKeyName(commands_1.default.units.value, value);
+        // convert target temperature to new unit
+        const actTemp = this.getTargetTempFromDevice(this.status[commands_1.default.targetTemperature.code], this.status[commands_1.default.temperatureOffset.code], this.units);
+        const tempValue = this.calcDeviceTargetTemp(actTemp, value);
+        if (tempValue !== this.status[commands_1.default.targetTemperature.code]) {
+            command[commands_1.default.targetTemperature.code] = tempValue;
+            logValue += ', targetTemperature -> ' + tempValue.toString();
+        }
+        const tempOffset = this.calcDeviceTargetOffset(actTemp, value);
+        if (tempOffset !== this.status[commands_1.default.temperatureOffset.code]) {
+            command[commands_1.default.temperatureOffset.code] = tempOffset;
+            logValue += ', temperatureOffset -> ' + tempOffset.toString();
+        }
+        this.platform.log.info(`[${this.getDeviceLabel()}]`, logValue);
         this.sendCommand(command);
     }
     get swingMode() {