homebridge-enphase-envoy 10.2.3 → 10.2.5-beta.0

package/index.js

@@ -98,7 +98,7 @@ class EnvoyPlatform {
             const impulseGenerator = new ImpulseGenerator()
               .on('start', async () => {
                 try {
-                  const envoyDevice = new DeviceClass(api, accessoryName, host, displayType, envoyFirmware7xxTokenGenerationMode, envoyPasswd, envoyToken, envoyTokenInstaller, enlightenUser, enlightenPasswd, envoyIdFile, envoyTokenFile, device, prefDir, energyMeterHistoryFileName, log)
+                  const envoyDevice = new DeviceClass(api, log, device, envoyIdFile, envoyTokenFile, prefDir, energyMeterHistoryFileName)
                     .on('devInfo', (info) => logLevel.devInfo && log.info(info))
                     .on('success', (msg) => logLevel.success && log.success(`Device: ${host} ${accessoryName}, ${msg}`))
                     .on('info', (msg) => logLevel.info && log.info(`Device: ${host} ${accessoryName}, ${msg}`))

package/package.json

@@ -2,7 +2,7 @@
     "private": false,
     "displayName": "Enphase Envoy",
     "name": "homebridge-enphase-envoy",
-    "version": "10.2.3",
+    "version": "10.2.5-beta.0",
     "description": "Homebridge p7ugin for Photovoltaic Energy System manufactured by Enphase.",
     "license": "MIT",
     "author": "grzegorz914",

package/src/energymeter.js

@@ -1,5 +1,3 @@
-import axios from 'axios';
-import { Agent } from 'https';
 import { XMLParser, XMLBuilder, XMLValidator } from 'fast-xml-parser';
 import EventEmitter from 'events';
 import EnvoyToken from './envoytoken.js';
@@ -10,7 +8,7 @@ import fakegato from 'fakegato-history';
 let Accessory, Characteristic, Service, Categories, AccessoryUUID;
 
 class EnergyMeter extends EventEmitter {
-    constructor(api, deviceName, host, displayType, envoyFirmware7xxTokenGenerationMode, envoyPasswd, envoyToken, envoyTokenInstaller, enlightenUser, enlightenPasswd, envoyIdFile, envoyTokenFile, device, prefDir, energyMeterHistoryFileName, log) {
+    constructor(api, log, device, envoyIdFile, envoyTokenFile, prefDir, energyMeterHistoryFileName) {
         super();
 
         Accessory = api.platformAccessory;
@@ -21,16 +19,14 @@ class EnergyMeter extends EventEmitter {
 
         //device configuration
         this.log = log;
-        this.name = deviceName;
-        this.host = host;
-
-        this.envoyFirmware7xxTokenGenerationMode = envoyFirmware7xxTokenGenerationMode;
-        this.envoyPasswd = envoyPasswd;
-        this.enlightenUser = enlightenUser;
-        this.enlightenPassword = enlightenPasswd;
-        this.envoyToken = envoyToken;
-        this.envoyTokenInstaller = envoyTokenInstaller;
-        this.powerProductionSummary = device.powerProductionSummary || 1;
+        this.name = device.ame;
+        this.host = device.host;
+
+        this.envoyFirmware7xxTokenGenerationMode = device.envoyFirmware7xxTokenGenerationMode;
+        this.enlightenUser = device.enlightenUser;
+        this.enlightenPasswd = device.enlightenPasswd;
+        this.envoyToken = device.envoyToken;
+        this.envoyTokenInstaller = device.envoyTokenInstaller;
         this.energyProductionLifetimeOffset = device.energyProductionLifetimeOffset || 0;
         this.energyConsumptionTotalLifetimeOffset = device.energyConsumptionTotalLifetimeOffset || 0;
         this.energyConsumptionNetLifetimeOffset = device.energyConsumptionNetLifetimeOffset || 0;
@@ -235,23 +231,6 @@ class EnergyMeter extends EventEmitter {
             });
     }
 
-    createAxiosInstance(authHeader = null, cookie = null) {
-        return axios.create({
-            baseURL: this.url,
-            headers: {
-                Accept: 'application/json',
-                ...(authHeader ? { Authorization: authHeader } : {}),
-                ...(cookie ? { Cookie: cookie } : {}),
-            },
-            withCredentials: true,
-            httpsAgent: new Agent({
-                keepAlive: true,
-                rejectUnauthorized: false
-            }),
-            timeout: 60000
-        });
-    }
-
     handleError(error) {
         const errorString = error.toString();
         const tokenNotValid = errorString.includes('status code 401');
@@ -269,7 +248,8 @@ class EnergyMeter extends EventEmitter {
     async startStopImpulseGenerator(state) {
         try {
             //start impulse generator 
-            const startStop = state ? await this.impulseGenerator.start(this.timers) : await this.impulseGenerator.stop();
+            const timers = state ? this.timers : [];
+            await this.impulseGenerator.state(state, timers)
             return true;
         } catch (error) {
             throw new Error(`Impulse generator start error: ${error}`);
@@ -504,7 +484,7 @@ class EnergyMeter extends EventEmitter {
             const jwt = this.feature.info.jwtToken;
 
             // Create a token-authenticated Axios instance
-            const axiosInstance = this.createAxiosInstance(`Bearer ${jwt.token}`, null);
+            const axiosInstance = this.functions.createAxiosInstance(`Bearer ${jwt.token}`, null);
 
             // Send validation request
             const response = await axiosInstance.get(ApiUrls.CheckJwt);
@@ -525,7 +505,7 @@ class EnergyMeter extends EventEmitter {
             }
 
             // Replace axios instance with cookie-authenticated one
-            this.axiosInstance = this.createAxiosInstance(null, cookie);
+            this.axiosInstance = this.functions.createAxiosInstance(null, cookie);
 
             // Update internal state
             this.feature.info.tokenValid = true;
@@ -552,8 +532,7 @@ class EnergyMeter extends EventEmitter {
             if (metersInstalled) {
                 const arr = [];
                 for (const meter of responseData) {
-                    const measurementType = ApiCodes[meter.measurementType];
-                    const key = MetersKeyMap[measurementType];
+                    const key = MetersKeyMap[meter.measurementType];
                     if (!key) {
                         if (this.logDebug) this.emit('debug', `Unknown meter measurement type: ${meter.measurementType}`);
                         continue;
@@ -655,10 +634,9 @@ class EnergyMeter extends EventEmitter {
             const metersReportsInstalled = Array.isArray(responseData) && responseData.length > 0;
             if (metersReportsInstalled) {
                 for (const meter of responseData) {
-                    const measurementType = ApiCodes[meter.reportType] ?? meter.reportType;
-                    const key = MetersKeyMap[measurementType];
+                    const key = MetersKeyMap[meter.reportType];
                     if (!key) {
-                        if (!this.logDebug) this.emit('debug', `Unknown meters reports type: ${measurementType}`);
+                        if (!this.logDebug) this.emit('debug', `Unknown meters reports type: ${meter.reportType}`);
                         continue;
                     }
 
@@ -999,6 +977,7 @@ class EnergyMeter extends EventEmitter {
                         sourceEnergy = meterEnabled ? sourceEim : sourcePcu;
                         power = this.functions.isValidValue(sourceMeter.power) ? sourceMeter.power : null;
                         energyLifetime = this.functions.isValidValue(sourceMeter.energyLifetime) ? sourceMeter.energyLifetime / 1000 : null;
+                        energyLifetimeWithOffset = this.functions.isValidValue(sourceMeter.energyLifetime) ? energyLifetime + this.energyProductionLifetimeOffset : null;
                         break;
                     }
                     case 'consumptionNet': {
@@ -1006,6 +985,7 @@ class EnergyMeter extends EventEmitter {
                         sourceEnergy = this.pv.powerAndEnergy.consumptionNet;
                         power = this.functions.isValidValue(sourceMeter.power) ? sourceMeter.power : null;
                         energyLifetime = this.functions.isValidValue(sourceMeter.energyLifetime) ? sourceMeter.energyLifetime / 1000 : null;
+                        energyLifetimeWithOffset = this.functions.isValidValue(sourceMeter.energyLifetime) ? energyLifetime + this.energyConsumptionNetLifetimeOffset : null;
                         break;
                     }
                     case 'consumptionTotal': {
@@ -1013,6 +993,7 @@ class EnergyMeter extends EventEmitter {
                         sourceEnergy = this.pv.powerAndEnergy.consumptionTotal;
                         power = this.functions.isValidValue(sourceMeter.power) ? sourceMeter.power : null;
                         energyLifetime = this.functions.isValidValue(sourceMeter.energyLifetime) ? sourceMeter.energyLifetime / 1000 : null;
+                        energyLifetimeWithOffset = this.functions.isValidValue(sourceMeter.energyLifetime) ? energyLifetime + this.energyConsumptionTotalLifetimeOffset : null;
                         break;
                     }
                 }
@@ -1029,7 +1010,7 @@ class EnergyMeter extends EventEmitter {
                         type,
                         measurementType,
                         power,
-                        energyLifetime,
+                        energyLifetimeWithOffset,
                         gridQualityState: meterEnabled,
                     };
 
@@ -1042,7 +1023,7 @@ class EnergyMeter extends EventEmitter {
                     // Create characteristics energy meter
                     const characteristics = [
                         { type: Characteristic.EvePower, value: obj.power },
-                        { type: Characteristic.EveEnergyLifetime, value: obj.energyLifetime },
+                        { type: Characteristic.EveEnergyLifetime, value: obj.energyLifetimeWithOffset },
                     ];
 
                     // Create characteristics energy meter
@@ -1137,7 +1118,7 @@ class EnergyMeter extends EventEmitter {
                 // Create characteristics
                 const characteristics = [
                     { type: Characteristic.EvePower, label: 'power', value: source.power, unit: 'W' },
-                    { type: Characteristic.EveEnergyLifetime, label: 'energy lifetime', value: source.energyLifetime, unit: 'kWh' },
+                    { type: Characteristic.EveEnergyLifetime, label: 'energy lifetime', value: source.energyLifetimeWithOffset, unit: 'kWh' },
                 ];
 
                 if (source.gridQualityState) {
@@ -1187,7 +1168,7 @@ class EnergyMeter extends EventEmitter {
 
         try {
             // Create axios instance
-            this.axiosInstance = this.createAxiosInstance();
+            this.axiosInstance = this.functions.createAxiosInstance();
 
             // Get basic PV info
             const getInfo = await this.getInfo();

package/src/envoydata.js

@@ -1,5 +1,3 @@
-import axios from 'axios';
-import { Agent } from 'https';
 import { XMLParser, XMLBuilder, XMLValidator } from 'fast-xml-parser';
 import EventEmitter from 'events';
 import EnvoyToken from './envoytoken.js';
@@ -10,17 +8,17 @@ import Functions from './functions.js';
 import { ApiUrls, PartNumbers, Authorization, ApiCodes, MetersKeyMap } from './constants.js';
 
 class EnvoyData extends EventEmitter {
-    constructor(host, envoyFirmware7xxTokenGenerationMode, envoyPasswd, envoyToken, envoyTokenInstaller, enlightenUser, enlightenPasswd, envoyIdFile, envoyTokenFile, device) {
+    constructor(device, envoyIdFile, envoyTokenFile) {
         super();
 
         //device configuration
         this.host = host;
-        this.envoyFirmware7xxTokenGenerationMode = envoyFirmware7xxTokenGenerationMode;
-        this.envoyPasswd = envoyPasswd;
-        this.enlightenUser = enlightenUser;
-        this.enlightenPasswd = enlightenPasswd;
-        this.envoyToken = envoyToken;
-        this.envoyTokenInstaller = envoyTokenInstaller;
+        this.envoyFirmware7xxTokenGenerationMode = device.envoyFirmware7xxTokenGenerationMode;
+        this.envoyPasswd = device.envoyPasswd;
+        this.enlightenUser = device.enlightenUser;
+        this.enlightenPasswd = device.enlightenPasswd;
+        this.envoyToken = device.envoyToken;
+        this.envoyTokenInstaller = device.envoyTokenInstaller;
         this.envoyIdFile = envoyIdFile;
         this.envoyTokenFile = envoyTokenFile;
 
@@ -454,23 +452,6 @@ class EnvoyData extends EventEmitter {
             });
     }
 
-    createAxiosInstance(authHeader = null, cookie = null) {
-        return axios.create({
-            baseURL: this.url,
-            headers: {
-                Accept: 'application/json',
-                ...(authHeader ? { Authorization: authHeader } : {}),
-                ...(cookie ? { Cookie: cookie } : {}),
-            },
-            withCredentials: true,
-            httpsAgent: new Agent({
-                keepAlive: false,
-                rejectUnauthorized: false
-            }),
-            timeout: 60000
-        });
-    }
-
     handleError(error) {
         const errorString = error.toString();
         const tokenNotValid = errorString.includes('status code 401');
@@ -488,7 +469,8 @@ class EnvoyData extends EventEmitter {
     async startStopImpulseGenerator(state) {
         try {
             //start impulse generator 
-            const startStop = state ? await this.impulseGenerator.start(this.timers) : await this.impulseGenerator.stop();
+            const timers = state ? this.timers : [];
+            await this.impulseGenerator.state(state, timers)
             return true;
         } catch (error) {
             throw new Error(`Impulse generator start error: ${error}`);
@@ -731,7 +713,7 @@ class EnvoyData extends EventEmitter {
             const jwt = this.feature.info.jwtToken;
 
             // Create a token-authenticated Axios instance
-            const axiosInstance = this.createAxiosInstance(`Bearer ${jwt.token}`, null);
+            const axiosInstance = this.functions.createAxiosInstance(`Bearer ${jwt.token}`, null);
 
             // Send validation request
             const response = await axiosInstance.get(ApiUrls.CheckJwt);
@@ -752,7 +734,7 @@ class EnvoyData extends EventEmitter {
             }
 
             // Replace axios instance with cookie-authenticated one
-            this.axiosInstance = this.createAxiosInstance(null, cookie);
+            this.axiosInstance = this.functions.createAxiosInstance(null, cookie);
 
             // Update internal state
             this.feature.info.tokenValid = true;
@@ -2750,7 +2732,7 @@ class EnvoyData extends EventEmitter {
 
         try {
             // Create axios instance
-            this.axiosInstance = this.createAxiosInstance();
+            this.axiosInstance = this.functions.createAxiosInstance();
 
             // Get basic PV info
             const getInfo = await this.getInfo();

package/src/envoydevice.js

@@ -7,7 +7,7 @@ import { PartNumbers, ApiCodes, MetersKeyMap, DeviceTypeMap, LedStatus } from '.
 let Accessory, Characteristic, Service, Categories, AccessoryUUID;
 
 class EnvoyDevice extends EventEmitter {
-    constructor(api, deviceName, host, displayType, envoyFirmware7xxTokenGenerationMode, envoyPasswd, envoyToken, envoyTokenInstaller, enlightenUser, enlightenPasswd, envoyIdFile, envoyTokenFile, device) {
+    constructor(api, log, device, envoyIdFile, envoyTokenFile) {
         super();
 
         Accessory = api.platformAccessory;
@@ -18,16 +18,9 @@ class EnvoyDevice extends EventEmitter {
 
         //device configuration
         this.device = device;
-        this.name = deviceName;
-        this.host = host;
-        this.displayType = displayType;
-
-        this.envoyFirmware7xxTokenGenerationMode = envoyFirmware7xxTokenGenerationMode;
-        this.envoyPasswd = envoyPasswd;
-        this.enlightenUser = enlightenUser;
-        this.enlightenPasswd = enlightenPasswd;
-        this.envoyToken = envoyToken;
-        this.envoyTokenInstaller = envoyTokenInstaller;
+        this.name = device.ame;
+        this.host = device.host;
+        this.displayType = device.displayType;
 
         this.lockControl = device.lockControl || false;
         this.lockControlPrefix = device.lockControlPrefix || false;
@@ -63,32 +56,32 @@ class EnvoyDevice extends EventEmitter {
         this.acBatterieBackupLevelAccessory = device.acBatterieBackupLevelAccessory || {};
 
         //enpower
-        this.enpowerDryContactsControl = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerDryContactsControl || false) : false;
-        this.enpowerDryContactsSensor = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerDryContactsSensor || false) : false;
-        this.enpowerGridStateControl = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerGridStateControl || {}) : {};
-        this.enpowerGridStateSensor = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerGridStateSensor || {}) : {};
-        this.enpowerGridModeSensors = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerGridModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
+        this.enpowerDryContactsControl = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerDryContactsControl || false) : false;
+        this.enpowerDryContactsSensor = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerDryContactsSensor || false) : false;
+        this.enpowerGridStateControl = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerGridStateControl || {}) : {};
+        this.enpowerGridStateSensor = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerGridStateSensor || {}) : {};
+        this.enpowerGridModeSensors = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enpowerGridModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
 
         //encharge
         this.enchargeName = device.enchargeName || 'Encharge';
-        this.enchargeBackupLevelSummaryAccessory = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeBackupLevelSummaryAccessory || {}) : {};
-        this.enchargeBackupLevelSummarySensors = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeBackupLevelSummarySensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
-        this.enchargeBackupLevelAccessory = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeBackupLevelAccessory || {}) : {};
-        this.enchargeStateSensor = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeStateSensor || {}) : {};
-        this.enchargeProfileControls = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeProfileControls || []).filter(control => (control.displayType ?? 0) > 0) : [];
-        this.enchargeProfileSensors = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeProfileSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
-        this.enchargeGridStateSensor = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeGridStateSensor || {}) : {};
-        this.enchargeGridModeSensors = envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeGridModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
+        this.enchargeBackupLevelSummaryAccessory = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeBackupLevelSummaryAccessory || {}) : {};
+        this.enchargeBackupLevelSummarySensors = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeBackupLevelSummarySensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
+        this.enchargeBackupLevelAccessory = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeBackupLevelAccessory || {}) : {};
+        this.enchargeStateSensor = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeStateSensor || {}) : {};
+        this.enchargeProfileControls = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeProfileControls || []).filter(control => (control.displayType ?? 0) > 0) : [];
+        this.enchargeProfileSensors = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeProfileSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
+        this.enchargeGridStateSensor = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeGridStateSensor || {}) : {};
+        this.enchargeGridModeSensors = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.enchargeGridModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
 
         //solar
-        this.solarGridStateSensor = envoyFirmware7xxTokenGenerationMode > 0 ? (device.solarGridStateSensor || {}) : {};
-        this.solarGridModeSensors = envoyFirmware7xxTokenGenerationMode > 0 ? (device.solarGridModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
+        this.solarGridStateSensor = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.solarGridStateSensor || {}) : {};
+        this.solarGridModeSensors = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.solarGridModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
 
         //generator
-        this.generatorStateControl = envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorStateControl || {}) : {};
-        this.generatorStateSensor = envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorStateSensor || {}) : {};
-        this.generatorModeContols = envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorModeControls || []).filter(control => (control.displayType ?? 0) > 0) : [];
-        this.generatorModeSensors = envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
+        this.generatorStateControl = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorStateControl || {}) : {};
+        this.generatorStateSensor = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorStateSensor || {}) : {};
+        this.generatorModeContols = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorModeControls || []).filter(control => (control.displayType ?? 0) > 0) : [];
+        this.generatorModeSensors = device.envoyFirmware7xxTokenGenerationMode > 0 ? (device.generatorModeSensors || []).filter(sensor => (sensor.displayType ?? 0) > 0) : [];
 
         //data refresh
         this.dataSamplingControl = device.dataRefreshControl || {};
@@ -2969,7 +2962,7 @@ class EnvoyDevice extends EventEmitter {
 
         try {
             // Envoy Data
-            this.envoyData = new EnvoyData(this.host, this.envoyFirmware7xxTokenGenerationMode, this.envoyPasswd, this.envoyToken, this.envoyTokenInstaller, this.enlightenUser, this.enlightenPasswd, this.envoyIdFile, this.envoyTokenFile, this.device)
+            this.envoyData = new EnvoyData(this.device, this.envoyIdFile, this.envoyTokenFile)
                 .on('deviceInfo', (feature, info, timeZone) => {
                     this.feature = Object.assign(this.feature, feature);
                     this.pv.info = info;

package/src/functions.js

@@ -112,5 +112,22 @@ class Functions {
         return powerPeakStored;
     }
 
+    createAxiosInstance(authHeader = null, cookie = null) {
+        return axios.create({
+            baseURL: this.url,
+            headers: {
+                Accept: 'application/json',
+                ...(authHeader ? { Authorization: authHeader } : {}),
+                ...(cookie ? { Cookie: cookie } : {}),
+            },
+            withCredentials: true,
+            httpsAgent: new Agent({
+                keepAlive: false,
+                rejectUnauthorized: false
+            }),
+            timeout: 60000
+        });
+    }
+
 }
 export default Functions

package/src/impulsegenerator.js

@@ -7,48 +7,37 @@ class ImpulseGenerator extends EventEmitter {
         this.timers = [];
     }
 
-    async start(timers) {
-        if (this.timersState) {
-            this.state(true);
-            return true;
+    async state(state, timers = []) {
+        // Stop current timers before new start
+        if (this.timersState && state) {
+            await this.state(false);
         }
 
-        this.timers = [];
-
-        for (const timer of timers) {
-            this.emit(timer.name);
+        if (state) {
+            if (!Array.isArray(timers)) throw new Error('Timers must be an array');
 
-            const interval = setInterval(() => {
-                this.emit(timer.name);
-            }, timer.sampling);
+            for (const { name, sampling } of timers) {
+                if (!name || !sampling) continue;
 
-            this.timers.push(interval);
-        }
+                this.emit(name);
 
-        this.state(true);
-        return true;
-    }
-
-    async stop() {
-        if (!this.timersState) {
-            this.state(false);
-            return true;
-        }
+                const interval = setInterval(() => {
+                    this.emit(name);
+                }, sampling);
 
-        for (const timer of this.timers) {
-            clearInterval(timer);
+                this.timers.push(interval);
+            }
+        } else {
+            this.timers.forEach(clearInterval);
+            this.timers = [];
         }
 
-        this.timers = [];
-        this.state(false);
-        return true;
-    }
-
-    state(state) {
         this.timersState = state;
         this.emit('state', state);
+        return true;
     }
 }
 
 export default ImpulseGenerator;
 
+