homebridge-eliot-smart-control 1.6.1 → 1.6.2

package/CHANGELOG.md

@@ -6,13 +6,34 @@ adheres to [semantic versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [1.6.2] — 2026-09-21
+
+### Changed
+
+- **The plugin declares the transport it speaks.** `supports-hap` in the
+  keywords, which is how Homebridge now expects a plugin to say whether it
+  publishes over HAP, Matter or both.
+- **`required` in the settings schema is spelled the way JSON Schema spells
+  it** — an array on the object rather than `"required": true` on each field.
+  The Homebridge UI reads both; only one of them is valid JSON Schema.
+- **The plugin icon lives in `docs/` and stays out of the npm package.** It is
+  loaded from GitHub where it is shown, so shipping 280 kB of photograph to
+  every install bought nothing.
+
+### Fixed
+
+- **`MOTION_MODE` in the protocol reference had its two values swapped.** One
+  touch is `0` and hold-to-move is `1`, as the Eliot app's own command table
+  and its reader both have it. Nothing in the plugin writes or interprets that
+  setting, so this is documentation only.
+
 ## [1.6.1] — 2026-09-21
 
 ### Added
 
 - **The plugin has an icon**: a photograph of the desk, square, at the top of
   the README and on the npm page. A copy sized for the Homebridge plugin icon
-  request sits in `branding/` — Homebridge hosts those icons itself, so the
+  request sits in `docs/` — Homebridge hosts those icons itself, so the
   repository holds the source rather than the thing the UI reads.
 
 ## [1.6.0] — 2026-09-21
@@ -390,7 +411,8 @@ First release.
   verified against hardware, including the measured travel speed and stopping
   distance.
 
-[Unreleased]: https://github.com/rummeyer/homebridge-eliot-smart-control/compare/v1.6.1...HEAD
+[Unreleased]: https://github.com/rummeyer/homebridge-eliot-smart-control/compare/v1.6.2...HEAD
+[1.6.2]: https://github.com/rummeyer/homebridge-eliot-smart-control/compare/v1.6.1...v1.6.2
 [1.6.1]: https://github.com/rummeyer/homebridge-eliot-smart-control/compare/v1.6.0...v1.6.1
 [1.6.0]: https://github.com/rummeyer/homebridge-eliot-smart-control/compare/v1.5.2...v1.6.0
 [1.5.2]: https://github.com/rummeyer/homebridge-eliot-smart-control/compare/v1.5.1...v1.5.2

package/README.md

@@ -1,5 +1,5 @@
 <p align="center">
-  <img src="https://raw.githubusercontent.com/rummeyer/homebridge-eliot-smart-control/main/branding/icon.png" alt="" width="120" height="120">
+  <img src="https://raw.githubusercontent.com/rummeyer/homebridge-eliot-smart-control/main/docs/icon.png" alt="" width="120" height="120">
 </p>
 
 <h1 align="center">homebridge-eliot-smart-control</h1>

package/config.schema.json

@@ -18,11 +18,11 @@
         "type": "array",
         "items": {
           "type": "object",
+          "required": ["name", "mac"],
           "properties": {
             "name": {
               "title": "Name",
               "type": "string",
-              "required": true,
               "default": "Desk",
               "placeholder": "Desk",
               "description": "What the desk is called in the Home app."
@@ -30,7 +30,6 @@
             "mac": {
               "title": "Dongle address",
               "type": "string",
-              "required": true,
               "placeholder": "E5:11:22:33:44:55",
               "pattern": "^([0-9A-Fa-f]{2}:){5}[0-9A-Fa-f]{2}$",
               "description": "Bluetooth address of the Smart Dongle."

package/docs/PROTOCOL.md

@@ -237,7 +237,7 @@ step commands and could not stop it properly.
 | `GOTO_HEIGHT` | `1B` | 2 | Drive to a height, big-endian millimetres. **Verified**: 802 → 900 mm against a target of 902, landing 2 mm out, on one command |
 | `STOP` | `2B` | 0 | Stop now. **Verified**: sent 108 mm into a move, halted after 13 mm of coasting |
 | `LOW_POWER` | `18` | 1 | `0` off, `1` on. **Verified stored**; takes effect only after a reset — see below |
-| `MOTION_MODE` | `19` | 1 | `0` hold the button, `1` one touch |
+| `MOTION_MODE` | `19` | 1 | `0` one touch, `1` hold the button. **Corrected 21.09.2026** — see below |
 | `VELOCITY` | `13` | 1 | Travel speed; the app offers 28, 31, 35, 38, 40. **Verified stored**; found at 21, below anything the app offers — see below |
 | `SENSITIVITY` | `1D` | 1 | Anti-collision: `1` high, `2` medium, `3` low |
 | `LOCK` | `1F` | 1 | Child lock: `0` reads the state, `1` toggles it. **Verified** |
@@ -248,9 +248,30 @@ step commands and could not stop it properly.
 | `CONNECT` | `FE` | 0 | **Reads the whole settings block.** Not decoration — see below |
 
 `GOTO_HEIGHT` is only sent once when the desk is in one-touch mode
-(`MOTION_MODE = 1`). In hold mode the app repeats it, which is worth knowing
-before exposing that setting to anyone: turning one-touch off takes away the
-desk's ability to drive itself anywhere.
+(`MOTION_MODE = 0`). In hold mode the app repeats it on an interval, which is
+worth knowing before exposing that setting to anyone: turning one-touch off
+takes away the desk's ability to drive itself anywhere.
+
+**Correction, 21.09.2026.** This table had `MOTION_MODE` the wrong way round —
+`0` as hold and `1` as one touch — and the sentence above inherited it. The
+app's own command table has both frames written out, and the parameter and its
+checksum settle it:
+
+```
+MOTION_PRESS: F1 F1 19 01 00 1A 7E      one touch is 0
+MOTION_HOLD:  F1 F1 19 01 01 1B 7E      hold is 1
+```
+
+Its reader agrees, in two places: `case '19'` maps `0` to `ONE_TOUCH` and `1`
+to `CONSTANT_TOUCH`. Nothing here was measured against the control box — the
+mapping is read out of the app, like the rest of this section, and writing
+`0x19` to find out would cost a reset.
+
+The wrong version was believed because it seemed to have been confirmed: with
+`00` stored the desk moved 10 mm on a `GOTO_HEIGHT` and stopped, which looks
+exactly like hold mode. That was the `SETTINGS` poll described below, not the
+motion mode, and the same afternoon produced two other conclusions of the same
+shape.
 
 **The app writes to service `FF12`, characteristic `FF01`** — not the `FE60`
 this dongle exposes. It targets an older generation. The frame layer is

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-eliot-smart-control",
   "displayName": "Eliot Smart Control",
-  "version": "1.6.1",
+  "version": "1.6.2",
   "description": "Homebridge plugin for the Eliot sit-stand desk with the Smart Dongle, over Bluetooth LE",
   "license": "MIT",
   "author": "Oliver Rummeyer",
@@ -19,6 +19,7 @@
   },
   "keywords": [
     "homebridge-plugin",
+    "supports-hap",
     "eliot",
     "smartfurniture",
     "standing-desk",
@@ -52,6 +53,7 @@
     "homebridge-ui",
     "tools",
     "docs",
+    "!docs/*.png",
     "config.schema.json",
     "README.md",
     "CHANGELOG.md",

package/tools/set-setting.js

@@ -13,13 +13,15 @@
  * and velocity 28 were both stored, neither was in force, and the desk moved at
  * 22.4 mm/s either way.
  *
- * It is also what broke GOTO_HEIGHT. `MOTION_MODE` (`0x19`) had `00` stored —
- * hold-to-move — while the box was running one-touch from some earlier reset.
- * The first reset performed here made the stored value live, and a single
- * GOTO_HEIGHT then moved the desk 10 mm and stopped, which is hold-mode doing
- * exactly what it says. So a value written here is a promise about the desk's
- * behaviour *after* its next reset, and this tool says so rather than
- * pretending the write took effect.
+ * So a value written here is a promise about the desk's behaviour *after* its
+ * next reset, and this tool says so rather than pretending the write took
+ * effect.
+ *
+ * This header used to blame `MOTION_MODE` (`0x19`) for GOTO_HEIGHT moving the
+ * desk 10 mm and stopping: `00` was stored, `00` was read as hold-to-move, and
+ * the reset performed here was said to have made it live. Both halves were
+ * wrong. `00` is one touch, not hold — see docs/PROTOCOL.md — and the 10 mm
+ * was a 400 ms `SETTINGS` poll in the test tools cancelling every move.
  *
  * `--reset` sends `0x91`, which is the entry into reset mode. Verified on this
  * hardware: the handset then shows RESET with a circle, and the reset happens
@@ -44,7 +46,7 @@ const HOLD = Number(arg('hold') ?? 45_000);
 
 if (!/^([0-9A-F]{2}:){5}[0-9A-F]{2}$/.test(MAC) || !Number.isInteger(CODE) || !Number.isInteger(VALUE)) {
   console.error('usage: node tools/set-setting.js <MAC> --code=0x19 --value=1 [--reset]');
-  console.error('  0x13 velocity   0x18 low power   0x19 motion mode (0 halten, 1 one-touch)');
+  console.error('  0x13 velocity   0x18 low power   0x19 motion mode (0 one-touch, 1 halten)');
   console.error('  0x1d sensitivity   0x0e units');
   process.exit(1);
 }