homebridge-deconz 0.0.6 → 0.0.11

package/config.schema.json

@@ -69,7 +69,7 @@
         "maximum": 2000
       },
       "waitTimeUpdate": {
-        "description": "The time, in milliseconds, to wait for a change from HomeKit to another characteristic for the same light or group, before updating the deCONZ gateway.  Default: 20.",
+        "description": "The time, in milliseconds, to wait for a change from HomeKit to another characteristic for the same light or group, before updating the deCONZ gateway.  Default: 100.",
         "type": "integer",
         "minimum": 0,
         "maximum": 500

package/lib/Client/ApiError.js

@@ -0,0 +1,42 @@
+// homebridge-deconz/lib/Deconz/ApiError.js
+//
+// Homebridge plug-in for deCONZ.
+// Copyright © 2018-2022 Erik Baauw. All rights reserved.
+
+'use strict'
+
+const homebridgeLib = require('homebridge-lib')
+
+// API errors that could still cause (part of) the PUT command to be executed.
+const nonCriticalApiErrorTypes = [
+  6, // parameter not available
+  7, // invalid value for parameter
+  8, // paramater not modifiable
+  201 // paramater not modifiable, device is set to off
+]
+
+/** Deconz API error.
+  * @hideconstructor
+  * @extends HttpClient.HttpError
+  * @memberof Deconz
+  */
+class ApiError extends homebridgeLib.HttpClient.HttpError {
+  constructor (message, response, type, description) {
+    super(message, response.request, response.statusCode, response.statusMessage)
+
+    /** @member {integer} - The API error type.
+      */
+    this.type = type
+
+    /** @member {string} - The API error description.
+      */
+    this.description = description
+
+    /** @member {boolean} - Indication that the request might still succeed
+      * for other attributes.
+      */
+    this.nonCritical = nonCriticalApiErrorTypes.includes(type)
+  }
+}
+
+module.exports = ApiError

package/lib/{DeconzClient.js → Deconz/ApiClient.js}

@@ -1,4 +1,4 @@
-// homebridge-deconz/lib/DeconzClient.js
+// homebridge-deconz/lib/Deconz/ApiClient.js
 //
 // Homebridge plug-in for deCONZ.
 // Copyright © 2018-2022 Erik Baauw. All rights reserved.
@@ -9,15 +9,9 @@ const events = require('events')
 const homebridgeLib = require('homebridge-lib')
 const os = require('os')
 
-// API errors that could still cause (part of) the PUT command to be executed.
-const nonCriticalApiErrorTypes = [
-  6, // parameter not available
-  7, // invalid value for parameter
-  8, // paramater not modifiable
-  201 // paramater not modifiable, device is set to off
-]
+const Deconz = require('../Deconz')
 
-// Estmate the number of Zigbee messages resulting from PUTting body.
+// Estmate the number of Zigbee messages resulting from PUT body.
 function numberOfZigbeeMessages (body = {}) {
   let n = 0
   if (Object.keys(body).includes('on')) {
@@ -41,82 +35,37 @@ function numberOfZigbeeMessages (body = {}) {
   return n === 0 ? 1 : n
 }
 
-/** Deconz API error.
-  * @hideconstructor
-  * @extends HttpClient.HttpError
-  * @memberof DeconzClient
-  */
-class DeconzError extends homebridgeLib.HttpClient.HttpError {
-  constructor (message, response, type, description) {
-    super(message, response.request, response.statusCode, response.statusMessage)
-
-    /** @member {integer} - The API error type.
-      */
-    this.type = type
-
-    /** @member {string} - The API error description.
-      */
-    this.description = description
-
-    /** @member {boolean} - Indication that the request might still succeed
-      * for other attributes.
-      */
-    this.nonCritical = nonCriticalApiErrorTypes.includes(type)
-  }
-}
-
-/** Deconz API response.
-  * @hideconstructor
-  * @extends HttpClient.HttpResponse
-  * @memberof DeconzClient
-  */
-class DeconzResponse extends homebridgeLib.HttpClient.HttpResponse {
-  constructor (response) {
-    super(
-      response.request, response.statusCode, response.statusMessage,
-      response.headers, response.body, response.parsedBody
-    )
-
-    /** @member {object} - An object with the `"success"` API responses.
-      */
-    this.success = {}
-
-    /** @member {DeconzClient.DeconzError[]} - A list of `"error"` API responses.
-      */
-    this.errors = []
-
-    if (Array.isArray(response.body)) {
-      for (const id in response.body) {
-        const e = response.body[id].error
-        if (e != null && typeof e === 'object') {
-          this.errors.push(new DeconzError(
-            `api error ${e.type}: ${e.description}`,
-            response, e.type, e.description
-          ))
-        }
-        const s = response.body[id].success
-        if (s != null && typeof s === 'object') {
-          for (const path of Object.keys(s)) {
-            const a = path.split('/')
-            const key = a[a.length - 1]
-            this.success[key] = s[path]
-          }
-        }
-      }
-    }
-  }
-}
-
-/** REST API client for deCONZ gateway.
+/** REST API client for a deCONZ gateway.
   *
   * See the [deCONZ API](https://dresden-elektronik.github.io/deconz-rest-doc/)
   * documentation for a better understanding of the API.
   * @extends HttpClient
+  * @memberof Deconz
   */
-class DeconzClient extends homebridgeLib.HttpClient {
-  static get DeconzError () { return DeconzError }
-  static get DeconzResponse () { return DeconzResponse }
+class ApiClient extends homebridgeLib.HttpClient {
+  /** Events reported through `buttonevent`.
+    * @type {Object<string, integer>}
+    */
+  static get buttonEvent () {
+    return {
+      PRESS: 0,
+      HOLD: 1,
+      SHORT_RELEASE: 2,
+      LONG_RELEASE: 3,
+      DOUBLE_PRESS: 4,
+      TRIPLE_PRESS: 5,
+      QUADRUPLE_PRESS: 6,
+      SHAKE: 7,
+      DROP: 8,
+      TILT: 9
+    }
+  }
 
+  /** Convert date as reported by deCONZ to human readable string.
+    * @param {string} date - The ISO-8601 date string.
+    * @param {boolean} [utc=true] - Treat date as UTC, even with missing `Z`.
+    * @param {string} date - The human readable date string.
+    */
   static dateToString (date, utc = true) {
     if (date == null || date === 'none') {
       return 'n/a'
@@ -127,33 +76,30 @@ class DeconzClient extends homebridgeLib.HttpClient {
     return String(new Date(date)).slice(0, 24)
   }
 
-  static parseUniqueid (uniqueid) {
-    // TODO sanity check
-    const a = uniqueid.replace(/:/g, '').toUpperCase().split('-')
-    const o = {
-      mac: a[0],
-      endpoint: a[1]
-    }
-    if (a.length > 2) {
-      o.cluster = a[2]
-    }
-    return o
+  /** Convert `lightlevel` to lux.
+    * @param {integer} lightLevel - The `lightlevel` as reported by deCONZ.
+    * @return {integer} lux - The value in lux.
+    */
+  static lightLevelToLux (v) {
+    let lux = v ? Math.pow(10, (v - 1) / 10000) : 0.0001
+    lux = Math.round(lux * 10000) / 10000
+    return Math.max(0.0001, Math.min(lux, 100000))
   }
 
-  /** Create a new instance of a DeconzClient.
+  /** Create a new instance of a Deconz.Client.
     *
     * The caller is expected to verify that the given host is a reachable
     * deCONZ gateway, by calling
     * {@link DeconzDiscovery#config DeconzDiscovery#config()} and passing the
     * response as `params.config`.<br>
-    * The caller is expected to persist the username (API key),
-    * passing it as `params.username`.
-    * If no API key is known {@link DeconzClient#createuser createuser()} can
+    * The caller is expected to persist the API key, passing it as
+    * `params.apiKey`.
+    * If no API key is known {@link Deconz.ApiClient#getApiKey getApiKey()} can
     * be called to create one.<br>
     *
     * @param {object} params - Parameters.
     * @param {?string} params.config - The bridge/gateway public configuration,
-    * i.e. the response of {@link DeconzDiscovery#config DeconzDiscovery#config()}.
+    * i.e. the response of {@link Deconz.Discovery#config config()}.
     * @param {!string} params.host - Hostname/IP address and port of the
     * deCONZ gateway.
     * @param {boolean} [params.keepAlive=false] - Keep server connection(s)
@@ -163,7 +109,7 @@ class DeconzClient extends homebridgeLib.HttpClient {
     * @param {boolean} [params.phoscon=false] - Mimic Phoscon web app to use
     * deCONZ gateway API extensions.
     * @param {integer} [params.timeout=5] - Request timeout (in seconds).
-    * @param {?string} params.username - The API key of the deCONZ gateway.
+    * @param {?string} params.apiKey - The API key of the deCONZ gateway.
     * @param {integer} [params.waitTimePut=50] - The time (in milliseconds),
     * after sending a PUT request, to wait before sending another PUT request.
     * @param {integer} [params.waitTimePutGroup=1000] - The time (in
@@ -190,7 +136,7 @@ class DeconzClient extends homebridgeLib.HttpClient {
       .intKey('maxSockets', 1, 20)
       .boolKey('phoscon')
       .intKey('timeout', 1, 60)
-      .stringKey('username')
+      .stringKey('apiKey')
       .intKey('waitTimePut', 0, 50)
       .intKey('waitTimePutGroup', 0, 1000)
       .intKey('waitTimeResend', 0, 1000)
@@ -209,8 +155,8 @@ class DeconzClient extends homebridgeLib.HttpClient {
       // options.headers = { Accept: 'application/vnd.ddel.v1' }
       options.headers = { Accept: 'application/vnd.ddel.v1.1,vnd.ddel.v1.1' }
     }
-    if (_options.username) {
-      options.path += '/' + _options.username
+    if (_options.apiKey) {
+      options.path += '/' + _options.apiKey
     }
     super(options)
     this._options = _options
@@ -224,7 +170,7 @@ class DeconzClient extends homebridgeLib.HttpClient {
     */
   get bridgeid () { return this._options.config.bridgeid }
 
-  /** Server (base) path, `/api/`_username_.
+  /** Server (base) path, `/api/`_API_key_.
     * @type {string}
     * @readonly
     */
@@ -233,9 +179,9 @@ class DeconzClient extends homebridgeLib.HttpClient {
   /** The API key.
     * @type {string}
     */
-  get username () { return this._options.username }
-  set username (value) {
-    this._options.username = value
+  get apiKey () { return this._options.apiKey }
+  set apiKey (value) {
+    this._options.apiKey = value
     let path = '/api'
     if (value != null) {
       path += '/' + value
@@ -245,7 +191,7 @@ class DeconzClient extends homebridgeLib.HttpClient {
 
   // ===========================================================================
 
-  /** Issue a GET request of `/api/`_username_`/`_resource_.
+  /** Issue a GET request of `/api/`_API_key_`/`_resource_.
     *
     * @param {string} resource - The resource.<br>
     * This might be a resource as exposed by the API, e.g. `/lights/1/state`,
@@ -309,9 +255,9 @@ class DeconzClient extends homebridgeLib.HttpClient {
     return body
   }
 
-  /** Issue a PUT request to `/api/`_username_`/`_resource_.
+  /** Issue a PUT request to `/api/`_API_key_`/`_resource_.
     *
-    * DeconzClient throttles the number of PUT requests to limit the Zigbee traffic
+    * ApiClient throttles the number of PUT requests to limit the Zigbee traffic
     * to 20 unicast messsages per seconds, or 1 broadcast message per second,
     * delaying the request when needed.
     * @param {string} resource - The resource.
@@ -342,7 +288,7 @@ class DeconzClient extends homebridgeLib.HttpClient {
     return this.request('PUT', resource, body)
   }
 
-  /** Issue a POST request to `/api/`_username_`/`_resource_.
+  /** Issue a POST request to `/api/`_API_key_`/`_resource_.
     *
     * @param {string} resource - The resource.
     * @param {*} body - The body, which will be converted to JSON.
@@ -353,7 +299,7 @@ class DeconzClient extends homebridgeLib.HttpClient {
     return this.request('POST', resource, body)
   }
 
-  /** Issue a DELETE request of `/api/`_username_`/`_resource_.
+  /** Issue a DELETE request of `/api/`_API_key_`/`_resource_.
     * @param {string} resource - The resource.
     * @param {*} body - The body, which will be converted to JSON.
     * @return {DeconzResponse} response - The response.
@@ -365,48 +311,48 @@ class DeconzClient extends homebridgeLib.HttpClient {
 
   // ===========================================================================
 
-  /** Create an API key and set {@link DeconzClient#username username}.
+  /** Obtain an API key and set {@link Deconz.ApiClient#apiKey apiKey}.
     *
-    * Calls {@link DeconzClient#post post()} to issue a POST request to `/api`.
+    * Calls {@link Deconz.ApiClient#post post()} to issue a POST request to `/api`.
     *
-    * Before calling `createUser`, the deCONZ gateway must be unlocked, unless
+    * Before calling `getApiKey`, the deCONZ gateway must be unlocked, unless
     * the client is running on the same host as the gateway.
-    * @return {string} username - The newly created API key.
+    * @return {string} apiKey - The newly created API key.
     * @throws {HttpError} In case of HTTP error.
     * @throws {DeconzError} In case of API error.
     */
-  async createUser (application) {
+  async getApiKey (application) {
     if (typeof application !== 'string' || application === '') {
       throw new TypeError(`${application}: invalid application name`)
     }
-    const username = this._options.username
+    const apiKey = this._options.apiKey
     const body = { devicetype: `${application}#${os.hostname().split('.')[0]}` }
-    this.username = null
+    this.apiKey = null
     try {
       const response = await this.post('/', body)
-      this.username = response.success.username
-      return this.username
+      this.apiKey = response.success.username
+      return this.apiKey
     } catch (error) {
-      this.username = username
+      this.apiKey = apiKey
       throw (error)
     }
   }
 
-  /** Delete the API key and clear {@link DeconzClient#username username}.
+  /** Delete the API key and clear {@link Deconz.ApiClient#apiKey apiKey}.
     * @throws {HttpError} In case of HTTP error.
     * @throws {DeconzError} In case of API error.
     */
-  async deleteUser () {
+  async deleteApiKey () {
     try {
-      await this.delete('/config/whitelist/' + this.username)
+      await this.delete('/config/whitelist/' + this.apiKey)
     } catch (error) {}
-    this.username = null
+    this.apiKey = null
   }
 
   /** Unlock the gateway to allow creating a new API key.
     *
-    * Calls {@link DeconzClient#put put()} to issue a PUT request to
-    * `/api/`_username_`/config`.
+    * Calls {@link Deconz.ApiClient#put put()} to issue a PUT request to
+    * `/api/`_API_key_`/config`.
     *
     * @return {DeconzResponse} response - The response.
     * @throws {HttpError} In case of HTTP error.
@@ -416,35 +362,13 @@ class DeconzClient extends homebridgeLib.HttpClient {
     return this.put('/config', { unlock: 60 })
   }
 
-  /** Initiate a touchlink scan.
-    *
-    * Calls {@link DeconzClient#post post()} to issue a POST request to
-    * `/api/`_username_`/touchlink/scan`, to initiate a touchlink scan.
-    * As the ConBee II and RaspBee II firmware lack support for touchlink,
-    * this will only work for the original ConBee and RaspBee.
-    * To see the results of the scan, issue a GET request of
-    * `/api/`_username_`/touchlink/scan`.
-    * The ID returned in the scan results is needed to touchlink identify or
-    * reset the device.
-    * To issue a touchlink identify, issue a POST request of
-    * `/api/`_username_`/touchlink/`_ID_`/identify`.
-    * To issue a touchlink reset, issue a POST request to
-    * `/api/`_username_`/touchlink/`_ID_`/reset`.
-    * @return {DeconzResponse} response - The response.
-    * @throws {HttpError} In case of HTTP error.
-    * @throws {DeconzError} In case of API error.
-    */
-  async touchlink () {
-    return this.post('/touchlink/scan')
-  }
-
   /** Search for new devices.
     *
-    * Calls {@link DeconzClient#put put()} to issue a PUT request to
-    * `/api/`_username_`/config`, to enable pairing of new Zigbee devices.
+    * Calls {@link Deconz.ApiClient#put put()} to issue a PUT request to
+    * `/api/`_API_key_`/config`, to enable pairing of new Zigbee devices.
     *
     * To see the newly paired devices, issue a GET request of
-    * `/api/`_username_`/lights/new` and/or `/api/`_username_`/sensor/new`
+    * `/api/`_API_key_`/lights/new` and/or `/api/`_API_key_`/sensor/new`
     * @return {DeconzResponse} response - The response.
     * @throws {HttpError} In case of HTTP error.
     * @throws {DeconzError} In case of API error.
@@ -455,8 +379,8 @@ class DeconzClient extends homebridgeLib.HttpClient {
 
   /** Restart the gateway.
     *
-    * Calls {@link DeconzClient#post post()} to issue a POST request to
-    * `/api/`_username_`/config/restartapp`, to restart the deCONZ gateway.
+    * Calls {@link Deconz.ApiClient#post post()} to issue a POST request to
+    * `/api/`_API_key_`/config/restartapp`, to restart the deCONZ gateway.
     *
     * @return {DeconzResponse} response - The response.
     * @throws {HttpError} In case of HTTP error.
@@ -470,9 +394,9 @@ class DeconzClient extends homebridgeLib.HttpClient {
 
   /** Issue an HTTP request to the deCONZ gateway.
     *
-    * This method does the heavy lifting for {@link DeconzClient#get get()},
-    * {@link DeconzClient#put put()}, {@link DeconzClient#post post()}, and
-    * {@link DeconzClient#delete delete()}.
+    * This method does the heavy lifting for {@link Deconz.AplClient#get get()},
+    * {@link Deconz.ApiClient#put put()}, {@link Deconz.ApiClient#post post()},
+    * and {@link Deconz.ApiClient#delete delete()}.
     * It shouldn't be called directly.
     *
     * @param {string} method - The method for the request.
@@ -485,12 +409,12 @@ class DeconzClient extends homebridgeLib.HttpClient {
   async request (method, resource, body = null, retry = 0) {
     try {
       const httpResponse = await super.request(method, resource, body)
-      const response = new DeconzResponse(httpResponse)
+      const response = new Deconz.ApiResponse(httpResponse)
       for (const error of response.errors) {
         /** Emitted for each API error returned by the or deCONZ gateway.
           *
-          * @event DeconzClient#error
-          * @param {HttpClient.HttpError|HttpClient.DeconzError} error - The error.
+          * @event Deconz.ApiClient#error
+          * @param {HttpClient.HttpError|Deconz.ApiError} error - The error.
           */
         this.emit('error', error)
         if (!error.nonCritical) {
@@ -516,4 +440,4 @@ class DeconzClient extends homebridgeLib.HttpClient {
   }
 }
 
-module.exports = DeconzClient
+module.exports = ApiClient

package/lib/Deconz/ApiError.js

@@ -0,0 +1,42 @@
+// homebridge-deconz/lib/Deconz/ApiError.js
+//
+// Homebridge plug-in for deCONZ.
+// Copyright © 2018-2022 Erik Baauw. All rights reserved.
+
+'use strict'
+
+const homebridgeLib = require('homebridge-lib')
+
+// API errors that could still cause (part of) the PUT command to be executed.
+const nonCriticalApiErrorTypes = [
+  6, // parameter not available
+  7, // invalid value for parameter
+  8, // paramater not modifiable
+  201 // paramater not modifiable, device is set to off
+]
+
+/** Deconz API error.
+  * @hideconstructor
+  * @extends HttpClient.HttpError
+  * @memberof Deconz
+  */
+class ApiError extends homebridgeLib.HttpClient.HttpError {
+  constructor (message, response, type, description) {
+    super(message, response.request, response.statusCode, response.statusMessage)
+
+    /** @member {integer} - The API error type.
+      */
+    this.type = type
+
+    /** @member {string} - The API error description.
+      */
+    this.description = description
+
+    /** @member {boolean} - Indication that the request might still succeed
+      * for other attributes.
+      */
+    this.nonCritical = nonCriticalApiErrorTypes.includes(type)
+  }
+}
+
+module.exports = ApiError

package/lib/Deconz/ApiResponse.js

@@ -0,0 +1,54 @@
+// homebridge-deconz/lib/Deconz/ApiResponse.js
+//
+// Homebridge plug-in for deCONZ.
+// Copyright © 2018-2022 Erik Baauw. All rights reserved.
+
+'use strict'
+
+const homebridgeLib = require('homebridge-lib')
+
+const Deconz = require('../Deconz')
+
+/** Deconz API response.
+  * @hideconstructor
+  * @extends HttpClient.HttpResponse
+  * @memberof Deconz
+  */
+class ApiResponse extends homebridgeLib.HttpClient.HttpResponse {
+  constructor (response) {
+    super(
+      response.request, response.statusCode, response.statusMessage,
+      response.headers, response.body, response.parsedBody
+    )
+
+    /** @member {object} - An object with the `"success"` API responses.
+      */
+    this.success = {}
+
+    /** @member {Deconz.ApiError[]} - A list of `"error"` API responses.
+      */
+    this.errors = []
+
+    if (Array.isArray(response.body)) {
+      for (const id in response.body) {
+        const e = response.body[id].error
+        if (e != null && typeof e === 'object') {
+          this.errors.push(new Deconz.ApiError(
+            `api error ${e.type}: ${e.description}`,
+            response, e.type, e.description
+          ))
+        }
+        const s = response.body[id].success
+        if (s != null && typeof s === 'object') {
+          for (const path of Object.keys(s)) {
+            const a = path.split('/')
+            const key = a[a.length - 1]
+            this.success[key] = s[path]
+          }
+        }
+      }
+    }
+  }
+}
+
+module.exports = ApiResponse

package/lib/Deconz/Device.js

@@ -0,0 +1,100 @@
+// homebridge-deconz/lib/Deconz/Device.js
+// Copyright © 2022 Erik Baauw. All rights reserved.
+//
+// Homebridge plugin for deCONZ.
+
+'use strict'
+
+/** Delegate class for a Zigbee or virtual device on a deCONZ gateway.
+  *
+  * The deCONZ REST API exposes a Zigbee device using one or more resources.
+  * These resources are linked to the device through the `uniqueid` in the
+  * resource body.
+  * Each supported device corresponds to a HomeKit accessory.
+  * Each supported resource corresponds to a HomeKit service.
+  * @memberof Deconz
+  */
+class Device {
+  /** Create a new instance of a delegate of a device, from a resource.
+    *
+    * @param {Deconz.Resource} resource - The resource.
+    */
+  constructor (resource) {
+    /** The device ID.
+      *
+      * This is the {@link Deconz.Resource#id id} of the delegates
+      * of all resources for the device.
+      * @type {string}
+      */
+    this.id = resource.id
+
+    /** Zigbee device vs virtual device.
+      *
+      * This is the {@link Deconz.Resource#zigbee zigbee} of the
+      * delegates of all resources for the device.
+      * @type {boolean}
+      */
+    this.zigbee = resource.zigbee
+
+    /** The delegates of the resources for the device, by subtype of the
+      * corresponding HomeKit service.
+      * @type {Object.<string, Deconz.Resource>}
+      */
+    this.resourceBySubtype = {}
+    this.resourceBySubtype[resource.subtype] = resource
+
+    /** The key of the delegate for the primary resource for the device in
+      * {@link DeconzDevice#resourceBySubtype resourceBySubtype}
+      *
+      * This is the {@link DeconzDevice.Resource#subtype subtype} of the
+      * HomeKit service corresponding to the primary resource.
+      * @type {string}
+      */
+    this.primary = resource.subtype
+  }
+
+  /** The delegate of the primary resource of the device.
+    * @type {Deconz.Resource}
+    */
+  get resource () { return this.resourceBySubtype[this.primary] }
+
+  /** List of resource paths of the resources for the device.
+    * @type {string[]}
+    */
+  get rpaths () {
+    return Object.keys(this.resourceBySubtype || {}).map((subtype) => {
+      return this.resourceBySubtype[subtype].rpath
+    })
+  }
+
+  /** Add a {@link Deconz.Resource Resource}.
+    *
+    * Updates {@link Deconz.Device#resourceBySubtype resourceBySubtype},
+    * {@link Deconz.Device#rpaths rpaths}, and, when the added resource
+    * has a higher priority, {@link Deconz.Device#primary primary} and
+    * {@link Deconz.Device#resource resource}.
+    * @param {Deconz.Resource} resource - The resource.
+    */
+  addResource (resource) {
+    const { body, id, prio, rtype, subtype, zigbee } = resource
+    if (this.resourceBySubtype[subtype] != null) {
+      const r = this.resourceBySubtype[subtype]
+      throw new Error(
+        `${resource.rpath}: duplicate uniqueid ${body.uniqueid} in ${r.rpath}`
+      )
+    }
+    if (zigbee !== this.zigbee || (zigbee && id !== this.id)) {
+      const r = this.resourceBySubtype[subtype]
+      throw new SyntaxError(
+        `${resource.rpath}: cannot combine ${r.rpath}`
+      )
+    }
+    this.resourceBySubtype[subtype] = resource
+    const p = this.resourceBySubtype[this.primary]
+    if (p.rtype === rtype && p.prio < prio) {
+      this.primary = resource.subtype
+    }
+  }
+}
+
+module.exports = Device