homebridge-ac-freedom 2.3.3 → 2.3.5

package/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## 2.3.5
+
+- **Fix double beep on power-on** — `TargetHeaterCoolerState` command is suppressed when fired within 200 ms of a power command; mode is already included in `sendPower`
+- **Fix device turns back on after power-off** — `sendPower(false)` no longer sends a separate sleep or fan command; UI reset is local-only, no extra cloud calls
+- **Fix fan not resetting on device** — `sendPower(false)` now includes `fanSpeed=0` in the same API call, so the device restores AUTO fan on next power-on
+- **Fix stale poll overriding command** — poll is suppressed for 5 s after any successful user command; a failed command no longer blocks state refresh
+- **Fix mode command turning device on** — `sendMode` uses `state.power` instead of hardcoded `power=1`; changing mode while AC is off no longer wakes the device
+- **Fix preset switches showing ON when AC is off** — `onGet` and `updateCharacteristics` now gate preset, fan and comfwind values on `state.power`
+- **Fix temperature step** — temperature is snapped in `onSet` and pushed back to HomeKit immediately; corrects slider behaviour even when HomeKit has a cached `minStep`
+- **Fix temperature out-of-range HAP error** — invalid temperature readings from cloud (e.g. 0°C or 100°C when AC is off) are ignored instead of forwarded to HomeKit
+- **Fix unhandled errors in onSet** — all send handlers now use `_trySend()` which catches errors and returns `SERVICE_COMMUNICATION_FAILURE` to HomeKit instead of logging "Unhandled error"
+- **Fix cloud error messages** — cloud API errors now extract `payload.message` instead of dumping the full JSON response
+- **Fix `connection: "cloud"` trying local** — local connection is only attempted when `connection` is explicitly `"hybrid"`
+- **Fix service tile order** — HomeKit climate card always shows tiles in the correct order (Fan → Sleep → Display → Health → Clean → Eco → Comf. Wind) regardless of when each service was first registered
+- **Fix crash on command failure** — `_trySend` now correctly references `this.platform.api.hap` instead of the undefined `this.api`
+- **Fix malformed device cookie** — cloud API now throws an actionable error instead of crashing with a JSON parse exception
+- **Remove Temperature Step and Poll Interval settings** — both are hardcoded (1 °C step, 30 s poll); removed from Config UI and schema to prevent misconfiguration
+- **Cleaner startup log** — reduced to one line per device; removed redundant "Restoring / Updating accessory" messages
+- **Code cleanup** — `LOCAL_MODE_MAP` and `FAN_REMAP` extracted as module-level constants; cloud API default params moved to `DEVICE_PARAMS` constant
+
+## 2.3.4
+
+- **UI: badge colors** — Cloud (teal), Hybrid (green), Local (yellow) — clearly distinct from each other
+- **UI: card colors** — all device cards now use the same neutral color regardless of connection mode
+- **UI: Local device numbering** — Local devices now always start from Local #1, independent of cloud device count
+- **UI: Poll Interval label** — removed "(seconds)" from the label; dropdown options now show "5 seconds", "10 seconds", etc.
+- **UI: English only** — removed all 14 language files; strings are now embedded directly in the UI (no i18n fetch on load)
+
 ## 2.3.3
 
 - **Hybrid offline startup** — if cloud is unavailable at Homebridge startup and the device has a local IP + MAC configured, the device now starts in local-only mode instead of failing. Full hybrid mode resumes automatically on the next restart when internet is available.

package/README.md

@@ -37,6 +37,7 @@ A [Homebridge](https://homebridge.io) plugin for controlling **AUX-based air con
 - **Multi-device** — configure as many ACs as needed
 - **Custom config UI** — built-in Homebridge UI with Fetch Devices button
 - Homebridge v1 & v2 compatible
+- English UI
 
 ---
 

package/config.schema.json

@@ -72,9 +72,9 @@
               "type": "object",
               "properties": {
                 "sleep":  { "title": "Sleep Mode",              "type": "boolean", "default": true },
-                "health": { "title": "Health / Ionizer",        "type": "boolean", "default": true },
-                "eco":    { "title": "Eco / Mildew Prevention", "type": "boolean", "default": true },
-                "clean":  { "title": "Self Clean",              "type": "boolean", "default": true }
+                "health": { "title": "Health / Ionizer",        "type": "boolean", "default": false },
+                "eco":    { "title": "Eco / Mildew Prevention", "type": "boolean", "default": false },
+                "clean":  { "title": "Self Clean",              "type": "boolean", "default": false }
               }
             },
             "showFan": {
@@ -91,19 +91,6 @@
               "title": "Display",
               "type": "boolean",
               "default": true
-            },
-            "pollInterval": {
-              "title": "Poll Interval (seconds)",
-              "type": "integer",
-              "default": 30,
-              "minimum": 5,
-              "maximum": 300
-            },
-            "tempStep": {
-              "title": "Temperature Step",
-              "type": "number",
-              "default": 0.5,
-              "enum": [0.5, 1]
             }
           }
         }
@@ -172,15 +159,7 @@
                 { "key": "devices[].showComfWind" },
                 { "key": "devices[].showDisplay" }
               ]
-            },
-            {
-              "key": "devices[].tempStep",
-              "titleMap": {
-                "0.5": "0.5 °C",
-                "1":   "1 °C"
-              }
-            },
-            { "key": "devices[].pollInterval" }
+            }
           ]
         }
       ]

package/homebridge-ui/public/index.html

@@ -3,12 +3,15 @@
     --accent:        #0095c8;
     --accent-light:  rgba(0,149,200,0.10);
     --accent-border: rgba(0,149,200,0.28);
-    --hybrid:        #7c3aed;
-    --hybrid-light:  rgba(124,58,237,0.08);
-    --hybrid-border: rgba(124,58,237,0.22);
-    --local:         #16a34a;
-    --local-light:   rgba(22,163,74,0.07);
-    --local-border:  rgba(22,163,74,0.22);
+    --hybrid:        #16a34a;
+    --hybrid-light:  rgba(22,163,74,0.08);
+    --hybrid-border: rgba(22,163,74,0.22);
+    --cloud-badge:        #0095c8;
+    --cloud-badge-light:  rgba(0,149,200,0.08);
+    --cloud-badge-border: rgba(0,149,200,0.28);
+    --local:         #a16207;
+    --local-light:   rgba(161,98,7,0.08);
+    --local-border:  rgba(161,98,7,0.25);
     --text:          #1a1a2e;
     --text-muted:    #6b7280;
     --border:        #e5e7eb;
@@ -22,12 +25,15 @@
       --accent:        #00b4d8;
       --accent-light:  rgba(0,180,216,0.08);
       --accent-border: rgba(0,180,216,0.26);
-      --hybrid:        #a78bfa;
-      --hybrid-light:  rgba(167,139,250,0.08);
-      --hybrid-border: rgba(167,139,250,0.22);
-      --local:         #4ade80;
-      --local-light:   rgba(74,222,128,0.08);
-      --local-border:  rgba(74,222,128,0.22);
+      --hybrid:        #4ade80;
+      --hybrid-light:  rgba(74,222,128,0.08);
+      --hybrid-border: rgba(74,222,128,0.22);
+      --cloud-badge:        #00b4d8;
+      --cloud-badge-light:  rgba(0,180,216,0.08);
+      --cloud-badge-border: rgba(0,180,216,0.26);
+      --local:         #facc15;
+      --local-light:   rgba(250,204,21,0.08);
+      --local-border:  rgba(250,204,21,0.22);
       --text:          #e2e8f0;
       --text-muted:    #94a3b8;
       --border:        #334155;
@@ -102,8 +108,6 @@
     border: 1.5px solid var(--accent-border); border-radius: 12px;
     margin-bottom: 12px; background: var(--accent-light); overflow: hidden;
   }
-  .device-card.hybrid-card { border-color: var(--hybrid-border); background: var(--hybrid-light); }
-  .device-card.local-card  { border-color: var(--local-border);  background: var(--local-light); }
 
   .device-header {
     display: flex; justify-content: space-between; align-items: center;
@@ -115,14 +119,12 @@
   .chevron.open { transform: rotate(90deg); }
   .dev-name { font-size: 14px; font-weight: 700; color: var(--accent);
     white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
-  .device-card.hybrid-card .dev-name { color: var(--hybrid); }
-  .device-card.local-card  .dev-name { color: var(--local);  }
 
   .conn-badge {
     font-size: 10px; font-weight: 700; letter-spacing: .5px;
     padding: 2px 7px; border-radius: 20px; flex-shrink: 0; text-transform: uppercase;
   }
-  .conn-badge.cloud  { background: var(--accent-light);  color: var(--accent);  border: 1px solid var(--accent-border); }
+  .conn-badge.cloud  { background: var(--cloud-badge-light); color: var(--cloud-badge); border: 1px solid var(--cloud-badge-border); }
   .conn-badge.hybrid { background: var(--hybrid-light); color: var(--hybrid); border: 1px solid var(--hybrid-border); }
   .conn-badge.local  { background: var(--local-light);  color: var(--local);  border: 1px solid var(--local-border); }
   .dev-meta { font-size: 11px; color: var(--text-muted); white-space: nowrap; }
@@ -131,8 +133,6 @@
     padding: 14px 16px 18px;
     border-top: 1px solid var(--accent-border);
   }
-  .device-card.hybrid-card .device-body { border-color: var(--hybrid-border); }
-  .device-card.local-card  .device-body { border-color: var(--local-border); }
   .device-body.collapsed { display: none; }
 
   /* ── Connection toggle (segmented) ── */
@@ -215,19 +215,21 @@
     }
   });
 
-  /* ── i18n ─────────────────────────────────────────────────── */
-  let t = {};
-  async function loadTranslations() {
-    let lang = 'en';
-    try { lang = await homebridge.i18nCurrentLang(); } catch {}
-    for (const l of [lang, lang.split('-')[0], 'en']) {
-      try {
-        const r = await fetch(`./i18n/${l}.json`);
-        if (r.ok) { t = await r.json(); return; }
-      } catch {}
-    }
-  }
-  await loadTranslations();
+  /* ── Strings ──────────────────────────────────────────────── */
+  const t = {
+    deviceName: 'Device Name',   connection: 'Connection Mode',
+    cloud: 'Cloud',              local: 'Local',
+    email: 'Email',              password: 'Password',      region: 'Region',
+    ip: 'IP Address',            mac: 'MAC Address',
+    fan: 'Fan',                  sleep: 'Sleep',            display: 'Display',
+    health: 'Health',            clean: 'Clean',            eco: 'Eco',
+    comfWind: 'Comf. Wind',
+    addDevice: 'Add Device',     remove: 'Remove',
+    hybrid: 'Hybrid',            cloudCredentials: 'Cloud Credentials',
+    fetching: 'Fetching…',       devicesFound: 'devices found',
+    fetchFailed: 'Fetch failed', fetch: 'Fetch',
+    cloudDevices: 'Cloud Devices', localDevices: 'Local Devices',
+  };
 
   /* ── Config ───────────────────────────────────────────────── */
   let config = {};
@@ -273,32 +275,6 @@
     `;
   }
 
-  function settingsRow(d, i) {
-    const step = d.tempStep !== undefined ? d.tempStep : 0.5;
-    const poll = d.pollInterval || 30;
-    return `
-      <div class="fieldset" style="margin-bottom:12px">
-        <div class="row-2">
-          <div class="fg" style="margin-bottom:0">
-            <label>${t.tempStep||'Temperature Step'}</label>
-            <select class="d-field" data-i="${i}" data-f="tempStep">
-              <option value="0.5" ${step==0.5?'selected':''}>0.5 °C</option>
-              <option value="1"   ${step==1  ?'selected':''}>1.0 °C</option>
-            </select>
-          </div>
-          <div class="fg" style="margin-bottom:0">
-            <label>${t.pollInterval||'Poll Interval'}</label>
-            <select class="d-field" data-i="${i}" data-f="pollInterval">
-              <option value="5"  ${poll==5 ?'selected':''}>5 s</option>
-              <option value="10" ${poll==10?'selected':''}>10 s</option>
-              <option value="20" ${poll==20?'selected':''}>20 s</option>
-              <option value="30" ${poll==30?'selected':''}>30 s</option>
-              <option value="60" ${poll==60?'selected':''}>60 s</option>
-            </select>
-          </div>
-        </div>
-      </div>`;
-  }
 
   /* ── Render cloud device card ─────────────────────────────── */
   function renderCloudDevice(d, i) {
@@ -307,8 +283,6 @@
     const conn      = (d.connection === 'local' || !d.connection) ? 'cloud' : d.connection;
     const isHybrid  = conn === 'hybrid';
     const local     = d.local || {};
-    const step      = d.tempStep !== undefined ? d.tempStep : 0.5;
-    const poll      = d.pollInterval || 30;
     const cardClass = isHybrid ? 'hybrid-card' : '';
     const badge     = isHybrid ? (t.hybrid||'Hybrid') : (t.cloud||'Cloud');
 
@@ -368,19 +342,16 @@
             </div>
           </div>
 
-          ${settingsRow(d, i)}
           ${featToggles(d, i)}
         </div>
       </div>`;
   }
 
   /* ── Render local-only device card ───────────────────────── */
-  function renderLocalDevice(d, i) {
+  function renderLocalDevice(d, i, li) {
     const isOpen = expanded.has(i);
-    const name   = d.name || `Local #${i + 1}`;
+    const name   = d.name || `Local #${li + 1}`;
     const local  = d.local || {};
-    const step   = d.tempStep !== undefined ? d.tempStep : 0.5;
-    const poll   = d.pollInterval || 30;
 
     return `
       <div class="device-card" id="dev-card-${i}">
@@ -390,7 +361,7 @@
             <span class="dev-name">${esc(name)}</span>
           </div>
           <div style="display:flex;align-items:center;gap:8px;flex-shrink:0;margin-left:8px">
-            <span class="conn-badge cloud">${t.local||'Local'}</span>
+            <span class="conn-badge local">${t.local||'Local'}</span>
             <button class="btn btn-danger btn-sm btn-remove" data-i="${i}">${t.remove||'Remove'}</button>
           </div>
         </div>
@@ -418,7 +389,6 @@
             </div>
           </div>
 
-          ${settingsRow(d, i)}
           ${featToggles(d, i)}
         </div>
       </div>`;
@@ -431,7 +401,8 @@
       .filter(({ d }) => d.connection !== 'local');
     const localDevs = config.devices
       .map((d, i) => ({ d, i }))
-      .filter(({ d }) => d.connection === 'local');
+      .filter(({ d }) => d.connection === 'local')
+      .map((item, li) => ({ ...item, li }));
 
     app.innerHTML = `
       <!-- Cloud Credentials -->
@@ -486,7 +457,7 @@
         ${t.localDevices||'Local Devices'}
       </div>
       <div id="local-device-list">
-        ${localDevs.map(({ d, i }) => renderLocalDevice(d, i)).join('')}
+        ${localDevs.map(({ d, i, li }) => renderLocalDevice(d, i, li)).join('')}
       </div>
       <div class="fieldset" style="margin-top:10px">
         <button class="btn btn-primary" id="btn-add-local"
@@ -568,7 +539,6 @@
               local:      { ip: '', mac: '' },
               presets:    { sleep: true, health: false, eco: false, clean: false },
               showFan: true, showComfWind: false, showDisplay: false,
-              tempStep: 0.5, pollInterval: 30,
             });
             expanded.add(config.devices.length - 1);
             added++;
@@ -598,7 +568,6 @@
         local: { ip: '', mac: '' },
         presets: { sleep: true, health: false, eco: false, clean: false },
         showFan: true, showComfWind: false, showDisplay: false,
-        tempStep: 0.5, pollInterval: 30,
       });
       expanded.add(i);
       render(); save();
@@ -630,13 +599,11 @@
       });
     });
 
-    /* Device-level fields (name, tempStep, pollInterval) */
+    /* Device-level fields (name) */
     document.querySelectorAll('.d-field').forEach(el => {
       el.addEventListener('change', () => {
         const i = +el.dataset.i, f = el.dataset.f;
-        config.devices[i][f] = (f === 'tempStep')    ? (parseFloat(el.value) || 0.5)
-          : (f === 'pollInterval') ? (parseInt(el.value)   || 30)
-          : el.value;
+        config.devices[i][f] = el.value;
         save();
       });
       el.addEventListener('input', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-ac-freedom",
-  "version": "2.3.3",
+  "version": "2.3.5",
   "displayName": "Homebridge AC Freedom",
   "description": "Homebridge plugin for AUX air conditioners via Broadlink (local UDP) and AUX Cloud API",
   "main": "index.js",