hoffmation-base 3.4.3 → 3.4.5

package/lib/services/ac/ac-device.js

@@ -161,18 +161,29 @@ class AcDevice extends devices_1.RoomBaseDevice {
         }
         if (this.settings.useOwnTemperature) {
             // Device is in automatic mode so ignore energy and room temperature
+            const outdoorTemp = weather_1.WeatherService.todayMaxTemp;
             if (this.settings.useAutomatic) {
+                // In automatic mode, check if outdoor temperature allows cooling
+                // If not and heating is allowed, prefer heating mode over automatic
+                if (!this.coolingAllowed && this.heatingAllowed) {
+                    this.log(enums_1.LogLevel.Info, `Using heating mode instead of automatic (useAutomatic=true, but outdoorTemp=${outdoorTemp}°C < minOutdoorTempForCooling=${this.settings.minOutdoorTempForCooling}°C, season not summer)`);
+                    return enums_1.AcMode.Heating;
+                }
+                this.log(enums_1.LogLevel.Info, `Using automatic mode (useAutomatic=true, outdoorTemp=${outdoorTemp}°C, coolingAllowed=${this.coolingAllowed})`);
                 return enums_1.AcMode.Auto;
             }
-            if (this.heatingAllowed) {
-                return enums_1.AcMode.Heating;
-            }
-            else if (this.coolingAllowed) {
+            if (this.coolingAllowed) {
                 if (this.settings.overrideCoolingTargetTemp > 0) {
                     this._desiredTemperatur = this.settings.overrideCoolingTargetTemp;
                 }
+                this.log(enums_1.LogLevel.Info, `Using cooling mode (useOwnTemperature=true, outdoorTemp=${outdoorTemp}°C, minOutdoorTempForCooling=${this.settings.minOutdoorTempForCooling}°C)`);
                 return enums_1.AcMode.Cooling;
             }
+            else if (this.heatingAllowed) {
+                this.log(enums_1.LogLevel.Info, `Using heating mode (useOwnTemperature=true, coolingAllowed=false, outdoorTemp=${outdoorTemp}°C, minOutdoorTempForCooling=${this.settings.minOutdoorTempForCooling}°C)`);
+                return enums_1.AcMode.Heating;
+            }
+            this.log(enums_1.LogLevel.Info, `Turning off AC (useOwnTemperature=true, coolingAllowed=false, heatingAllowed=false, outdoorTemp=${outdoorTemp}°C)`);
             return enums_1.AcMode.Off;
         }
         const temp = this.roomTemperature;
@@ -196,6 +207,9 @@ class AcDevice extends devices_1.RoomBaseDevice {
         const targetTemp = heatGroup.desiredTemp;
         const coolUntil = targetTemp + threshold;
         const heatUntil = targetTemp - thresholdHeating;
+        if (coolUntil <= heatUntil && this.coolingAllowed && this.heatingAllowed) {
+            this.log(enums_1.LogLevel.Warn, `INVALID CONFIGURATION: coolUntil (${coolUntil}°C) <= heatUntil (${heatUntil}°C) with both cooling and heating allowed. This will cause oscillation! targetTemp: ${targetTemp}°C, threshold: ${threshold}, thresholdHeating: ${thresholdHeating}`);
+        }
         if (temp > coolUntil && this.coolingAllowed) {
             desiredMode = enums_1.AcMode.Cooling;
         }