hoffmation-base 3.0.0-alpha.5 → 3.0.0-alpha.51

package/lib/server/devices/groups/heatGroup.js

@@ -12,6 +12,7 @@ const models_1 = require("../../../models");
 class HeatGroup extends base_group_1.BaseGroup {
     constructor(roomName, heaterIds, tempSensorIds, humiditySensorIds, acIds) {
         super(roomName, group_type_1.GroupType.Heating);
+        /** @inheritDoc */
         this.settings = new heatGroupSettings_1.HeatGroupSettings();
         this.deviceCluster.deviceMap.set(device_cluster_type_1.DeviceClusterType.Heater, new device_list_1.DeviceList(heaterIds));
         this.deviceCluster.deviceMap.set(device_cluster_type_1.DeviceClusterType.TemperaturSensor, new device_list_1.DeviceList(tempSensorIds));
@@ -19,8 +20,8 @@ class HeatGroup extends base_group_1.BaseGroup {
         this.deviceCluster.deviceMap.set(device_cluster_type_1.DeviceClusterType.Ac, new device_list_1.DeviceList(acIds));
     }
     /**
-     * The current measured temperature of the room in Celsius
-     * @returns {number}
+     * Calculates the combined humidity Level in this room
+     * @returns The humidity in percent
      */
     get humidity() {
         let humidity = baseDeviceInterfaces_1.UNDEFINED_HUMIDITY_VALUE;
@@ -40,8 +41,8 @@ class HeatGroup extends base_group_1.BaseGroup {
         return humidity;
     }
     /**
-     * The current measured temperature of the room in Celsius
-     * @returns {number}
+     * Calculates the temperature based on all available sensors.
+     * @returns The temperature in °C
      */
     get temperature() {
         let temp = baseDeviceInterfaces_1.UNDEFINED_TEMP_VALUE;
@@ -93,8 +94,8 @@ class HeatGroup extends base_group_1.BaseGroup {
         rooms.sort((a, b) => {
             return a.roomName.localeCompare(b.roomName);
         });
-        const response = [`Dies sind die aktuellen Informationen der Heizungen:`];
-        response.push(`Name\t\tLuft Feuchtigkeit\t\tAktuelle Temperatur\t\tSoll Temperatur\t\tVentilstellung`);
+        const response = ['Dies sind die aktuellen Informationen der Heizungen:'];
+        response.push('Name\t\tLuft Feuchtigkeit\t\tAktuelle Temperatur\t\tSoll Temperatur\t\tVentilstellung');
         for (const r of rooms) {
             response.push(`${r.roomName}:\t\t${(_a = r.HeatGroup) === null || _a === void 0 ? void 0 : _a.humidity}%\t\t${(_b = r.HeatGroup) === null || _b === void 0 ? void 0 : _b.temperature}°C\t\t${(_c = r.HeatGroup) === null || _c === void 0 ? void 0 : _c.desiredTemp}°C`);
         }
@@ -127,8 +128,9 @@ class HeatGroup extends base_group_1.BaseGroup {
     }
     /**
      * Sets all ACs to new desired Value
-     * @param {boolean} newDesiredState
-     * @param {boolean} force Whether this was a manual trigger, thus blocking automatic changes for 1 hour
+     * TODO: Migrate to new Command System
+     * @param newDesiredState - The new desired (on/off) state
+     * @param force - Whether this was a manual trigger, thus blocking automatic changes for 1 hour
      */
     setAc(newDesiredState, force = false) {
         const devs = this.getOwnAcDevices();
@@ -139,9 +141,7 @@ class HeatGroup extends base_group_1.BaseGroup {
                 continue;
             }
             dev.turnOff();
-            if (force) {
-                dev.deactivateAutomaticChange(60 * 60 * 1000);
-            }
+            dev.blockAutomationHandler.disableAutomatic(new models_1.BlockAutomaticCommand(force ? models_1.CommandSource.Force : models_1.CommandSource.Unknown, 60 * 60 * 1000));
         }
     }
     deleteAutomaticPoint(name) {

package/lib/server/devices/groups/lightGroup.d.ts

@@ -1,10 +1,18 @@
 import { BaseGroup } from './base-group';
 import { iActuator, iLamp } from '../baseDeviceInterfaces';
-import { ActuatorSetStateCommand, LampSetLightCommand, LampSetTimeBasedCommand, LedSetLightCommand, LightGroupSwitchTimeConditionalCommand, TimeCallback, TimeOfDay, WledSetLightCommand } from '../../../models';
+import { ActuatorSetStateCommand, LampSetLightCommand, LampSetTimeBasedCommand, LedSetLightCommand, LightGroupSwitchTimeConditionalCommand, TimeCallback, WledSetLightCommand } from '../../../models';
 import { WledDevice } from '../wledDevice';
 import { iLedRgbCct } from '../baseDeviceInterfaces/iLedRgbCct';
 export declare class LightGroup extends BaseGroup {
+    /**
+     * Time-Callback for the sunrise light off
+     * @remark This is undefined if the light should not be turned off at sunrise or no calculation has been done yet
+     */
     sonnenAufgangLichtCallback: TimeCallback | undefined;
+    /**
+     * Time-Callback for the sunset light on
+     * @remark This is undefined if the light should not be turned on at sunset or no calculation has been done yet
+     */
     sonnenUntergangLichtCallback: TimeCallback | undefined;
     private _ambientLightOn;
     constructor(roomName: string, lampenIds?: string[], steckerIds?: string[], ledIds?: string[], wledIds?: string[]);
@@ -20,7 +28,7 @@ export declare class LightGroup extends BaseGroup {
     setAllLampen(c: LampSetLightCommand): void;
     setAllLampenTimeBased(c: LampSetTimeBasedCommand): void;
     setAllOutlets(c: ActuatorSetStateCommand): void;
-    setAllActuatorsTimeBased(time: TimeOfDay): void;
+    setAllActuatorsTimeBased(c: LampSetTimeBasedCommand): void;
     setAllLED(c: LedSetLightCommand): void;
     setAllWled(c: WledSetLightCommand): void;
     initialize(): void;

package/lib/server/devices/groups/lightGroup.js

@@ -17,28 +17,9 @@ class LightGroup extends base_group_1.BaseGroup {
         this.deviceCluster.deviceMap.set(device_cluster_type_1.DeviceClusterType.WLED, new device_list_1.DeviceList(wledIds));
     }
     anyLightsOn() {
-        let i;
-        for (i = 0; i < this.getLights().length; i++) {
-            if (this.getLights()[i].lightOn) {
-                return true;
-            }
-        }
-        for (i = 0; i < this.getLED().length; i++) {
-            if (this.getLED()[i].actuatorOn) {
-                return true;
-            }
-        }
-        for (i = 0; i < this.getOutlets().length; i++) {
-            if (this.getOutlets()[i].actuatorOn) {
-                return true;
-            }
-        }
-        for (i = 0; i < this.getWled().length; i++) {
-            if (this.getWled()[i].on) {
-                return true;
-            }
-        }
-        return false;
+        return (this.getAllAsActuator().find((a) => {
+            return a.actuatorOn;
+        }) !== undefined);
     }
     getLights() {
         return this.deviceCluster.getDevicesByType(device_cluster_type_1.DeviceClusterType.Lamps);
@@ -70,14 +51,13 @@ class LightGroup extends base_group_1.BaseGroup {
     switchAll(c) {
         this.getAllAsActuator().forEach((a) => {
             if (a.settings.includeInAmbientLight && !c.isForceAction && !c.on && this._ambientLightOn) {
-                a.log(models_1.LogLevel.Info, `Ambient light mode is active --> Skip non force light off command in ${this.roomName}`);
+                a.log(models_1.LogLevel.Info, `Ambient light mode is active --> Skip non force light off command in ${this.roomName}; command: ${c.logMessage}`);
                 return;
             }
             a.setActuator(c);
         });
     }
     switchTimeConditional(c) {
-        const darkOutside = services_1.TimeCallbackService.darkOutsideOrNight(c.time);
         let resultLampen = false;
         let resultSteckdosen = false;
         let activatedGroups = 0;
@@ -99,23 +79,23 @@ class LightGroup extends base_group_1.BaseGroup {
         if (this.getOutlets().length > 0) {
             activatedGroups++;
             this.log(models_1.LogLevel.Trace, `Set outlets time based for time "${models_1.TimeOfDay[c.time]}"`);
-            resultSteckdosen = darkOutside;
+            resultSteckdosen = true;
         }
         if (activatedGroups === 0 || this.getRoom().settings.includeLampsInNormalMovementLightning) {
             this.log(models_1.LogLevel.Trace, `Set Lamps time based for time "${models_1.TimeOfDay[c.time]}"`);
-            resultLampen = darkOutside;
+            resultLampen = true;
         }
         if (resultLampen) {
-            this.setAllLampenTimeBased(new models_1.LampSetTimeBasedCommand(models_1.CommandSource.Automatic, c.time, 'LightGroup switchTimeConditional'));
+            this.setAllLampenTimeBased(new models_1.LampSetTimeBasedCommand(c, c.time));
         }
         else {
-            this.setAllLampen(new models_1.LampSetLightCommand(models_1.CommandSource.Automatic, false, 'LightGroup switchTimeConditional --> off'));
+            this.setAllLampen(new models_1.LampSetLightCommand(c, false));
         }
         if (resultSteckdosen) {
-            this.setAllActuatorsTimeBased(c.time);
+            this.setAllActuatorsTimeBased(new models_1.LampSetTimeBasedCommand(c, c.time));
         }
         else {
-            this.setAllOutlets(new models_1.ActuatorSetStateCommand(models_1.CommandSource.Automatic, false, 'LightGroup switchTimeConditional --> off'));
+            this.setAllOutlets(new models_1.ActuatorSetStateCommand(c, false));
         }
     }
     setAllLampen(c) {
@@ -133,12 +113,13 @@ class LightGroup extends base_group_1.BaseGroup {
             s.setActuator(c);
         });
     }
-    setAllActuatorsTimeBased(time) {
+    setAllActuatorsTimeBased(c) {
         this.getOutlets().forEach((s) => {
-            if ((time === models_1.TimeOfDay.Night && s.settings.nightOn) ||
-                (time === models_1.TimeOfDay.BeforeSunrise && s.settings.dawnOn) ||
-                (time === models_1.TimeOfDay.AfterSunset && s.settings.duskOn)) {
-                s.setActuator(new models_1.ActuatorSetStateCommand(models_1.CommandSource.Automatic, true, `LightGroup setAllActuatorsTimeBased`));
+            if ((c.time === models_1.TimeOfDay.Daylight && s.settings.dayOn) ||
+                (c.time === models_1.TimeOfDay.Night && s.settings.nightOn) ||
+                (c.time === models_1.TimeOfDay.BeforeSunrise && s.settings.dawnOn) ||
+                (c.time === models_1.TimeOfDay.AfterSunset && s.settings.duskOn)) {
+                s.setActuator(new models_1.ActuatorSetStateCommand(c, true, 'LightGroup setAllActuatorsTimeBased', c.disableAutomaticCommand));
             }
         });
     }
@@ -205,7 +186,7 @@ class LightGroup extends base_group_1.BaseGroup {
     }
     ambientLightStartCallback() {
         this._ambientLightOn = true;
-        this.log(models_1.LogLevel.Info, `Draußen wird es dunkel --> Aktiviere Ambientenbeleuchtung`);
+        this.log(models_1.LogLevel.Info, 'Draußen wird es dunkel --> Aktiviere Ambientenbeleuchtung');
         this.getAllAsActuator().forEach((a) => {
             if (a.settings.includeInAmbientLight) {
                 a.setActuator(new models_1.ActuatorSetStateCommand(models_1.CommandSource.Automatic, true, 'Ambient Light Start Callback'));
@@ -213,7 +194,7 @@ class LightGroup extends base_group_1.BaseGroup {
         });
         services_1.Utils.guardedTimeout(() => {
             var _a;
-            this.log(models_1.LogLevel.Info, `Ambientenbeleuchtung um Mitternacht abschalten.`);
+            this.log(models_1.LogLevel.Info, 'Ambientenbeleuchtung um Mitternacht abschalten.');
             this._ambientLightOn = false;
             if (((_a = this.getRoom().PraesenzGroup) === null || _a === void 0 ? void 0 : _a.anyPresent()) !== true) {
                 this.switchAll(new models_1.ActuatorSetStateCommand(models_1.CommandSource.Automatic, false, 'Ambient Light End Callback'));

package/lib/server/devices/groups/presenceGroup.d.ts

@@ -1,3 +1,4 @@
+import { PresenceGroupFirstEnterAction, PresenceGroupLastLeftAction } from '../../../models';
 import { BaseGroup } from './base-group';
 import { iMotionSensor } from '../baseDeviceInterfaces';
 export declare class PresenceGroup extends BaseGroup {
@@ -9,15 +10,21 @@ export declare class PresenceGroup extends BaseGroup {
     getMotionDetector(): Array<iMotionSensor>;
     initCallbacks(): void;
     presentAmount(): number;
+    addLastLeftCallback(cb: (action: PresenceGroupLastLeftAction) => void): void;
     anyPresent(): boolean;
-    addLastLeftCallback(cb: () => void): void;
-    addFirstEnterCallback(cb: () => void): void;
+    private fireFistEnterCBs;
+    addFirstEnterCallback(cb: (action: PresenceGroupFirstEnterAction) => void): void;
+    private motionSensorOnAnyMovement;
     private motionSensorOnLastLeft;
+    /**
+     * Calculates whether we are after (negative if before) the time the movement
+     * reset timer should have reset the movement.
+     * @returns The time in milliseconds after the reset time.
+     */
+    private getTimeAfterReset;
     /**
      * In case of an existing delayed last left callback timeout, this removes it.
-     * @private
      */
     private resetLastLeftTimeout;
-    private motionSensorOnFirstEnter;
     private executeLastLeftCbs;
 }

package/lib/server/devices/groups/presenceGroup.js

@@ -21,113 +21,106 @@ class PresenceGroup extends base_group_1.BaseGroup {
     }
     initCallbacks() {
         this.getMotionDetector().forEach((b) => {
-            b.addMovementCallback((val) => {
-                var _a;
-                if (!val) {
+            b.addMovementCallback((action) => {
+                if (!action.motionDetected && !this.anyPresent()) {
+                    this.motionSensorOnLastLeft(action);
                     return;
                 }
-                if (services_1.RoomService.awayModeActive || (services_1.RoomService.nightAlarmActive && !b.settings.excludeFromNightAlarm)) {
-                    services_1.RoomService.startIntrusionAlarm(this.getRoom(), b);
+                if (!action.motionDetected && this.anyPresent()) {
+                    this.resetLastLeftTimeout();
+                    return;
                 }
-                if (!b.settings.seesWindow) {
-                    (_a = this.getRoom().WindowGroup) === null || _a === void 0 ? void 0 : _a.changeVibrationMotionBlock(true);
+                // At this Point we can be certain about motion being detected.
+                this.log(models_1.LogLevel.Debug, `New Motion detected, present Amount: ${this.presentAmount()}`, services_1.LogDebugType.NewMovementState);
+                this.motionSensorOnAnyMovement(action);
+                if (this.presentAmount() === 1 && this._lastLeftTimeout === null) {
+                    this.fireFistEnterCBs(action);
                 }
-                services_1.RoomService.movementHistory.add(`${services_1.Utils.nowString()}: Raum "${this.roomName}" Gerät "${b.info.fullName}"`);
+                this.resetLastLeftTimeout();
             });
         });
-        this.addLastLeftCallback(() => {
+        this.addLastLeftCallback((action) => {
             var _a, _b;
             (_a = this.getRoom().WindowGroup) === null || _a === void 0 ? void 0 : _a.changeVibrationMotionBlock(false);
-            (_b = this.getRoom().LightGroup) === null || _b === void 0 ? void 0 : _b.switchAll(new models_1.ActuatorSetStateCommand(models_1.CommandSource.Automatic, false, 'Presence Group LastLeftCallback'));
+            (_b = this.getRoom().LightGroup) === null || _b === void 0 ? void 0 : _b.switchAll(new models_1.ActuatorSetStateCommand(action, false, 'Presence Group LastLeftCallback'));
         });
-        this.addFirstEnterCallback(() => {
+        this.addFirstEnterCallback((action) => {
             if (!this.getRoom().settings.lampenBeiBewegung) {
                 return;
             }
             this.log(models_1.LogLevel.DeepTrace, `Bewegung im Raum ${this.roomName} festgestellt --> Licht einschalten`);
-            this.getRoom().setLightTimeBased(new models_1.RoomSetLightTimeBasedCommand(models_1.CommandSource.Automatic, true, 'Motion detected'));
-        });
-        this.getMotionDetector().forEach((b) => {
-            b.addMovementCallback((val) => {
-                this.motionSensorOnFirstEnter(val);
-            });
-        });
-        this.getMotionDetector().forEach((b) => {
-            b.addMovementCallback((val) => {
-                this.motionSensorOnLastLeft(val);
-            });
+            this.getRoom().setLightTimeBased(new models_1.RoomSetLightTimeBasedCommand(action, true));
         });
     }
     presentAmount() {
-        let count = 0;
-        for (let i = 0; i < this.getMotionDetector().length; i++) {
-            if (this.getMotionDetector()[i].movementDetected) {
-                count++;
-            }
-        }
-        return count;
-    }
-    anyPresent() {
-        for (let i = 0; i < this.getMotionDetector().length; i++) {
-            if (this.getMotionDetector()[i].movementDetected) {
-                return true;
-            }
-        }
-        return false;
+        return this.getMotionDetector().filter((b) => b.movementDetected).length;
     }
     addLastLeftCallback(cb) {
         this._lastLeftCbs.push(cb);
     }
+    anyPresent() {
+        return this.getMotionDetector().find((b) => b.movementDetected) !== undefined;
+    }
+    fireFistEnterCBs(action) {
+        for (const cb of this._firstEnterCbs) {
+            cb(new models_1.PresenceGroupFirstEnterAction(action));
+        }
+    }
     addFirstEnterCallback(cb) {
         this._firstEnterCbs.push(cb);
     }
-    motionSensorOnLastLeft(val) {
-        if (val || this.anyPresent()) {
-            this.resetLastLeftTimeout();
-            return;
+    motionSensorOnAnyMovement(action) {
+        var _a;
+        this._lastMovement = new Date();
+        if (services_1.RoomService.awayModeActive || (services_1.RoomService.nightAlarmActive && !action.sensor.settings.excludeFromNightAlarm)) {
+            services_1.RoomService.startIntrusionAlarm(this.getRoom(), action.sensor);
+        }
+        if (!action.sensor.settings.seesWindow) {
+            (_a = this.getRoom().WindowGroup) === null || _a === void 0 ? void 0 : _a.changeVibrationMotionBlock(true);
         }
-        let timeAfterReset = services_1.Utils.nowMS() - this._lastMovement.getTime() - this.getRoom().settings.movementResetTimer * 1000;
+        services_1.RoomService.movementHistory.add(`${services_1.Utils.nowString()}: Raum "${this.roomName}" Gerät "${action.sensor.info.fullName}"`);
+    }
+    motionSensorOnLastLeft(action) {
+        let timeAfterReset = this.getTimeAfterReset();
         if (timeAfterReset > 0) {
             this.log(models_1.LogLevel.Debug, `Movement reset. Active Motions: ${this.presentAmount()}\tTime after Last Movement including Reset: ${timeAfterReset}`);
-            this.executeLastLeftCbs();
+            this.executeLastLeftCbs(new models_1.PresenceGroupLastLeftAction(action));
             return;
         }
-        this.log(models_1.LogLevel.Debug, `Movement reset in ${this.roomName} delayed.`);
+        const newResetTime = new Date(services_1.Utils.nowMS() + Math.abs(timeAfterReset));
+        this.log(models_1.LogLevel.Debug, `Movement reset in ${this.roomName} delayed to ${newResetTime.toLocaleTimeString('de-DE')}.`);
         this.resetLastLeftTimeout();
         this._lastLeftTimeout = services_1.Utils.guardedTimeout(() => {
-            timeAfterReset =
-                services_1.Utils.nowMS() - this._lastMovement.getTime() - this.getRoom().settings.movementResetTimer * 1000;
+            this._lastLeftTimeout = null;
+            timeAfterReset = this.getTimeAfterReset();
             const presentAmount = this.presentAmount();
-            this.log(models_1.LogLevel.Debug, `Delayed Movement reset. Active Motions: ${this.presentAmount()}\tTime after Last Movement including Reset: ${timeAfterReset}`);
+            this.log(models_1.LogLevel.Debug, `Delayed Movement reset. Active Motions: ${presentAmount}\tTime after Last Movement including Reset: ${timeAfterReset}, action: ${action.reasonTrace}`);
             if (presentAmount <= 0 && timeAfterReset > 0) {
-                this.executeLastLeftCbs();
+                this.executeLastLeftCbs(new models_1.PresenceGroupLastLeftAction(action));
             }
         }, Math.abs(timeAfterReset) + 500, this);
     }
+    /**
+     * Calculates whether we are after (negative if before) the time the movement
+     * reset timer should have reset the movement.
+     * @returns The time in milliseconds after the reset time.
+     */
+    getTimeAfterReset() {
+        return services_1.Utils.nowMS() - this._lastMovement.getTime() - this.getRoom().settings.movementResetTimer * 1000;
+    }
     /**
      * In case of an existing delayed last left callback timeout, this removes it.
-     * @private
      */
     resetLastLeftTimeout() {
-        if (this._lastLeftTimeout !== null) {
-            clearTimeout(this._lastLeftTimeout);
-        }
-    }
-    motionSensorOnFirstEnter(val) {
-        if (!val) {
-            return;
-        }
-        this._lastMovement = new Date();
-        if (this.presentAmount() > 1) {
+        if (this._lastLeftTimeout === null) {
             return;
         }
-        for (const cb of this._firstEnterCbs) {
-            cb();
-        }
+        clearTimeout(this._lastLeftTimeout);
+        this._lastLeftTimeout = null;
     }
-    executeLastLeftCbs() {
+    executeLastLeftCbs(action) {
         for (const cb of this._lastLeftCbs) {
-            cb();
+            cb(action);
         }
     }
 }

package/lib/server/devices/groups/tasterGroup.js

@@ -25,42 +25,42 @@ class TasterGroup extends base_group_1.BaseGroup {
                     return;
                 }
                 (_a = this.getRoom().WindowGroup) === null || _a === void 0 ? void 0 : _a.setDesiredPosition(new models_1.WindowSetDesiredPositionCommand(models_1.CommandSource.Manual, 0, 'Button Top Left pressed long'));
-            }, `Close all Rollos in this room`);
+            }, 'Close all Rollos in this room');
             (_b = t.buttonTopLeft) === null || _b === void 0 ? void 0 : _b.addCb(button_1.ButtonPressType.short, (pValue) => {
                 var _a;
                 if (!pValue) {
                     return;
                 }
                 (_a = this.getRoom().WindowGroup) === null || _a === void 0 ? void 0 : _a.setDesiredPosition(new models_1.WindowSetDesiredPositionCommand(models_1.CommandSource.Manual, 25, 'Button Top Left pressed short'));
-            }, `Nearly closes all Rollos in this room`);
+            }, 'Nearly closes all Rollos in this room');
             (_c = t.buttonTopRight) === null || _c === void 0 ? void 0 : _c.addCb(button_1.ButtonPressType.long, (pValue) => {
                 var _a;
                 if (!pValue) {
                     return;
                 }
                 (_a = this.getRoom().WindowGroup) === null || _a === void 0 ? void 0 : _a.setDesiredPosition(new models_1.WindowSetDesiredPositionCommand(models_1.CommandSource.Manual, 100, 'Button Top Right pressed long'));
-            }, `Open all Rollos in this room`);
+            }, 'Open all Rollos in this room');
             (_d = t.buttonTopRight) === null || _d === void 0 ? void 0 : _d.addCb(button_1.ButtonPressType.short, (pValue) => {
                 var _a;
                 if (!pValue) {
                     return;
                 }
                 (_a = this.getRoom().WindowGroup) === null || _a === void 0 ? void 0 : _a.setDesiredPosition(new models_1.WindowSetDesiredPositionCommand(models_1.CommandSource.Manual, 50, 'Button Top Right pressed short'));
-            }, `All Rollos in this room to middle`);
+            }, 'All Rollos in this room to middle');
             (_e = t.buttonMidLeft) === null || _e === void 0 ? void 0 : _e.addCb(button_1.ButtonPressType.long, (pValue) => {
                 var _a;
                 if (!pValue) {
                     return;
                 }
                 (_a = this.getRoom().LightGroup) === null || _a === void 0 ? void 0 : _a.switchAll(new models_1.ActuatorSetStateCommand(models_1.CommandSource.Manual, true, 'Button press to turn all lights on'));
-            }, `Turn all Lights in this room on`);
+            }, 'Turn all Lights in this room on');
             (_f = t.buttonMidRight) === null || _f === void 0 ? void 0 : _f.addCb(button_1.ButtonPressType.long, (pValue) => {
                 var _a;
                 if (!pValue) {
                     return;
                 }
                 (_a = this.getRoom().LightGroup) === null || _a === void 0 ? void 0 : _a.switchAll(new models_1.ActuatorSetStateCommand(models_1.CommandSource.Manual, false, 'Button press to turn all lights off'));
-            }, `Turn all Lights in this room off`);
+            }, 'Turn all Lights in this room off');
             if (((_g = services_1.SettingsService.settings.sonos) === null || _g === void 0 ? void 0 : _g.buttonBotRightForRadio) === true) {
                 const sonosGroup = this.getRoom().SonosGroup;
                 if (sonosGroup !== undefined && sonosGroup.getOwnSonosDevices().length > 0) {

package/lib/server/devices/groups/windowGroup.d.ts

@@ -3,7 +3,17 @@ import { Window } from './Window';
 import { BaseGroup } from './base-group';
 export declare class WindowGroup extends BaseGroup {
     windows: Window[];
+    /**
+     * Timecallback for sunrise-shutter actions
+     * @remarks This callback is only set if needed and already calculated.
+     * @warning Manual setting of this callback is not recommended. Prefer {@link recalcTimeCallbacks} after changing settings.
+     */
     sunriseShutterCallback: TimeCallback | undefined;
+    /**
+     * Timecallback for sunset-shutter actions
+     * @remarks This callback is only set if needed and already calculated.
+     * @warning Manual setting of this callback is not recommended. Prefer {@link recalcTimeCallbacks} after changing settings.
+     */
     sunsetShutterCallback: TimeCallback | undefined;
     constructor(roomName: string, windows: Window[]);
     setDesiredPosition(c: WindowSetDesiredPositionCommand): void;
@@ -11,7 +21,7 @@ export declare class WindowGroup extends BaseGroup {
     recalcTimeCallbacks(): void;
     setRolloByWeatherStatus(c: WindowSetRolloByWeatherStatusCommand): void;
     sunriseUp(c: ShutterSunriseUpCommand): void;
-    restoreRolloPosition(c: RoomRestoreShutterPositionCommand): void;
+    restoreShutterPosition(c: RoomRestoreShutterPositionCommand): void;
     changeVibrationMotionBlock(block: boolean): void;
     private sunsetDown;
     private reconfigureSunsetShutterCallback;

package/lib/server/devices/groups/windowGroup.js

@@ -62,7 +62,7 @@ class WindowGroup extends base_group_1.BaseGroup {
                 return;
             }
             if (darkOutside) {
-                f.restoreDesiredPosition(new models_1.WindowRestoreDesiredPositionCommand(c, `It's dark outside.`));
+                f.restoreDesiredPosition(new models_1.WindowRestoreDesiredPositionCommand(c, "It's dark outside."));
                 return;
             }
             let desiredPos = f.desiredPosition;
@@ -79,14 +79,14 @@ class WindowGroup extends base_group_1.BaseGroup {
         });
     }
     sunriseUp(c) {
-        this.windows.forEach((f) => {
-            if (!this.getRoom().settings.sonnenAufgangRollos || f.getShutter().length === 0) {
+        this.windows.forEach((w) => {
+            if (!this.getRoom().settings.sonnenAufgangRollos || w.getShutter().length === 0) {
                 return;
             }
-            f.setDesiredPosition(new models_1.WindowSetDesiredPositionCommand(c, 100));
+            w.setDesiredPosition(new models_1.WindowSetDesiredPositionCommand(c, 100));
         });
     }
-    restoreRolloPosition(c) {
+    restoreShutterPosition(c) {
         if (!c.recalc) {
             this.windows.forEach((f) => {
                 f.restoreDesiredPosition(new models_1.WindowRestoreDesiredPositionCommand(c));
@@ -164,7 +164,7 @@ class WindowGroup extends base_group_1.BaseGroup {
         }
         if (this.sunriseShutterCallback === undefined) {
             this.log(models_1.LogLevel.Debug, `Add Sunrise shutter TimeCallback for ${this.roomName}`);
-            this.sunriseShutterCallback = new models_1.TimeCallback(`${this.roomName} Sonnenaufgang Rollos`, models_1.TimeCallbackType.Sunrise, () => {
+            this.sunriseShutterCallback = new models_1.TimeCallback(`${this.roomName} Sunrise Shutter`, models_1.TimeCallbackType.Sunrise, () => {
                 if (room.skipNextRolloUp) {
                     this.log(models_1.LogLevel.Info, `${this.roomName} skipped sunrise up due to room.skipNextRolloUp`);
                     room.skipNextRolloUp = false;

package/lib/server/devices/hmIPDevices/hmIpAccessPoint.d.ts

@@ -4,6 +4,7 @@ export declare class HmIpAccessPoint extends HmIPDevice {
     constructor(pInfo: IoBrokerDeviceInfo);
     private _ip;
     get ip(): string;
+    /** @inheritDoc */
     update(idSplit: string[], state: ioBroker.State, initial?: boolean): void;
     private updateBaseInformation;
 }

package/lib/server/devices/hmIPDevices/hmIpAccessPoint.js

@@ -12,6 +12,7 @@ class HmIpAccessPoint extends hmIpDevice_1.HmIPDevice {
     get ip() {
         return this._ip;
     }
+    /** @inheritDoc */
     update(idSplit, state, initial = false) {
         this.log(models_1.LogLevel.DeepTrace, `AP Update: ID: ${idSplit.join('.')} JSON: ${JSON.stringify(state)}`);
         super.update(idSplit, state, initial, true);

package/lib/server/devices/hmIPDevices/hmIpBewegung.d.ts

@@ -1,26 +1,29 @@
 import { HmIPDevice } from './hmIpDevice';
-import { MotionSensorSettings } from '../../../models';
+import { MotionSensorAction, MotionSensorSettings } from '../../../models';
 import { iIlluminationSensor, iMotionSensor } from '../baseDeviceInterfaces';
 import { IoBrokerDeviceInfo } from '../IoBrokerDeviceInfo';
 export declare class HmIpBewegung extends HmIPDevice implements iIlluminationSensor, iMotionSensor {
     private static MOVEMENT_DETECTION;
     private static CURRENT_ILLUMINATION;
+    /** @inheritDoc */
     settings: MotionSensorSettings;
+    /** @inheritDoc */
     movementDetected: boolean;
+    /** @inheritDoc */
+    detectionsToday: number;
     private _movementDetectedCallback;
     private initialized;
     private _fallBackTimeout;
     private _lastMotionTime;
+    private _currentIllumination;
     constructor(pInfo: IoBrokerDeviceInfo);
+    /** @inheritDoc */
     get timeSinceLastMotion(): number;
-    private _detectionsToday;
-    get detectionsToday(): number;
-    set detectionsToday(pVal: number);
-    private _currentIllumination;
     get currentIllumination(): number;
     private set currentIllumination(value);
-    addMovementCallback(pCallback: (pValue: boolean) => void): void;
+    addMovementCallback(pCallback: (action: MotionSensorAction) => void): void;
     persistMotionSensor(): void;
+    /** @inheritDoc */
     update(idSplit: string[], state: ioBroker.State, initial?: boolean): void;
     updateMovement(pVal: boolean): void;
     private resetFallbackTimeout;