hof 24.5.1 → 24.6.0

package/CHANGELOG.md

@@ -1,3 +1,12 @@
+## 2026-10-07 Version 24.5.2 (Stable), @vivekkumar-ho
+
+### Fixes
+- Preserved original Notify errors and their response payloads, and removed duplicate failure logging.
+
+### Chore & Maintenance
+- Replaced Notify email reference generation with Node.js `crypto.randomUUID`.
+- Added Notify coverage for email payloads, UUID references, attachments, and error propagation and logging.
+
 ## 2026-09-14 Version 24.5.1 (Stable), @nzorba @dk4g @dalglishdhandaHO
 
 ### Changed

package/components/notify/notify.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const NotifyClient = require('notifications-node-client').NotifyClient;
-const { v4: uuidv4 } = require('uuid');
+const { randomUUID } = require('node:crypto');
 const config = require('../../config/hof-defaults');
 const logger = require('../../lib/logger');
 
@@ -10,41 +10,42 @@ module.exports = class Notify {
     const options = opts || {};
     this.options = options;
     this.logger = logger(config);
-    this.notifyClient =  new NotifyClient(options.notifyApiKey);
+    this.notifyClient = new NotifyClient(options.notifyApiKey);
     this.notifyTemplate = options.notifyTemplate;
   }
 
   async sendEmail(templateId, recipient, personalisation) {
-    const reference = uuidv4();
+    const reference = randomUUID();
 
     try {
       await this.notifyClient.sendEmail(templateId, recipient, {
         personalisation: personalisation,
-        reference });
+        reference
+      });
       this.logger.log('info', 'Email sent');
     } catch (error) {
-      this.logger.log('error', error.response ? error.response.data : error.message);
-      throw new Error(error.response ? error.response.data : error.message);
+      this.logger.log(
+        'error',
+        error.response ? error.response.data : error.message
+      );
+      // Preserve the original Notify error and its response payload.
+      throw error;
     }
   }
 
   async send(email) {
-    let personalisation = {
+    const personalisation = {
       'email-subject': email.subject,
       'email-body': email.body
     };
 
-    if (email.attachment && email.attachment !== undefined) {
-      personalisation = Object.assign({'email-attachment':
-        this.notifyClient.prepareUpload(email.attachment)}, personalisation);
+    if (email.attachment) {
+      personalisation['email-attachment'] = this.notifyClient.prepareUpload(
+        email.attachment
+      );
     }
 
-    try {
-      await this.sendEmail(this.notifyTemplate, email.recipient, personalisation);
-    } catch (error) {
-      this.logger.log('error', error.response ? error.response.data : error.message);
-      throw new Error(error.response ? error.response.data : error.message);
-    }
+    await this.sendEmail(this.notifyTemplate, email.recipient, personalisation);
   }
 };
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "hof",
   "description": "A bootstrap for HOF projects",
-  "version": "24.5.1",
+  "version": "24.6.0",
   "license": "MIT",
   "main": "index.js",
   "author": "HomeOffice",
@@ -79,7 +79,7 @@
     "mixwith": "^0.1.1",
     "morgan": "^1.11.0",
     "mustache": "^4.2.0",
-    "notifications-node-client": "^8.4.0",
+    "notifications-node-client": "^8.5.0",
     "redis": "^3.1.2",
     "reqres": "^3.0.1",
     "rimraf": "^3.0.2",
@@ -135,6 +135,7 @@
     "exit": "true"
   },
   "resolutions": {
+    "vite": "^7.3.6",
     "form-data": "^4.0.6",
     "js-yaml": "^4.2.0",
     "qs": "^6.14.1",