hls.js 1.5.14-0.canary.10448 → 1.5.14-0.canary.10451

package/package.json

@@ -117,7 +117,7 @@
     "mocha": "10.6.0",
     "node-fetch": "3.3.2",
     "npm-run-all2": "6.2.2",
-    "prettier": "3.3.2",
+    "prettier": "3.3.3",
     "promise-polyfill": "8.3.0",
     "rollup": "4.18.1",
     "rollup-plugin-istanbul": "5.0.0",
@@ -130,5 +130,5 @@
     "url-toolkit": "2.2.5",
     "wrangler": "3.65.0"
   },
-  "version": "1.5.14-0.canary.10448"
+  "version": "1.5.14-0.canary.10451"
 }

package/src/errors.ts

@@ -85,6 +85,8 @@ export enum ErrorDetails {
   INTERNAL_EXCEPTION = 'internalException',
   // Identifier for an internal call to abort a loader
   INTERNAL_ABORTED = 'aborted',
+  // Triggered when attachMedia fails
+  ATTACH_MEDIA_ERROR = 'attachMediaError',
   // Uncategorized error
   UNKNOWN = 'unknown',
 }

package/src/hls.ts

@@ -389,6 +389,17 @@ export default class Hls implements HlsEventEmitter {
    * Attaches Hls.js to a media element
    */
   attachMedia(media: HTMLMediaElement) {
+    if (!media) {
+      const error = new Error(`attachMedia failed: media argument is ${media}`);
+      this.trigger(Events.ERROR, {
+        type: ErrorTypes.OTHER_ERROR,
+        details: ErrorDetails.ATTACH_MEDIA_ERROR,
+        fatal: true,
+        error,
+      });
+      return;
+    }
+
     this.logger.log('attachMedia');
     this._media = media;
     this.trigger(Events.MEDIA_ATTACHING, { media: media });