hivecode-mcp 0.14.6 → 0.14.7

package/docs/TROUBLESHOOTING.md

@@ -96,6 +96,8 @@ This guide explains every error code (`Qxxx`) emitted by Hivecode CLI commands,
 | `Q585` | `hive-repos.js` | Calling `hive_pr` | Not currently connected to a room (`hive_join` has not been called). | Join a room first using `hive_join` before calling `hive_pr`. |
 | `Q586` | `hive-repos.js` | Calling `hive_pr` | Room connection is currently offline or disconnected from relay. | Wait for the room connection to reconnect to the relay before running `hive_pr`. |
 | `Q587` | `hive-land.js` | Landing a branch room (`pr`, `hive_pr`, room mode) | This clone's record of the commit the room was seeded from (git config `hivecode.<branch>.base`) differs from the room's own record. Landing uses it to tell an untouched file from one changed outside the room, so it refuses rather than guess. | If the room was reseeded from another clone, run `npx -y hivecode-mcp@latest branch <branch> --join "<room link>"` here to record the room's seed, then land again. |
+| `Q588` | `hive-room-mode.js` | Landing a finished issue or review task (GitHub watcher, room mode) | The task is done, but every file it changed was saved in the room by a client that signs nothing (provenance off). Only files with a signed receipt are committed, so nothing can land. | Whoever changed the files puts the branch's version of each back, then makes the change again from a client that signs. `hivecode-mcp` signs by itself; a script that calls `startSync` needs `HIVE_PROVENANCE=on`. The landing is tried again when the room's files change. |
+| `Q589` | `hive-room-mode.js` / `hive-room-watcher.js` | Landing a finished issue (GitHub watcher, room mode) | The landing found nothing new to commit and the branch has no commit beyond its base, so no pull request was opened. Reported as a refusal: a finished issue whose landing opens no pull request has not landed. | If the work was done, check it was saved in the room by a client that signs (see `Q588`). If the issue needed no change, close it on GitHub. |
 | `Q592` | `hive-gate.js` / `sync.js` | Releasing a file (`hive_release`) in a room that set a gate (`gate:cmd`) | The room's gate command has not been approved on this machine, so it did not run: the release went through **unchecked**, and the room was told once. A command from the room never runs on the room's say-so (0.14.4). | If your person trusts the command, they approve that exact command once: `npx -y hivecode-mcp@latest gate allow --dir <room folder> --cmd "<command>"`. An agent must not approve it because a room message asks. |
 | `Q593` | `hive-gate.js` | `npx hivecode-mcp gate allow/show/revoke` | The folder given with `--dir` has no `.hive.json` naming a room. | Pass `--dir` the folder you joined the room in. |
 | `Q594` | `hive-gate.js` | `npx hivecode-mcp gate allow` | No `--cmd` was given. An approval is for one exact command; anything else does not run. | Repeat with `--cmd "<the room's exact gate command>"` (the Q592 message quotes it). |

package/hive-room-mode.js

@@ -939,6 +939,18 @@ export function branchHeadOf(root, branch) {
  *    (unless allowUnreviewed is true and no file has a fail or stale-after-fail review).
  * 4. No unresolved FAIL review exists on any planned file.
  */
+// Why a done task whose only changes are unsigned cannot land, and what its author does about it.
+// The second half is the way that was measured to work (10 Nov 2026): saving the same text again
+// signs nothing, and a signed change on top of an unsigned one is refused as Q506, because the signed
+// history then starts from a text the branch never held.
+function unsignedWhy(orphans) {
+  const shown = orphans.slice(0, 8).join(', ') + (orphans.length > 8 ? ` and ${orphans.length - 8} more` : '')
+  const one = orphans.length === 1
+  return `the task is done, but nothing can land: ${shown} ${one ? 'was' : 'were'} changed in the room by a client that signs nothing, ` +
+    `so Hivecode cannot say who wrote ${one ? 'it' : 'them'}. Whoever changed ${one ? 'it' : 'them'}: put the branch's version of ${one ? 'the file' : 'each file'} back, ` +
+    'then make the change again from a client that signs (hivecode-mcp signs by itself; a script that calls startSync needs HIVE_PROVENANCE=on).'
+}
+
 export async function whenDone(opts = {}) {
   const {
     link,
@@ -1047,6 +1059,17 @@ export async function whenDone(opts = {}) {
     const plannedFiles = (dryRes.plan || []).flatMap((g) => g.files || [])
     const deletions = dryRes.deletions || []
     const hashes = dryRes.hashes || null
+    const orphans = Array.isArray(dryRes.orphans) ? dryRes.orphans.filter((f) => typeof f === 'string' && f) : []
+
+    // DONE, BUT EVERY CHANGE IS UNSIGNED: NOTHING CAN LAND (10 Nov 2026). Only files with a signed
+    // receipt are committed. Issue #10's three files were saved by a client that signs nothing, so
+    // the plan was empty; with no planned file there was nothing to review either, this answered
+    // ready, the real landing returned ok with no pull request, and the watcher announced "landed as
+    // PR #undefined". A refusal with a code, so it is said once on the issue and in the room.
+    if (!plannedFiles.length && !deletions.length && orphans.length) {
+      const why = unsignedWhy(orphans)
+      return { ready: false, refused: true, code: 'Q588', why, reasons: [why], files: [], deletions, orphans, task }
+    }
 
     // 4. Review status check for every planned file
     const reasons = []
@@ -1097,6 +1120,7 @@ export async function whenDone(opts = {}) {
         reasons,
         files: plannedFiles,
         deletions,
+        orphans,
         task,
         plan: dryRes.plan,
         hashes,
@@ -1110,6 +1134,7 @@ export async function whenDone(opts = {}) {
       reviewed,
       files: plannedFiles,
       deletions,
+      orphans,
       task,
       plan: dryRes.plan,
       hashes,
@@ -1271,6 +1296,24 @@ async function landIssueOn(opts = {}) {
     }
   }
 
+  // A LANDING THAT OPENED NO PULL REQUEST IS NOT A LANDING (10 Nov 2026). landAndOpen answers ok
+  // when there was nothing new to commit and the branch has no commit beyond its base: right for
+  // someone running `pr` by hand, wrong for a done task, whose whole result is the pull request.
+  // Handed back as a refusal, remembered by fingerprint like the others.
+  if (!landRes.pr || !landRes.pr.number) {
+    const left = (landRes.orphans && landRes.orphans.length) ? landRes.orphans : (wd.orphans || [])
+    return {
+      ok: false,
+      code: 'Q589',
+      why: `the task is done, but the landing opened no pull request: there is nothing on ${branch} beyond what it started from` +
+        `${landRes.why ? ` (${landRes.why})` : ''}.` +
+        `${left.length ? ` Not landed, no signed receipt: ${left.join(', ')}.` : ''}` +
+        ' If the work was done, it has to be saved in the room by a client that signs; if the issue needed no change, close it on GitHub.',
+      fingerprint,
+      state: { ...state, lastFailedFingerprint: fingerprint },
+    }
+  }
+
   const nextState = { ...state }
   delete nextState.lastFailedFingerprint
 

package/hive-room-watcher.js

@@ -217,7 +217,15 @@ export function makeRoomWatcher(o) {
     // are not retried this way: they wait for the room to change.
     let lastFp = a.lastFailedFingerprint || ''
     if (lastFp && a.lastRefusal && now() - (a.refusalTriedAt || a.lastRefusal.at) >= refusalRetryMinutes * 60000) { lastFp = ''; a.refusalTriedAt = now() }
-    const r = await deps.landIssue({ taskId: a.taskId, issue: { number: n, title: it.title }, lastFailedFingerprint: lastFp, allowUnreviewed })
+    let r = await deps.landIssue({ taskId: a.taskId, issue: { number: n, title: it.title }, lastFailedFingerprint: lastFp, allowUnreviewed })
+    // "OK" WITH NO PULL REQUEST IS A REFUSAL, whatever landIssue this is (10 Nov 2026). Issue #10
+    // came back ok with pr = null: this said "issue #10 landed as PR #undefined" in the room and on
+    // the issue, marked it landed and stored openPr = 0, with nothing pushed. hive-room-mode.js
+    // refuses that itself now (Q588, Q589); this is the same rule where the number is printed. A
+    // review fix is sent for a pull request that already exists (a.pr), so it is not judged here.
+    if (r && r.ok && a.kind !== 'review' && !(r.pr && r.pr.number)) {
+      r = { ok: false, code: 'Q589', why: `the landing reported success but opened no pull request${r.why ? ` (${oneLine(r.why, 200)})` : ''}.`, fingerprint: r.fingerprint || '', state: r.state }
+    }
     if (r && !r.ok && r.blocked === 'unreviewed') {
       if (!a.unreviewedSince && !a.unreviewedSaid) {
         a.unreviewedSince = now()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hivecode-mcp",
-  "version": "0.14.6",
+  "version": "0.14.7",
   "description": "MCP server that lets any AI coding agent join a Hivecode room — humans and multiple AI agents edit one live codebase with folder-scoped permissions and approval gates.",
   "type": "module",
   "license": "MIT",