hippo-memory 1.61.0 → 1.63.0

package/dist/connectors/github/backfill.d.ts

@@ -5,13 +5,13 @@
  *   - /repos/{repo}/issues/comments      -> issue_comments_hwm
  *   - /repos/{repo}/pulls/comments       -> pr_review_comments_hwm
  *
- * Crash safety (codex P1 #3): each stream's HWM is persisted ONLY after
+ * Crash safety: each stream's HWM is persisted ONLY after
  * the stream fully drains. If stream 2 throws mid-flight, stream 1's HWM
  * is committed and stream 2's stays NULL (or its prior value). Rerun
  * picks up from stream 1's saved HWM and re-fetches stream 2 from its
  * last committed point.
  *
- * Codex P1 #2: the /issues endpoint returns BOTH issues and PRs (a PR is
+ * The /issues endpoint returns BOTH issues and PRs (a PR is
  * an issue with a `pull_request` field). We skip PRs here so they don't
  * get ingested under the issues schema. PRs are handled via webhook in
  * V1 (no /pulls backfill stream — review comments cover the discussion

package/dist/connectors/github/backfill.js

@@ -5,13 +5,13 @@
  *   - /repos/{repo}/issues/comments      -> issue_comments_hwm
  *   - /repos/{repo}/pulls/comments       -> pr_review_comments_hwm
  *
- * Crash safety (codex P1 #3): each stream's HWM is persisted ONLY after
+ * Crash safety: each stream's HWM is persisted ONLY after
  * the stream fully drains. If stream 2 throws mid-flight, stream 1's HWM
  * is committed and stream 2's stays NULL (or its prior value). Rerun
  * picks up from stream 1's saved HWM and re-fetches stream 2 from its
  * last committed point.
  *
- * Codex P1 #2: the /issues endpoint returns BOTH issues and PRs (a PR is
+ * The /issues endpoint returns BOTH issues and PRs (a PR is
  * an issue with a `pull_request` field). We skip PRs here so they don't
  * get ingested under the issues schema. PRs are handled via webhook in
  * V1 (no /pulls backfill stream — review comments cover the discussion
@@ -110,18 +110,15 @@ function isCommentItem(x) {
 }
 /**
  * Drain one stream end-to-end. Pauses and retries on rate-limit. Throws on
- * any other fetch error so the caller leaves the HWM unchanged (round 1
- * codex P1 #3 crash safety).
+ * any other fetch error so the caller leaves the HWM unchanged.
  *
- * v1.3.1 (round 2 codex P1s + claude P1):
  *   - Tracks max(updated_at) across ALL fetched items, including ones
  *     `toIngestEvent` rejects (e.g., PRs returned via `/issues`). Otherwise
  *     a page of pure PRs would never advance the HWM and the next run would
  *     re-fetch the same window forever.
  *   - Returns `drained: boolean` — true only when the stream actually ran
- *     to next=null. Callers MUST NOT advance the HWM when drained=false.
- *     Was a bug in v1.3.0: hitting maxPerStream cap returned the partial
- *     maxUpdatedAt and the caller persisted it, skipping the unfetched tail.
+ *     to next=null. Callers MUST NOT advance the HWM when drained=false,
+ *     or a capped run would persist a partial HWM and skip the unfetched tail.
  */
 async function drainStream(ctx, url0, toIngestEvent, fetcher, token, sleep, maxItems) {
     let url = url0;
@@ -141,9 +138,7 @@ async function drainStream(ctx, url0, toIngestEvent, fetcher, token, sleep, maxI
         }
         pages++;
         for (const item of page.items) {
-            // v1.3.1: track updated_at on EVERY item, before the toIngestEvent
-            // filter. Skipped PRs from /issues still contribute to the HWM so
-            // PR-only pages don't loop forever.
+            // Track updated_at on EVERY item, before the toIngestEvent filter, so PR-only pages don't loop forever.
             // SAFETY: updated_at is GitHub's ISO-timestamp field on every item
             // shape this stream returns; a non-string value would only fail the
             // string comparisons below, matching pre-migration passthrough.
@@ -175,7 +170,7 @@ async function drainStream(ctx, url0, toIngestEvent, fetcher, token, sleep, maxI
 function issueItemToEvent(item, repository) {
     if (!isIssuesItem(item))
         return null;
-    // Codex P1 #2: /issues returns PRs too — skip them.
+    // /issues returns PRs too; skip them.
     if (item.pull_request)
         return null;
     const payload = {
@@ -240,9 +235,7 @@ function prReviewCommentItemToEvent(item, repository) {
 /** Drains one stream, then persists its HWM only when the stream ran to the end. */
 async function backfillStream(ctx, opts, sleep, stream) {
     const res = await drainStream(ctx, stream.url, stream.toIngestEvent, opts.fetcher, opts.token, sleep, opts.maxPerStream);
-    // v1.3.1: only advance HWM when the stream actually drained. A capped run
-    // (--max) must leave the HWM at its previous value so the next invocation
-    // re-fetches the unprocessed tail.
+    // A capped run (--max) must leave the HWM at its previous value so the next run re-fetches the unprocessed tail.
     if (res.drained && res.maxUpdatedAt) {
         writeOneHwm(ctx.hippoRoot, ctx.tenantId, opts.repoFullName, stream.column, res.maxUpdatedAt);
     }

package/dist/connectors/github/cli-impl.js

@@ -162,9 +162,7 @@ export async function cmdGithubDlqReplay(hippoRoot, args, flags) {
         tenantId: resolveTenantId({}),
         actor: adminActor('cli:github-dlq-replay'),
     };
-    // v1.3.1 hotfix (codex P1): without an ingestHook the v1.3.0 CLI was a
-    // dry-run that printed "replay ok" while only bumping retry_count. Wire the
-    // real hook so `replay` actually re-runs the ingest path.
+    // Without an ingestHook replay only bumps retry_count while printing "replay ok"; the real hook re-runs ingest.
     const result = await replayDlqEntry(ctx, id, {
         force,
         webhookSecret: envGithubWebhookSecret(),
@@ -175,11 +173,8 @@ export async function cmdGithubDlqReplay(hippoRoot, args, flags) {
             if (!event) {
                 return { memoryId: null };
             }
-            // v1.3.2 (codex round 3 P1): a replayed `issue_comment.deleted` or
-            // `pull_request_review_comment.deleted` row must route to the deletion
-            // handler, NOT to ingestEvent. The v1.3.1 hook unconditionally called
-            // ingestEvent and would have written the deleted comment as a NEW raw
-            // memory instead of archiving the matching ones.
+            // A replayed comment `.deleted` row must route to the deletion handler, NOT to ingestEvent,
+            // which would write the deleted comment as a NEW raw memory instead of archiving the matching ones.
             if ((event.eventName === 'issue_comment' || event.eventName === 'pull_request_review_comment') &&
                 event.payload.action === 'deleted') {
                 const repo = event.payload.repository?.full_name ?? '';

package/dist/connectors/github/deletion.d.ts

@@ -19,21 +19,14 @@ export interface DeletionResult {
 /**
  * Handle GitHub `issue_comment.deleted` and `pull_request_review_comment.deleted`.
  *
- * Codex round 1 P0 #5: filter by tenant_id + kind='raw'. Multi-row archive:
+ * Filter by tenant_id + kind='raw'. Multi-row archive:
  * GitHub edits keep the same artifact_ref, so multiple active raw rows can
  * match a single deletion event. Archive ALL of them.
  *
- * Claude round 2 P0 #2 (v1.3.1 hotfix): the v1.3.0 implementation called
- * archiveRaw N times in a loop, each opening its own DB handle and SAVEPOINT.
- * The first archive's afterArchive committed the idempotency mark. If archive
- * 2..N threw, idempotency was already committed and retry returned 'duplicate'
- * with archivedCount=0 — survivors stayed searchable, leaking private bodies.
- *
- * v1.3.1 fix: ONE shared DB handle wrapping ALL archives + the idempotency
- * mark in a single outer SAVEPOINT. Any per-row failure rolls back the entire
- * batch (including idempotency), so retry re-attempts cleanly. archiveRawMemory
- * (the lower-level function from raw-archive.js) runs its own inner SAVEPOINT
- * which nests safely inside the outer one.
+ * ONE shared DB handle wraps ALL archives + the idempotency mark in a single
+ * outer SAVEPOINT: a per-row failure rolls back the whole batch, idempotency
+ * included, so a retry re-attempts cleanly instead of leaving searchable
+ * survivors. archiveRawMemory's own inner SAVEPOINT nests safely inside it.
  *
  * Tenant scope and kind='raw' filtering are load-bearing: without them a
  * deletion event from tenant A could archive tenant B's row sharing the same

package/dist/connectors/github/deletion.js

@@ -4,21 +4,14 @@ import { hasSeenKey, markKeySeen } from './idempotency.js';
 /**
  * Handle GitHub `issue_comment.deleted` and `pull_request_review_comment.deleted`.
  *
- * Codex round 1 P0 #5: filter by tenant_id + kind='raw'. Multi-row archive:
+ * Filter by tenant_id + kind='raw'. Multi-row archive:
  * GitHub edits keep the same artifact_ref, so multiple active raw rows can
  * match a single deletion event. Archive ALL of them.
  *
- * Claude round 2 P0 #2 (v1.3.1 hotfix): the v1.3.0 implementation called
- * archiveRaw N times in a loop, each opening its own DB handle and SAVEPOINT.
- * The first archive's afterArchive committed the idempotency mark. If archive
- * 2..N threw, idempotency was already committed and retry returned 'duplicate'
- * with archivedCount=0 — survivors stayed searchable, leaking private bodies.
- *
- * v1.3.1 fix: ONE shared DB handle wrapping ALL archives + the idempotency
- * mark in a single outer SAVEPOINT. Any per-row failure rolls back the entire
- * batch (including idempotency), so retry re-attempts cleanly. archiveRawMemory
- * (the lower-level function from raw-archive.js) runs its own inner SAVEPOINT
- * which nests safely inside the outer one.
+ * ONE shared DB handle wraps ALL archives + the idempotency mark in a single
+ * outer SAVEPOINT: a per-row failure rolls back the whole batch, idempotency
+ * included, so a retry re-attempts cleanly instead of leaving searchable
+ * survivors. archiveRawMemory's own inner SAVEPOINT nests safely inside it.
  *
  * Tenant scope and kind='raw' filtering are load-bearing: without them a
  * deletion event from tenant A could archive tenant B's row sharing the same

package/dist/connectors/github/dlq.d.ts

@@ -3,9 +3,8 @@ import type { Context } from '../../api.js';
 /**
  * GitHub webhook DLQ. Mirrors the Slack DLQ shape (src/connectors/slack/dlq.ts)
  * but carries GitHub-specific metadata: event_name, delivery_id, signature,
- * installation_id, repo_full_name. Codex P1 #5 mandates this rich context
- * so a `hippo gh dlq replay` operator can triage without re-deriving anything
- * from the raw payload.
+ * installation_id, repo_full_name, so a `hippo gh dlq replay` operator can
+ * triage without re-deriving anything from the raw payload.
  *
  * Buckets:
  *   - parse_error     — raw_payload was not valid JSON
@@ -56,7 +55,7 @@ export interface ReplayDlqOpts {
     /** Current webhook secret. If omitted, signature check is skipped (force-only path). */
     webhookSecret?: string;
     /**
-     * Previous webhook secret during rotation (v1.3.1 hotfix — claude P1).
+     * Previous webhook secret during rotation.
      * Operators rotating GITHUB_WEBHOOK_SECRET would otherwise be forced into
      * --force on DLQ rows written under the old secret. Plumbed through to
      * verifyGitHubSignature.previousSecret.
@@ -79,10 +78,8 @@ export interface ReplayResult {
  * route already knows how to route an envelope, so it passes that capability
  * back in.
  *
- * v1.3.2 (claude review): the v1.3.1 contract advertised an `idempotencyKey`
- * field, but the v1.3.1 ingest re-derives the key from the parsed event
- * itself, so the field was a phantom — any future hook that trusted the
- * passed-in value would dedupe against a stale key. Field removed.
+ * No `idempotencyKey` field: ingest re-derives the key from the parsed event,
+ * so a hook trusting a passed-in key would dedupe against a stale one.
  */
 export type IngestHook = (ctx: Context, args: {
     rawPayload: string;
@@ -101,7 +98,7 @@ export type IngestHook = (ctx: Context, args: {
  *   4. Type-guard the envelope. Fail → bump, `unhandled`.
  *   5. If an `ingestHook` is supplied, call it and return its memoryId.
  *      If not (dry-run path), bump retry_count and return status `replayed`
- *      with memoryId=null. The webhook route wires the real hook in Task 14.
+ *      with memoryId=null. The webhook route wires the real hook.
  *
  * Mirrors Slack's "always use current routing" policy: replays use the
  * deployment state NOW, not at the time of original DLQing.

package/dist/connectors/github/dlq.js

@@ -79,7 +79,7 @@ function bumpRetryCount(hippoRoot, id) {
  *   4. Type-guard the envelope. Fail → bump, `unhandled`.
  *   5. If an `ingestHook` is supplied, call it and return its memoryId.
  *      If not (dry-run path), bump retry_count and return status `replayed`
- *      with memoryId=null. The webhook route wires the real hook in Task 14.
+ *      with memoryId=null. The webhook route wires the real hook.
  *
  * Mirrors Slack's "always use current routing" policy: replays use the
  * deployment state NOW, not at the time of original DLQing.
@@ -125,8 +125,7 @@ export async function replayDlqEntry(ctx, id, opts = {}) {
     // Real replay path. The route's IngestHook is responsible for routing,
     // idempotency, and writing the memory. The DLQ module only validates the
     // surface and bumps the retry counter.
-    // v1.3.2: dropped the stale idempotencyKey arg — the hook re-derives it
-    // from the parsed event (artifact_ref + updated_at) since v1.3.1.
+    // No idempotencyKey arg: the hook re-derives it from the parsed event (artifact_ref + updated_at).
     const eventName = row.eventName ?? '';
     const deliveryId = row.deliveryId ?? '';
     const { memoryId } = await opts.ingestHook(ctx, {

package/dist/connectors/github/ingest.d.ts

@@ -2,11 +2,11 @@
  * GitHub event ingest with afterWrite race-safe idempotency.
  *
  * Mirrors src/connectors/slack/ingest.ts. The dedupe key is sha256(eventName +
- * ':' + rawBody) (codex P0 #3) — derived from the signed body, not from the
+ * ':' + rawBody), derived from the signed body, not from the
  * unsigned X-GitHub-Delivery header, so a replay attacker cannot bypass
  * idempotency by rotating the delivery UUID.
  *
- * Race semantics (codex P1 #6):
+ * Race semantics:
  *   - Fast path: hasSeenKey pre-check returns 'duplicate' for the common case.
  *   - Slow path: hasSeenKey passes (no row yet). Two workers may race into
  *     remember() concurrently. Inside the writeEntry SAVEPOINT, INSERT OR
@@ -15,10 +15,8 @@
  *     rolls back this worker's memory row). Exactly one memory exists per
  *     idempotency_key.
  *
- * The Slack precedent's race test was insufficient — it tested the fast path,
- * not the SAVEPOINT collision. The `__testInjectBeforeLog` hook below lets
- * tests pre-populate github_event_log inside the SAVEPOINT to actually
- * exercise the changes=0 -> rollback path.
+ * The `__testInjectBeforeLog` hook below lets tests pre-populate github_event_log
+ * inside the SAVEPOINT to exercise the changes=0 -> rollback path, not just the fast path.
  */
 import { type Context } from '../../api.js';
 import { type DatabaseSyncLike } from '../../db.js';
@@ -50,7 +48,7 @@ export type IngestEvent = {
 export interface IngestInput {
     /** The X-GitHub-Event header value + parsed body, discriminated. */
     event: IngestEvent;
-    /** The raw HTTP body — used for the idempotency key (replay-safe per codex P0 #3). */
+    /** The raw HTTP body, used for the idempotency key (replay-safe). */
     rawBody: string;
     /** X-GitHub-Delivery header value, audit metadata only. */
     deliveryId: string;

package/dist/connectors/github/ingest.js

@@ -2,11 +2,11 @@
  * GitHub event ingest with afterWrite race-safe idempotency.
  *
  * Mirrors src/connectors/slack/ingest.ts. The dedupe key is sha256(eventName +
- * ':' + rawBody) (codex P0 #3) — derived from the signed body, not from the
+ * ':' + rawBody), derived from the signed body, not from the
  * unsigned X-GitHub-Delivery header, so a replay attacker cannot bypass
  * idempotency by rotating the delivery UUID.
  *
- * Race semantics (codex P1 #6):
+ * Race semantics:
  *   - Fast path: hasSeenKey pre-check returns 'duplicate' for the common case.
  *   - Slow path: hasSeenKey passes (no row yet). Two workers may race into
  *     remember() concurrently. Inside the writeEntry SAVEPOINT, INSERT OR
@@ -15,10 +15,8 @@
  *     rolls back this worker's memory row). Exactly one memory exists per
  *     idempotency_key.
  *
- * The Slack precedent's race test was insufficient — it tested the fast path,
- * not the SAVEPOINT collision. The `__testInjectBeforeLog` hook below lets
- * tests pre-populate github_event_log inside the SAVEPOINT to actually
- * exercise the changes=0 -> rollback path.
+ * The `__testInjectBeforeLog` hook below lets tests pre-populate github_event_log
+ * inside the SAVEPOINT to exercise the changes=0 -> rollback path, not just the fast path.
  */
 import { remember } from '../../api.js';
 import { openHippoDb, closeHippoDb } from '../../db.js';
@@ -39,7 +37,7 @@ function transformEvent(event) {
     }
 }
 /**
- * v1.3.1: extract the source-normalized identifier the idempotency key needs.
+ * Extract the source-normalized identifier the idempotency key needs.
  * Backfill and webhook both produce IngestEvent objects describing the same
  * source revision, so deriving the key from these fields collapses both paths
  * onto the same dedupe row. Mirrors the artifactRef strings in transform.ts.
@@ -113,10 +111,8 @@ export function ingestEvent(ctx, input) {
             }
         }
         if (e instanceof RejectedValueError) {
-            // AT1 (plan §3 containment): a tombstone hit is a PERMANENT skip, not
-            // a transient failure — never DLQ-retry it. Mark the idempotency key
-            // seen exactly like the empty-body branch above so a GitHub retry of
-            // the same delivery acks as done, not error.
+            // A tombstone hit is a PERMANENT skip, never DLQ-retried: mark the key seen like the empty-body
+            // branch above so a GitHub retry of the same delivery acks as done, not error.
             markKeySeenWithoutMemory(ctx.hippoRoot, idempotencyKey, input);
             return { status: 'skipped', memoryId: null };
         }
@@ -135,7 +131,7 @@ function markKeySeenWithoutMemory(hippoRoot, idempotencyKey, input) {
     }
 }
 function rememberWithEventLog(ctx, input, idempotencyKey, opts) {
-    // v1.12.0: drop the legacy `|| 'connector:github'` fallback (see slack/ingest.ts:73 for rationale).
+    // No `|| 'connector:github'` fallback (see rememberWithEventLog in slack/ingest.ts for rationale).
     const result = remember(ctx, {
         ...opts,
         untrusted: true,

package/dist/connectors/github/octokit-client.d.ts

@@ -4,13 +4,11 @@
  * Production uses `realGitHubFetcher` against `https://api.github.com`.
  * Tests inject a fake `GitHubFetcher` so they never hit the network.
  *
- * Codex P1 #4 mandate: any non-200 response that is NOT a recognized
- * rate-limit pause MUST throw `GitHubFetchError`. Silently turning
- * 401/403/404/500 into empty pages produced empty backfills with no
- * operator signal, so this code path is now load-bearing.
+ * Any non-200 response that is NOT a recognized rate-limit pause MUST throw
+ * `GitHubFetchError`: an empty page would be an empty backfill with no operator signal.
  */
-import type { JsonValue } from './types.js';
 import { type RateLimitInfo } from './ratelimit.js';
+import type { JsonValue } from '../../json.js';
 export declare class GitHubFetchError extends Error {
     readonly status: number;
     readonly bodyExcerpt: string;

package/dist/connectors/github/octokit-client.js

@@ -4,10 +4,8 @@
  * Production uses `realGitHubFetcher` against `https://api.github.com`.
  * Tests inject a fake `GitHubFetcher` so they never hit the network.
  *
- * Codex P1 #4 mandate: any non-200 response that is NOT a recognized
- * rate-limit pause MUST throw `GitHubFetchError`. Silently turning
- * 401/403/404/500 into empty pages produced empty backfills with no
- * operator signal, so this code path is now load-bearing.
+ * Any non-200 response that is NOT a recognized rate-limit pause MUST throw
+ * `GitHubFetchError`: an empty page would be an empty backfill with no operator signal.
  */
 import { parseRateLimit } from './ratelimit.js';
 import { fetchWithRetry } from '../../http-retry.js';
@@ -44,6 +42,7 @@ function headersToRecord(h) {
     return Object.fromEntries(entries);
 }
 const GITHUB_TIMEOUT_MS = 30_000;
+const ERROR_BODY_SNIPPET_CHARS = 256;
 export const realGitHubFetcher = async ({ url, token }) => {
     const res = await fetchWithRetry(url, {
         headers: {
@@ -54,10 +53,10 @@ export const realGitHubFetcher = async ({ url, token }) => {
     }, { timeoutMs: GITHUB_TIMEOUT_MS });
     const headers = headersToRecord(res.headers);
     const rateLimit = parseRateLimit(headers, res.status);
-    // Codex P1 #4: don't silently turn 401/403/404/500 into empty pages.
+    // Don't silently turn 401/403/404/500 into empty pages.
     if (res.status !== 200 && rateLimit.reason === 'none') {
         const body = await res.text().catch(() => '');
-        throw new GitHubFetchError(res.status, body.slice(0, 256), url);
+        throw new GitHubFetchError(res.status, body.slice(0, ERROR_BODY_SNIPPET_CHARS), url);
     }
     // SAFETY: GitHub's list/paginated endpoints (issues, comments, etc. — the
     // only endpoints this backfill fetcher targets) return a JSON array body

package/dist/connectors/github/signature.d.ts

@@ -8,24 +8,11 @@ export interface VerifyOpts {
 }
 export declare function verifyGitHubSignature(opts: VerifyOpts): boolean;
 /**
- * Source-aware idempotency key. v1.3.1 hotfix (codex round 1 P0 #3 + claude
- * round 2 P0 #3).
- *
- * Round 1 design: sha256(eventName + ':' + rawBody) so an attacker rotating
- * X-GitHub-Delivery cannot bypass dedupe.
- *
- * Round 2 found that key produced different hashes for the SAME source event
- * delivered via webhook vs via REST backfill, because backfill rawBody is the
- * REST list-item shape while webhook rawBody is the envelope. Result:
- * backfill + later webhook of the same issue created two `kind='raw'` rows
- * with the same artifact_ref. Combined with the deletion bug, deletion could
- * not archive both.
- *
- * v1.3.1 fix: key from the SOURCE-NORMALIZED identifier — artifact_ref plus
- * the source-side updated_at timestamp. Same artifact + same revision = same
- * key, regardless of which path delivered it. Different revisions of the same
- * issue (an edit) get different keys, which is correct: each edit IS a new
- * memory revision.
+ * Source-aware idempotency key: artifact_ref plus the source-side updated_at.
+ * A raw-body key would hash a webhook envelope and a REST backfill item of the
+ * SAME source event differently and ingest it twice. Same artifact + same
+ * revision = same key, whichever path delivered it; an edit gets a new key,
+ * which is correct because each edit IS a new memory revision.
  *
  * Both inputs are upstream-derived from the parsed event, not from the
  * unsigned delivery header — replay attacks still cannot bypass dedupe.
@@ -36,30 +23,13 @@ export declare function verifyGitHubSignature(opts: VerifyOpts): boolean;
  *   - updatedAt: source-side ISO timestamp (issue.updated_at,
  *     comment.updated_at, pull_request.updated_at). Empty string when the
  *     payload omits it (rare; older REST shapes).
- *
- * Migration note for v1.3.0 → v1.3.1: existing github_event_log rows from
- * v1.3.0 used the round-1 key shape and will not collide with v1.3.1 keys.
- * The first webhook delivery after upgrading creates a new log row with the
- * new key. This is acceptable for a hotfix (no production users on v1.3.0)
- * and correct semantics going forward.
  */
 export declare function computeIdempotencyKey(artifactRef: string, updatedAt: string | null | undefined): string;
 /**
- * v1.3.2: deletion-specific idempotency key. Distinct namespace from
- * computeIdempotencyKey so an ingest's row in github_event_log doesn't make
- * a deletion event return 'duplicate' before it gets a chance to archive.
- *
- * The codex round 3 P0 fix on server.ts was to call computeIdempotencyKey
- * with the right (artifactRef, updatedAt) shape for deletions. That made
- * the deletion key MATCH the ingest key — which collapsed to a "deletion
- * always returns duplicate" bug because both shared github_event_log.
- *
- * v1.3.2 splits the namespace: deletion key = sha256('deleted:' +
- * artifactRef + ':' + updatedAt). Two retries of the SAME deletion event
- * still dedupe (same artifact + same updatedAt + same prefix → same key).
- * Ingest of the same artifact + same updatedAt produces a DIFFERENT key,
- * so a deletion event does not get short-circuited by the ingest's prior
- * log row.
+ * Deletion-specific idempotency key: sha256('deleted:' + artifactRef + ':' +
+ * updatedAt). Distinct namespace from computeIdempotencyKey so an ingest's row
+ * in github_event_log doesn't make a deletion return 'duplicate' before it
+ * gets a chance to archive; retries of the SAME deletion still dedupe.
  *
  * Kept as a separate exported function so the namespace prefix is explicit
  * at every call site (server.ts deletion branches, deletion.ts, DLQ replay).

package/dist/connectors/github/signature.js

@@ -17,24 +17,11 @@ export function verifyGitHubSignature(opts) {
     return false;
 }
 /**
- * Source-aware idempotency key. v1.3.1 hotfix (codex round 1 P0 #3 + claude
- * round 2 P0 #3).
- *
- * Round 1 design: sha256(eventName + ':' + rawBody) so an attacker rotating
- * X-GitHub-Delivery cannot bypass dedupe.
- *
- * Round 2 found that key produced different hashes for the SAME source event
- * delivered via webhook vs via REST backfill, because backfill rawBody is the
- * REST list-item shape while webhook rawBody is the envelope. Result:
- * backfill + later webhook of the same issue created two `kind='raw'` rows
- * with the same artifact_ref. Combined with the deletion bug, deletion could
- * not archive both.
- *
- * v1.3.1 fix: key from the SOURCE-NORMALIZED identifier — artifact_ref plus
- * the source-side updated_at timestamp. Same artifact + same revision = same
- * key, regardless of which path delivered it. Different revisions of the same
- * issue (an edit) get different keys, which is correct: each edit IS a new
- * memory revision.
+ * Source-aware idempotency key: artifact_ref plus the source-side updated_at.
+ * A raw-body key would hash a webhook envelope and a REST backfill item of the
+ * SAME source event differently and ingest it twice. Same artifact + same
+ * revision = same key, whichever path delivered it; an edit gets a new key,
+ * which is correct because each edit IS a new memory revision.
  *
  * Both inputs are upstream-derived from the parsed event, not from the
  * unsigned delivery header — replay attacks still cannot bypass dedupe.
@@ -45,32 +32,15 @@ export function verifyGitHubSignature(opts) {
  *   - updatedAt: source-side ISO timestamp (issue.updated_at,
  *     comment.updated_at, pull_request.updated_at). Empty string when the
  *     payload omits it (rare; older REST shapes).
- *
- * Migration note for v1.3.0 → v1.3.1: existing github_event_log rows from
- * v1.3.0 used the round-1 key shape and will not collide with v1.3.1 keys.
- * The first webhook delivery after upgrading creates a new log row with the
- * new key. This is acceptable for a hotfix (no production users on v1.3.0)
- * and correct semantics going forward.
  */
 export function computeIdempotencyKey(artifactRef, updatedAt) {
     return createHash('sha256').update(`${artifactRef}:${updatedAt ?? ''}`).digest('hex');
 }
 /**
- * v1.3.2: deletion-specific idempotency key. Distinct namespace from
- * computeIdempotencyKey so an ingest's row in github_event_log doesn't make
- * a deletion event return 'duplicate' before it gets a chance to archive.
- *
- * The codex round 3 P0 fix on server.ts was to call computeIdempotencyKey
- * with the right (artifactRef, updatedAt) shape for deletions. That made
- * the deletion key MATCH the ingest key — which collapsed to a "deletion
- * always returns duplicate" bug because both shared github_event_log.
- *
- * v1.3.2 splits the namespace: deletion key = sha256('deleted:' +
- * artifactRef + ':' + updatedAt). Two retries of the SAME deletion event
- * still dedupe (same artifact + same updatedAt + same prefix → same key).
- * Ingest of the same artifact + same updatedAt produces a DIFFERENT key,
- * so a deletion event does not get short-circuited by the ingest's prior
- * log row.
+ * Deletion-specific idempotency key: sha256('deleted:' + artifactRef + ':' +
+ * updatedAt). Distinct namespace from computeIdempotencyKey so an ingest's row
+ * in github_event_log doesn't make a deletion return 'duplicate' before it
+ * gets a chance to archive; retries of the SAME deletion still dedupe.
  *
  * Kept as a separate exported function so the namespace prefix is explicit
  * at every call site (server.ts deletion branches, deletion.ts, DLQ replay).

package/dist/connectors/github/tenant-routing.d.ts

@@ -20,7 +20,7 @@ export interface ResolveArgs {
  *         is non-empty (multi-tenant install with foreign installation)
  *       - `installationId` is missing AND either routing table is non-empty
  *         AND no `repository.full_name` match (PAT-mode webhook from a foreign
- *         account — codex P0 #4 regression target)
+ *         account)
  *
  * Escape hatch: `GITHUB_ALLOW_UNKNOWN_INSTALLATION_FALLBACK=1` restores the
  * env fallback for emergency rollback only. Mirrors the Slack equivalent

package/dist/connectors/github/tenant-routing.js

@@ -14,7 +14,7 @@ import { envGithubAllowUnknownInstallationFallback, envTenant } from '../../env.
  *         is non-empty (multi-tenant install with foreign installation)
  *       - `installationId` is missing AND either routing table is non-empty
  *         AND no `repository.full_name` match (PAT-mode webhook from a foreign
- *         account — codex P0 #4 regression target)
+ *         account)
  *
  * Escape hatch: `GITHUB_ALLOW_UNKNOWN_INSTALLATION_FALLBACK=1` restores the
  * env fallback for emergency rollback only. Mirrors the Slack equivalent

package/dist/connectors/github/transform.js

@@ -5,13 +5,13 @@ import { scopeFromRepository } from './scope.js';
  * caller can mark the delivery seen for idempotency and skip the insert.
  *
  * Contract (mirrors src/connectors/slack/transform.ts):
- * - kind is the literal 'raw' (E1.x connector boundary, see src/importers.ts).
+ * - kind is the literal 'raw' (connector boundary, see src/importers.ts).
  * - artifact_ref formats are stable; deletion paths look up by these strings.
  *   - issue:               github://<owner/repo>/issue/<number>
  *   - issue_comment:       github://<owner/repo>/issue/<number>/comment/<id>
  *   - pull_request:        github://<owner/repo>/pull/<number>
  *   - pr_review_comment:   github://<owner/repo>/pull/<number>/review_comment/<id>
- * - owner is `user:github:<login>`. Required by the v0.40.0 provenance gate.
+ * - owner is `user:github:<login>`. Required by the provenance gate.
  * - scope is derived from repository.private via scopeFromRepository (default
  *   private when undetermined).
  */

package/dist/connectors/github/types.d.ts

@@ -7,8 +7,9 @@
  * header value so a malicious or misrouted payload cannot satisfy a guard
  * for the wrong event type.
  */
+import { type JsonValue } from '../../json.js';
 /**
- * Codex P1 #7: `private` MUST be optional, not required. The Slack-style
+ * `private` MUST be optional, not required. The Slack-style
  * fail-safe in scope.ts requires an envelope with `private: undefined` to
  * map to private; a strict boolean type would reject the payload before
  * scope can fail closed.
@@ -79,15 +80,6 @@ export interface GitHubPullRequestReviewCommentEvent extends GitHubWebhookEnvelo
         updated_at?: string;
     };
 }
-/**
- * The full value space `JSON.parse` can produce. Boundary-guard functions in
- * this file accept `JsonValue` (never `unknown`) so a value's origin as
- * unparsed external JSON stays visible in its type, then narrow it via the
- * `isJson*` predicates below.
- */
-export type JsonValue = string | number | boolean | null | JsonValue[] | {
-    [key: string]: JsonValue;
-};
 export declare function isGitHubWebhookEnvelope(x: JsonValue): x is JsonValue & GitHubWebhookEnvelope;
 export declare function isGitHubIssueEvent(x: JsonValue, evtHeader: string): x is JsonValue & GitHubIssueEvent;
 export declare function isGitHubIssueCommentEvent(x: JsonValue, evtHeader: string): x is JsonValue & GitHubIssueCommentEvent;

package/dist/connectors/github/types.js

@@ -7,12 +7,10 @@
  * header value so a malicious or misrouted payload cannot satisfy a guard
  * for the wrong event type.
  */
+import { isJsonString } from '../../json.js';
 function isJsonObject(x) {
     return x !== null && typeof x === 'object';
 }
-function isJsonString(x) {
-    return typeof x === 'string';
-}
 function isJsonNumber(x) {
     return typeof x === 'number';
 }

package/dist/connectors/slack/deletion.d.ts

@@ -11,14 +11,9 @@ export interface DeletionResult {
     memoryId: string | null;
 }
 /**
- * Handle Slack `message_deleted`. v0.39 commit 3 closes the prior race where
- * the archive committed but `markEventSeen` ran on a second db handle — a
- * crash between them left the deletion event un-acked, and the next retry
- * hit a now-archived row and returned `not_found` instead of `duplicate`.
- *
- * Fix: pass `afterArchive` to `archiveRaw`, which runs inside the same
- * SAVEPOINT as the archive itself. The slack_event_log row commits with the
- * archive or not at all.
+ * Handle Slack `message_deleted`. `afterArchive` runs inside the archive's own
+ * SAVEPOINT, so the slack_event_log row commits with the archive or not at all
+ * and a crash cannot leave a retry hitting `not_found` instead of `duplicate`.
  */
 export declare function handleMessageDeleted(ctx: Context, input: DeletionInput): DeletionResult;
 //# sourceMappingURL=deletion.d.ts.map