hippo-memory 1.38.3 → 1.38.9

package/dist/cli.js

@@ -36,7 +36,6 @@ import { fileURLToPath } from 'node:url';
 import { execFileSync, execSync, spawn } from 'child_process';
 import { installJsonHooks, uninstallJsonHooks, resolveJsonHookPaths, detectInstalledTools, defaultSleepLogPath, ensureCodexWrapperInstalled, installCodexWrapper, isCodexWrapperInstalled, repairCodexWrapperIfInstalled, uninstallCodexWrapper, resolveCodexSessionTranscript, resolveCodexWrapperPaths, installOpencodePlugin, uninstallOpencodePlugin, resolveOpencodePluginPath, } from './hooks.js';
 import { createMemory, calculateStrength, calculateRewardFactor, deriveHalfLife, resolveConfidence, computeSchemaFit, Layer, } from './memory.js';
-import { resolveProjectIdentity } from './project-identity.js';
 import { detectSecret } from './secret-detect.js';
 import { getHippoRoot, isInitialized, initStore, writeEntry, readEntry, deleteEntry, loadAllEntries, loadSearchEntries, loadRecallSearchEntries, loadIndex, saveIndex, loadStats, updateStats, saveActiveTaskSnapshot, loadActiveTaskSnapshot, closeTaskSnapshotsForSession, clearActiveTaskSnapshot, appendSessionEvent, listSessionEvents, listMemoryConflicts, resolveConflict, saveSessionHandoff, loadLatestHandoff, loadHandoffById, RECALL_DEFAULT_DENY_SCOPES, } from './store.js';
 import { rejectValue, unrejectValue, listRejectionsForTenant } from './reject-flow.js';
@@ -115,7 +114,7 @@ import { graphExpandRecall, MAX_HOPS, DEFAULT_MAX_NEIGHBORS } from './graph-reca
 import { DEFAULT_GRAPH_STREAM_WEIGHT } from './graph-stream.js';
 import { getReranker } from './rerankers/index.js';
 import { computeSalience } from './salience.js';
-import { computeAmbientState, renderAmbientSummary } from './ambient.js';
+import { renderAmbientSummary } from './ambient.js';
 import { validateOwner, isStrictOwnerEnv } from './owner-validation.js';
 import { pruneAuditLog, parseOlderThanFlag } from './audit-prune.js';
 import { listDlq, replayDlqEntry } from './connectors/slack/dlq.js';
@@ -2868,7 +2867,7 @@ function cmdCompactResume(hippoRoot, stdinText) {
  * immediately. The child writes to the log file and survives TUI teardown;
  * the next SessionStart reads the log via `hippo last-sleep`.
  */
-function cmdSessionEnd(hippoRoot, flags) {
+async function cmdSessionEnd(hippoRoot, flags) {
     const logFile = typeof flags['log-file'] === 'string' ? flags['log-file'] : null;
     // Read stdin synchronously. The SessionEnd hook payload carries
     // `transcript_path` as JSON; we extract it here and pass it to the worker
@@ -2915,7 +2914,7 @@ function cmdSessionEnd(hippoRoot, flags) {
         // --session-id (both are stdin-derived, argv-only for the child), so in
         // this fallback capture auto-discovers the transcript and the DF1
         // snapshot close no-ops — the ambient freshness bound is the backstop.
-        cmdSessionEndWorker(hippoRoot, flags);
+        await cmdSessionEndWorker(hippoRoot, flags);
         return;
     }
 }
@@ -2924,9 +2923,9 @@ function cmdSessionEnd(hippoRoot, flags) {
  * `__session-end-worker` subcommand (not user-facing). Failures in one stage
  * do not block the other.
  */
-function cmdSessionEndWorker(hippoRoot, flags) {
+async function cmdSessionEndWorker(hippoRoot, flags) {
     try {
-        cmdSleep(hippoRoot, flags);
+        await cmdSleep(hippoRoot, flags);
     }
     catch {
         // sleep errors are already tee'd to the log file via cmdSleep's
@@ -3035,7 +3034,7 @@ function cmdCodexRun(hippoRoot, args) {
         console.error(`Failed to launch Codex: ${err.message}`);
         process.exit(1);
     });
-    child.on('exit', (code, signal) => {
+    child.on('exit', async (code, signal) => {
         const workerArgs = [
             process.argv[1],
             '__codex-session-end-worker',
@@ -3060,13 +3059,19 @@ function cmdCodexRun(hippoRoot, args) {
         }
         catch {
             // Fall back to the inline path if the detached worker cannot be created.
-            cmdCodexSessionEndWorker(hippoRoot, {
-                'codex-home': path.dirname(historyPath),
-                'history-path': historyPath,
-                'start-offset': String(startOffsetBytes),
-                'started-at': String(startedAtMs),
-                'log-file': metadata.logFile,
-            });
+            // Awaited so the sleep write can't be killed by the exit calls below.
+            try {
+                await cmdCodexSessionEndWorker(hippoRoot, {
+                    'codex-home': path.dirname(historyPath),
+                    'history-path': historyPath,
+                    'start-offset': String(startOffsetBytes),
+                    'started-at': String(startedAtMs),
+                    'log-file': metadata.logFile,
+                });
+            }
+            catch {
+                // cmdCodexSessionEndWorker already fail-softs internally; this is belt-and-braces.
+            }
         }
         if (signal) {
             try {
@@ -3080,10 +3085,10 @@ function cmdCodexRun(hippoRoot, args) {
         process.exit(code ?? 0);
     });
 }
-function cmdCodexSessionEndWorker(hippoRoot, flags) {
+async function cmdCodexSessionEndWorker(hippoRoot, flags) {
     const logFile = typeof flags['log-file'] === 'string' ? flags['log-file'] : undefined;
     try {
-        cmdSleep(hippoRoot, logFile ? { 'log-file': logFile } : {});
+        await cmdSleep(hippoRoot, logFile ? { 'log-file': logFile } : {});
     }
     catch {
         // sleep errors are already written via cmdSleep
@@ -3314,6 +3319,8 @@ function cmdOutcome(hippoRoot, flags) {
     }
     console.log(`Applied ${good ? 'positive' : 'negative'} outcome to ${updated} memor${updated === 1 ? 'y' : 'ies'}`);
 }
+// Shared between the forget dispatch and cmdForget so the message can't drift.
+const ARCHIVE_REASON_REQUIRED = 'hippo forget --archive requires --reason "<why>" (recorded on the archive).';
 function cmdForget(hippoRoot, id, flags) {
     requireInit(hippoRoot);
     const ctx = {
@@ -3327,12 +3334,11 @@ function cmdForget(hippoRoot, id, flags) {
     if (flags['archive'] === true) {
         const reason = typeof flags['reason'] === 'string' ? flags['reason'] : null;
         if (!reason) {
-            console.error('hippo forget --archive requires --reason "<why>" (recorded on the archive).');
+            console.error(ARCHIVE_REASON_REQUIRED);
             process.exit(1);
         }
         try {
             api.archiveRaw(ctx, id, reason);
-            updateStats(hippoRoot, { forgotten: 1 });
             console.log(`Archived ${id}`);
         }
         catch (err) {
@@ -3343,7 +3349,6 @@ function cmdForget(hippoRoot, id, flags) {
     }
     try {
         api.forget(ctx, id);
-        updateStats(hippoRoot, { forgotten: 1 });
         console.log(`Forgot ${id}`);
     }
     catch (err) {
@@ -5590,30 +5595,8 @@ async function cmdContext(hippoRoot, args, flags, stdinText) {
             printContextMarkdown(renderItems, result.tokens, framing);
         }
         printCrossProjectSection(crossEntries);
-        // Ambient state summary (CLI-side: api.getContext doesn't load all entries
-        // post-selection, so we re-load here for the landscape summary).
-        const ambientConfig = loadConfig(hippoRoot);
-        if (ambientConfig.ambient.enabled && !pinnedOnly) {
-            const tenantId = ctx.tenantId;
-            const globalRoot = getGlobalRoot();
-            const hasGlobalForAmbient = isInitialized(globalRoot);
-            // v39: the landscape summary must reflect the same admission policy as
-            // the injected entries - otherwise excluded rows leak back in as
-            // aggregate signal (codex P2-13).
-            const isolationOff = ambientConfig.contextProjectIsolation === false;
-            const ambientCurrentName = resolveProjectIdentity(process.cwd()).name;
-            const ambientAdmit = (e) => api.ambientAdmitEntry(e, ambientCurrentName, crossProject || isolationOff);
-            const localForAmbient = isInitialized(hippoRoot)
-                ? loadAllEntries(hippoRoot, tenantId).filter(e => !e.superseded_by).filter(ambientAdmit)
-                : [];
-            const globalForAmbient = hasGlobalForAmbient
-                ? loadAllEntries(globalRoot, tenantId).filter(e => !e.superseded_by).filter(ambientAdmit)
-                : [];
-            const allForAmbient = [...localForAmbient, ...globalForAmbient];
-            if (allForAmbient.length > 0) {
-                const ambientState = computeAmbientState(allForAmbient);
-                console.log(`\n${renderAmbientSummary(ambientState)}`);
-            }
+        if (result.ambientState) {
+            console.log(`\n${renderAmbientSummary(result.ambientState)}`);
         }
     }
 }
@@ -8130,8 +8113,11 @@ async function main() {
             }
             // Thin-client routing. When a server is up, simple `remember` calls go
             // over HTTP so the daemon stays single-writer (footgun #2). Rich CLI
-            // flags (--pin, --layer, --extract, --global, salience gates) still
-            // need the direct path; we only intercept the minimal envelope.
+            // flags (--pin, --layer, --extract, --global) still need the direct
+            // path; we only intercept the minimal envelope. The salience gate is
+            // NOT in richFlag and the route does not apply it, so a routed remember
+            // stores what a direct one would skip. Measured 2026-09-07, tracked in
+            // TODOS.md; do not read this list as covering salience.
             const richFlag = flags['pin'] || flags['global'] || flags['extract'] || flags['force'] ||
                 flags['observed'] || flags['inferred'] || flags['verified'] ||
                 flags['layer'] !== undefined;
@@ -8247,10 +8233,10 @@ async function main() {
             cmdLastSleep(flags);
             break;
         case 'session-end':
-            cmdSessionEnd(hippoRoot, flags);
+            await cmdSessionEnd(hippoRoot, flags);
             break;
         case '__session-end-worker':
-            cmdSessionEndWorker(hippoRoot, flags);
+            await cmdSessionEndWorker(hippoRoot, flags);
             break;
         case 'pre-compact': {
             // Same TTY guard as `capture --last-session`: skip reading stdin when
@@ -8287,7 +8273,7 @@ async function main() {
             cmdCodexRun(hippoRoot, args);
             break;
         case '__codex-session-end-worker':
-            cmdCodexSessionEndWorker(hippoRoot, flags);
+            await cmdCodexSessionEndWorker(hippoRoot, flags);
             break;
         case 'dedup':
             cmdDedup(hippoRoot, flags);
@@ -8446,23 +8432,37 @@ async function main() {
                 console.error('Please provide a memory ID.');
                 process.exit(1);
             }
-            // A3: --archive is a direct-DB operation (raw archival via archiveRaw);
-            // the HTTP forget route does not carry it, so archive requests always
-            // take the direct path rather than silently no-op'ing over a server.
-            if (flags['archive'] !== true) {
-                const routed = await runViaServerIfAvailable(hippoRoot, async (info, apiKey) => {
-                    try {
+            // Archive has its own HTTP route (POST /v1/memories/:id/archive); route
+            // both branches the same way the direct path does.
+            const archive = flags['archive'] === true;
+            const reason = typeof flags['reason'] === 'string' ? flags['reason'] : null;
+            if (archive && !reason) {
+                console.error(ARCHIVE_REASON_REQUIRED);
+                process.exit(1);
+            }
+            const routed = await runViaServerIfAvailable(hippoRoot, async (info, apiKey) => {
+                try {
+                    if (archive) {
+                        await client.archiveRaw(info.url, apiKey, id, reason);
+                        console.log(`Archived ${id}`);
+                    }
+                    else {
                         await client.forget(info.url, apiKey, id);
                         console.log(`Forgot ${id}`);
                     }
-                    catch (err) {
-                        console.error(err.message);
-                        process.exit(1);
-                    }
-                });
-                if (routed)
-                    break;
-            }
+                }
+                catch (err) {
+                    // A server that died after the health probe is the caller's stale
+                    // pidfile fallback to handle, not an error to report to the user.
+                    if (client.isConnectionRefused(err))
+                        throw err;
+                    const msg = err instanceof Error ? err.message : String(err);
+                    console.error(archive ? `Could not archive ${id}: ${msg}` : msg);
+                    process.exit(1);
+                }
+            });
+            if (routed)
+                break;
             cmdForget(hippoRoot, id, flags);
             break;
         }