hippo-memory 1.2.1 → 1.3.1

package/dist/src/connectors/github/backfill.js

@@ -0,0 +1,272 @@
+/**
+ * Paginated backfill of three GitHub REST streams with per-stream
+ * high-water marks (HWMs):
+ *   - /repos/{repo}/issues               -> issues_hwm
+ *   - /repos/{repo}/issues/comments      -> issue_comments_hwm
+ *   - /repos/{repo}/pulls/comments       -> pr_review_comments_hwm
+ *
+ * Crash safety (codex P1 #3): each stream's HWM is persisted ONLY after
+ * the stream fully drains. If stream 2 throws mid-flight, stream 1's HWM
+ * is committed and stream 2's stays NULL (or its prior value). Rerun
+ * picks up from stream 1's saved HWM and re-fetches stream 2 from its
+ * last committed point.
+ *
+ * Codex P1 #2: the /issues endpoint returns BOTH issues and PRs (a PR is
+ * an issue with a `pull_request` field). We skip PRs here so they don't
+ * get ingested under the issues schema. PRs are handled via webhook in
+ * V1 (no /pulls backfill stream — review comments cover the discussion
+ * surface).
+ *
+ * Privacy (V1 limitation): the REST list endpoints don't reliably set
+ * `repository.private`, and resolving it requires an extra API call per
+ * repo. Backfill leaves the field undefined so scopeFromRepository falls
+ * through to private. Callers who know the repo is public can re-tag
+ * downstream; the fail-safe default protects private orgs.
+ */
+import { openHippoDb, closeHippoDb } from '../../db.js';
+import { ingestEvent } from './ingest.js';
+const API = 'https://api.github.com';
+function readCursor(root, tenantId, repo) {
+    const db = openHippoDb(root);
+    try {
+        const row = db
+            .prepare(`SELECT issues_hwm, issue_comments_hwm, pr_review_comments_hwm
+         FROM github_cursors WHERE tenant_id = ? AND repo_full_name = ?`)
+            .get(tenantId, repo);
+        return {
+            issues: row?.issues_hwm ?? null,
+            issueComments: row?.issue_comments_hwm ?? null,
+            prReviewComments: row?.pr_review_comments_hwm ?? null,
+        };
+    }
+    finally {
+        closeHippoDb(db);
+    }
+}
+function writeOneHwm(root, tenantId, repo, column, value) {
+    const db = openHippoDb(root);
+    try {
+        db.prepare(`INSERT INTO github_cursors (tenant_id, repo_full_name, ${column}, updated_at)
+       VALUES (?, ?, ?, ?)
+       ON CONFLICT(tenant_id, repo_full_name)
+       DO UPDATE SET ${column} = excluded.${column}, updated_at = excluded.updated_at`).run(tenantId, repo, value, new Date().toISOString());
+    }
+    finally {
+        closeHippoDb(db);
+    }
+}
+/**
+ * Build a synthetic `repository` object from the known repo full name.
+ * REST list endpoints often omit the full repository object on each item;
+ * we already know the repo since the caller passed it. `private` left
+ * undefined so scopeFromRepository falls through to private.
+ */
+function syntheticRepository(repoFullName) {
+    const [owner, name] = repoFullName.split('/');
+    return {
+        full_name: repoFullName,
+        name: name ?? repoFullName,
+        owner: { login: owner ?? repoFullName },
+        // private intentionally omitted — fail-safe to private scope.
+    };
+}
+/**
+ * Parse the trailing issue/PR number from a REST API URL.
+ * e.g. https://api.github.com/repos/o/r/issues/42 -> 42
+ *      https://api.github.com/repos/o/r/pulls/7   -> 7
+ */
+function parseTrailingNumber(url) {
+    if (!url)
+        return null;
+    const m = url.match(/\/(\d+)(?:\?.*)?$/);
+    if (!m)
+        return null;
+    const n = Number(m[1]);
+    return Number.isFinite(n) ? n : null;
+}
+function isIssuesItem(x) {
+    if (!x || typeof x !== 'object')
+        return false;
+    const o = x;
+    if (typeof o.number !== 'number')
+        return false;
+    if (typeof o.title !== 'string')
+        return false;
+    const u = o.user;
+    if (!u || typeof u.login !== 'string' || typeof u.id !== 'number')
+        return false;
+    return true;
+}
+function isCommentItem(x) {
+    if (!x || typeof x !== 'object')
+        return false;
+    const o = x;
+    if (typeof o.id !== 'number')
+        return false;
+    const u = o.user;
+    if (!u || typeof u.login !== 'string' || typeof u.id !== 'number')
+        return false;
+    return true;
+}
+/**
+ * Drain one stream end-to-end. Pauses and retries on rate-limit. Throws on
+ * any other fetch error so the caller leaves the HWM unchanged (round 1
+ * codex P1 #3 crash safety).
+ *
+ * v1.3.1 (round 2 codex P1s + claude P1):
+ *   - Tracks max(updated_at) across ALL fetched items, including ones
+ *     `toIngestEvent` rejects (e.g., PRs returned via `/issues`). Otherwise
+ *     a page of pure PRs would never advance the HWM and the next run would
+ *     re-fetch the same window forever.
+ *   - Returns `drained: boolean` — true only when the stream actually ran
+ *     to next=null. Callers MUST NOT advance the HWM when drained=false.
+ *     Was a bug in v1.3.0: hitting maxPerStream cap returned the partial
+ *     maxUpdatedAt and the caller persisted it, skipping the unfetched tail.
+ */
+async function drainStream(ctx, url0, toIngestEvent, fetcher, token, sleep, maxItems) {
+    let url = url0;
+    let ingested = 0;
+    let pages = 0;
+    let maxUpdatedAt = null;
+    while (url) {
+        // Fetch with rate-limit retry loop.
+        let page;
+        while (true) {
+            page = await fetcher({ url, token });
+            if (page.rateLimit.reason !== 'none') {
+                await sleep(page.rateLimit.sleepSeconds * 1000);
+                continue;
+            }
+            break;
+        }
+        pages++;
+        for (const item of page.items) {
+            // v1.3.1: track updated_at on EVERY item, before the toIngestEvent
+            // filter. Skipped PRs from /issues still contribute to the HWM so
+            // PR-only pages don't loop forever.
+            const updatedAt = item && typeof item === 'object'
+                ? (item.updated_at ?? null)
+                : null;
+            if (updatedAt && (!maxUpdatedAt || updatedAt > maxUpdatedAt)) {
+                maxUpdatedAt = updatedAt;
+            }
+            const evt = toIngestEvent(item);
+            if (!evt)
+                continue;
+            const r = ingestEvent(ctx, {
+                event: evt,
+                rawBody: JSON.stringify(item),
+                deliveryId: `backfill:${ctx.tenantId}:${updatedAt ?? ''}`,
+            });
+            if (r.status === 'ingested' || r.status === 'skipped')
+                ingested++;
+            if (maxItems && ingested >= maxItems) {
+                // Capped mid-stream: caller MUST NOT advance the HWM (drained=false).
+                return { ingested, pages, maxUpdatedAt, drained: false };
+            }
+        }
+        url = page.next;
+    }
+    return { ingested, pages, maxUpdatedAt, drained: true };
+}
+export async function backfillRepo(ctx, opts) {
+    const sleep = opts.sleepMs ?? ((ms) => new Promise((r) => setTimeout(r, ms)));
+    const cursors = readCursor(ctx.hippoRoot, ctx.tenantId, opts.repoFullName);
+    const repository = syntheticRepository(opts.repoFullName);
+    const result = {
+        ingested: { issues: 0, issueComments: 0, prReviewComments: 0 },
+        pages: { issues: 0, issueComments: 0, prReviewComments: 0 },
+    };
+    // ---------- Stream 1: issues (skip PRs) ----------
+    const issuesUrl = `${API}/repos/${opts.repoFullName}/issues?state=all&per_page=100` +
+        (cursors.issues ? `&since=${encodeURIComponent(cursors.issues)}` : '');
+    const issuesRes = await drainStream(ctx, issuesUrl, (item) => {
+        if (!isIssuesItem(item))
+            return null;
+        // Codex P1 #2: /issues returns PRs too — skip them.
+        if (item.pull_request)
+            return null;
+        const payload = {
+            action: 'opened',
+            repository,
+            issue: {
+                number: item.number,
+                title: item.title,
+                body: item.body ?? null,
+                user: { login: item.user.login, id: item.user.id },
+                updated_at: item.updated_at,
+            },
+        };
+        return { eventName: 'issues', payload };
+    }, opts.fetcher, opts.token, sleep, opts.maxPerStream);
+    result.ingested.issues = issuesRes.ingested;
+    result.pages.issues = issuesRes.pages;
+    // v1.3.1: only advance HWM when the stream actually drained. A capped run
+    // (--max) must leave the HWM at its previous value so the next invocation
+    // re-fetches the unprocessed tail.
+    if (issuesRes.drained && issuesRes.maxUpdatedAt) {
+        writeOneHwm(ctx.hippoRoot, ctx.tenantId, opts.repoFullName, 'issues_hwm', issuesRes.maxUpdatedAt);
+    }
+    // ---------- Stream 2: repo-level issue comments ----------
+    const commentsUrl = `${API}/repos/${opts.repoFullName}/issues/comments?per_page=100` +
+        (cursors.issueComments
+            ? `&since=${encodeURIComponent(cursors.issueComments)}`
+            : '');
+    const commentsRes = await drainStream(ctx, commentsUrl, (item) => {
+        if (!isCommentItem(item))
+            return null;
+        const c = item;
+        const issueNumber = parseTrailingNumber(c.issue_url);
+        if (issueNumber === null)
+            return null;
+        const payload = {
+            action: 'created',
+            repository,
+            issue: { number: issueNumber },
+            comment: {
+                id: c.id,
+                body: c.body ?? null,
+                user: { login: c.user.login, id: c.user.id },
+                updated_at: c.updated_at,
+            },
+        };
+        return { eventName: 'issue_comment', payload };
+    }, opts.fetcher, opts.token, sleep, opts.maxPerStream);
+    result.ingested.issueComments = commentsRes.ingested;
+    result.pages.issueComments = commentsRes.pages;
+    if (commentsRes.drained && commentsRes.maxUpdatedAt) {
+        writeOneHwm(ctx.hippoRoot, ctx.tenantId, opts.repoFullName, 'issue_comments_hwm', commentsRes.maxUpdatedAt);
+    }
+    // ---------- Stream 3: repo-level PR review comments ----------
+    const prCommentsUrl = `${API}/repos/${opts.repoFullName}/pulls/comments?per_page=100` +
+        (cursors.prReviewComments
+            ? `&since=${encodeURIComponent(cursors.prReviewComments)}`
+            : '');
+    const prCommentsRes = await drainStream(ctx, prCommentsUrl, (item) => {
+        if (!isCommentItem(item))
+            return null;
+        const c = item;
+        const prNumber = parseTrailingNumber(c.pull_request_url);
+        if (prNumber === null)
+            return null;
+        const payload = {
+            action: 'created',
+            repository,
+            pull_request: { number: prNumber },
+            comment: {
+                id: c.id,
+                body: c.body ?? null,
+                user: { login: c.user.login, id: c.user.id },
+                updated_at: c.updated_at,
+            },
+        };
+        return { eventName: 'pull_request_review_comment', payload };
+    }, opts.fetcher, opts.token, sleep, opts.maxPerStream);
+    result.ingested.prReviewComments = prCommentsRes.ingested;
+    result.pages.prReviewComments = prCommentsRes.pages;
+    if (prCommentsRes.drained && prCommentsRes.maxUpdatedAt) {
+        writeOneHwm(ctx.hippoRoot, ctx.tenantId, opts.repoFullName, 'pr_review_comments_hwm', prCommentsRes.maxUpdatedAt);
+    }
+    return result;
+}
+//# sourceMappingURL=backfill.js.map

package/dist/src/connectors/github/backfill.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"backfill.js","sourceRoot":"","sources":["../../../../src/connectors/github/backfill.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AAGH,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,aAAa,CAAC;AACxD,OAAO,EAAE,WAAW,EAAoB,MAAM,aAAa,CAAC;AAU5D,MAAM,GAAG,GAAG,wBAAwB,CAAC;AAgCrC,SAAS,UAAU,CAAC,IAAY,EAAE,QAAgB,EAAE,IAAY;IAC9D,MAAM,EAAE,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC;IAC7B,IAAI,CAAC;QACH,MAAM,GAAG,GAAG,EAAE;aACX,OAAO,CACN;wEACgE,CACjE;aACA,GAAG,CAAC,QAAQ,EAAE,IAAI,CAMR,CAAC;QACd,OAAO;YACL,MAAM,EAAE,GAAG,EAAE,UAAU,IAAI,IAAI;YAC/B,aAAa,EAAE,GAAG,EAAE,kBAAkB,IAAI,IAAI;YAC9C,gBAAgB,EAAE,GAAG,EAAE,sBAAsB,IAAI,IAAI;SACtD,CAAC;IACJ,CAAC;YAAS,CAAC;QACT,YAAY,CAAC,EAAE,CAAC,CAAC;IACnB,CAAC;AACH,CAAC;AAED,SAAS,WAAW,CAClB,IAAY,EACZ,QAAgB,EAChB,IAAY,EACZ,MAAiB,EACjB,KAAa;IAEb,MAAM,EAAE,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC;IAC7B,IAAI,CAAC;QACH,EAAE,CAAC,OAAO,CACR,0DAA0D,MAAM;;;uBAG/C,MAAM,eAAe,MAAM,oCAAoC,CACjF,CAAC,GAAG,CAAC,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC;IACzD,CAAC;YAAS,CAAC;QACT,YAAY,CAAC,EAAE,CAAC,CAAC;IACnB,CAAC;AACH,CAAC;AAED;;;;;GAKG;AACH,SAAS,mBAAmB,CAAC,YAAoB;IAC/C,MAAM,CAAC,KAAK,EAAE,IAAI,CAAC,GAAG,YAAY,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;IAC9C,OAAO;QACL,SAAS,EAAE,YAAY;QACvB,IAAI,EAAE,IAAI,IAAI,YAAY;QAC1B,KAAK,EAAE,EAAE,KAAK,EAAE,KAAK,IAAI,YAAY,EAAE;QACvC,8DAA8D;KAC/D,CAAC;AACJ,CAAC;AAED;;;;GAIG;AACH,SAAS,mBAAmB,CAAC,GAAuB;IAClD,IAAI,CAAC,GAAG;QAAE,OAAO,IAAI,CAAC;IACtB,MAAM,CAAC,GAAG,GAAG,CAAC,KAAK,CAAC,mBAAmB,CAAC,CAAC;IACzC,IAAI,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IACpB,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IACvB,OAAO,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AACvC,CAAC;AA2BD,SAAS,YAAY,CAAC,CAAU;IAC9B,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAC9C,MAAM,CAAC,GAAG,CAA4B,CAAC;IACvC,IAAI,OAAO,CAAC,CAAC,MAAM,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAC/C,IAAI,OAAO,CAAC,CAAC,KAAK,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAC9C,MAAM,CAAC,GAAG,CAAC,CAAC,IAAqD,CAAC;IAClE,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC,CAAC,KAAK,KAAK,QAAQ,IAAI,OAAO,CAAC,CAAC,EAAE,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAChF,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,aAAa,CAAC,CAAU;IAC/B,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAC9C,MAAM,CAAC,GAAG,CAA4B,CAAC;IACvC,IAAI,OAAO,CAAC,CAAC,EAAE,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAC3C,MAAM,CAAC,GAAG,CAAC,CAAC,IAAqD,CAAC;IAClE,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC,CAAC,KAAK,KAAK,QAAQ,IAAI,OAAO,CAAC,CAAC,EAAE,KAAK,QAAQ;QAAE,OAAO,KAAK,CAAC;IAChF,OAAO,IAAI,CAAC;AACd,CAAC;AAED;;;;;;;;;;;;;;GAcG;AACH,KAAK,UAAU,WAAW,CACxB,GAAY,EACZ,IAAY,EACZ,aAAoD,EACpD,OAAsB,EACtB,KAAa,EACb,KAAoC,EACpC,QAAiB;IAEjB,IAAI,GAAG,GAAkB,IAAI,CAAC;IAC9B,IAAI,QAAQ,GAAG,CAAC,CAAC;IACjB,IAAI,KAAK,GAAG,CAAC,CAAC;IACd,IAAI,YAAY,GAAkB,IAAI,CAAC;IAEvC,OAAO,GAAG,EAAE,CAAC;QACX,oCAAoC;QACpC,IAAI,IAAwB,CAAC;QAC7B,OAAO,IAAI,EAAE,CAAC;YACZ,IAAI,GAAG,MAAM,OAAO,CAAC,EAAE,GAAG,EAAE,KAAK,EAAE,CAAC,CAAC;YACrC,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,KAAK,MAAM,EAAE,CAAC;gBACrC,MAAM,KAAK,CAAC,IAAI,CAAC,SAAS,CAAC,YAAY,GAAG,IAAI,CAAC,CAAC;gBAChD,SAAS;YACX,CAAC;YACD,MAAM;QACR,CAAC;QACD,KAAK,EAAE,CAAC;QAER,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YAC9B,mEAAmE;YACnE,kEAAkE;YAClE,oCAAoC;YACpC,MAAM,SAAS,GACb,IAAI,IAAI,OAAO,IAAI,KAAK,QAAQ;gBAC9B,CAAC,CAAC,CAAE,IAAgC,CAAC,UAAU,IAAI,IAAI,CAAC;gBACxD,CAAC,CAAC,IAAI,CAAC;YACX,IAAI,SAAS,IAAI,CAAC,CAAC,YAAY,IAAI,SAAS,GAAG,YAAY,CAAC,EAAE,CAAC;gBAC7D,YAAY,GAAG,SAAS,CAAC;YAC3B,CAAC;YAED,MAAM,GAAG,GAAG,aAAa,CAAC,IAAI,CAAC,CAAC;YAChC,IAAI,CAAC,GAAG;gBAAE,SAAS;YACnB,MAAM,CAAC,GAAG,WAAW,CAAC,GAAG,EAAE;gBACzB,KAAK,EAAE,GAAG;gBACV,OAAO,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC;gBAC7B,UAAU,EAAE,YAAY,GAAG,CAAC,QAAQ,IAAI,SAAS,IAAI,EAAE,EAAE;aAC1D,CAAC,CAAC;YACH,IAAI,CAAC,CAAC,MAAM,KAAK,UAAU,IAAI,CAAC,CAAC,MAAM,KAAK,SAAS;gBAAE,QAAQ,EAAE,CAAC;YAElE,IAAI,QAAQ,IAAI,QAAQ,IAAI,QAAQ,EAAE,CAAC;gBACrC,sEAAsE;gBACtE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,YAAY,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC;YAC3D,CAAC;QACH,CAAC;QAED,GAAG,GAAG,IAAI,CAAC,IAAI,CAAC;IAClB,CAAC;IAED,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,YAAY,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC;AAC1D,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,YAAY,CAChC,GAAY,EACZ,IAAkB;IAElB,MAAM,KAAK,GACT,IAAI,CAAC,OAAO,IAAI,CAAC,CAAC,EAAU,EAAE,EAAE,CAAC,IAAI,OAAO,CAAO,CAAC,CAAC,EAAE,EAAE,CAAC,UAAU,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC;IAChF,MAAM,OAAO,GAAG,UAAU,CAAC,GAAG,CAAC,SAAS,EAAE,GAAG,CAAC,QAAQ,EAAE,IAAI,CAAC,YAAY,CAAC,CAAC;IAC3E,MAAM,UAAU,GAAG,mBAAmB,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;IAE1D,MAAM,MAAM,GAAmB;QAC7B,QAAQ,EAAE,EAAE,MAAM,EAAE,CAAC,EAAE,aAAa,EAAE,CAAC,EAAE,gBAAgB,EAAE,CAAC,EAAE;QAC9D,KAAK,EAAE,EAAE,MAAM,EAAE,CAAC,EAAE,aAAa,EAAE,CAAC,EAAE,gBAAgB,EAAE,CAAC,EAAE;KAC5D,CAAC;IAEF,oDAAoD;IACpD,MAAM,SAAS,GACb,GAAG,GAAG,UAAU,IAAI,CAAC,YAAY,gCAAgC;QACjE,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,UAAU,kBAAkB,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;IACzE,MAAM,SAAS,GAAG,MAAM,WAAW,CACjC,GAAG,EACH,SAAS,EACT,CAAC,IAAI,EAAE,EAAE;QACP,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAC;QACrC,oDAAoD;QACpD,IAAI,IAAI,CAAC,YAAY;YAAE,OAAO,IAAI,CAAC;QACnC,MAAM,OAAO,GAAqB;YAChC,MAAM,EAAE,QAAQ;YAChB,UAAU;YACV,KAAK,EAAE;gBACL,MAAM,EAAE,IAAI,CAAC,MAAM;gBACnB,KAAK,EAAE,IAAI,CAAC,KAAK;gBACjB,IAAI,EAAE,IAAI,CAAC,IAAI,IAAI,IAAI;gBACvB,IAAI,EAAE,EAAE,KAAK,EAAE,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,EAAE;gBAClD,UAAU,EAAE,IAAI,CAAC,UAAU;aAC5B;SACF,CAAC;QACF,OAAO,EAAE,SAAS,EAAE,QAAQ,EAAE,OAAO,EAAE,CAAC;IAC1C,CAAC,EACD,IAAI,CAAC,OAAO,EACZ,IAAI,CAAC,KAAK,EACV,KAAK,EACL,IAAI,CAAC,YAAY,CAClB,CAAC;IACF,MAAM,CAAC,QAAQ,CAAC,MAAM,GAAG,SAAS,CAAC,QAAQ,CAAC;IAC5C,MAAM,CAAC,KAAK,CAAC,MAAM,GAAG,SAAS,CAAC,KAAK,CAAC;IACtC,0EAA0E;IAC1E,0EAA0E;IAC1E,mCAAmC;IACnC,IAAI,SAAS,CAAC,OAAO,IAAI,SAAS,CAAC,YAAY,EAAE,CAAC;QAChD,WAAW,CACT,GAAG,CAAC,SAAS,EACb,GAAG,CAAC,QAAQ,EACZ,IAAI,CAAC,YAAY,EACjB,YAAY,EACZ,SAAS,CAAC,YAAY,CACvB,CAAC;IACJ,CAAC;IAED,4DAA4D;IAC5D,MAAM,WAAW,GACf,GAAG,GAAG,UAAU,IAAI,CAAC,YAAY,+BAA+B;QAChE,CAAC,OAAO,CAAC,aAAa;YACpB,CAAC,CAAC,UAAU,kBAAkB,CAAC,OAAO,CAAC,aAAa,CAAC,EAAE;YACvD,CAAC,CAAC,EAAE,CAAC,CAAC;IACV,MAAM,WAAW,GAAG,MAAM,WAAW,CACnC,GAAG,EACH,WAAW,EACX,CAAC,IAAI,EAAE,EAAE;QACP,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAC;QACtC,MAAM,CAAC,GAAG,IAAwB,CAAC;QACnC,MAAM,WAAW,GAAG,mBAAmB,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;QACrD,IAAI,WAAW,KAAK,IAAI;YAAE,OAAO,IAAI,CAAC;QACtC,MAAM,OAAO,GAA4B;YACvC,MAAM,EAAE,SAAS;YACjB,UAAU;YACV,KAAK,EAAE,EAAE,MAAM,EAAE,WAAW,EAAE;YAC9B,OAAO,EAAE;gBACP,EAAE,EAAE,CAAC,CAAC,EAAE;gBACR,IAAI,EAAE,CAAC,CAAC,IAAI,IAAI,IAAI;gBACpB,IAAI,EAAE,EAAE,KAAK,EAAE,CAAC,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,EAAE,EAAE;gBAC5C,UAAU,EAAE,CAAC,CAAC,UAAU;aACzB;SACF,CAAC;QACF,OAAO,EAAE,SAAS,EAAE,eAAe,EAAE,OAAO,EAAE,CAAC;IACjD,CAAC,EACD,IAAI,CAAC,OAAO,EACZ,IAAI,CAAC,KAAK,EACV,KAAK,EACL,IAAI,CAAC,YAAY,CAClB,CAAC;IACF,MAAM,CAAC,QAAQ,CAAC,aAAa,GAAG,WAAW,CAAC,QAAQ,CAAC;IACrD,MAAM,CAAC,KAAK,CAAC,aAAa,GAAG,WAAW,CAAC,KAAK,CAAC;IAC/C,IAAI,WAAW,CAAC,OAAO,IAAI,WAAW,CAAC,YAAY,EAAE,CAAC;QACpD,WAAW,CACT,GAAG,CAAC,SAAS,EACb,GAAG,CAAC,QAAQ,EACZ,IAAI,CAAC,YAAY,EACjB,oBAAoB,EACpB,WAAW,CAAC,YAAY,CACzB,CAAC;IACJ,CAAC;IAED,gEAAgE;IAChE,MAAM,aAAa,GACjB,GAAG,GAAG,UAAU,IAAI,CAAC,YAAY,8BAA8B;QAC/D,CAAC,OAAO,CAAC,gBAAgB;YACvB,CAAC,CAAC,UAAU,kBAAkB,CAAC,OAAO,CAAC,gBAAgB,CAAC,EAAE;YAC1D,CAAC,CAAC,EAAE,CAAC,CAAC;IACV,MAAM,aAAa,GAAG,MAAM,WAAW,CACrC,GAAG,EACH,aAAa,EACb,CAAC,IAAI,EAAE,EAAE;QACP,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAC;QACtC,MAAM,CAAC,GAAG,IAA2B,CAAC;QACtC,MAAM,QAAQ,GAAG,mBAAmB,CAAC,CAAC,CAAC,gBAAgB,CAAC,CAAC;QACzD,IAAI,QAAQ,KAAK,IAAI;YAAE,OAAO,IAAI,CAAC;QACnC,MAAM,OAAO,GAAwC;YACnD,MAAM,EAAE,SAAS;YACjB,UAAU;YACV,YAAY,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE;YAClC,OAAO,EAAE;gBACP,EAAE,EAAE,CAAC,CAAC,EAAE;gBACR,IAAI,EAAE,CAAC,CAAC,IAAI,IAAI,IAAI;gBACpB,IAAI,EAAE,EAAE,KAAK,EAAE,CAAC,CAAC,IAAI,CAAC,KAAK,EAAE,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,EAAE,EAAE;gBAC5C,UAAU,EAAE,CAAC,CAAC,UAAU;aACzB;SACF,CAAC;QACF,OAAO,EAAE,SAAS,EAAE,6BAA6B,EAAE,OAAO,EAAE,CAAC;IAC/D,CAAC,EACD,IAAI,CAAC,OAAO,EACZ,IAAI,CAAC,KAAK,EACV,KAAK,EACL,IAAI,CAAC,YAAY,CAClB,CAAC;IACF,MAAM,CAAC,QAAQ,CAAC,gBAAgB,GAAG,aAAa,CAAC,QAAQ,CAAC;IAC1D,MAAM,CAAC,KAAK,CAAC,gBAAgB,GAAG,aAAa,CAAC,KAAK,CAAC;IACpD,IAAI,aAAa,CAAC,OAAO,IAAI,aAAa,CAAC,YAAY,EAAE,CAAC;QACxD,WAAW,CACT,GAAG,CAAC,SAAS,EACb,GAAG,CAAC,QAAQ,EACZ,IAAI,CAAC,YAAY,EACjB,wBAAwB,EACxB,aAAa,CAAC,YAAY,CAC3B,CAAC;IACJ,CAAC;IAED,OAAO,MAAM,CAAC;AAChB,CAAC"}

package/dist/src/connectors/github/cli-impl.js

@@ -0,0 +1,192 @@
+/**
+ * Implementation of `hippo github` CLI subcommands. Extracted from the main
+ * cli.ts so unit tests can import these functions directly without triggering
+ * the cli.ts main() side effects. The cli.ts dispatcher re-exports the
+ * top-level cmdGithub.
+ *
+ * Subcommands mirror the Slack connector shape (cli.ts §Slack subcommands):
+ *   - hippo github backfill --repo <owner/name> [--since ISO] [--max <N>]
+ *   - hippo github dlq list
+ *   - hippo github dlq replay <id> [--force]
+ */
+import { openHippoDb, closeHippoDb } from '../../db.js';
+import { resolveTenantId } from '../../tenant.js';
+import { backfillRepo } from './backfill.js';
+import { realGitHubFetcher } from './octokit-client.js';
+import { listDlq, replayDlqEntry } from './dlq.js';
+import { ingestEvent } from './ingest.js';
+import { isGitHubIssueEvent, isGitHubIssueCommentEvent, isGitHubPullRequestEvent, isGitHubPullRequestReviewCommentEvent, } from './types.js';
+/**
+ * Map a parsed envelope + eventName header to an IngestEvent discriminated
+ * union. Returns null for unknown event types or shapes that don't pass the
+ * type guards.
+ */
+function parsedToIngestEvent(parsed, eventName) {
+    if (eventName === 'issues' && isGitHubIssueEvent(parsed, eventName)) {
+        return { eventName: 'issues', payload: parsed };
+    }
+    if (eventName === 'issue_comment' && isGitHubIssueCommentEvent(parsed, eventName)) {
+        return { eventName: 'issue_comment', payload: parsed };
+    }
+    if (eventName === 'pull_request' && isGitHubPullRequestEvent(parsed, eventName)) {
+        return { eventName: 'pull_request', payload: parsed };
+    }
+    if (eventName === 'pull_request_review_comment' &&
+        isGitHubPullRequestReviewCommentEvent(parsed, eventName)) {
+        return { eventName: 'pull_request_review_comment', payload: parsed };
+    }
+    return null;
+}
+export function printGithubBackfillUsage() {
+    console.log('hippo github backfill --repo <owner/name> [--since ISO] [--max <N>]');
+    console.log('  --repo   GitHub repository in owner/name format (required, e.g. acme/widgets)');
+    console.log('  --since  Initial high-water-mark for first run (optional, ISO 8601)');
+    console.log('  --max    Cap items per stream (optional, integer)');
+    console.log('  Requires GITHUB_TOKEN env var with repo read scope.');
+}
+/**
+ * `hippo github backfill`. The fetcher is injectable so tests can drive the
+ * code path without hitting the network. Defaults to `realGitHubFetcher`.
+ */
+export async function cmdGithubBackfill(hippoRoot, flags, fetcher = realGitHubFetcher) {
+    if (flags['help']) {
+        printGithubBackfillUsage();
+        return;
+    }
+    const repo = flags['repo'];
+    if (typeof repo !== 'string' || !repo.includes('/')) {
+        printGithubBackfillUsage();
+        process.exit(2);
+    }
+    const token = process.env.GITHUB_TOKEN;
+    if (!token) {
+        console.error('GITHUB_TOKEN is not set. Backfill requires a personal access token with repo read scope.');
+        process.exit(2);
+    }
+    const maxRaw = flags['max'];
+    let maxPerStream;
+    if (typeof maxRaw === 'string' || typeof maxRaw === 'number') {
+        const parsed = Number(maxRaw);
+        if (Number.isFinite(parsed) && parsed > 0) {
+            maxPerStream = Math.floor(parsed);
+        }
+    }
+    const sinceIso = typeof flags['since'] === 'string' ? flags['since'] : undefined;
+    const tenantId = resolveTenantId({});
+    // Seed the github_cursors row so all 3 streams use --since on a fresh run.
+    // COALESCE preserves any existing HWM (subsequent runs ignore --since for
+    // streams that already drained at least once — same idempotency story as
+    // Slack's slack_cursors).
+    if (sinceIso) {
+        const db = openHippoDb(hippoRoot);
+        try {
+            db.prepare(`INSERT INTO github_cursors (tenant_id, repo_full_name, issues_hwm, issue_comments_hwm, pr_review_comments_hwm, updated_at)
+         VALUES (?, ?, ?, ?, ?, ?)
+         ON CONFLICT(tenant_id, repo_full_name) DO UPDATE SET
+           issues_hwm = COALESCE(github_cursors.issues_hwm, excluded.issues_hwm),
+           issue_comments_hwm = COALESCE(github_cursors.issue_comments_hwm, excluded.issue_comments_hwm),
+           pr_review_comments_hwm = COALESCE(github_cursors.pr_review_comments_hwm, excluded.pr_review_comments_hwm),
+           updated_at = excluded.updated_at`).run(tenantId, repo, sinceIso, sinceIso, sinceIso, new Date().toISOString());
+        }
+        finally {
+            closeHippoDb(db);
+        }
+    }
+    const ctx = {
+        hippoRoot,
+        tenantId,
+        actor: 'cli:github-backfill',
+    };
+    try {
+        const result = await backfillRepo(ctx, {
+            repoFullName: repo,
+            fetcher,
+            token: token,
+            maxPerStream,
+        });
+        console.log(JSON.stringify(result, null, 2));
+    }
+    catch (e) {
+        console.error('backfill failed:', e.message);
+        process.exit(3);
+    }
+}
+export function cmdGithubDlqList(hippoRoot, _flags) {
+    const db = openHippoDb(hippoRoot);
+    try {
+        const tenantId = resolveTenantId({});
+        const items = listDlq(db, { tenantId });
+        if (items.length === 0) {
+            console.log('no entries');
+            return;
+        }
+        for (const it of items) {
+            console.log(`${it.id}\t${it.bucket}\t${it.tenantId}\t${it.eventName ?? '-'}\t${it.receivedAt}\t${it.error}`);
+        }
+    }
+    finally {
+        closeHippoDb(db);
+    }
+}
+export async function cmdGithubDlqReplay(hippoRoot, args, flags) {
+    const idArg = args[0];
+    if (!idArg) {
+        console.error('Usage: hippo github dlq replay <id> [--force]');
+        process.exit(1);
+    }
+    const id = Number(idArg);
+    if (!Number.isFinite(id) || !Number.isInteger(id) || id < 1) {
+        console.error(`replay: invalid id ${idArg}`);
+        process.exit(1);
+    }
+    const force = flags['force'] === true;
+    const ctx = {
+        hippoRoot,
+        tenantId: resolveTenantId({}),
+        actor: 'cli:github-dlq-replay',
+    };
+    // v1.3.1 hotfix (codex P1): without an ingestHook the v1.3.0 CLI was a
+    // dry-run that printed "replay ok" while only bumping retry_count. Wire the
+    // real hook so `replay` actually re-runs the ingest path.
+    const result = await replayDlqEntry(ctx, id, {
+        force,
+        webhookSecret: process.env.GITHUB_WEBHOOK_SECRET,
+        previousSecret: process.env.GITHUB_WEBHOOK_SECRET_PREVIOUS,
+        ingestHook: async (innerCtx, args) => {
+            const parsed = JSON.parse(args.rawPayload);
+            const event = parsedToIngestEvent(parsed, args.eventName);
+            if (!event) {
+                return { memoryId: null };
+            }
+            const r = ingestEvent(innerCtx, {
+                event,
+                rawBody: args.rawPayload,
+                deliveryId: args.deliveryId,
+            });
+            return { memoryId: r.memoryId };
+        },
+    });
+    if (!result.ok) {
+        console.error(`replay failed: status=${result.status} retry_count=${result.retryCount}${result.reason ? ` reason=${result.reason}` : ''}`);
+        process.exit(1);
+    }
+    console.log(`replay ok: status=${result.status} memory_id=${result.memoryId ?? '(none)'} retry_count=${result.retryCount}`);
+}
+export async function cmdGithub(hippoRoot, args, flags) {
+    const sub = args[0];
+    if (sub === 'backfill') {
+        await cmdGithubBackfill(hippoRoot, flags);
+        return;
+    }
+    if (sub === 'dlq' && args[1] === 'list') {
+        cmdGithubDlqList(hippoRoot, flags);
+        return;
+    }
+    if (sub === 'dlq' && args[1] === 'replay') {
+        await cmdGithubDlqReplay(hippoRoot, args.slice(2), flags);
+        return;
+    }
+    console.error('Usage: hippo github <backfill|dlq list|dlq replay <id> [--force]> [...]');
+    process.exit(1);
+}
+//# sourceMappingURL=cli-impl.js.map

package/dist/src/connectors/github/cli-impl.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"cli-impl.js","sourceRoot":"","sources":["../../../../src/connectors/github/cli-impl.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAGH,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,aAAa,CAAC;AACxD,OAAO,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAC;AAClD,OAAO,EAAE,YAAY,EAAE,MAAM,eAAe,CAAC;AAC7C,OAAO,EAAE,iBAAiB,EAAsB,MAAM,qBAAqB,CAAC;AAC5E,OAAO,EAAE,OAAO,EAAE,cAAc,EAAE,MAAM,UAAU,CAAC;AACnD,OAAO,EAAE,WAAW,EAAoB,MAAM,aAAa,CAAC;AAC5D,OAAO,EACL,kBAAkB,EAClB,yBAAyB,EACzB,wBAAwB,EACxB,qCAAqC,GACtC,MAAM,YAAY,CAAC;AAIpB;;;;GAIG;AACH,SAAS,mBAAmB,CAAC,MAAe,EAAE,SAAiB;IAC7D,IAAI,SAAS,KAAK,QAAQ,IAAI,kBAAkB,CAAC,MAAM,EAAE,SAAS,CAAC,EAAE,CAAC;QACpE,OAAO,EAAE,SAAS,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC;IAClD,CAAC;IACD,IAAI,SAAS,KAAK,eAAe,IAAI,yBAAyB,CAAC,MAAM,EAAE,SAAS,CAAC,EAAE,CAAC;QAClF,OAAO,EAAE,SAAS,EAAE,eAAe,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC;IACzD,CAAC;IACD,IAAI,SAAS,KAAK,cAAc,IAAI,wBAAwB,CAAC,MAAM,EAAE,SAAS,CAAC,EAAE,CAAC;QAChF,OAAO,EAAE,SAAS,EAAE,cAAc,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC;IACxD,CAAC;IACD,IACE,SAAS,KAAK,6BAA6B;QAC3C,qCAAqC,CAAC,MAAM,EAAE,SAAS,CAAC,EACxD,CAAC;QACD,OAAO,EAAE,SAAS,EAAE,6BAA6B,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC;IACvE,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,UAAU,wBAAwB;IACtC,OAAO,CAAC,GAAG,CAAC,qEAAqE,CAAC,CAAC;IACnF,OAAO,CAAC,GAAG,CAAC,iFAAiF,CAAC,CAAC;IAC/F,OAAO,CAAC,GAAG,CAAC,uEAAuE,CAAC,CAAC;IACrF,OAAO,CAAC,GAAG,CAAC,qDAAqD,CAAC,CAAC;IACnE,OAAO,CAAC,GAAG,CAAC,uDAAuD,CAAC,CAAC;AACvE,CAAC;AAED;;;GAGG;AACH,MAAM,CAAC,KAAK,UAAU,iBAAiB,CACrC,SAAiB,EACjB,KAAY,EACZ,UAAyB,iBAAiB;IAE1C,IAAI,KAAK,CAAC,MAAM,CAAC,EAAE,CAAC;QAClB,wBAAwB,EAAE,CAAC;QAC3B,OAAO;IACT,CAAC;IACD,MAAM,IAAI,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC;IAC3B,IAAI,OAAO,IAAI,KAAK,QAAQ,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;QACpD,wBAAwB,EAAE,CAAC;QAC3B,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IACD,MAAM,KAAK,GAAG,OAAO,CAAC,GAAG,CAAC,YAAY,CAAC;IACvC,IAAI,CAAC,KAAK,EAAE,CAAC;QACX,OAAO,CAAC,KAAK,CACX,0FAA0F,CAC3F,CAAC;QACF,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IACD,MAAM,MAAM,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC;IAC5B,IAAI,YAAgC,CAAC;IACrC,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,OAAO,MAAM,KAAK,QAAQ,EAAE,CAAC;QAC7D,MAAM,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC,CAAC;QAC9B,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,MAAM,GAAG,CAAC,EAAE,CAAC;YAC1C,YAAY,GAAG,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC;QACpC,CAAC;IACH,CAAC;IACD,MAAM,QAAQ,GAAG,OAAO,KAAK,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAE,KAAK,CAAC,OAAO,CAAY,CAAC,CAAC,CAAC,SAAS,CAAC;IAC7F,MAAM,QAAQ,GAAG,eAAe,CAAC,EAAE,CAAC,CAAC;IAErC,2EAA2E;IAC3E,0EAA0E;IAC1E,yEAAyE;IACzE,0BAA0B;IAC1B,IAAI,QAAQ,EAAE,CAAC;QACb,MAAM,EAAE,GAAG,WAAW,CAAC,SAAS,CAAC,CAAC;QAClC,IAAI,CAAC;YACH,EAAE,CAAC,OAAO,CACR;;;;;;4CAMoC,CACrC,CAAC,GAAG,CAAC,QAAQ,EAAE,IAAI,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC;QAChF,CAAC;gBAAS,CAAC;YACT,YAAY,CAAC,EAAE,CAAC,CAAC;QACnB,CAAC;IACH,CAAC;IAED,MAAM,GAAG,GAAY;QACnB,SAAS;QACT,QAAQ;QACR,KAAK,EAAE,qBAAqB;KAC7B,CAAC;IACF,IAAI,CAAC;QACH,MAAM,MAAM,GAAG,MAAM,YAAY,CAAC,GAAG,EAAE;YACrC,YAAY,EAAE,IAAI;YAClB,OAAO;YACP,KAAK,EAAE,KAAe;YACtB,YAAY;SACb,CAAC,CAAC;QACH,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;IAC/C,CAAC;IAAC,OAAO,CAAC,EAAE,CAAC;QACX,OAAO,CAAC,KAAK,CAAC,kBAAkB,EAAG,CAAW,CAAC,OAAO,CAAC,CAAC;QACxD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;AACH,CAAC;AAED,MAAM,UAAU,gBAAgB,CAAC,SAAiB,EAAE,MAAa;IAC/D,MAAM,EAAE,GAAG,WAAW,CAAC,SAAS,CAAC,CAAC;IAClC,IAAI,CAAC;QACH,MAAM,QAAQ,GAAG,eAAe,CAAC,EAAE,CAAC,CAAC;QACrC,MAAM,KAAK,GAAG,OAAO,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC,CAAC;QACxC,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACvB,OAAO,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC;YAC1B,OAAO;QACT,CAAC;QACD,KAAK,MAAM,EAAE,IAAI,KAAK,EAAE,CAAC;YACvB,OAAO,CAAC,GAAG,CACT,GAAG,EAAE,CAAC,EAAE,KAAK,EAAE,CAAC,MAAM,KAAK,EAAE,CAAC,QAAQ,KAAK,EAAE,CAAC,SAAS,IAAI,GAAG,KAAK,EAAE,CAAC,UAAU,KAAK,EAAE,CAAC,KAAK,EAAE,CAChG,CAAC;QACJ,CAAC;IACH,CAAC;YAAS,CAAC;QACT,YAAY,CAAC,EAAE,CAAC,CAAC;IACnB,CAAC;AACH,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,kBAAkB,CACtC,SAAiB,EACjB,IAAc,EACd,KAAY;IAEZ,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;IACtB,IAAI,CAAC,KAAK,EAAE,CAAC;QACX,OAAO,CAAC,KAAK,CAAC,+CAA+C,CAAC,CAAC;QAC/D,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IACD,MAAM,EAAE,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;IACzB,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,EAAE,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,EAAE,CAAC,IAAI,EAAE,GAAG,CAAC,EAAE,CAAC;QAC5D,OAAO,CAAC,KAAK,CAAC,sBAAsB,KAAK,EAAE,CAAC,CAAC;QAC7C,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IACD,MAAM,KAAK,GAAG,KAAK,CAAC,OAAO,CAAC,KAAK,IAAI,CAAC;IACtC,MAAM,GAAG,GAAY;QACnB,SAAS;QACT,QAAQ,EAAE,eAAe,CAAC,EAAE,CAAC;QAC7B,KAAK,EAAE,uBAAuB;KAC/B,CAAC;IACF,uEAAuE;IACvE,4EAA4E;IAC5E,0DAA0D;IAC1D,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,GAAG,EAAE,EAAE,EAAE;QAC3C,KAAK;QACL,aAAa,EAAE,OAAO,CAAC,GAAG,CAAC,qBAAqB;QAChD,cAAc,EAAE,OAAO,CAAC,GAAG,CAAC,8BAA8B;QAC1D,UAAU,EAAE,KAAK,EAAE,QAAQ,EAAE,IAAI,EAAE,EAAE;YACnC,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YAC3C,MAAM,KAAK,GAAG,mBAAmB,CAAC,MAAM,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC;YAC1D,IAAI,CAAC,KAAK,EAAE,CAAC;gBACX,OAAO,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC;YAC5B,CAAC;YACD,MAAM,CAAC,GAAG,WAAW,CAAC,QAAQ,EAAE;gBAC9B,KAAK;gBACL,OAAO,EAAE,IAAI,CAAC,UAAU;gBACxB,UAAU,EAAE,IAAI,CAAC,UAAU;aAC5B,CAAC,CAAC;YACH,OAAO,EAAE,QAAQ,EAAE,CAAC,CAAC,QAAQ,EAAE,CAAC;QAClC,CAAC;KACF,CAAC,CAAC;IACH,IAAI,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC;QACf,OAAO,CAAC,KAAK,CACX,yBAAyB,MAAM,CAAC,MAAM,gBAAgB,MAAM,CAAC,UAAU,GACrE,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,WAAW,MAAM,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC,EAC/C,EAAE,CACH,CAAC;QACF,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;IACD,OAAO,CAAC,GAAG,CACT,qBAAqB,MAAM,CAAC,MAAM,cAAc,MAAM,CAAC,QAAQ,IAAI,QAAQ,gBAAgB,MAAM,CAAC,UAAU,EAAE,CAC/G,CAAC;AACJ,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,SAAS,CAC7B,SAAiB,EACjB,IAAc,EACd,KAAY;IAEZ,MAAM,GAAG,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;IACpB,IAAI,GAAG,KAAK,UAAU,EAAE,CAAC;QACvB,MAAM,iBAAiB,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;QAC1C,OAAO;IACT,CAAC;IACD,IAAI,GAAG,KAAK,KAAK,IAAI,IAAI,CAAC,CAAC,CAAC,KAAK,MAAM,EAAE,CAAC;QACxC,gBAAgB,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;QACnC,OAAO;IACT,CAAC;IACD,IAAI,GAAG,KAAK,KAAK,IAAI,IAAI,CAAC,CAAC,CAAC,KAAK,QAAQ,EAAE,CAAC;QAC1C,MAAM,kBAAkB,CAAC,SAAS,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QAC1D,OAAO;IACT,CAAC;IACD,OAAO,CAAC,KAAK,CAAC,yEAAyE,CAAC,CAAC;IACzF,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;AAClB,CAAC"}

package/dist/src/connectors/github/deletion.js

@@ -0,0 +1,83 @@
+import { openHippoDb, closeHippoDb } from '../../db.js';
+import { archiveRawMemory } from '../../raw-archive.js';
+import { hasSeenKey, markKeySeen } from './idempotency.js';
+/**
+ * Handle GitHub `issue_comment.deleted` and `pull_request_review_comment.deleted`.
+ *
+ * Codex round 1 P0 #5: filter by tenant_id + kind='raw'. Multi-row archive:
+ * GitHub edits keep the same artifact_ref, so multiple active raw rows can
+ * match a single deletion event. Archive ALL of them.
+ *
+ * Claude round 2 P0 #2 (v1.3.1 hotfix): the v1.3.0 implementation called
+ * archiveRaw N times in a loop, each opening its own DB handle and SAVEPOINT.
+ * The first archive's afterArchive committed the idempotency mark. If archive
+ * 2..N threw, idempotency was already committed and retry returned 'duplicate'
+ * with archivedCount=0 — survivors stayed searchable, leaking private bodies.
+ *
+ * v1.3.1 fix: ONE shared DB handle wrapping ALL archives + the idempotency
+ * mark in a single outer SAVEPOINT. Any per-row failure rolls back the entire
+ * batch (including idempotency), so retry re-attempts cleanly. archiveRawMemory
+ * (the lower-level function from raw-archive.js) runs its own inner SAVEPOINT
+ * which nests safely inside the outer one.
+ *
+ * Tenant scope and kind='raw' filtering are load-bearing: without them a
+ * deletion event from tenant A could archive tenant B's row sharing the same
+ * artifact_ref, or accidentally target a distilled row.
+ */
+export function handleCommentDeleted(ctx, input) {
+    const db = openHippoDb(ctx.hippoRoot);
+    try {
+        if (hasSeenKey(db, input.idempotencyKey)) {
+            return { status: 'duplicate', archivedCount: 0 };
+        }
+        const rows = db
+            .prepare(`SELECT id FROM memories WHERE artifact_ref = ? AND tenant_id = ? AND kind = 'raw'`)
+            .all(input.artifactRef, ctx.tenantId);
+        const memoryIds = rows.map((r) => r.id);
+        if (memoryIds.length === 0) {
+            // Nothing to archive — still mark idempotency so a retry returns 'duplicate'.
+            // Independent INSERT, no rollback needed.
+            markKeySeen(db, {
+                idempotencyKey: input.idempotencyKey,
+                deliveryId: input.deliveryId,
+                eventName: input.eventName,
+                memoryId: null,
+            });
+            return { status: 'archive_skipped_not_found', archivedCount: 0 };
+        }
+        // Outer SAVEPOINT wrapping all archives + the idempotency mark. Any throw
+        // rolls back the whole batch so retry sees neither archive nor mark — and
+        // re-attempts the full set.
+        db.exec('SAVEPOINT github_delete_all');
+        try {
+            for (const id of memoryIds) {
+                archiveRawMemory(db, id, {
+                    reason: `source_deleted:github:${input.eventName}:${input.deliveryId}`,
+                    who: ctx.actor || 'connector:github',
+                });
+            }
+            markKeySeen(db, {
+                idempotencyKey: input.idempotencyKey,
+                deliveryId: input.deliveryId,
+                eventName: input.eventName,
+                memoryId: memoryIds[0],
+            });
+            db.exec('RELEASE SAVEPOINT github_delete_all');
+        }
+        catch (e) {
+            try {
+                db.exec('ROLLBACK TO SAVEPOINT github_delete_all');
+                db.exec('RELEASE SAVEPOINT github_delete_all');
+            }
+            catch {
+                // Best effort. Surface the original error.
+            }
+            throw e;
+        }
+        return { status: 'archived', archivedCount: memoryIds.length };
+    }
+    finally {
+        closeHippoDb(db);
+    }
+}
+//# sourceMappingURL=deletion.js.map

package/dist/src/connectors/github/deletion.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"deletion.js","sourceRoot":"","sources":["../../../../src/connectors/github/deletion.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,aAAa,CAAC;AACxD,OAAO,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AACxD,OAAO,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAC;AAsB3D;;;;;;;;;;;;;;;;;;;;;;GAsBG;AACH,MAAM,UAAU,oBAAoB,CAAC,GAAY,EAAE,KAAoB;IACrE,MAAM,EAAE,GAAG,WAAW,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;IACtC,IAAI,CAAC;QACH,IAAI,UAAU,CAAC,EAAE,EAAE,KAAK,CAAC,cAAc,CAAC,EAAE,CAAC;YACzC,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,aAAa,EAAE,CAAC,EAAE,CAAC;QACnD,CAAC;QAED,MAAM,IAAI,GAAG,EAAE;aACZ,OAAO,CACN,mFAAmF,CACpF;aACA,GAAG,CAAC,KAAK,CAAC,WAAW,EAAE,GAAG,CAAC,QAAQ,CAA0B,CAAC;QACjE,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;QAExC,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC3B,8EAA8E;YAC9E,0CAA0C;YAC1C,WAAW,CAAC,EAAE,EAAE;gBACd,cAAc,EAAE,KAAK,CAAC,cAAc;gBACpC,UAAU,EAAE,KAAK,CAAC,UAAU;gBAC5B,SAAS,EAAE,KAAK,CAAC,SAAS;gBAC1B,QAAQ,EAAE,IAAI;aACf,CAAC,CAAC;YACH,OAAO,EAAE,MAAM,EAAE,2BAA2B,EAAE,aAAa,EAAE,CAAC,EAAE,CAAC;QACnE,CAAC;QAED,0EAA0E;QAC1E,0EAA0E;QAC1E,4BAA4B;QAC5B,EAAE,CAAC,IAAI,CAAC,6BAA6B,CAAC,CAAC;QACvC,IAAI,CAAC;YACH,KAAK,MAAM,EAAE,IAAI,SAAS,EAAE,CAAC;gBAC3B,gBAAgB,CAAC,EAAE,EAAE,EAAE,EAAE;oBACvB,MAAM,EAAE,yBAAyB,KAAK,CAAC,SAAS,IAAI,KAAK,CAAC,UAAU,EAAE;oBACtE,GAAG,EAAE,GAAG,CAAC,KAAK,IAAI,kBAAkB;iBACrC,CAAC,CAAC;YACL,CAAC;YACD,WAAW,CAAC,EAAE,EAAE;gBACd,cAAc,EAAE,KAAK,CAAC,cAAc;gBACpC,UAAU,EAAE,KAAK,CAAC,UAAU;gBAC5B,SAAS,EAAE,KAAK,CAAC,SAAS;gBAC1B,QAAQ,EAAE,SAAS,CAAC,CAAC,CAAE;aACxB,CAAC,CAAC;YACH,EAAE,CAAC,IAAI,CAAC,qCAAqC,CAAC,CAAC;QACjD,CAAC;QAAC,OAAO,CAAC,EAAE,CAAC;YACX,IAAI,CAAC;gBACH,EAAE,CAAC,IAAI,CAAC,yCAAyC,CAAC,CAAC;gBACnD,EAAE,CAAC,IAAI,CAAC,qCAAqC,CAAC,CAAC;YACjD,CAAC;YAAC,MAAM,CAAC;gBACP,2CAA2C;YAC7C,CAAC;YACD,MAAM,CAAC,CAAC;QACV,CAAC;QACD,OAAO,EAAE,MAAM,EAAE,UAAU,EAAE,aAAa,EAAE,SAAS,CAAC,MAAM,EAAE,CAAC;IACjE,CAAC;YAAS,CAAC;QACT,YAAY,CAAC,EAAE,CAAC,CAAC;IACnB,CAAC;AACH,CAAC"}