heroku 9.3.0-alpha.3 → 9.3.0-beta.0

package/lib/commands/local/run.js

@@ -4,14 +4,14 @@ const completions_1 = require("@heroku-cli/command/lib/completions");
 const core_1 = require("@oclif/core");
 const color_1 = require("@heroku-cli/color");
 const fork_foreman_1 = require("../../lib/local/fork-foreman");
-const helpers_1 = require("../../lib/run/helpers");
 const fs = require("fs");
 class Run extends core_1.Command {
     async run() {
         const execArgv = ['run'];
         const { argv, flags } = await this.parse(Run);
-        const userArgvInputOrder = (0, helpers_1.revertSortedArgs)(process.argv, argv);
-        if (userArgvInputOrder.length === 0) {
+        const maybeOptionsIndex = process.argv.indexOf('--');
+        const commandArgs = (maybeOptionsIndex === -1 ? argv : process.argv.slice(maybeOptionsIndex + 1));
+        if (commandArgs.length === 0) {
             const errorMessage = 'Usage: heroku local:run [COMMAND]\nMust specify command to run';
             this.error(errorMessage, { exit: -1 });
         }
@@ -24,7 +24,7 @@ class Run extends core_1.Command {
         if (flags.port)
             execArgv.push('--port', flags.port);
         execArgv.push('--'); // disable node-foreman flag parsing
-        execArgv.push(...userArgvInputOrder); // eslint-disable-line unicorn/no-array-push-push
+        execArgv.push(...commandArgs); // eslint-disable-line unicorn/no-array-push-push
         await (0, fork_foreman_1.fork)(execArgv);
     }
 }

package/lib/commands/pg/promote.js

@@ -17,36 +17,36 @@ class Promote extends command_1.Command {
         core_1.ux.action.start(`Ensuring an alternate alias for existing ${color_1.default.green('DATABASE_URL')}`);
         const { body: attachments } = await this.heroku.get(`/apps/${app}/addon-attachments`);
         const current = attachments.find(a => a.name === 'DATABASE');
-        if (!current)
-            return;
-        // eslint-disable-next-line eqeqeq
-        if (((_a = current.addon) === null || _a === void 0 ? void 0 : _a.name) === attachment.addon.name && current.namespace == attachment.namespace) {
-            if (attachment.namespace) {
-                core_1.ux.error(`${color_1.default.cyan(attachment.name)} is already promoted on ${color_1.default.app(app)}`);
+        if (current) {
+            // eslint-disable-next-line eqeqeq
+            if (((_a = current.addon) === null || _a === void 0 ? void 0 : _a.name) === attachment.addon.name && current.namespace == attachment.namespace) {
+                if (attachment.namespace) {
+                    core_1.ux.error(`${color_1.default.cyan(attachment.name)} is already promoted on ${color_1.default.app(app)}`);
+                }
+                else {
+                    core_1.ux.error(`${color_1.default.addon(attachment.addon.name)} is already promoted on ${color_1.default.app(app)}`);
+                }
+            }
+            const existing = attachments.filter(a => { var _a, _b; return ((_a = a.addon) === null || _a === void 0 ? void 0 : _a.id) === ((_b = current.addon) === null || _b === void 0 ? void 0 : _b.id) && a.namespace === current.namespace; })
+                .find(a => a.name !== 'DATABASE');
+            if (existing) {
+                core_1.ux.action.stop(color_1.default.green(existing.name + '_URL'));
             }
             else {
-                core_1.ux.error(`${color_1.default.addon(attachment.addon.name)} is already promoted on ${color_1.default.app(app)}`);
+                // The current add-on occupying the DATABASE attachment has no
+                // other attachments. In order to promote this database without
+                // error, we can create a secondary attachment, just-in-time.
+                const { body: backup } = await this.heroku.post('/addon-attachments', {
+                    body: {
+                        app: { name: app },
+                        addon: { name: (_b = current.addon) === null || _b === void 0 ? void 0 : _b.name },
+                        namespace: current.namespace,
+                        confirm: app,
+                    },
+                });
+                core_1.ux.action.stop(color_1.default.green(backup.name + '_URL'));
             }
         }
-        const existing = attachments.filter(a => { var _a, _b; return ((_a = a.addon) === null || _a === void 0 ? void 0 : _a.id) === ((_b = current.addon) === null || _b === void 0 ? void 0 : _b.id) && a.namespace === current.namespace; })
-            .find(a => a.name !== 'DATABASE');
-        if (existing) {
-            core_1.ux.action.stop(color_1.default.green(existing.name + '_URL'));
-        }
-        else {
-            // The current add-on occupying the DATABASE attachment has no
-            // other attachments. In order to promote this database without
-            // error, we can create a secondary attachment, just-in-time.
-            const { body: backup } = await this.heroku.post('/addon-attachments', {
-                body: {
-                    app: { name: app },
-                    addon: { name: (_b = current.addon) === null || _b === void 0 ? void 0 : _b.name },
-                    namespace: current.namespace,
-                    confirm: app,
-                },
-            });
-            core_1.ux.action.stop(color_1.default.green(backup.name + '_URL'));
-        }
         if (!force) {
             const { body: status } = await this.heroku.get(`/client/v11/databases/${attachment.addon.id}/wait_status`, {
                 hostname: (0, host_1.default)(),
@@ -54,9 +54,9 @@ class Promote extends command_1.Command {
             if (status['waiting?']) {
                 core_1.ux.error((0, tsheredoc_1.default)(`
           Database cannot be promoted while in state: ${status.message}
-          
+
           Promoting this database can lead to application errors and outage. Please run ${color_1.default.cmd('heroku pg:wait')} to wait for database to become available.
-          
+
           To ignore this error, you can pass the --force flag to promote the database and risk application issues.
         `));
             }
@@ -79,7 +79,7 @@ class Promote extends command_1.Command {
             },
         });
         core_1.ux.action.stop();
-        const currentPooler = attachments.find(a => { var _a, _b; return a.namespace === 'connection-pooling:default' && ((_a = a.addon) === null || _a === void 0 ? void 0 : _a.id) === ((_b = current.addon) === null || _b === void 0 ? void 0 : _b.id) && a.name === 'DATABASE_CONNECTION_POOL'; });
+        const currentPooler = attachments.find(a => { var _a, _b; return a.namespace === 'connection-pooling:default' && ((_a = a.addon) === null || _a === void 0 ? void 0 : _a.id) === ((_b = current === null || current === void 0 ? void 0 : current.addon) === null || _b === void 0 ? void 0 : _b.id) && a.name === 'DATABASE_CONNECTION_POOL'; });
         if (currentPooler) {
             core_1.ux.action.start('Reattaching pooler to new leader');
             await this.heroku.post('/addon-attachments', {
@@ -100,9 +100,9 @@ class Promote extends command_1.Command {
             const unfollowLeaderCmd = `heroku pg:unfollow ${attachment.addon.name}`;
             core_1.ux.warn((0, tsheredoc_1.default)(`
         Your database has been promoted but it is currently a follower database in read-only mode.
-        
+
         Promoting a database with ${color_1.default.cmd('heroku pg:promote')} doesn't automatically unfollow its leader.
-        
+
         Use ${color_1.default.cmd(unfollowLeaderCmd)} to stop this follower from replicating from its leader (${color_1.default.yellow(promotedDatabaseDetails.leader)}) and convert it into a writable database.
       `));
         }
@@ -141,7 +141,7 @@ class Promote extends command_1.Command {
                         msg += 'without an attached DATABASE_URL.';
                     }
                     else {
-                        msg += `with ${(_c = current.addon) === null || _c === void 0 ? void 0 : _c.name} attached as DATABASE_URL.`;
+                        msg += `with ${(_c = current === null || current === void 0 ? void 0 : current.addon) === null || _c === void 0 ? void 0 : _c.name} attached as DATABASE_URL.`;
                     }
                     msg += ' Check your release phase logs for failure causes.';
                     core_1.ux.action.stop(msg);

package/lib/commands/pg/settings/auto-explain/log-format.d.ts

@@ -0,0 +1,12 @@
+import { PGSettingsCommand } from '../../../../lib/pg/setter';
+import { Setting, SettingKey } from '../../../../lib/pg/types';
+export default class LogFormat extends PGSettingsCommand {
+    static description: string;
+    static args: {
+        database: import("@oclif/core/lib/interfaces/parser").Arg<string | undefined, Record<string, unknown>>;
+        value: import("@oclif/core/lib/interfaces/parser").Arg<string | undefined, Record<string, unknown>>;
+    };
+    protected settingKey: SettingKey;
+    protected explain(setting: Setting<string>): string;
+    protected convertValue(val: string): string;
+}

package/lib/commands/pg/settings/auto-explain/log-format.js

@@ -0,0 +1,26 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const core_1 = require("@oclif/core");
+const setter_1 = require("../../../../lib/pg/setter");
+const tsheredoc_1 = require("tsheredoc");
+class LogFormat extends setter_1.PGSettingsCommand {
+    constructor() {
+        super(...arguments);
+        this.settingKey = 'auto_explain.log_format';
+    }
+    explain(setting) {
+        return `Auto explain log output will log in ${setting.value} format.`;
+    }
+    convertValue(val) {
+        return val;
+    }
+}
+exports.default = LogFormat;
+LogFormat.description = (0, tsheredoc_1.default)(`
+    selects the EXPLAIN output format to be used
+    The allowed values are text, xml, json, and yaml. The default is text.
+  `);
+LogFormat.args = {
+    database: core_1.Args.string(),
+    value: core_1.Args.string({ options: ['text', 'json', 'yaml', 'xml'] }),
+};

package/lib/commands/pg/settings/explain-data-connector-details.d.ts

@@ -0,0 +1,16 @@
+import { type BooleanAsString, PGSettingsCommand } from '../../../lib/pg/setter';
+import type { Setting, SettingKey } from '../../../lib/pg/types';
+export default class ExplainDataConnectorDetails extends PGSettingsCommand {
+    static description: string;
+    static flags: {
+        app: import("@oclif/core/lib/interfaces").OptionFlag<string, import("@oclif/core/lib/interfaces/parser").CustomOptions>;
+        remote: import("@oclif/core/lib/interfaces").OptionFlag<string | undefined, import("@oclif/core/lib/interfaces/parser").CustomOptions>;
+    };
+    static args: {
+        database: import("@oclif/core/lib/interfaces/parser").Arg<string | undefined, Record<string, unknown>>;
+        value: import("@oclif/core/lib/interfaces/parser").Arg<string | undefined, Record<string, unknown>>;
+    };
+    protected settingKey: SettingKey;
+    protected convertValue(val: BooleanAsString): boolean;
+    protected explain(setting: Setting<boolean>): string;
+}

package/lib/commands/pg/settings/explain-data-connector-details.js

@@ -0,0 +1,33 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const command_1 = require("@heroku-cli/command");
+const core_1 = require("@oclif/core");
+const tsheredoc_1 = require("tsheredoc");
+const setter_1 = require("../../../lib/pg/setter");
+class ExplainDataConnectorDetails extends setter_1.PGSettingsCommand {
+    constructor() {
+        super(...arguments);
+        this.settingKey = 'explain_data_connector_details';
+    }
+    convertValue(val) {
+        return (0, setter_1.booleanConverter)(val);
+    }
+    explain(setting) {
+        if (setting === null || setting === void 0 ? void 0 : setting.value) {
+            return 'Data replication slot details will be logged.';
+        }
+        return 'Data replication slot details will no longer be logged.';
+    }
+}
+exports.default = ExplainDataConnectorDetails;
+ExplainDataConnectorDetails.description = (0, tsheredoc_1.default)(`
+  displays stats on replication slots on your database, the default value is "off"
+  `);
+ExplainDataConnectorDetails.flags = {
+    app: command_1.flags.app({ required: true }),
+    remote: command_1.flags.remote(),
+};
+ExplainDataConnectorDetails.args = {
+    database: core_1.Args.string(),
+    value: core_1.Args.string(),
+};

package/lib/commands/pg/settings/log-min-error-statement.d.ts

@@ -0,0 +1,12 @@
+import { PGSettingsCommand } from '../../../lib/pg/setter';
+import type { Setting, SettingKey } from '../../../lib/pg/types';
+export default class LogMinErrorStatement extends PGSettingsCommand {
+    static description: string;
+    static args: {
+        database: import("@oclif/core/lib/interfaces/parser").Arg<string | undefined, Record<string, unknown>>;
+        value: import("@oclif/core/lib/interfaces/parser").Arg<string | undefined, Record<string, unknown>>;
+    };
+    protected settingKey: SettingKey;
+    protected convertValue(val: string): string;
+    protected explain(setting: Setting<string>): string;
+}

package/lib/commands/pg/settings/log-min-error-statement.js

@@ -0,0 +1,27 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const core_1 = require("@oclif/core");
+const tsheredoc_1 = require("tsheredoc");
+const setter_1 = require("../../../lib/pg/setter");
+class LogMinErrorStatement extends setter_1.PGSettingsCommand {
+    constructor() {
+        super(...arguments);
+        this.settingKey = 'log_min_error_statement';
+    }
+    convertValue(val) {
+        return val;
+    }
+    explain(setting) {
+        return setting.values[setting.value];
+    }
+}
+exports.default = LogMinErrorStatement;
+LogMinErrorStatement.description = (0, tsheredoc_1.default)(`
+    log-min-error-statement controls the logging of SQL statements that cause an error at a specified severity level.
+    This setting is useful to prevent logging SQL queries that might contain sensitive information.
+    Use this setting to prevent logging SQL queries that contain sensitive information. Default is "error".
+  `);
+LogMinErrorStatement.args = {
+    database: core_1.Args.string(),
+    value: core_1.Args.string({ options: ['error', 'log', 'fatal', 'panic'] }),
+};

package/lib/commands/run/index.js

@@ -10,13 +10,14 @@ const debug = (0, debug_1.default)('heroku:run');
 class Run extends command_1.Command {
     async run() {
         const { argv, flags } = await this.parse(Run);
-        const userArgvInputOrder = (0, helpers_1.revertSortedArgs)(process.argv, argv);
+        const maybeOptionsIndex = process.argv.indexOf('--');
+        const command = (0, helpers_1.buildCommand)((maybeOptionsIndex === -1 ? argv : process.argv.slice(maybeOptionsIndex + 1)));
         const opts = {
             'exit-code': flags['exit-code'],
             'no-tty': flags['no-tty'],
             app: flags.app,
             attach: true,
-            command: (0, helpers_1.buildCommand)(userArgvInputOrder),
+            command,
             env: flags.env,
             heroku: this.heroku,
             listen: flags.listen,

package/lib/lib/pg/types.d.ts

@@ -155,7 +155,7 @@ export declare type PgDatabaseConfig = {
         value: boolean;
     };
 };
-export declare type SettingKey = 'log_lock_waits' | 'log_connections' | 'log_min_duration_statement' | 'log_statement' | 'track_functions' | 'pgbouncer_max_client_conn' | 'pg_bouncer_max_db_conns' | 'pg_bouncer_default_pool_size' | 'auto_explain' | 'auto_explain.log_min_duration' | 'auto_explain.log_analyze' | 'auto_explain.log_triggers' | 'auto_explain.log_buffers' | 'auto_explain.log_verbose' | 'auto_explain.log_nested_statements';
+export declare type SettingKey = 'log_lock_waits' | 'log_connections' | 'log_min_duration_statement' | 'log_min_error_statement' | 'log_statement' | 'track_functions' | 'pgbouncer_max_client_conn' | 'pg_bouncer_max_db_conns' | 'pg_bouncer_default_pool_size' | 'explain_data_connector_details' | 'auto_explain' | 'auto_explain.log_min_duration' | 'auto_explain.log_analyze' | 'auto_explain.log_triggers' | 'auto_explain.log_buffers' | 'auto_explain.log_verbose' | 'auto_explain.log_nested_statements' | 'auto_explain.log_format';
 export declare type Setting<T> = {
     value: T;
     values: Record<string, string>;

package/lib/lib/run/helpers.d.ts

@@ -1,3 +1,2 @@
-export declare function revertSortedArgs(processArgs: Array<string>, argv: Array<string>): string[];
 export declare function buildCommand(args: Array<string>): string;
 export declare function buildEnvFromFlag(flag: string): {};

package/lib/lib/run/helpers.js

@@ -1,20 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.buildEnvFromFlag = exports.buildCommand = exports.revertSortedArgs = void 0;
+exports.buildEnvFromFlag = exports.buildCommand = void 0;
 /* eslint-disable @typescript-eslint/ban-ts-comment */
 const core_1 = require("@oclif/core");
-// this function exists because oclif sorts argv
-function revertSortedArgs(processArgs, argv) {
-    const originalInputOrder = [];
-    // this reorders the arguments in the order the user inputted
-    for (const processArg of processArgs) {
-        if (argv.includes(processArg)) {
-            originalInputOrder.push(processArg);
-        }
-    }
-    return originalInputOrder;
-}
-exports.revertSortedArgs = revertSortedArgs;
 function buildCommand(args) {
     if (args.length === 1) {
         // do not add quotes around arguments if there is only one argument