hermes-transform 0.36.1 → 0.37.0

package/dist/detachedNode.js

@@ -15,30 +15,16 @@ exports.updateAllParentPointers = updateAllParentPointers;
 
 var _hermesParser = require("hermes-parser");
 
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * 
- * @format
- */
 const DETACHED_MARKER = Symbol.for('hermes-transform - Detached AST Node');
 const ORIGINAL_NODE = Symbol.for('hermes-transform - Original Node');
 
 function isDetachedNode(node) {
-  // $FlowExpectedError[invalid-in-lhs] flow doesn't support symbols as keys
   return DETACHED_MARKER in node;
 }
 
 function getOriginalNode(node) {
-  // $FlowExpectedError[prop-missing]
   return node[ORIGINAL_NODE];
 }
-/* $FlowExpectedError[unclear-type] Type safety is not needed for generated
- * code, this avoids us always having to pass a generic property within codegen */
-
 
 function asDetachedNodeForCodeGen(node) {
   if (node == null) {
@@ -66,30 +52,13 @@ const asDetachedNode = (node, {
   }
 
   return useDeepClone ? deepCloneNode(node, {}) : shallowCloneNode(node, {});
-}; // used by the node type function codegen
-
+};
 
 exports.asDetachedNode = asDetachedNode;
 
 function detachedProps(parent, props, config = {}) {
-  // $FlowExpectedError[incompatible-type]
   const detachedNode = { ...props,
     ...((config == null ? void 0 : config.preserveLocation) !== true ? {
-      // if this is [0,0] AND the file has a docblock then prettier will insert newlines between
-      // certain detached nodes. Because of "intended" formatting behaviour (https://github.com/prettier/prettier/issues/12078)
-      // this can cause us to output weirdly formatted code that should have been collapsed.
-      //
-      // prettier works backwards from the position you give it to find newlines or non whitespace
-      // tokens and uses this to determine if newlines should be inserted between nodes.
-      // By placing the range at [1, 1] we can ensure a token is always found before a newline
-      // and therefore no newlines will be placed between nodes.
-      //
-      // NOTE: we will still run into the bug if there is weird code like a docblock with whitespace
-      //       characters before it. However we assume this isn't going to happen because any file
-      //       already formatted by prettier will have that whitespace removed.
-      // We considered a more complex solution involving traversing the AST and manually updating
-      // detached node ranges after mutations are applied - however this is a lot heavier and will
-      // probably never be needed.
       range: [1, 1],
       loc: {
         start: {
@@ -102,12 +71,8 @@ function detachedProps(parent, props, config = {}) {
         }
       }
     } : {}),
-    // if not provided, then we purposely don't set this here
-    // and will rely on the tooling to update it as appropriate.
-    // nothing should be reading from this before it's set anyway.
     parent: parent
-  }; // mark the node as detached
-
+  };
   Object.defineProperty(detachedNode, DETACHED_MARKER, {
     configurable: false,
     enumerable: false,
@@ -126,10 +91,6 @@ function detachedProps(parent, props, config = {}) {
 
   return detachedNode;
 }
-/**
- * Shallowly clones the node, but not its children.
- */
-
 
 function shallowCloneNode(node, newProps, config = {}) {
   var _config$preserveLocat, _config$originalNode;
@@ -141,37 +102,22 @@ function shallowCloneNode(node, newProps, config = {}) {
     originalNode: (_config$originalNode = config.originalNode) != null ? _config$originalNode : node
   });
 }
-/**
- * Deeply clones node and its entire tree.
- */
-
 
 function deepCloneNode(node, newProps) {
-  // $FlowFixMe[unsafe-object-assign]
   const clone = Object.assign(JSON.parse(JSON.stringify(node, (key, value) => {
-    // null out parent pointers
     if (key === 'parent') {
       return undefined;
     }
 
     return value;
   })), newProps);
-  updateAllParentPointers(clone); // $FlowExpectedError[class-object-subtyping]
-
+  updateAllParentPointers(clone);
   return detachedProps(null, clone);
 }
-/**
- * Corrects the parent pointers in direct children of the given node
- */
-
 
 function setParentPointersInDirectChildren(node) {
   _hermesParser.astNodeMutationHelpers.setParentPointersInDirectChildren(node);
 }
-/**
- * Traverses the entire subtree to ensure the parent pointers are set correctly
- */
-
 
 function updateAllParentPointers(node) {
   _hermesParser.astNodeMutationHelpers.updateAllParentPointers(node);

package/dist/detachedNode.js.flow

@@ -12,10 +12,10 @@ import type {BaseNode, ESNode} from 'hermes-estree';
 
 import {astNodeMutationHelpers} from 'hermes-parser';
 
-export opaque type DetachedNode<+T> = T;
-export type MaybeDetachedNode<+T> = T | DetachedNode<T>;
+export opaque type DetachedNode<out T> = T;
+export type MaybeDetachedNode<out T> = T | DetachedNode<T>;
 
-type DetachConfig = $ReadOnly<{
+type DetachConfig = Readonly<{
   preserveLocation?: boolean,
   originalNode?: ESNode,
 }>;
@@ -47,16 +47,16 @@ export function asDetachedNodeForCodeGen(node: any): ?DetachedNode<any> {
 }
 
 export const asDetachedNode: {
-  <T: ESNode>(
+  <T extends ESNode>(
     node: MaybeDetachedNode<T>,
     config?: {useDeepClone: boolean},
   ): DetachedNode<T>,
-  <T: ?ESNode>(
+  <T extends ?ESNode>(
     node: ?MaybeDetachedNode<T>,
     config?: {useDeepClone: boolean},
   ): ?DetachedNode<T>,
   // $FlowFixMe[incompatible-exact]
-} = <T: ESNode>(
+} = <T extends ESNode>(
   node: ?MaybeDetachedNode<T>,
   {useDeepClone}: {useDeepClone: boolean} = {useDeepClone: false},
 ): // $FlowExpectedError[incompatible-type]
@@ -65,7 +65,7 @@ export const asDetachedNode: {
     return null;
   }
 
-  if (isDetachedNode((node: MaybeDetachedNode<T>))) {
+  if (isDetachedNode(node as MaybeDetachedNode<T>)) {
     return node;
   }
 
@@ -75,7 +75,7 @@ export const asDetachedNode: {
 };
 
 // used by the node type function codegen
-export function detachedProps<T: BaseNode>(
+export function detachedProps<T extends BaseNode>(
   parent: ?ESNode,
   props: {...},
   config: DetachConfig = {},
@@ -116,7 +116,7 @@ export function detachedProps<T: BaseNode>(
     // if not provided, then we purposely don't set this here
     // and will rely on the tooling to update it as appropriate.
     // nothing should be reading from this before it's set anyway.
-    parent: (parent: $FlowFixMe),
+    parent: parent as $FlowFixMe,
   };
 
   // mark the node as detached
@@ -142,14 +142,14 @@ export function detachedProps<T: BaseNode>(
 /**
  * Shallowly clones the node, but not its children.
  */
-export function shallowCloneNode<T: ESNode>(
+export function shallowCloneNode<T extends ESNode>(
   node: T,
   newProps: {...},
   config?: DetachConfig = {},
 ): DetachedNode<T> {
   return detachedProps<T>(
     null,
-    {...(node: $FlowFixMe), ...newProps},
+    {...(node as $FlowFixMe), ...newProps},
     {
       preserveLocation: config.preserveLocation ?? true,
       originalNode: config.originalNode ?? node,
@@ -160,7 +160,7 @@ export function shallowCloneNode<T: ESNode>(
 /**
  * Deeply clones node and its entire tree.
  */
-export function deepCloneNode<T: ESNode>(
+export function deepCloneNode<T extends ESNode>(
   node: T,
   newProps: {...},
 ): DetachedNode<T> {

package/dist/generated/TransformCloneSignatures.js.flow

@@ -17,7 +17,7 @@
 
 // lint directives to let us do some basic validation of generated files
 /* eslint no-undef: 'error', no-unused-vars: ['error', {vars: "local"}], no-redeclare: 'error' */
-/* global $NonMaybeType, Partial, $ReadOnly, $ReadOnlyArray, $FlowFixMe */
+/* global NonNullable, Partial, Readonly, ReadonlyArray, $FlowFixMe */
 
 'use strict';
 

package/dist/generated/TransformModifySignatures.js.flow

@@ -17,7 +17,7 @@
 
 // lint directives to let us do some basic validation of generated files
 /* eslint no-undef: 'error', no-unused-vars: ['error', {vars: "local"}], no-redeclare: 'error' */
-/* global $NonMaybeType, Partial, $ReadOnly, $ReadOnlyArray, $FlowFixMe */
+/* global NonNullable, Partial, Readonly, ReadonlyArray, $FlowFixMe */
 
 'use strict';