hereby 1.4.1 → 1.4.2

package/dist/cli/loadHerebyfile.js

@@ -3,7 +3,6 @@ import fs from "fs/promises";
 import path from "path";
 import { pathToFileURL } from "url";
 import { Task } from "../index.js";
-import { forEachTask } from "../utils.js";
 import { UserError } from "./utils.js";
 const filenames = ["Herebyfile", "herebyfile"];
 const extensions = ["mjs", "js"];
@@ -56,20 +55,37 @@ export async function loadHerebyfile(herebyfilePath) {
     const tasks = Array.from(exportedTasks.values());
     // We check this here by walking the DAG, as some dependencies may not be
     // exported and therefore would not be seen by the above loop.
-    assertUniqueNames(tasks);
+    checkTaskInvariants(tasks);
     return {
         tasks,
         defaultTask,
     };
 }
-function assertUniqueNames(tasks) {
-    const names = new Set();
-    forEachTask(tasks, (task) => {
-        const name = task.options.name;
-        if (names.has(name)) {
-            throw new UserError(`Task "${chalk.blue(name)}" was declared twice.`);
+function checkTaskInvariants(tasks) {
+    const checkedTasks = new Set();
+    const taskStack = new Set();
+    const seenNames = new Set();
+    checkTaskInvariantsWorker(tasks);
+    function checkTaskInvariantsWorker(tasks) {
+        for (const task of tasks) {
+            if (checkedTasks.has(task)) {
+                continue;
+            }
+            if (taskStack.has(task)) {
+                throw new UserError(`Task "${chalk.blue(task.options.name)}" references itself.`);
+            }
+            const name = task.options.name;
+            if (seenNames.has(name)) {
+                throw new UserError(`Task "${chalk.blue(name)}" was declared twice.`);
+            }
+            seenNames.add(name);
+            if (task.options.dependencies) {
+                taskStack.add(task);
+                checkTaskInvariantsWorker(task.options.dependencies);
+                taskStack.delete(task);
+            }
+            checkedTasks.add(task);
         }
-        names.add(name);
-    });
+    }
 }
 //# sourceMappingURL=loadHerebyfile.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "hereby",
-    "version": "1.4.1",
+    "version": "1.4.2",
     "description": "A simple task runner",
     "repository": "github:jakebailey/hereby",
     "type": "module",

package/dist/utils.js

@@ -1,13 +0,0 @@
-export function forEachTask(tasks, fn, seen = new Set()) {
-    tasks.forEach(visit);
-    return;
-    function visit(task) {
-        if (seen.has(task)) {
-            return;
-        }
-        seen.add(task);
-        fn(task);
-        task.options.dependencies?.forEach(visit);
-    }
-}
-//# sourceMappingURL=utils.js.map