helloloop 0.3.1 → 0.7.0

package/src/completion_review.mjs

@@ -0,0 +1,243 @@
+import path from "node:path";
+
+import { formatList, tailText } from "./common.mjs";
+import { runEngineTask } from "./process.mjs";
+
+function section(title, content) {
+  if (!content || !String(content).trim()) {
+    return "";
+  }
+  return `## ${title}\n${String(content).trim()}\n`;
+}
+
+function listSection(title, items) {
+  if (!Array.isArray(items) || !items.length) {
+    return "";
+  }
+  return section(title, formatList(items));
+}
+
+function normalizeDocEntry(doc) {
+  return String(doc || "").trim().replaceAll("\\", "/");
+}
+
+function normalizeDocList(items) {
+  const result = [];
+  const seen = new Set();
+
+  for (const item of items || []) {
+    const normalized = normalizeDocEntry(item);
+    if (!normalized) {
+      continue;
+    }
+
+    const key = normalized.toLowerCase();
+    if (seen.has(key)) {
+      continue;
+    }
+    seen.add(key);
+    result.push(normalized);
+  }
+
+  return result;
+}
+
+function renderVerifyResultLines(verifyResult) {
+  if (!verifyResult?.results?.length) {
+    return [
+      "- 未执行额外验证命令",
+    ];
+  }
+
+  return verifyResult.results.map((item) => {
+    const stdoutTail = tailText(item.stdout, 6) || "无";
+    const stderrTail = tailText(item.stderr, 6) || "无";
+    return [
+      `- ${item.ok ? "通过" : "失败"}：${item.command}`,
+      `  stdout: ${stdoutTail}`,
+      `  stderr: ${stderrTail}`,
+    ].join("\n");
+  });
+}
+
+function buildTaskReviewPrompt({
+  task,
+  requiredDocs = [],
+  constraints = [],
+  repoStateText = "",
+  engineFinalMessage = "",
+  verifyResult = null,
+}) {
+  const allDocs = normalizeDocList([
+    ...requiredDocs,
+    ...(task.docs || []),
+  ]);
+
+  return [
+    "你要做的是“任务完成复核”，目标是判断当前任务是否真的已经完成。",
+    "不要相信执行代理口头说“已完成”；必须直接检查仓库当前代码、测试和产物。",
+    "如果只是做到一半、只改了部分文件、或者验收条件仍缺项，都不能判定为完成。",
+    "",
+    section("当前任务", [
+      `- 标题：${task.title}`,
+      `- 编号：${task.id}`,
+      `- 目标：${task.goal || "按文档完成当前工作包。"}`,
+      `- 风险：${task.risk || "low"}`,
+    ].join("\n")),
+    listSection("开发文档", allDocs),
+    listSection("涉及路径", task.paths || []),
+    listSection("验收条件", task.acceptance || []),
+    constraints.length ? listSection("项目约束", constraints) : "",
+    repoStateText ? section("当前仓库状态摘要", repoStateText) : "",
+    engineFinalMessage
+      ? section("执行代理最后输出", tailText(engineFinalMessage, 20))
+      : "",
+    section("验证结果", renderVerifyResultLines(verifyResult).join("\n")),
+    section("判定规则", [
+      "1. 只有当所有验收条件都有明确仓库证据支撑时，才能输出 `complete`。",
+      "2. 只要有任一验收条件未满足、证据不足、或只能部分成立，就输出 `incomplete`。",
+      "3. 只有外部权限、环境损坏、文档缺口、不可获得依赖等真正硬阻塞，才允许输出 `blocked`。",
+      "4. “代理提前停止”“只完成一部分”“建议下次继续”都属于 `incomplete`，不是 `blocked`。",
+      "5. 不要给泛泛建议，`missing` 和 `nextAction` 必须直接指出还差什么。",
+    ].join("\n")),
+    section("输出要求", [
+      "1. 严格输出 JSON，不要带 Markdown 代码块。",
+      "2. `verdict` 只能是 `complete`、`incomplete`、`blocked`。",
+      "3. `acceptanceChecks` 必须逐条覆盖本任务所有验收条件。",
+      "4. `acceptanceChecks[].status` 只能是 `met`、`not_met`、`uncertain`。",
+      "5. `acceptanceChecks[].evidence` 必须写具体证据或缺口，不能只写“已完成”。",
+      "6. 若 `verdict=complete`，则所有 `acceptanceChecks[].status` 必须都是 `met`，且 `missing` 为空。",
+      "7. 若 `verdict=blocked`，`blockerReason` 必须明确写出硬阻塞原因。",
+    ].join("\n")),
+  ].filter(Boolean).join("\n");
+}
+
+function normalizeAcceptanceCheck(check) {
+  return {
+    item: String(check?.item || "").trim(),
+    status: ["met", "not_met", "uncertain"].includes(String(check?.status || ""))
+      ? String(check.status)
+      : "uncertain",
+    evidence: String(check?.evidence || "").trim() || "未提供可用证据。",
+  };
+}
+
+function normalizeTaskReviewPayload(payload, task) {
+  const requestedAcceptance = Array.isArray(task?.acceptance)
+    ? task.acceptance.map((item) => String(item || "").trim()).filter(Boolean)
+    : [];
+  const receivedChecks = Array.isArray(payload?.acceptanceChecks)
+    ? payload.acceptanceChecks.map((item) => normalizeAcceptanceCheck(item)).filter((item) => item.item)
+    : [];
+
+  const normalizedChecks = requestedAcceptance.map((item) => {
+    const matched = receivedChecks.find((check) => check.item === item);
+    return matched || {
+      item,
+      status: "uncertain",
+      evidence: "复核结果未覆盖该验收条件。",
+    };
+  });
+
+  const missing = Array.isArray(payload?.missing)
+    ? payload.missing.map((item) => String(item || "").trim()).filter(Boolean)
+    : [];
+  const blockerReason = String(payload?.blockerReason || "").trim();
+  const requestedVerdict = ["complete", "incomplete", "blocked"].includes(String(payload?.verdict || ""))
+    ? String(payload.verdict)
+    : "incomplete";
+  const hasUnmetAcceptance = normalizedChecks.some((item) => item.status !== "met");
+  const verdict = requestedVerdict === "complete" && (hasUnmetAcceptance || missing.length)
+    ? "incomplete"
+    : requestedVerdict;
+
+  return {
+    verdict,
+    summary: String(payload?.summary || "").trim() || "任务完成复核已结束。",
+    acceptanceChecks: normalizedChecks,
+    missing,
+    blockerReason,
+    nextAction: String(payload?.nextAction || "").trim() || "请根据缺口继续完成当前任务。",
+    isComplete: verdict === "complete" && !hasUnmetAcceptance && missing.length === 0,
+  };
+}
+
+export function renderTaskReviewSummary(review) {
+  const acceptanceLines = review.acceptanceChecks.map((item) => (
+    `- ${item.status === "met" ? "已满足" : (item.status === "not_met" ? "未满足" : "待确认")}：${item.item}；${item.evidence}`
+  ));
+
+  return [
+    `任务复核结论：${review.summary}`,
+    ...acceptanceLines,
+    ...(review.missing.length
+      ? review.missing.map((item) => `- 剩余缺口：${item}`)
+      : []),
+    review.blockerReason ? `- 硬阻塞：${review.blockerReason}` : "",
+    `- 下一动作：${review.nextAction}`,
+  ].filter(Boolean).join("\n");
+}
+
+export async function reviewTaskCompletion({
+  engine,
+  context,
+  task,
+  requiredDocs = [],
+  constraints = [],
+  repoStateText = "",
+  engineFinalMessage = "",
+  verifyResult = null,
+  runDir,
+  policy = {},
+}) {
+  const prompt = buildTaskReviewPrompt({
+    task,
+    requiredDocs,
+    constraints,
+    repoStateText,
+    engineFinalMessage,
+    verifyResult,
+  });
+  const schemaFile = path.join(context.templatesDir, "task-review-output.schema.json");
+  const reviewResult = await runEngineTask({
+    engine,
+    context,
+    prompt,
+    runDir,
+    policy,
+    executionMode: "analyze",
+    outputSchemaFile: schemaFile,
+    outputPrefix: `${engine}-task-review`,
+    skipGitRepoCheck: true,
+  });
+
+  if (!reviewResult.ok) {
+    return {
+      ok: false,
+      code: "task_review_failed",
+      summary: reviewResult.stderr || reviewResult.stdout || "任务完成复核失败。",
+      raw: reviewResult,
+    };
+  }
+
+  let payload;
+  try {
+    payload = JSON.parse(reviewResult.finalMessage);
+  } catch (error) {
+    return {
+      ok: false,
+      code: "invalid_task_review_json",
+      summary: `任务完成复核结果无法解析为 JSON：${String(error?.message || error || "")}`,
+      raw: reviewResult,
+    };
+  }
+
+  const review = normalizeTaskReviewPayload(payload, task);
+  return {
+    ok: true,
+    code: "task_reviewed",
+    review,
+    summary: renderTaskReviewSummary(review),
+    raw: reviewResult,
+  };
+}

package/src/config.mjs

@@ -15,8 +15,19 @@ const defaultPolicy = {
   maxLoopTasks: 4,
   maxTaskAttempts: 2,
   maxTaskStrategies: 4,
+  maxReanalysisPasses: 3,
   stopOnFailure: false,
   stopOnHighRisk: true,
+  runtimeRecovery: {
+    enabled: true,
+    heartbeatIntervalSeconds: 60,
+    stallWarningSeconds: 900,
+    maxIdleSeconds: 2700,
+    killGraceSeconds: 10,
+    healthProbeTimeoutSeconds: 120,
+    hardRetryDelaysSeconds: [900, 900, 900, 900, 900],
+    softRetryDelaysSeconds: [900, 900, 900, 900, 900, 1800, 1800, 3600, 5400, 7200, 9000, 10800],
+  },
   codex: {
     model: "",
     executable: "",
@@ -24,6 +35,20 @@ const defaultPolicy = {
     dangerouslyBypassSandbox: false,
     jsonOutput: true,
   },
+  claude: {
+    model: "",
+    executable: "",
+    permissionMode: "bypassPermissions",
+    analysisPermissionMode: "plan",
+    outputFormat: "text",
+  },
+  gemini: {
+    model: "",
+    executable: "",
+    approvalMode: "yolo",
+    analysisApprovalMode: "plan",
+    outputFormat: "text",
+  },
 };
 
 const defaultPlanner = {
@@ -46,6 +71,24 @@ export function loadPolicy(context) {
     ...defaultPolicy.codex,
     ...(policy.codex || {}),
   };
+  policy.claude = {
+    ...defaultPolicy.claude,
+    ...(policy.claude || {}),
+  };
+  policy.gemini = {
+    ...defaultPolicy.gemini,
+    ...(policy.gemini || {}),
+  };
+  policy.runtimeRecovery = {
+    ...defaultPolicy.runtimeRecovery,
+    ...(policy.runtimeRecovery || {}),
+    hardRetryDelaysSeconds: Array.isArray(policy?.runtimeRecovery?.hardRetryDelaysSeconds)
+      ? policy.runtimeRecovery.hardRetryDelaysSeconds
+      : defaultPolicy.runtimeRecovery.hardRetryDelaysSeconds,
+    softRetryDelaysSeconds: Array.isArray(policy?.runtimeRecovery?.softRetryDelaysSeconds)
+      ? policy.runtimeRecovery.softRetryDelaysSeconds
+      : defaultPolicy.runtimeRecovery.softRetryDelaysSeconds,
+  };
   return policy;
 }
 
@@ -54,6 +97,8 @@ export function loadProjectConfig(context) {
     return {
       requiredDocs: [],
       constraints: [],
+      defaultEngine: "",
+      lastSelectedEngine: "",
       planner: defaultPlanner,
     };
   }
@@ -62,6 +107,8 @@ export function loadProjectConfig(context) {
   return {
     requiredDocs: Array.isArray(config.requiredDocs) ? config.requiredDocs : [],
     constraints: Array.isArray(config.constraints) ? config.constraints : [],
+    defaultEngine: typeof config.defaultEngine === "string" ? config.defaultEngine : "",
+    lastSelectedEngine: typeof config.lastSelectedEngine === "string" ? config.lastSelectedEngine : "",
     planner: {
       ...defaultPlanner,
       ...(config.planner || {}),
@@ -87,6 +134,10 @@ export function saveBacklog(context, backlog) {
   });
 }
 
+export function saveProjectConfig(context, config) {
+  writeJson(context.projectFile, config);
+}
+
 export function loadVerifyCommands(context) {
   const raw = readTextIfExists(context.repoVerifyFile, "");
   return raw

package/src/discovery.mjs

@@ -1,3 +1,4 @@
+import os from "node:os";
 import path from "node:path";
 
 import { expandDocumentEntries } from "./doc_loader.mjs";
@@ -49,6 +50,11 @@ const DOCS_SOURCE_META = {
   repo_docs: { label: "仓库 docs 目录", confidence: "medium" },
 };
 
+function isImplicitHomeDirectory(targetPath) {
+  return Boolean(targetPath)
+    && path.resolve(targetPath) === path.resolve(os.homedir());
+}
+
 function pushBasis(basis, message) {
   if (message && !basis.includes(message)) {
     basis.push(message);
@@ -127,6 +133,10 @@ export function discoverWorkspace(options = {}) {
   const explicitRepoRoot = options.repoRoot ? resolveAbsolute(options.repoRoot, cwd) : "";
   const explicitDocsPath = options.docsPath ? resolveAbsolute(options.docsPath, cwd) : "";
   const explicitInputPath = options.inputPath ? resolveAbsolute(options.inputPath, cwd) : "";
+  const treatCwdAsHomeWorkspace = !explicitRepoRoot
+    && !explicitDocsPath
+    && !explicitInputPath
+    && isImplicitHomeDirectory(cwd);
 
   if (explicitRepoRoot && !pathExists(explicitRepoRoot)) {
     if (!allowNewRepoRoot) {
@@ -196,13 +206,15 @@ export function discoverWorkspace(options = {}) {
   }
 
   if (!repoRoot && !docsEntries.length) {
-    const cwdRepoRoot = findRepoRootFromPath(cwd);
+    const cwdRepoRoot = treatCwdAsHomeWorkspace ? "" : findRepoRootFromPath(cwd);
     if (cwdRepoRoot) {
       repoRoot = cwdRepoRoot;
       repoSource = "cwd_repo";
       pushBasis(repoBasis, "当前终端目录已经位于一个项目仓库内。");
     } else {
-      const cwdClassified = classifyExplicitPath(cwd);
+      const cwdClassified = treatCwdAsHomeWorkspace
+        ? { kind: "workspace", absolutePath: cwd }
+        : classifyExplicitPath(cwd);
       if (cwdClassified.kind === "docs") {
         docsEntries = [cwdClassified.absolutePath];
         docsSource = "cwd_docs";
@@ -373,6 +385,13 @@ export function resolveRepoRoot(options = {}) {
     return { ok: false, message: renderMissingRepoMessage([classified.absolutePath], inferred.candidates) };
   }
 
+  if (!explicitRepoRoot && !explicitInputPath && isImplicitHomeDirectory(cwd)) {
+    return {
+      ok: false,
+      message: "当前目录看起来是用户主目录；HelloLoop 不会把主目录自动当作项目仓库。请切到项目目录，或传入一个项目路径/开发文档路径。",
+    };
+  }
+
   const repoRoot = findRepoRootFromPath(cwd);
   if (repoRoot) {
     return { ok: true, repoRoot };

package/src/discovery_prompt.mjs

@@ -1,6 +1,5 @@
 import fs from "node:fs";
 import path from "node:path";
-import { createInterface } from "node:readline/promises";
 
 import {
   listDocFilesInDirectory,
@@ -8,38 +7,14 @@ import {
   pathExists,
   resolveAbsolute,
 } from "./discovery_paths.mjs";
+import { createPromptSession } from "./prompt_session.mjs";
 
 function toDisplayPath(targetPath) {
   return String(targetPath || "").replaceAll("\\", "/");
 }
 
 export function createDiscoveryPromptSession() {
-  if (process.stdin.isTTY) {
-    const readline = createInterface({
-      input: process.stdin,
-      output: process.stdout,
-    });
-    return {
-      async question(promptText) {
-        return readline.question(promptText);
-      },
-      close() {
-        readline.close();
-      },
-    };
-  }
-
-  const bufferedAnswers = fs.readFileSync(0, "utf8").split(/\r?\n/);
-  let answerIndex = 0;
-  return {
-    async question(promptText) {
-      process.stdout.write(promptText);
-      const answer = bufferedAnswers[answerIndex] ?? "";
-      answerIndex += 1;
-      return answer;
-    },
-    close() {},
-  };
+  return createPromptSession();
 }
 
 function summarizeList(items, options = {}) {