helloagents 3.0.33 → 3.0.37

package/scripts/notify-closeout.mjs

@@ -1,15 +1,56 @@
 import { createHash } from 'node:crypto'
 import { closeSync, mkdirSync, openSync, readFileSync, statSync, unlinkSync, writeFileSync } from 'node:fs'
-import { dirname } from 'node:path'
+import { dirname, join } from 'node:path'
+import { homedir } from 'node:os'
 
-import { getRuntimeEvidencePath, readRuntimeEvidence, writeRuntimeEvidence } from './runtime-artifacts.mjs'
-
-export const CODEX_CLOSEOUT_EVIDENCE_FILE = 'codex-native-stop.json'
-export const CODEX_QUICK_NOTIFY_EVIDENCE_FILE = 'codex-quick-notify.json'
-const CODEX_CLOSEOUT_LOCK_FILE = 'codex-native-stop.lock'
+export const CODEX_NOTIFY_STATE_FILE = 'notify-state.json'
+export const CODEX_NOTIFY_LOCK_FILE = 'notify.lock'
 const WEAK_KEY_TTL_MS = 10_000
 const LOCK_STALE_MS = 120_000
 
+function getHomeDir(env = process.env) {
+  return env.HOME || env.USERPROFILE || homedir()
+}
+
+export function getCodexNotifyDir(env = process.env) {
+  return join(getHomeDir(env), '.codex', '.helloagents')
+}
+
+export function getCodexNotifyStatePath(env = process.env) {
+  return join(getCodexNotifyDir(env), CODEX_NOTIFY_STATE_FILE)
+}
+
+export function getCodexNotifyLockPath(env = process.env) {
+  return join(getCodexNotifyDir(env), CODEX_NOTIFY_LOCK_FILE)
+}
+
+function readNotifyState(env = process.env) {
+  try {
+    const value = JSON.parse(readFileSync(getCodexNotifyStatePath(env), 'utf-8'))
+    if (!value || typeof value !== 'object' || Array.isArray(value)) {
+      return { version: 1, nativeStop: null, quickNotify: null }
+    }
+    return {
+      version: 1,
+      nativeStop: value.nativeStop && typeof value.nativeStop === 'object' ? value.nativeStop : null,
+      quickNotify: value.quickNotify && typeof value.quickNotify === 'object' ? value.quickNotify : null,
+    }
+  } catch {
+    return { version: 1, nativeStop: null, quickNotify: null }
+  }
+}
+
+function writeNotifyState(state, env = process.env) {
+  const filePath = getCodexNotifyStatePath(env)
+  mkdirSync(dirname(filePath), { recursive: true })
+  writeFileSync(filePath, `${JSON.stringify({
+    version: 1,
+    nativeStop: state?.nativeStop || null,
+    quickNotify: state?.quickNotify || null,
+  }, null, 2)}\n`, 'utf-8')
+  return filePath
+}
+
 function getTurnId(payload = {}) {
   return String(payload.turnId || payload.turn_id || payload['turn-id'] || '').trim()
 }
@@ -118,13 +159,10 @@ export function matchesCodexCloseoutEvidence(evidence, snapshot, now = Date.now(
   return intersects(snapshot.weakKeys, weakKeys)
 }
 
-/**
- * Try to claim the current Codex closeout so Stop and native notify handle one turn only once.
- */
 export function beginCodexCloseoutClaim(cwd, { payload = {}, turnState = null, source = '' } = {}) {
   const snapshot = buildCodexCloseoutSnapshot({ payload, turnState })
-  const lockPath = getRuntimeEvidencePath(cwd, CODEX_CLOSEOUT_LOCK_FILE, { payload })
-  const evidencePath = getRuntimeEvidencePath(cwd, CODEX_CLOSEOUT_EVIDENCE_FILE, { payload })
+  const lockPath = getCodexNotifyLockPath()
+  const evidencePath = getCodexNotifyStatePath()
   const now = Date.now()
   const lockPayload = {
     source,
@@ -164,8 +202,8 @@ export function beginCodexCloseoutClaim(cwd, { payload = {}, turnState = null, s
     }
   }
 
-  const evidence = readRuntimeEvidence(cwd, CODEX_CLOSEOUT_EVIDENCE_FILE, { payload })
-  if (matchesCodexCloseoutEvidence(evidence, snapshot, now)) {
+  const notifyState = readNotifyState()
+  if (matchesCodexCloseoutEvidence(notifyState.nativeStop, snapshot, now)) {
     releaseLockFile(lockPath)
     return {
       claimed: false,
@@ -186,15 +224,13 @@ export function beginCodexCloseoutClaim(cwd, { payload = {}, turnState = null, s
   }
 }
 
-/**
- * Persist the handled closeout fingerprint and release the in-flight lock.
- */
 export function finalizeCodexCloseoutClaim(claim, meta = {}) {
   if (!claim?.claimed) return
 
   try {
     if (meta.handled !== false) {
-      writeRuntimeEvidence(claim.cwd, CODEX_CLOSEOUT_EVIDENCE_FILE, {
+      const notifyState = readNotifyState()
+      notifyState.nativeStop = {
         version: 2,
         updatedAt: new Date().toISOString(),
         source: meta.source || claim.source || '',
@@ -205,7 +241,8 @@ export function finalizeCodexCloseoutClaim(claim, meta = {}) {
         messageHash: claim.snapshot.messageHash,
         strongKeys: claim.snapshot.strongKeys,
         weakKeys: claim.snapshot.weakKeys,
-      }, { payload: claim.payload })
+      }
+      writeNotifyState(notifyState)
     }
   } finally {
     releaseLockFile(claim.lockPath)
@@ -214,7 +251,8 @@ export function finalizeCodexCloseoutClaim(claim, meta = {}) {
 
 export function writeCodexQuickNotifyEvidence(cwd, { payload = {}, turnState = null, event = '' } = {}) {
   const snapshot = buildCodexCloseoutSnapshot({ payload, turnState })
-  return writeRuntimeEvidence(cwd, CODEX_QUICK_NOTIFY_EVIDENCE_FILE, {
+  const notifyState = readNotifyState()
+  notifyState.quickNotify = {
     version: 1,
     updatedAt: new Date().toISOString(),
     event,
@@ -223,11 +261,12 @@ export function writeCodexQuickNotifyEvidence(cwd, { payload = {}, turnState = n
     messageHash: snapshot.messageHash,
     strongKeys: snapshot.strongKeys,
     weakKeys: snapshot.weakKeys,
-  }, { payload })
+  }
+  return writeNotifyState(notifyState)
 }
 
 export function hasCodexQuickNotifyEvidence(cwd, { payload = {}, turnState = null } = {}) {
   const snapshot = buildCodexCloseoutSnapshot({ payload, turnState })
-  const evidence = readRuntimeEvidence(cwd, CODEX_QUICK_NOTIFY_EVIDENCE_FILE, { payload })
-  return matchesCodexCloseoutEvidence(evidence, snapshot)
+  const notifyState = readNotifyState()
+  return matchesCodexCloseoutEvidence(notifyState.quickNotify, snapshot)
 }

package/scripts/notify-context.mjs

@@ -11,7 +11,7 @@ import {
 const COMMAND_ALIASES = {
   do: 'build',
   design: 'plan',
-  review: 'verify',
+  review: 'qa',
 };
 
 function buildRuntimeRootBlock(pkgRoot) {
@@ -49,7 +49,7 @@ function buildAliasRouteNote(skillName) {
     return '兼容别名映射：本次按 ~plan 规则执行；方案文件使用 `plan.md`，项目级 UI 契约仍使用 `DESIGN.md`。';
   }
   if (skillName === 'review') {
-    return '兼容别名映射：本次按 ~verify 的审查优先模式执行。';
+    return '兼容别名映射：本次按 ~qa 规则执行；统一走 qa-review 质量闭环。';
   }
   return '';
 }
@@ -137,7 +137,7 @@ export function buildInjectContext({ source, bootstrap, settings, pkgRoot, host,
   if (capabilityHint) context += `\n\n## 当前按需能力\n${capabilityHint}`;
   if (stateSyncHint) context += `\n\n## 状态文件提醒\n${stateSyncHint}`;
   context += settingsBlock;
-  if (source === 'resume' || source === 'compact') {
+  if ((source === 'resume' || source === 'compact') && stateSnapshot.exists) {
     context += `\n\n> ⚠️ 会话已恢复/压缩，请先读取 \`state_path\` 指向的 \`${stateSnapshot.statePath.replace(/\\/g, '/')}\`；先看当前用户消息，如果仍是同一任务，再参考状态文件。`;
   }
   return context;
@@ -165,8 +165,8 @@ export function buildSemanticRouteInstruction(cwd, payload = {}) {
     '请根据用户请求的真实意图选路，不依赖关键词表。',
     buildDelegatedTaskHint(),
     'Delivery Tier: T0=探索/比较；T1=低风险小改动或显式验证；T2=多文件功能/新项目/需要结构化产物；T3=高风险或不可逆操作。',
-    '路由映射：~idea=只读探索，不创建文件；~build=明确实现；~verify=审查/验证；~plan=结构化规划；~prd=重型规格；~auto=自动选择并继续执行后续阶段。',
-    '若判定为 T3，默认先走 ~plan / ~prd；纯审查/验证请求才优先 ~verify。',
+    '路由映射：~idea=只读探索，不创建文件；~build=明确实现；~qa=统一质量审查/验证/修复/收尾；~plan=结构化规划；~prd=重型规格；~auto=自动选择并继续执行后续阶段。',
+    '若判定为 T3，默认先走 ~plan / ~prd；纯质量审查、验真或收尾请求才优先 ~qa。',
     `涉及 UI 任务时，设计决策优先级：当前活跃 plan / PRD → ${describeProjectStoreFile(cwd, 'DESIGN.md')} → 已读取的 hello-ui 规则；同时所有 UI 任务都必须满足 UI 质量基线。`,
     projectStorageHint,
     workflowHint ? `项目状态：${workflowHint}` : '',

package/scripts/notify-route.mjs

@@ -22,7 +22,7 @@ function shouldBypassRoute(prompt) {
 
 function buildHelpExtraRules(skillName) {
   if (skillName !== 'help') return ''
-  return ' 这是 HelloAGENTS 的帮助命令，不是宿主 CLI 的内置帮助。仅显示 HelloAGENTS 的帮助和当前设置；优先使用当前会话上下文中已注入的“当前用户设置”、配置文件原始 JSON 或此前读取结果摘要，上下文不存在或缺少要展示的配置项时才读取一次 ~/.helloagents/helloagents.json；自动激活技能说明仅在全局模式或已初始化项目时生效。不要调用宿主 CLI 的帮助工具（如 cli_help 或 /help），不要使用子代理，不要读取项目文件；若受工作区限制无法读取配置，必须明确说明并按已知默认值或已注入设置展示。'
+  return ' 这是 HelloAGENTS 的帮助命令，不是宿主 CLI 的内置帮助。仅显示 HelloAGENTS 的帮助和当前设置；优先使用当前会话上下文中已注入的“当前用户设置”、配置文件原始 JSON 或此前读取结果摘要，上下文不存在或缺少要展示的配置项时才读取一次 ~/.helloagents/helloagents.json；自动激活技能说明仅在宿主全局模式或已初始化项目时生效。不要调用宿主 CLI 的帮助工具（如 cli_help 或 /help），不要使用子代理，不要读取项目文件；若受工作区限制无法读取配置，必须明确说明并按已知默认值或已注入设置展示。'
 }
 
 function routeExplicitCommand({

package/scripts/notify-sound.mjs

@@ -24,7 +24,8 @@ export function buildWindowsSoundCommand(filePath = '') {
 }
 
 function playWindows(filePath) {
-  const result = spawnSync('powershell', [
+  const command = process.platform === 'win32' ? 'powershell.exe' : 'powershell'
+  const result = spawnSync(command, [
     '-NoProfile',
     '-c',
     buildWindowsSoundCommand(filePath),

package/scripts/notify.mjs

@@ -41,7 +41,7 @@ const EVENT_NAME = {
   UserPromptSubmit: IS_GEMINI ? 'BeforeAgent' : 'UserPromptSubmit',
   PreCompact: IS_GEMINI ? 'BeforeAgent' : 'PreCompact',
 };
-const RALPH_LOOP_ROUTE_COMMANDS = new Set(['verify', 'loop']);
+const RALPH_LOOP_ROUTE_COMMANDS = new Set(['qa', 'loop']);
 const CODEX_HOOKS_FILE = join(homedir(), '.codex', 'hooks.json');
 const GATE_MODULE_LOADERS = {
   'turn-stop-gate': () => import('./turn-stop-gate.mjs'),
@@ -459,7 +459,7 @@ function cmdInject() {
   const cwd = payload.cwd || process.cwd();
   const settings = getSettings();
   const bootstrapFile = resolveBootstrapFile(cwd, settings, HOST);
-  const shouldEnsureProjectLocal = bootstrapFile === 'bootstrap.md' || source === 'resume' || source === 'compact';
+  const shouldEnsureProjectLocal = isProjectRuntimeActive(cwd);
 
   startReplaySession(cwd, {
     host: HOST,

package/scripts/plan-contract.mjs

@@ -4,7 +4,7 @@ import { fileURLToPath } from 'node:url'
 import { resolveProjectPlanDir } from './project-storage.mjs'
 
 export const PLAN_CONTRACT_FILE_NAME = 'contract.json'
-const VALID_VERIFY_MODES = new Set(['test-first', 'review-first'])
+const VALID_QA_MODES = new Set(['standard', 'deep'])
 const VALID_ADVISOR_SOURCES = new Set(['claude', 'codex', 'gemini'])
 
 function normalizeStringArray(values) {
@@ -14,9 +14,9 @@ function normalizeStringArray(values) {
     .filter(Boolean))]
 }
 
-function normalizeVerifyMode(value) {
+function normalizeQaMode(value) {
   const normalized = typeof value === 'string' ? value.trim().toLowerCase() : ''
-  return VALID_VERIFY_MODES.has(normalized) ? normalized : ''
+  return VALID_QA_MODES.has(normalized) ? normalized : ''
 }
 
 function normalizeUiStyleAdvisorContract(input = {}) {
@@ -88,12 +88,11 @@ export function readPlanContract(planDir) {
 
 export function normalizePlanContract(input = {}) {
   return {
-    version: 1,
+    version: 2,
     source: typeof input.source === 'string' && input.source.trim() ? input.source.trim() : 'manual',
     originCommand: typeof input.originCommand === 'string' ? input.originCommand.trim() : '',
-    verifyMode: normalizeVerifyMode(input.verifyMode),
-    reviewerFocus: normalizeStringArray(input.reviewerFocus),
-    testerFocus: normalizeStringArray(input.testerFocus),
+    qaMode: normalizeQaMode(input.qaMode),
+    qaFocus: normalizeStringArray(input.qaFocus),
     ui: normalizeUiContract(input.ui),
     advisor: normalizeAdvisorContract(input.advisor),
   }
@@ -128,14 +127,11 @@ export function getPlanContractIssues(contract = null) {
   const advisorRequirement = getAdvisorRequirement(normalized)
   const visualValidation = getVisualValidationRequirement(normalized)
   const issues = []
-  if (!normalizeVerifyMode(normalized.verifyMode)) {
-    issues.push('contract.json missing valid verifyMode')
+  if (!normalizeQaMode(normalized.qaMode)) {
+    issues.push('contract.json missing valid qaMode')
   }
-  if (normalizeStringArray(normalized.testerFocus).length === 0) {
-    issues.push('contract.json missing testerFocus')
-  }
-  if (normalizeVerifyMode(normalized.verifyMode) === 'review-first' && normalizeStringArray(normalized.reviewerFocus).length === 0) {
-    issues.push('contract.json missing reviewerFocus for review-first flow')
+  if (normalizeStringArray(normalized.qaFocus).length === 0) {
+    issues.push('contract.json missing qaFocus')
   }
   if (normalized.ui?.required && normalizeStringArray(normalized.ui.sourcePriority).length === 0) {
     issues.push('contract.json missing ui.sourcePriority')

package/scripts/project-session-cleanup.mjs

@@ -1,19 +1,20 @@
-import { existsSync, readdirSync, rmSync } from 'node:fs'
+import { existsSync, readdirSync, rmSync, statSync } from 'node:fs'
 import { join } from 'node:path'
 
 import {
   ACTIVE_SESSION_FILE_NAME,
-  CAPSULE_FILE_NAME,
-  EVENTS_FILE_NAME,
-  PROJECT_ARTIFACTS_DIR_NAME,
   PROJECT_SESSIONS_DIR_NAME,
   getProjectActivationDir,
   getProjectRoot,
   readJsonFile,
   writeJsonFileAtomic,
 } from './runtime-scope.mjs'
+import { LONG_RUNNING_TTL_MS } from './runtime-ttl.mjs'
+import { readStateDocument } from './state-document.mjs'
 
 export const PROJECT_SESSION_CLEANUP_COOLDOWN_MS = 10 * 60 * 1000
+export const PROJECT_SESSION_MAX_AGE_MS = LONG_RUNNING_TTL_MS
+const AUTO_CREATED_STATE_MARKER = '由运行时自动创建；后续按实际任务重写'
 
 function removePath(filePath, result, bucket) {
   try {
@@ -24,6 +25,10 @@ function removePath(filePath, result, bucket) {
   }
 }
 
+function isDebugLog(entryName = '') {
+  return /\.log$/i.test(entryName)
+}
+
 function isDirectoryEmptyRecursive(dirPath) {
   const entries = readdirSync(dirPath, { withFileTypes: true })
   if (entries.length === 0) return true
@@ -33,29 +38,6 @@ function isDirectoryEmptyRecursive(dirPath) {
   })
 }
 
-function listFilesRecursive(dirPath) {
-  const entries = readdirSync(dirPath, { withFileTypes: true })
-  return entries.flatMap((entry) => {
-    const entryPath = join(dirPath, entry.name)
-    if (entry.isDirectory()) {
-      return listFilesRecursive(entryPath).map((child) => `${entry.name}/${child}`)
-    }
-    return entry.isFile() ? [entry.name] : []
-  })
-}
-
-function isRouteOnlySessionDir(sessionDir) {
-  if (existsSync(join(sessionDir, 'STATE.md'))) return false
-  const files = listFilesRecursive(sessionDir).map((file) => file.replace(/\\/g, '/'))
-  if (files.length === 0) return false
-  if (!files.includes(`${PROJECT_ARTIFACTS_DIR_NAME}/codex-native-stop.json`)) return false
-  return files.every((file) => [
-    CAPSULE_FILE_NAME,
-    EVENTS_FILE_NAME,
-    `${PROJECT_ARTIFACTS_DIR_NAME}/codex-native-stop.json`,
-  ].includes(file))
-}
-
 function shouldKeepSession(active, workspace, session) {
   const activeWorkspace = active.workspace || active.branch || ''
   return activeWorkspace === workspace && active.session === session
@@ -75,7 +57,70 @@ function writeCleanupCheckpoint(activePath, active, now) {
   })
 }
 
-export function cleanupProjectSessions(cwd, { now = Date.now(), minIntervalMs = 0 } = {}) {
+function hasStateSnapshot(sessionDir) {
+  return existsSync(join(sessionDir, 'STATE.md'))
+}
+
+function isAutoCreatedSeedSession(sessionDir) {
+  const statePath = join(sessionDir, 'STATE.md')
+  if (!existsSync(statePath)) return false
+
+  const { metadata, body } = readStateDocument(statePath)
+  if (metadata && typeof metadata === 'object' && Object.keys(metadata).length > 0) return false
+  return String(body || '').includes(AUTO_CREATED_STATE_MARKER)
+}
+
+function readSessionStateMtimeMs(sessionDir) {
+  try {
+    return statSync(join(sessionDir, 'STATE.md')).mtimeMs
+  } catch {
+    return 0
+  }
+}
+
+function isStaleStateSession(sessionDir, now, maxAgeMs) {
+  const mtimeMs = readSessionStateMtimeMs(sessionDir)
+  return !Number.isFinite(mtimeMs) || mtimeMs <= 0 || (now - mtimeMs > maxAgeMs)
+}
+
+function isTransientSessionTemp(entryName = '') {
+  return /^\.[0-9]+-[0-9a-f-]+\.tmp$/i.test(entryName)
+}
+
+function cleanupTransientSessionTemps(sessionsDir, result) {
+  for (const entry of readdirSync(sessionsDir, { withFileTypes: true })) {
+    if (!entry.isFile() || !isTransientSessionTemp(entry.name)) continue
+    removePath(join(sessionsDir, entry.name), result, 'removedTempFiles')
+  }
+}
+
+function cleanupLegacyProjectArtifacts(activationDir, result) {
+  const artifactsDir = join(activationDir, 'artifacts')
+  if (!existsSync(artifactsDir)) return
+
+  let removableEntries = []
+  try {
+    removableEntries = readdirSync(artifactsDir, { withFileTypes: true })
+  } catch (error) {
+    result.errors.push(`${artifactsDir}: ${error.message}`)
+    return
+  }
+
+  for (const entry of removableEntries) {
+    if (!entry.isFile() || !isDebugLog(entry.name)) continue
+    removePath(join(artifactsDir, entry.name), result, 'removedLegacyArtifacts')
+  }
+
+  try {
+    if (isDirectoryEmptyRecursive(artifactsDir)) {
+      removePath(artifactsDir, result, 'removedLegacyArtifacts')
+    }
+  } catch (error) {
+    result.errors.push(`${artifactsDir}: ${error.message}`)
+  }
+}
+
+export function cleanupProjectSessions(cwd, { now = Date.now(), minIntervalMs = 0, maxAgeMs = PROJECT_SESSION_MAX_AGE_MS } = {}) {
   const projectRoot = getProjectRoot(cwd)
   const activationDir = getProjectActivationDir(projectRoot)
   const sessionsDir = join(activationDir, PROJECT_SESSIONS_DIR_NAME)
@@ -84,7 +129,11 @@ export function cleanupProjectSessions(cwd, { now = Date.now(), minIntervalMs =
   const result = {
     sessionsDir,
     removedEmptyDirs: [],
-    removedRouteOnlyDirs: [],
+    removedInactiveDirs: [],
+    removedNoStateDirs: [],
+    removedSeedDirs: [],
+    removedTempFiles: [],
+    removedLegacyArtifacts: [],
     errors: [],
     skipped: false,
   }
@@ -98,6 +147,13 @@ export function cleanupProjectSessions(cwd, { now = Date.now(), minIntervalMs =
     }
   }
 
+  try {
+    cleanupTransientSessionTemps(sessionsDir, result)
+  } catch (error) {
+    result.errors.push(`${sessionsDir}: ${error.message}`)
+  }
+  cleanupLegacyProjectArtifacts(activationDir, result)
+
   for (const workspaceEntry of readdirSync(sessionsDir, { withFileTypes: true })) {
     if (!workspaceEntry.isDirectory()) continue
     const workspaceDir = join(sessionsDir, workspaceEntry.name)
@@ -110,8 +166,12 @@ export function cleanupProjectSessions(cwd, { now = Date.now(), minIntervalMs =
       try {
         if (isDirectoryEmptyRecursive(sessionDir)) {
           removePath(sessionDir, result, 'removedEmptyDirs')
-        } else if (isRouteOnlySessionDir(sessionDir)) {
-          removePath(sessionDir, result, 'removedRouteOnlyDirs')
+        } else if (!hasStateSnapshot(sessionDir)) {
+          removePath(sessionDir, result, 'removedNoStateDirs')
+        } else if (isAutoCreatedSeedSession(sessionDir)) {
+          removePath(sessionDir, result, 'removedSeedDirs')
+        } else if (isStaleStateSession(sessionDir, now, maxAgeMs)) {
+          removePath(sessionDir, result, 'removedInactiveDirs')
         }
       } catch (error) {
         result.errors.push(`${sessionDir}: ${error.message}`)