hello-lights 0.3.16 → 0.3.17

package/README.md

@@ -63,46 +63,6 @@ Check out the available commands [here](https://jordao76.github.io/hello-lights)
 
 For the documentation look [here](https://jordao76.github.io/hello-lights/doc/index.html).
 
-## Development
-
-Install dependencies:
-
-```sh
-$ npm install
-```
-
-### npm scripts
-
-| Script | Description |
-|---|---|
-| `npm test` | Run all tests (generates PEG parsers first) |
-| `npm run lint` | Lint source and test files |
-| `npm run coverage` | Run tests with coverage instrumentation |
-| `npm run coverage:text` | Print a text coverage summary to the terminal |
-| `npm run coverage:open` | Generate and open an HTML coverage report |
-| `npm run build:doc` | Generate JSDoc documentation into `web/doc/` |
-| `npm run build:web` | Build all web assets (PEG parsers, browserify bundle, docs) |
-| `npm run doc` | Build and open the documentation in the browser |
-| `npm run web` | Build and open the browser demo |
-| `npm run mocha-grep <pattern>` | Run only tests matching a pattern |
-| `npm run cli` | Run the CLI locally |
-
-### CLI
-
-Run the CLI locally with `npm run cli`:
-
-```sh
-$ npm run cli -- exec bounce 300       # execute a command
-$ npm run cli -- exec-file ./cmds.clj  # execute commands from a file
-$ npm run cli -- repl                  # start an interactive REPL
-$ npm run cli -- serve                 # start the HTTP server on port 9000
-$ npm run cli -- serve --port 3000     # start the HTTP server on a custom port
-$ npm run cli -- --selector http exec bounce 300   # execute via a remote server
-$ npm run cli -- --selector http --host http://myserver:3000 repl  # REPL via a remote server
-```
-
-Use `--help` for the full list of options, including `--serial-num` to target a specific device, `--selector multi` to control multiple traffic lights at once, and `--selector http` to send commands to a remote hello-lights server.
-
 ## HTTP Server REST API
 
 The `serve` command starts an HTTP server that exposes the Commander interface as a REST API. By default it listens on port 9000.
@@ -112,7 +72,6 @@ The `serve` command starts an HTTP server that exposes the Commander interface a
 | `/run` | POST | Command string (plain text) | 202 Accepted, or 400 if malformed |
 | `/run?reset=true` | POST | Command string (plain text) | 202 Accepted (resets lights first), or 400 if malformed |
 | `/cancel` | POST | — | 200 OK |
-| `/definitions` | POST | Definition string (plain text) | 202 Accepted, or 400 if malformed |
 | `/commands` | GET | — | 200 + JSON array of command names |
 | `/commands/:name` | GET | — | 200 + help text (`text/x-ansi`) or 404 |
 | `/info` | GET | — | 200 + JSON array of `{ serialNum, status }` |
@@ -123,7 +82,6 @@ Examples:
 $ curl -X POST http://localhost:9000/run -d 'blink 3 green 300'
 $ curl -X POST http://localhost:9000/run?reset=true -d 'twinkle red 400'
 $ curl -X POST http://localhost:9000/cancel
-$ curl -X POST http://localhost:9000/definitions -d '(def foo (blink 1 green 300))'
 $ curl http://localhost:9000/commands
 $ curl http://localhost:9000/commands/turn
 $ curl http://localhost:9000/info
@@ -176,6 +134,30 @@ $ systemctl --user status hello-lights
 $ journalctl --user -u hello-lights -f   # follow logs
 ```
 
+## Development
+
+Install dependencies:
+
+```sh
+$ npm install
+```
+
+### npm scripts
+
+| Script | Description |
+|---|---|
+| `npm test` | Run all tests (generates PEG parsers first) |
+| `npm run lint` | Lint source and test files |
+| `npm run coverage` | Run tests with coverage instrumentation |
+| `npm run coverage:text` | Print a text coverage summary to the terminal |
+| `npm run coverage:open` | Generate and open an HTML coverage report |
+| `npm run build:doc` | Generate JSDoc documentation into `web/doc/` |
+| `npm run build:web` | Build all web assets (PEG parsers, browserify bundle, docs) |
+| `npm run doc` | Build and open the documentation in the browser |
+| `npm run web` | Build and open the browser demo |
+| `npm run mocha-grep <pattern>` | Run only tests matching a pattern |
+| `npm run cli` | Run the CLI locally (e.g. `npm run cli -- exec bounce 300`) |
+
 ## CI
 
 The CI workflow runs on every push and pull request to `master`. It has three jobs:

package/lib/cli/serve/index.js

@@ -44,20 +44,6 @@ function createApp(commander, {logger: log = logger} = {}) {
     res.sendStatus(200);
   });
 
-  app.post('/definitions', (req, res) => {
-    let body = req.body || '';
-    log.log('POST /definitions:', body);
-    try {
-      commander.interpreter.process(body);
-    } catch (e) {
-      log.error('POST /definitions: malformed:', e.message);
-      res.status(400).send(e.message);
-      return;
-    }
-    commander.runDefinitions(body);
-    res.sendStatus(202);
-  });
-
   app.get('/commands', async (req, res) => {
     res.json(await commander.fetchCommandNames());
   });

package/lib/rest-commander.js

@@ -70,17 +70,6 @@ class RestCommander {
     await request(this.host, 'POST', '/cancel');
   }
 
-  /**
-   * Executes definition-only commands on the remote server.
-   * @param {string} command - Command with definitions to execute.
-   */
-  async runDefinitions(command) {
-    let res = await request(this.host, 'POST', '/definitions', command);
-    if (res.statusCode === 400) {
-      this.logger.error(res.body);
-    }
-  }
-
   /**
    * Fetches all available command names from the remote server.
    * @returns {Promise<string[]>} Array of command names.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hello-lights",
-  "version": "0.3.16",
+  "version": "0.3.17",
   "description": "Commands to control a traffic light",
   "main": "index.js",
   "bin": {

package/.github/dependabot.yml

@@ -1,14 +0,0 @@
-version: 2
-updates:
-  - package-ecosystem: "npm"
-    directory: "/"
-    schedule:
-      interval: "weekly"
-    # Only open PRs for security vulnerabilities, not version bumps
-    open-pull-requests-limit: 5
-    groups:
-      # Group all security patches into a single PR when possible
-      security-patches:
-        applies-to: security-updates
-        patterns:
-          - "*"

package/.github/workflows/ci.yml

@@ -1,118 +0,0 @@
-name: CI
-
-on:
-  pull_request:
-    branches: [master]
-  push:
-    branches: [master]
-
-permissions:
-  contents: read
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 22
-
-      - name: Install system dependencies
-        run: sudo apt-get update && sudo apt-get install -y libusb-1.0-0-dev libudev-dev
-
-      - run: npm ci
-
-      - run: npm run lint
-
-      - run: npm run coverage
-
-      - run: npm run coverage:text
-
-      - run: npm run build:web
-
-      - name: Upload web artifact
-        if: github.event_name == 'push'
-        uses: actions/upload-pages-artifact@v3
-        with:
-          path: web
-
-  deploy:
-    needs: build
-    if: github.event_name == 'push'
-    runs-on: ubuntu-latest
-
-    permissions:
-      pages: write
-      id-token: write
-
-    environment:
-      name: github-pages
-      url: ${{ steps.deploy.outputs.page_url }}
-
-    steps:
-      - name: Deploy to GitHub Pages
-        id: deploy
-        uses: actions/deploy-pages@v4
-
-  publish:
-    needs: build
-    if: github.event_name == 'push' && !contains(github.event.head_commit.message, '[skip ci]')
-    runs-on: ubuntu-latest
-
-    permissions:
-      contents: write
-      id-token: write
-
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 22
-          registry-url: https://registry.npmjs.org
-
-      - name: Install system dependencies
-        run: sudo apt-get update && sudo apt-get install -y libusb-1.0-0-dev libudev-dev
-
-      - run: npm ci
-
-      - run: npm run peg
-
-      - run: npm install -g npm@latest
-
-      - name: Determine version bump type
-        id: bump
-        run: |
-          COMMIT_MSG="${{ github.event.head_commit.message }}"
-          if echo "$COMMIT_MSG" | grep -qiE '\[major\]|BREAKING CHANGE'; then
-            echo "type=major" >> $GITHUB_OUTPUT
-          elif echo "$COMMIT_MSG" | grep -qi '\[minor\]'; then
-            echo "type=minor" >> $GITHUB_OUTPUT
-          else
-            echo "type=patch" >> $GITHUB_OUTPUT
-          fi
-
-      - name: Bump version
-        id: version
-        run: |
-          git config user.name "github-actions[bot]"
-          git config user.email "github-actions[bot]@users.noreply.github.com"
-          npm version ${{ steps.bump.outputs.type }} -m "v%s [skip ci]"
-          echo "new_version=$(node -p 'require("./package.json").version')" >> $GITHUB_OUTPUT
-
-      - name: Push version bump
-        run: git push --follow-tags
-
-      - name: Publish to npm
-        run: npm publish --provenance
-
-      - name: Create GitHub Release
-        uses: softprops/action-gh-release@v2
-        with:
-          tag_name: v${{ steps.version.outputs.new_version }}
-          generate_release_notes: true

package/eslint.config.js

@@ -1,163 +0,0 @@
-'use strict';
-
-const globals = require('globals');
-
-module.exports = [
-  {
-    ignores: [
-      'src/commands/peg-parser.js',
-      'src/commands/doc-peg-parser.js',
-      'src/commands/formatter-peg-parser.js',
-      'web/bundle.js',
-      'web/doc'
-    ]
-  },
-  {
-    languageOptions: {
-      ecmaVersion: 2018,
-      globals: {
-        ...globals.node,
-        ...globals.browser
-      }
-    },
-    rules: {
-      'accessor-pairs': 'error',
-      'arrow-spacing': ['error', {'before': true, 'after': true}],
-      'block-spacing': ['error', 'always'],
-      'brace-style': ['error', '1tbs', {'allowSingleLine': true}],
-      'camelcase': ['error', {'properties': 'never'}],
-      'comma-dangle': ['error', {'arrays': 'never', 'objects': 'never', 'imports': 'never', 'exports': 'never', 'functions': 'never'}],
-      'comma-spacing': ['error', {'before': false, 'after': true}],
-      'comma-style': ['error', 'last'],
-      'constructor-super': 'error',
-      'curly': ['error', 'multi-line'],
-      'dot-location': ['error', 'property'],
-      'eol-last': 'error',
-      'eqeqeq': ['error', 'always', {'null': 'ignore'}],
-      'func-call-spacing': ['error', 'never'],
-      'generator-star-spacing': ['error', {'before': true, 'after': true}],
-      'indent': ['error', 2, {
-        'SwitchCase': 1,
-        'VariableDeclarator': 1,
-        'outerIIFEBody': 1,
-        'MemberExpression': 1,
-        'FunctionDeclaration': {'parameters': 1, 'body': 1},
-        'FunctionExpression': {'parameters': 1, 'body': 1},
-        'CallExpression': {'arguments': 1},
-        'ArrayExpression': 1,
-        'ObjectExpression': 1,
-        'ImportDeclaration': 1,
-        'flatTernaryExpressions': false,
-        'ignoreComments': false
-      }],
-      'key-spacing': ['error', {'beforeColon': false, 'afterColon': true}],
-      'keyword-spacing': ['error', {'before': true, 'after': true}],
-      'new-cap': ['error', {'newIsCap': true, 'capIsNew': false}],
-      'no-array-constructor': 'error',
-      'no-caller': 'error',
-      'no-class-assign': 'error',
-      'no-compare-neg-zero': 'error',
-      'no-cond-assign': 'error',
-      'no-const-assign': 'error',
-      'no-constant-condition': ['error', {'checkLoops': false}],
-      'no-control-regex': 'error',
-      'no-debugger': 'error',
-      'no-delete-var': 'error',
-      'no-dupe-args': 'error',
-      'no-dupe-class-members': 'error',
-      'no-dupe-keys': 'error',
-      'no-duplicate-case': 'error',
-      'no-empty-character-class': 'error',
-      'no-empty-pattern': 'error',
-      'no-eval': 'error',
-      'no-ex-assign': 'error',
-      'no-extend-native': 'error',
-      'no-extra-bind': 'error',
-      'no-extra-boolean-cast': 'error',
-      'no-extra-parens': ['error', 'functions'],
-      'no-fallthrough': 'error',
-      'no-floating-decimal': 'error',
-      'no-func-assign': 'error',
-      'no-global-assign': 'error',
-      'no-implied-eval': 'error',
-      'no-inner-declarations': ['error', 'functions'],
-      'no-invalid-regexp': 'error',
-      'no-irregular-whitespace': 'error',
-      'no-iterator': 'error',
-      'no-label-var': 'error',
-      'no-labels': ['error', {'allowLoop': false, 'allowSwitch': false}],
-      'no-lone-blocks': 'error',
-      'no-mixed-operators': ['error', {
-        'groups': [
-          ['==', '!=', '===', '!==', '>', '>=', '<', '<='],
-          ['&&', '||'],
-          ['in', 'instanceof']
-        ],
-        'allowSamePrecedence': true
-      }],
-      'no-mixed-spaces-and-tabs': 'error',
-      'no-multi-spaces': 'error',
-      'no-multi-str': 'error',
-      'no-multiple-empty-lines': ['error', {'max': 1, 'maxEOF': 0}],
-      'no-new': 'error',
-      'no-new-func': 'error',
-      'no-new-object': 'error',
-      'no-new-symbol': 'error',
-      'no-new-wrappers': 'error',
-      'no-obj-calls': 'error',
-      'no-octal': 'error',
-      'no-octal-escape': 'error',
-      'no-proto': 'error',
-      'no-redeclare': 'error',
-      'no-regex-spaces': 'error',
-      'no-return-await': 'error',
-      'no-self-assign': 'error',
-      'no-self-compare': 'error',
-      'no-sequences': 'error',
-      'no-shadow-restricted-names': 'error',
-      'no-sparse-arrays': 'error',
-      'no-tabs': 'error',
-      'no-template-curly-in-string': 'error',
-      'no-this-before-super': 'error',
-      'no-throw-literal': 'error',
-      'no-trailing-spaces': 'error',
-      'no-undef': 'error',
-      'no-undef-init': 'error',
-      'no-unexpected-multiline': 'error',
-      'no-unmodified-loop-condition': 'error',
-      'no-unneeded-ternary': ['error', {'defaultAssignment': false}],
-      'no-unreachable': 'error',
-      'no-unsafe-finally': 'error',
-      'no-unsafe-negation': 'error',
-      'no-unused-expressions': ['error', {'allowShortCircuit': true, 'allowTernary': true, 'allowTaggedTemplates': true}],
-      'no-unused-vars': ['error', {'vars': 'all', 'args': 'none', 'caughtErrors': 'none', 'ignoreRestSiblings': true}],
-      'no-use-before-define': ['error', {'functions': false, 'classes': false, 'variables': false}],
-      'no-useless-call': 'error',
-      'no-useless-computed-key': 'error',
-      'no-useless-constructor': 'error',
-      'no-useless-escape': 'error',
-      'no-useless-rename': 'error',
-      'no-useless-return': 'error',
-      'no-whitespace-before-property': 'error',
-      'no-with': 'error',
-      'operator-linebreak': ['error', 'after', {'overrides': {'?': 'before', ':': 'before'}}],
-      'prefer-promise-reject-errors': 'error',
-      'quotes': ['error', 'single', {'avoidEscape': true, 'allowTemplateLiterals': true}],
-      'rest-spread-spacing': ['error', 'never'],
-      'semi': 'error',
-      'semi-spacing': ['error', {'before': false, 'after': true}],
-      'space-before-blocks': ['error', 'always'],
-      'space-in-parens': ['error', 'never'],
-      'space-unary-ops': ['error', {'words': true, 'nonwords': false}],
-      'symbol-description': 'error',
-      'template-curly-spacing': ['error', 'never'],
-      'template-tag-spacing': ['error', 'never'],
-      'unicode-bom': ['error', 'never'],
-      'use-isnan': 'error',
-      'valid-typeof': ['error', {'requireStringLiterals': true}],
-      'wrap-iife': ['error', 'any', {'functionPrototypeMethods': true}],
-      'yield-star-spacing': ['error', 'both'],
-      'yoda': ['error', 'never']
-    }
-  }
-];

package/jsdoc.json

@@ -1,23 +0,0 @@
-{
-  "plugins": [
-    "plugins/markdown"
-  ],
-  "opts": {
-    "template": "node_modules/docdash",
-    "readme": "./README.md",
-    "destination": "./web/doc/",
-    "recurse": true
-  },
-  "docdash": {
-    "typedefs": true,
-    "sectionOrder": [
-      "Tutorials",
-      "Namespaces",
-      "Modules",
-      "Interfaces",
-      "Classes",
-      "Mixins",
-      "Externals"
-    ]
-}
-}