heimdall-agent 1.0.0 → 1.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +57 -26
- package/README.pt-BR.md +443 -0
- package/agents/cloud-engineer.md +77 -0
- package/agents/code-sentinel.md +71 -34
- package/agents/database-architect.md +31 -25
- package/agents/frontend-designer.md +30 -28
- package/agents/mobile-designer.md +25 -24
- package/agents/modernizer.md +68 -0
- package/agents/orchestrator.md +107 -93
- package/agents/reviewer.md +102 -71
- package/agents/security-auditor.md +27 -27
- package/agents/tester.md +97 -90
- package/commands/grill-me.md +20 -4
- package/commands/orchestrate.md +16 -0
- package/commands/orchestrator.md +16 -0
- package/commands/plan.md +17 -1
- package/config/agents.json +31 -3
- package/config/mcp.json +72 -0
- package/config/models.json +26 -16
- package/config/profiles.json +2 -4
- package/config/skills.json +762 -573
- package/docs/SKILLS.md +393 -275
- package/docs/designs/old/2026-10-31 plan-lifecycle-backlog-and-clean-code-skill.md +87 -0
- package/docs/designs/old/2026-11-02 skill-upstream-audit-and-update.md +105 -0
- package/docs/designs/old/2026-11-05 communication-doctrine-bluf-ste.md +94 -0
- package/docs/designs/old/2026-11-06-cloud-engineer-and-resilience-synthesis.md +67 -0
- package/docs/designs/old/2026-11-06-herdr-native-agent-orchestration.md +45 -0
- package/docs/runs/skill-audit/2026-11-12-compare-report.json +1028 -0
- package/docs/runs/skill-audit/2026-11-12-upstream-audit.json +275 -0
- package/docs/runs/skill-audit/add_progressive_disclosure.cjs +30 -0
- package/docs/runs/skill-audit/check_heimdall_skills.ps1 +9 -0
- package/docs/runs/skill-audit/compare_classics.ps1 +26 -0
- package/docs/runs/skill-audit/compare_taste.ps1 +12 -0
- package/docs/runs/skill-audit/customization-report.json +380 -0
- package/docs/runs/skill-audit/diff_pending_skills.cjs +94 -0
- package/docs/runs/skill-audit/fetch_and_apply_skill.cjs +58 -0
- package/docs/runs/skill-audit/fetch_and_apply_taste_v2.cjs +65 -0
- package/docs/runs/skill-audit/inspect_pending_skills.cjs +71 -0
- package/docs/runs/skill-audit/inventory.json +308 -0
- package/docs/runs/skill-audit/list_local_taste.ps1 +1 -0
- package/docs/runs/skill-audit/phase5-update-plan.json +595 -0
- package/docs/runs/skill-audit/phase5-update-plan.md +138 -0
- package/docs/runs/skill-audit/probe.ps1 +16 -0
- package/docs/runs/skill-audit/probe_classics_branches.ps1 +3 -0
- package/docs/runs/skill-audit/probe_commits.ps1 +15 -0
- package/docs/runs/skill-audit/probe_repos.ps1 +17 -0
- package/docs/runs/skill-audit/probe_sentry_sec.ps1 +3 -0
- package/docs/runs/skill-audit/probe_sentry_sweep.ps1 +5 -0
- package/docs/runs/skill-audit/probe_snyk.ps1 +3 -0
- package/docs/runs/skill-audit/probe_snyk_recipes.ps1 +5 -0
- package/docs/runs/skill-audit/probe_taste_branches.ps1 +8 -0
- package/docs/runs/skill-audit/probe_taste_v19.ps1 +3 -0
- package/docs/runs/skill-audit/probe_user_repos.ps1 +19 -0
- package/docs/runs/skill-audit/prune_taste_skills.cjs +22 -0
- package/docs/runs/skill-audit/run_phase1_2.cjs +142 -0
- package/docs/runs/skill-audit/run_phase6_verification.cjs +107 -0
- package/docs/runs/skill-audit/show_16_details.ps1 +25 -0
- package/docs/runs/skill-audit/show_20_skills.ps1 +28 -0
- package/docs/runs/skill-audit/show_classics_diff.cjs +37 -0
- package/docs/runs/skill-audit/sync_agent_markdowns.cjs +30 -0
- package/docs/runs/skill-audit/taste-skill-upstream.md +542 -0
- package/docs/runs/skill-audit/update-manifest.md +88 -0
- package/docs/runs/skill-audit/update_config_skills.cjs +52 -0
- package/docs/runs/skill-audit/update_registry_phase7.cjs +83 -0
- package/docs/runs/skill-audit/upstream-status.json +563 -0
- package/docs/runs/skill-audit/verification-results.json +252 -0
- package/doctrine/AGENTS.md +42 -77
- package/hooks/git/pre-commit +11 -0
- package/hooks/heimdall-hook.cjs +81 -2
- package/hooks/herdr-agent-state.ps1 +55 -0
- package/hooks/hooks.json +0 -11
- package/lib/catalog-sync.cjs +167 -0
- package/lib/hermes-context.cjs +57 -0
- package/lib/model-context.cjs +123 -0
- package/lib/path-discovery.cjs +94 -0
- package/package.json +7 -3
- package/playbooks/01-interactive-grilling-gate.md +23 -6
- package/playbooks/02-fast-code-deep-verification.md +3 -2
- package/playbooks/03-adversarial-code-review.md +15 -7
- package/playbooks/05-canonical-plan-template.md +35 -19
- package/playbooks/06-model-registry-matrix.md +24 -13
- package/playbooks/07-legacy-code-modernization.md +74 -0
- package/playbooks/08-backlog-and-change-request-flow.md +122 -0
- package/setup.mjs +592 -172
- package/skills/antislop/SKILL.md +76 -56
- package/skills/antislop/VERSION +1 -0
- package/skills/antislop-copywriting/SKILL.md +407 -372
- package/skills/antislop-human/LICENSE-web-quality-skills +21 -0
- package/skills/antislop-human/SKILL.md +204 -147
- package/skills/antislop-human/contrast-check.py +168 -165
- package/skills/antislop-human/contrast-mcp.py +6 -3
- package/skills/antislop-human/references/A11Y-PATTERNS.md +249 -0
- package/skills/antislop-human/references/WCAG.md +127 -0
- package/skills/antislop-ui/LICENSE-web-quality-skills +21 -0
- package/skills/antislop-ui/SKILL.md +344 -304
- package/skills/antislop-ui/references/CORE-WEB-VITALS.md +181 -0
- package/skills/antislop-ui/references/WEB-BASELINE.md +28 -0
- package/skills/brainstorming/SKILL.md +296 -265
- package/skills/brainstorming/builder-check-prompt.md +23 -0
- package/skills/brainstorming/scripts/frame-template.html +213 -213
- package/skills/brainstorming/scripts/server.cjs +723 -723
- package/skills/brandkit/SKILL.md +798 -798
- package/skills/brutalist-skill/SKILL.md +93 -92
- package/skills/caveman/README.md +68 -0
- package/skills/caveman/SKILL.md +73 -38
- package/skills/claude-collaborator/SKILL.md +24 -44
- package/skills/clean-code/SKILL.md +152 -0
- package/skills/cloudflare-security-audit/AI-AND-LLM.md +83 -83
- package/skills/cloudflare-security-audit/ATTACK-CLASSES.md +130 -130
- package/skills/cloudflare-security-audit/CLIENT-SIDE.md +83 -83
- package/skills/cloudflare-security-audit/CLOUD-AND-DEPLOYMENT.md +86 -86
- package/skills/cloudflare-security-audit/DATA-ISOLATION-AND-LIFECYCLE.md +84 -84
- package/skills/cloudflare-security-audit/DESKTOP-MOBILE-AND-LOCAL-IPC.md +89 -89
- package/skills/cloudflare-security-audit/HUNTING.md +251 -251
- package/skills/cloudflare-security-audit/MEMORY-SAFETY-AND-BINARY.md +101 -101
- package/skills/cloudflare-security-audit/PROTOCOLS-RPC-AND-MESSAGING.md +81 -81
- package/skills/cloudflare-security-audit/RECONNAISSANCE.md +156 -156
- package/skills/cloudflare-security-audit/RESOURCE-EXHAUSTION-AND-AVAILABILITY.md +78 -78
- package/skills/cloudflare-security-audit/SKILL.md +192 -192
- package/skills/cloudflare-security-audit/SUPPLY-CHAIN-AND-RELEASE.md +73 -73
- package/skills/cloudflare-security-audit/VALIDATION-AND-REPORTING.md +186 -186
- package/skills/cloudflare-security-audit/WEB-PROTOCOL-AND-AUTH.md +105 -105
- package/skills/cloudflare-security-audit/report-schema.json +461 -461
- package/skills/cloudflare-security-audit/validate-coverage-ledger.cjs +872 -872
- package/skills/cloudflare-security-audit/validate-coverage-ledger.test.cjs +740 -740
- package/skills/cloudflare-security-audit/validate-findings.cjs +773 -773
- package/skills/cloudflare-security-audit/validate-findings.test.cjs +652 -652
- package/skills/codebase-design/DEEPENING.md +37 -0
- package/skills/codebase-design/DESIGN-IT-TWICE.md +44 -0
- package/skills/codebase-design/SKILL.md +114 -0
- package/skills/codex-collaborator/SKILL.md +24 -45
- package/skills/communication-doctrine/SKILL.md +89 -0
- package/skills/diagnosing-superpowers/SKILL.md +1 -1
- package/skills/diagnosing-superpowers/references/github-issues.md +3 -3
- package/skills/diagnosing-superpowers/templates/issue.md +23 -4
- package/skills/domain-modeling/ADR-FORMAT.md +47 -0
- package/skills/domain-modeling/GLOSSARY-FORMAT.md +60 -0
- package/skills/domain-modeling/SKILL.md +74 -0
- package/skills/executing-plans/SKILL.md +6 -56
- package/skills/executing-plans/scripts/task-done +52 -52
- package/skills/executing-plans/scripts/task-start +28 -28
- package/skills/gemini-collaborator/SKILL.md +24 -56
- package/skills/grill-me/SKILL.md +65 -0
- package/skills/handoff/SKILL.md +64 -0
- package/skills/herdr/SKILL.md +243 -0
- package/skills/image-to-code-skill/SKILL.md +1228 -1228
- package/skills/imagegen-frontend-mobile/SKILL.md +1465 -1465
- package/skills/imagegen-frontend-web/SKILL.md +987 -987
- package/skills/improve-codebase-architecture/HTML-REPORT.md +123 -0
- package/skills/improve-codebase-architecture/SKILL.md +71 -0
- package/skills/karpathy-guidelines/SKILL.md +67 -67
- package/skills/mcp-engineering/SKILL.md +74 -0
- package/skills/minimalist-skill/SKILL.md +87 -85
- package/skills/output-skill/SKILL.md +49 -49
- package/skills/owasp-security/reference/config-and-supply-chain.md +346 -344
- package/skills/owasp-security/reference/languages.md +378 -372
- package/skills/owasp-security/reference/owasp-report.md +1144 -1140
- package/skills/owasp-security/reference/review-checklist.md +134 -132
- package/skills/ponytail/SKILL.md +36 -52
- package/skills/postgres-best-practices/SKILL.md +30 -52
- package/skills/postgres-best-practices/references/backup-restore.md +372 -0
- package/skills/postgres-best-practices/references/bulk-loading.md +315 -0
- package/skills/postgres-best-practices/references/connection-pooling.md +310 -0
- package/skills/postgres-best-practices/references/hot-standby.md +221 -0
- package/skills/postgres-best-practices/references/indexing.md +318 -0
- package/skills/postgres-best-practices/references/logical-replication.md +610 -0
- package/skills/postgres-best-practices/references/major-version-upgrades.md +334 -0
- package/skills/postgres-best-practices/references/performance-diagnostics.md +553 -0
- package/skills/postgres-best-practices/references/query-optimization.md +294 -0
- package/skills/postgres-best-practices/references/query-patterns.md +566 -0
- package/skills/postgres-best-practices/references/schema-design.md +362 -0
- package/skills/postgres-best-practices/references/security-roles.md +489 -0
- package/skills/postgres-best-practices/references/transaction-isolation.md +344 -0
- package/skills/progressive-disclosure/SKILL.md +68 -0
- package/skills/pstack-discipline/SKILL.md +40 -0
- package/skills/receiving-code-review/SKILL.md +2 -23
- package/skills/requesting-code-review/SKILL.md +7 -36
- package/skills/soft-skill/SKILL.md +99 -98
- package/skills/stitch-skill/DESIGN.md +121 -121
- package/skills/stitch-skill/SKILL.md +185 -184
- package/skills/strix-security/SKILL.md +54 -53
- package/skills/subagent-driven-development/SKILL.md +35 -264
- package/skills/subagent-driven-development/references/batching.md +11 -0
- package/skills/subagent-driven-development/references/cannot-verify.md +10 -0
- package/skills/subagent-driven-development/references/final-review.md +47 -0
- package/skills/subagent-driven-development/references/fix-loop.md +77 -0
- package/skills/subagent-driven-development/references/handling-reports.md +15 -0
- package/skills/subagent-driven-development/references/preflight.md +26 -0
- package/skills/subagent-driven-development/references/resuming.md +12 -0
- package/skills/subagent-driven-development/scripts/review-package +53 -53
- package/skills/subagent-driven-development/scripts/sdd-workspace +87 -82
- package/skills/subagent-driven-development/scripts/task-brief +43 -43
- package/skills/systematic-debugging/SKILL.md +283 -306
- package/skills/taste-skill/SKILL.md +542 -1206
- package/skills/taste-skill/references/app-screens.md +1199 -0
- package/skills/taste-skill/references/colour.md +141 -0
- package/skills/taste-skill/references/copy.md +177 -0
- package/skills/taste-skill/references/critique.md +182 -0
- package/skills/taste-skill/references/imagery.md +791 -0
- package/skills/taste-skill/references/layout.md +292 -0
- package/skills/taste-skill/references/motion.md +980 -0
- package/skills/taste-skill/references/research.md +356 -0
- package/skills/taste-skill/references/scenes.md +174 -0
- package/skills/taste-skill/references/tells.md +115 -0
- package/skills/taste-skill/references/type.md +170 -0
- package/skills/test-driven-development/SKILL.md +330 -337
- package/skills/thermo/SKILL.md +67 -0
- package/skills/threat-modeling/SKILL.md +55 -0
- package/skills/to-spec/SKILL.md +75 -0
- package/skills/to-tickets/SKILL.md +105 -0
- package/skills/trailofbits-audit-context/SKILL.md +72 -72
- package/skills/trailofbits-insecure-defaults/commands/audit.md +35 -0
- package/skills/trailofbits-insecure-defaults/references/debug-features.json +13 -13
- package/skills/trailofbits-insecure-defaults/references/debug-features.md +75 -75
- package/skills/trailofbits-insecure-defaults/references/default-credentials.json +12 -12
- package/skills/trailofbits-insecure-defaults/references/default-credentials.md +76 -76
- package/skills/trailofbits-insecure-defaults/references/fail-open-security.json +11 -11
- package/skills/trailofbits-insecure-defaults/references/fail-open-security.md +70 -70
- package/skills/trailofbits-insecure-defaults/references/fallback-secrets.json +11 -11
- package/skills/trailofbits-insecure-defaults/references/fallback-secrets.md +70 -70
- package/skills/trailofbits-insecure-defaults/references/permissive-access.json +13 -13
- package/skills/trailofbits-insecure-defaults/references/permissive-access.md +62 -62
- package/skills/trailofbits-insecure-defaults/references/weak-crypto.json +13 -13
- package/skills/trailofbits-insecure-defaults/references/weak-crypto.md +71 -71
- package/skills/trailofbits-triage-brocards/SKILL.md +208 -208
- package/skills/verification-before-completion/SKILL.md +0 -14
- package/skills/wayfinder/SKILL.md +128 -0
- package/skills/writing-plans/SKILL.md +11 -15
- package/skills/writing-skills/SKILL.md +21 -303
- package/skills/writing-skills/references/CLAUDE_MD_TESTING.md +189 -0
- package/skills/writing-skills/references/anthropic-best-practices.md +1150 -0
- package/skills/writing-skills/references/bulletproofing.md +80 -0
- package/skills/writing-skills/references/discovery.md +201 -0
- package/skills/writing-skills/references/flowcharts.md +37 -0
- package/skills/writing-skills/references/graphviz-conventions.dot +172 -0
- package/skills/writing-skills/references/persuasion-principles.md +187 -0
- package/skills/writing-skills/references/testing-skills-with-subagents.md +384 -0
- package/tools/{claude-bridge.ps1 → archive/claude-bridge.ps1} +10 -7
- package/tools/{codex-bridge.ps1 → archive/codex-bridge.ps1} +1 -1
- package/tools/{gemini-bridge.ps1 → archive/gemini-bridge.ps1} +12 -19
- package/skills/gpt-tasteskill/SKILL.md +0 -74
- package/skills/taste-skill-v1/SKILL.md +0 -226
- /package/tools/{claude-bridge.cmd → archive/claude-bridge.cmd} +0 -0
- /package/tools/{claude-bridge.sh → archive/claude-bridge.sh} +0 -0
- /package/tools/{codex-bridge.cmd → archive/codex-bridge.cmd} +0 -0
- /package/tools/{codex-bridge.sh → archive/codex-bridge.sh} +0 -0
- /package/tools/{codexcli-bridge.cmd → archive/codexcli-bridge.cmd} +0 -0
- /package/tools/{codexcli-bridge.ps1 → archive/codexcli-bridge.ps1} +0 -0
- /package/tools/{gemini-bridge.cmd → archive/gemini-bridge.cmd} +0 -0
- /package/tools/{gemini-bridge.sh → archive/gemini-bridge.sh} +0 -0
|
@@ -1,13 +1,13 @@
|
|
|
1
|
-
{
|
|
2
|
-
"id": "permissive-access",
|
|
3
|
-
"title": "Permissive access defaults",
|
|
4
|
-
"seeds": [
|
|
5
|
-
"(cors|CORS|Access-Control-Allow-Origin|allow_origins|allowedOrigins).{0,80}['\"]?\\*",
|
|
6
|
-
"(^|[^0-9.])0o?(777|776|766|707|666|000)([^0-9]|$)",
|
|
7
|
-
"(chmod|umask|os\\.chmod|os\\.open|mkdir|mkstemp|FileMode|Chmod).{0,60}[0-7]{3}",
|
|
8
|
-
"(ACL|acl|canned_acl|predefined_acl)[[:space:]]*[:=][[:space:]]*['\"]?(public-read|public-read-write|authenticated-read)",
|
|
9
|
-
"(allUsers|AllUsers|AuthenticatedUsers|0\\.0\\.0\\.0/0|::/0)",
|
|
10
|
-
"(0\\.0\\.0\\.0|::)[:'\"]",
|
|
11
|
-
"(AllowAny|IsAuthenticatedOrReadOnly|permitAll|anonymous[[:space:]]*=[[:space:]]*true|privileged[[:space:]]*:[[:space:]]*true|runAsUser[[:space:]]*:[[:space:]]*0)"
|
|
12
|
-
]
|
|
13
|
-
}
|
|
1
|
+
{
|
|
2
|
+
"id": "permissive-access",
|
|
3
|
+
"title": "Permissive access defaults",
|
|
4
|
+
"seeds": [
|
|
5
|
+
"(cors|CORS|Access-Control-Allow-Origin|allow_origins|allowedOrigins).{0,80}['\"]?\\*",
|
|
6
|
+
"(^|[^0-9.])0o?(777|776|766|707|666|000)([^0-9]|$)",
|
|
7
|
+
"(chmod|umask|os\\.chmod|os\\.open|mkdir|mkstemp|FileMode|Chmod).{0,60}[0-7]{3}",
|
|
8
|
+
"(ACL|acl|canned_acl|predefined_acl)[[:space:]]*[:=][[:space:]]*['\"]?(public-read|public-read-write|authenticated-read)",
|
|
9
|
+
"(allUsers|AllUsers|AuthenticatedUsers|0\\.0\\.0\\.0/0|::/0)",
|
|
10
|
+
"(0\\.0\\.0\\.0|::)[:'\"]",
|
|
11
|
+
"(AllowAny|IsAuthenticatedOrReadOnly|permitAll|anonymous[[:space:]]*=[[:space:]]*true|privileged[[:space:]]*:[[:space:]]*true|runAsUser[[:space:]]*:[[:space:]]*0)"
|
|
12
|
+
]
|
|
13
|
+
}
|
|
@@ -1,62 +1,62 @@
|
|
|
1
|
-
# Permissive Access Defaults
|
|
2
|
-
|
|
3
|
-
**Report when:** Access is granted to a party who should not have it, either because that is the hardcoded value (ACL='public-read', mode 0o666, Access-Control-Allow-Origin '*') or because it is what the unconfigured state falls back to. Both count; most real cases are hardcoded, with no configuration involved at all.
|
|
4
|
-
|
|
5
|
-
**Skip when:** Deliberate public endpoints with a stated reason. Local-only dev servers. Permissiveness already gated by an outer authorization layer at the same trust boundary.
|
|
6
|
-
|
|
7
|
-
Ask who gains access, not how wide the value looks. `0o644` on a CDN asset is correct; `0o666` on a key file is not.
|
|
8
|
-
|
|
9
|
-
## VULNERABLE - Report These
|
|
10
|
-
|
|
11
|
-
**File permissions world-writable**
|
|
12
|
-
```python
|
|
13
|
-
# File: src/storage/files.py
|
|
14
|
-
def create_secure_file(path):
|
|
15
|
-
fd = os.open(path, os.O_CREAT | os.O_WRONLY, 0o666) # rw-rw-rw-
|
|
16
|
-
return fd
|
|
17
|
-
```
|
|
18
|
-
**Why vulnerable:** Any user can write to file. Should be 0o600 or 0o644.
|
|
19
|
-
|
|
20
|
-
**S3 bucket public by default**
|
|
21
|
-
```python
|
|
22
|
-
# File: infrastructure/storage.py
|
|
23
|
-
def create_storage_bucket(name):
|
|
24
|
-
bucket = s3.create_bucket(
|
|
25
|
-
Bucket=name,
|
|
26
|
-
ACL='public-read' # Publicly readable by default
|
|
27
|
-
)
|
|
28
|
-
```
|
|
29
|
-
**Why vulnerable:** Sensitive data exposed publicly. Should require explicit configuration.
|
|
30
|
-
|
|
31
|
-
**API allows any origin**
|
|
32
|
-
```python
|
|
33
|
-
# File: app.py
|
|
34
|
-
@app.after_request
|
|
35
|
-
def after_request(response):
|
|
36
|
-
response.headers['Access-Control-Allow-Origin'] = '*'
|
|
37
|
-
response.headers['Access-Control-Allow-Credentials'] = 'true'
|
|
38
|
-
return response
|
|
39
|
-
```
|
|
40
|
-
**Why vulnerable:** CORS misconfiguration. Allows credential theft from any site.
|
|
41
|
-
|
|
42
|
-
## SECURE - Skip These
|
|
43
|
-
|
|
44
|
-
**Explicitly configured permissiveness with justification**
|
|
45
|
-
```python
|
|
46
|
-
# File: src/storage/public_assets.py
|
|
47
|
-
def create_public_asset(path):
|
|
48
|
-
"""Create world-readable asset for CDN distribution"""
|
|
49
|
-
# Intentionally public - static assets only
|
|
50
|
-
fd = os.open(path, os.O_CREAT | os.O_WRONLY, 0o644)
|
|
51
|
-
return fd
|
|
52
|
-
```
|
|
53
|
-
|
|
54
|
-
**Restrictive by default**
|
|
55
|
-
```python
|
|
56
|
-
# File: infrastructure/storage.py
|
|
57
|
-
def create_storage_bucket(name, public=False):
|
|
58
|
-
acl = 'public-read' if public else 'private'
|
|
59
|
-
if public:
|
|
60
|
-
logger.warning(f'Creating PUBLIC bucket: {name}')
|
|
61
|
-
bucket = s3.create_bucket(Bucket=name, ACL=acl)
|
|
62
|
-
```
|
|
1
|
+
# Permissive Access Defaults
|
|
2
|
+
|
|
3
|
+
**Report when:** Access is granted to a party who should not have it, either because that is the hardcoded value (ACL='public-read', mode 0o666, Access-Control-Allow-Origin '*') or because it is what the unconfigured state falls back to. Both count; most real cases are hardcoded, with no configuration involved at all.
|
|
4
|
+
|
|
5
|
+
**Skip when:** Deliberate public endpoints with a stated reason. Local-only dev servers. Permissiveness already gated by an outer authorization layer at the same trust boundary.
|
|
6
|
+
|
|
7
|
+
Ask who gains access, not how wide the value looks. `0o644` on a CDN asset is correct; `0o666` on a key file is not.
|
|
8
|
+
|
|
9
|
+
## VULNERABLE - Report These
|
|
10
|
+
|
|
11
|
+
**File permissions world-writable**
|
|
12
|
+
```python
|
|
13
|
+
# File: src/storage/files.py
|
|
14
|
+
def create_secure_file(path):
|
|
15
|
+
fd = os.open(path, os.O_CREAT | os.O_WRONLY, 0o666) # rw-rw-rw-
|
|
16
|
+
return fd
|
|
17
|
+
```
|
|
18
|
+
**Why vulnerable:** Any user can write to file. Should be 0o600 or 0o644.
|
|
19
|
+
|
|
20
|
+
**S3 bucket public by default**
|
|
21
|
+
```python
|
|
22
|
+
# File: infrastructure/storage.py
|
|
23
|
+
def create_storage_bucket(name):
|
|
24
|
+
bucket = s3.create_bucket(
|
|
25
|
+
Bucket=name,
|
|
26
|
+
ACL='public-read' # Publicly readable by default
|
|
27
|
+
)
|
|
28
|
+
```
|
|
29
|
+
**Why vulnerable:** Sensitive data exposed publicly. Should require explicit configuration.
|
|
30
|
+
|
|
31
|
+
**API allows any origin**
|
|
32
|
+
```python
|
|
33
|
+
# File: app.py
|
|
34
|
+
@app.after_request
|
|
35
|
+
def after_request(response):
|
|
36
|
+
response.headers['Access-Control-Allow-Origin'] = '*'
|
|
37
|
+
response.headers['Access-Control-Allow-Credentials'] = 'true'
|
|
38
|
+
return response
|
|
39
|
+
```
|
|
40
|
+
**Why vulnerable:** CORS misconfiguration. Allows credential theft from any site.
|
|
41
|
+
|
|
42
|
+
## SECURE - Skip These
|
|
43
|
+
|
|
44
|
+
**Explicitly configured permissiveness with justification**
|
|
45
|
+
```python
|
|
46
|
+
# File: src/storage/public_assets.py
|
|
47
|
+
def create_public_asset(path):
|
|
48
|
+
"""Create world-readable asset for CDN distribution"""
|
|
49
|
+
# Intentionally public - static assets only
|
|
50
|
+
fd = os.open(path, os.O_CREAT | os.O_WRONLY, 0o644)
|
|
51
|
+
return fd
|
|
52
|
+
```
|
|
53
|
+
|
|
54
|
+
**Restrictive by default**
|
|
55
|
+
```python
|
|
56
|
+
# File: infrastructure/storage.py
|
|
57
|
+
def create_storage_bucket(name, public=False):
|
|
58
|
+
acl = 'public-read' if public else 'private'
|
|
59
|
+
if public:
|
|
60
|
+
logger.warning(f'Creating PUBLIC bucket: {name}')
|
|
61
|
+
bucket = s3.create_bucket(Bucket=name, ACL=acl)
|
|
62
|
+
```
|
|
@@ -1,13 +1,13 @@
|
|
|
1
|
-
{
|
|
2
|
-
"id": "weak-crypto",
|
|
3
|
-
"title": "Weak cryptographic defaults",
|
|
4
|
-
"seeds": [
|
|
5
|
-
"(md5|sha1|MD5|SHA1)[[:space:]]*\\(",
|
|
6
|
-
"(^|[^A-Za-z])(DESede|DES|RC2|RC4|Blowfish|ECB|PKCS1v15)([^A-Za-z]|$)",
|
|
7
|
-
"(algorithm|alg|cipher|mode)[[:space:]]*[:=][[:space:]]*['\"](md5|sha1|none|HS256|DES|RC4|ECB)",
|
|
8
|
-
"(createHmac|createHash|createCipher|createCipheriv|getInstance|MessageDigest|hmac\\.new|HMAC|Signature)[^)]{0,40}['\"](md5|sha1|MD5|SHA1|DES|RC4)",
|
|
9
|
-
"['\"](md5|sha1|des|rc4|des-ede3-cbc|aes-[0-9]+-ecb)['\"]",
|
|
10
|
-
"(token|secret|key|password|passwd|salt|nonce|otp|session|csrf)[A-Za-z_]*[[:space:]]*[:=][[:space:]]*[^=]{0,60}(random\\.|Math\\.random|mt_rand|rand\\()",
|
|
11
|
-
"(random\\.|Math\\.random|mt_rand|rand\\()[^;]{0,80}(token|secret|key|password|salt|nonce|otp|session|csrf)"
|
|
12
|
-
]
|
|
13
|
-
}
|
|
1
|
+
{
|
|
2
|
+
"id": "weak-crypto",
|
|
3
|
+
"title": "Weak cryptographic defaults",
|
|
4
|
+
"seeds": [
|
|
5
|
+
"(md5|sha1|MD5|SHA1)[[:space:]]*\\(",
|
|
6
|
+
"(^|[^A-Za-z])(DESede|DES|RC2|RC4|Blowfish|ECB|PKCS1v15)([^A-Za-z]|$)",
|
|
7
|
+
"(algorithm|alg|cipher|mode)[[:space:]]*[:=][[:space:]]*['\"](md5|sha1|none|HS256|DES|RC4|ECB)",
|
|
8
|
+
"(createHmac|createHash|createCipher|createCipheriv|getInstance|MessageDigest|hmac\\.new|HMAC|Signature)[^)]{0,40}['\"](md5|sha1|MD5|SHA1|DES|RC4)",
|
|
9
|
+
"['\"](md5|sha1|des|rc4|des-ede3-cbc|aes-[0-9]+-ecb)['\"]",
|
|
10
|
+
"(token|secret|key|password|passwd|salt|nonce|otp|session|csrf)[A-Za-z_]*[[:space:]]*[:=][[:space:]]*[^=]{0,60}(random\\.|Math\\.random|mt_rand|rand\\()",
|
|
11
|
+
"(random\\.|Math\\.random|mt_rand|rand\\()[^;]{0,80}(token|secret|key|password|salt|nonce|otp|session|csrf)"
|
|
12
|
+
]
|
|
13
|
+
}
|
|
@@ -1,71 +1,71 @@
|
|
|
1
|
-
# Weak Cryptographic Defaults
|
|
2
|
-
|
|
3
|
-
**Report when:** A broken or non-cryptographic primitive standing in for a security-relevant one: password hashing, token generation, encryption, signature verification.
|
|
4
|
-
|
|
5
|
-
**Skip when:** Checksums, ETags, cache keys, deduplication hashes, test vectors. Non-security shuffling or sampling.
|
|
6
|
-
|
|
7
|
-
The algorithm alone is never the finding. `hashlib.md5` over a cache key is fine; the same call over a password is not. Trace to the use site before filing.
|
|
8
|
-
|
|
9
|
-
## VULNERABLE - Report These
|
|
10
|
-
|
|
11
|
-
**MD5 for password hashing**
|
|
12
|
-
```python
|
|
13
|
-
# File: src/auth/passwords.py
|
|
14
|
-
import hashlib
|
|
15
|
-
|
|
16
|
-
def hash_password(password):
|
|
17
|
-
"""Hash user password"""
|
|
18
|
-
return hashlib.md5(password.encode()).hexdigest()
|
|
19
|
-
```
|
|
20
|
-
**Why vulnerable:** MD5 is cryptographically broken. Rainbow tables exist. Use bcrypt/Argon2.
|
|
21
|
-
|
|
22
|
-
**DES encryption for sensitive data**
|
|
23
|
-
```java
|
|
24
|
-
// File: Encryption.java
|
|
25
|
-
public static byte[] encrypt(String data, byte[] key) {
|
|
26
|
-
Cipher cipher = Cipher.getInstance("DES/ECB/PKCS5Padding");
|
|
27
|
-
SecretKeySpec secretKey = new SecretKeySpec(key, "DES");
|
|
28
|
-
cipher.init(Cipher.ENCRYPT_MODE, secretKey);
|
|
29
|
-
return cipher.doFinal(data.getBytes());
|
|
30
|
-
}
|
|
31
|
-
```
|
|
32
|
-
**Why vulnerable:** DES has 56-bit keys (brute-forceable). ECB mode leaks patterns.
|
|
33
|
-
|
|
34
|
-
**SHA1 for signature verification**
|
|
35
|
-
```javascript
|
|
36
|
-
// File: webhooks.js
|
|
37
|
-
function verifySignature(payload, signature) {
|
|
38
|
-
const hmac = crypto.createHmac('sha1', WEBHOOK_SECRET);
|
|
39
|
-
const computed = hmac.update(payload).digest('hex');
|
|
40
|
-
return computed === signature;
|
|
41
|
-
}
|
|
42
|
-
```
|
|
43
|
-
**Why vulnerable:** SHA1 collisions exist. Use SHA256 or better.
|
|
44
|
-
|
|
45
|
-
## SECURE - Skip These
|
|
46
|
-
|
|
47
|
-
**Weak crypto for non-security checksums**
|
|
48
|
-
```python
|
|
49
|
-
# File: src/utils/cache.py
|
|
50
|
-
import hashlib
|
|
51
|
-
|
|
52
|
-
def cache_key(data):
|
|
53
|
-
"""Generate cache key - not security-sensitive"""
|
|
54
|
-
return hashlib.md5(data.encode()).hexdigest() # OK - just for cache lookup
|
|
55
|
-
```
|
|
56
|
-
|
|
57
|
-
**Modern crypto for passwords**
|
|
58
|
-
```python
|
|
59
|
-
# File: src/auth/passwords.py
|
|
60
|
-
import bcrypt
|
|
61
|
-
|
|
62
|
-
def hash_password(password):
|
|
63
|
-
return bcrypt.hashpw(password.encode(), bcrypt.gensalt())
|
|
64
|
-
```
|
|
65
|
-
|
|
66
|
-
**Strong encryption**
|
|
67
|
-
```java
|
|
68
|
-
// File: Encryption.java
|
|
69
|
-
Cipher cipher = Cipher.getInstance("AES/GCM/NoPadding");
|
|
70
|
-
// 256-bit key, authenticated encryption
|
|
71
|
-
```
|
|
1
|
+
# Weak Cryptographic Defaults
|
|
2
|
+
|
|
3
|
+
**Report when:** A broken or non-cryptographic primitive standing in for a security-relevant one: password hashing, token generation, encryption, signature verification.
|
|
4
|
+
|
|
5
|
+
**Skip when:** Checksums, ETags, cache keys, deduplication hashes, test vectors. Non-security shuffling or sampling.
|
|
6
|
+
|
|
7
|
+
The algorithm alone is never the finding. `hashlib.md5` over a cache key is fine; the same call over a password is not. Trace to the use site before filing.
|
|
8
|
+
|
|
9
|
+
## VULNERABLE - Report These
|
|
10
|
+
|
|
11
|
+
**MD5 for password hashing**
|
|
12
|
+
```python
|
|
13
|
+
# File: src/auth/passwords.py
|
|
14
|
+
import hashlib
|
|
15
|
+
|
|
16
|
+
def hash_password(password):
|
|
17
|
+
"""Hash user password"""
|
|
18
|
+
return hashlib.md5(password.encode()).hexdigest()
|
|
19
|
+
```
|
|
20
|
+
**Why vulnerable:** MD5 is cryptographically broken. Rainbow tables exist. Use bcrypt/Argon2.
|
|
21
|
+
|
|
22
|
+
**DES encryption for sensitive data**
|
|
23
|
+
```java
|
|
24
|
+
// File: Encryption.java
|
|
25
|
+
public static byte[] encrypt(String data, byte[] key) {
|
|
26
|
+
Cipher cipher = Cipher.getInstance("DES/ECB/PKCS5Padding");
|
|
27
|
+
SecretKeySpec secretKey = new SecretKeySpec(key, "DES");
|
|
28
|
+
cipher.init(Cipher.ENCRYPT_MODE, secretKey);
|
|
29
|
+
return cipher.doFinal(data.getBytes());
|
|
30
|
+
}
|
|
31
|
+
```
|
|
32
|
+
**Why vulnerable:** DES has 56-bit keys (brute-forceable). ECB mode leaks patterns.
|
|
33
|
+
|
|
34
|
+
**SHA1 for signature verification**
|
|
35
|
+
```javascript
|
|
36
|
+
// File: webhooks.js
|
|
37
|
+
function verifySignature(payload, signature) {
|
|
38
|
+
const hmac = crypto.createHmac('sha1', WEBHOOK_SECRET);
|
|
39
|
+
const computed = hmac.update(payload).digest('hex');
|
|
40
|
+
return computed === signature;
|
|
41
|
+
}
|
|
42
|
+
```
|
|
43
|
+
**Why vulnerable:** SHA1 collisions exist. Use SHA256 or better.
|
|
44
|
+
|
|
45
|
+
## SECURE - Skip These
|
|
46
|
+
|
|
47
|
+
**Weak crypto for non-security checksums**
|
|
48
|
+
```python
|
|
49
|
+
# File: src/utils/cache.py
|
|
50
|
+
import hashlib
|
|
51
|
+
|
|
52
|
+
def cache_key(data):
|
|
53
|
+
"""Generate cache key - not security-sensitive"""
|
|
54
|
+
return hashlib.md5(data.encode()).hexdigest() # OK - just for cache lookup
|
|
55
|
+
```
|
|
56
|
+
|
|
57
|
+
**Modern crypto for passwords**
|
|
58
|
+
```python
|
|
59
|
+
# File: src/auth/passwords.py
|
|
60
|
+
import bcrypt
|
|
61
|
+
|
|
62
|
+
def hash_password(password):
|
|
63
|
+
return bcrypt.hashpw(password.encode(), bcrypt.gensalt())
|
|
64
|
+
```
|
|
65
|
+
|
|
66
|
+
**Strong encryption**
|
|
67
|
+
```java
|
|
68
|
+
// File: Encryption.java
|
|
69
|
+
Cipher cipher = Cipher.getInstance("AES/GCM/NoPadding");
|
|
70
|
+
// 256-bit key, authenticated encryption
|
|
71
|
+
```
|