harness-everything 0.2.1 → 0.3.6

package/scripts/lib/advisory-text.js

@@ -1,163 +1,167 @@
-// Prompt-injection-only guidance for platforms with no hook/execution
-// mechanism (Cursor, Copilot, Codex, Continue, Hermes). Single source of
-// truth for the advisory block - it used to be duplicated verbatim inside
-// installer.js's top level and again inside main().
-const fs = require('fs');
-const path = require('path');
-
-const MARKER = "Harness OS Guidance (Advisory)";
-
-const advisoryInstructions = [
-  `\n# ${MARKER}`,
-  `This file is advisory only - this platform has no hook/execution mechanism to`,
-  `enforce it mechanically (unlike Claude Code's hook-based circuit breaker). Treat`,
-  `these as strong defaults, not guarantees.`,
-  ``,
-  `## 🚦 MANDATORY ENTRY TRIAGE & ROUTING (ALWAYS RUN FIRST)`,
-  `Every time you receive a new prompt, you MUST load the \`harness-everything\` skill and immediately do the following:`,
-  `1. Run the Tier Router script: \`node harness-everything/scripts/tier-router.js "<Brief summary of user's prompt>"\` (or simulate its routing logic if terminal is not initialized yet).`,
-  `2. Output a clear, stylized routing checkpoint block at the VERY BEGINNING of your response to the user:`,
-  `   \`\`\`markdown`,
-  `   ## 🚦 Harness OS Routing Checkpoint`,
-  `   - **Active Tier**: Tier 1 (Trivial) | Tier 2 (Standard) | Tier 3 (Macro)`,
-  `   - **Rationale**: <1-sentence rationale from the tier router output>`,
-  `   - **Routed Skills, Guides & Actions**:`,
-  `     - \`path/to/skill/or/guide.md\` (<Brief reason why this guide/skill is loaded/used>)`,
-  `   \`\`\``,
-  ``,
-  `## 🤖 COGNITIVE COMPLIANCE (NO SILENT DEGRADES FOR NEW FEATURES)`,
-  `- **Newly Added Features / Extensions**: Copilot is highly prone to treating new feature requests as Tier 1 direct edits. If a task introduces *any* new logic, a new API endpoint, or a new file/module, you **MUST NOT** treat it as Tier 1. It **MUST** be treated as a **Tier 2 (Standard Task)** or **Tier 3 (Macro Task)**.`,
-  `- **Tier 2 Activation**: Initialize the \`todo-driven-workflow\` checklist first. Summon Domain Experts based on tech stack. Load and execute the \`tdd\` (Test-Driven Development) skill (write tests first, implement, refactor).`,
-  `- **Tier 3 Activation**: Initialize the \`todo-driven-workflow\` checklist, load \`fable-mode\` and \`fable-discipline\`, run sub-agents via \`create-agent-launcher\`, and write global docs using \`repo-docs\`.`,
-  `- **Memory Summarization (Self-Evolve)**: Upon task completion, you **MUST** run the \`self-evolve\` skill (running \`node self-evolve/scripts/self-regression.js\` or writing memories) to record key insights, lessons learned, and error boundaries so your context builds across sessions.`,
-  `- **Environment Discovery**: Discover the environment (OS, shell, package manager) before running commands - don't assume.`,
-  `- **Rule of 3**: If the same error repeats 3 times in a row, STOP retrying. Explain what's failing and ask the human for direction instead of continuing to guess.`,
-  `- **Prefer Editing**: Prefer editing over rewriting; commit logically complete chunks rather than one giant diff.`,
-  ``
-].join('\n');
-
-function injectAdvisoryText(targetFile, header, label) {
-  const dir = path.dirname(targetFile);
-  if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
-
-  if (fs.existsSync(targetFile)) {
-    const content = fs.readFileSync(targetFile, 'utf8');
-    if (!content.includes(MARKER)) {
-      fs.appendFileSync(targetFile, advisoryInstructions, 'utf8');
-      console.log(`  ✅ Augmented existing ${label} with Harness guidance (advisory-only)`);
-    }
-  } else {
-    fs.writeFileSync(targetFile, `${header}\n${advisoryInstructions}`, 'utf8');
-    console.log(`  ✅ Created ${label} with Harness guidance (advisory-only)`);
-  }
-}
-
-function removeAdvisoryText(targetFile) {
-  if (!fs.existsSync(targetFile)) return;
-  try {
-    let content = fs.readFileSync(targetFile, 'utf8');
-    const markerIndex = content.indexOf(MARKER);
-    if (markerIndex !== -1) {
-      let cleanContent = content;
-      const hashMarkerIndex = content.lastIndexOf('#', markerIndex);
-      if (hashMarkerIndex !== -1) {
-        cleanContent = content.substring(0, hashMarkerIndex).trim() + '\n';
-      } else {
-        cleanContent = content.substring(0, markerIndex).trim() + '\n';
-      }
-
-      const lines = cleanContent.trim().split('\n').map(l => l.trim()).filter(l => l !== '');
-      if (lines.length === 0 || (lines.length === 1 && (lines[0] === '# Cursor Project Rules' || lines[0] === '# AGENTS.md' || lines[0] === '# Copilot Instructions' || lines[0] === '# .hermes.md'))) {
-        fs.unlinkSync(targetFile);
-        console.log(`  ✅ Removed empty advisory file: ${targetFile}`);
-      } else {
-        fs.writeFileSync(targetFile, cleanContent.trim() + '\n', 'utf8');
-        console.log(`  ✅ Removed Harness guidance from: ${targetFile}`);
-      }
-    }
-  } catch (e) {
-    console.warn(`  ⚠️ Error removing advisory text from ${targetFile}: ${e.message}`);
-  }
-}
-
-// Continue.dev reads project rules as individual Markdown files (with YAML
-// frontmatter) from a `.continue/rules/` folder rather than one shared file,
-// so - unlike the shared-file platforms above - Harness gets its own
-// dedicated `harness.md` rule file instead of appending into an arbitrary
-// pre-existing one.
-function installContinueRule(targetFile, label) {
-  const dir = path.dirname(targetFile);
-  if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
-  if (fs.existsSync(targetFile) && fs.readFileSync(targetFile, 'utf8').includes(MARKER)) {
-    return;
-  }
-  const content = [
-    `---`,
-    `name: Harness OS Guidance`,
-    `alwaysApply: true`,
-    `description: "Harness OS routing, circuit-breaker awareness, and environment-discovery guidance (advisory only on Continue - no hook mechanism)"`,
-    `---`,
-    advisoryInstructions.replace(/^\n/, '')
-  ].join('\n');
-  fs.writeFileSync(targetFile, content, 'utf8');
-  console.log(`  ✅ Installed Continue rule file with Harness guidance (advisory-only): ${label}`);
-}
-
-function removeContinueRule(targetFile) {
-  if (!fs.existsSync(targetFile)) return;
-  try {
-    const content = fs.readFileSync(targetFile, 'utf8');
-    if (content.includes(MARKER)) {
-      fs.unlinkSync(targetFile);
-      console.log(`  ✅ Removed Harness rule file: ${targetFile}`);
-    }
-  } catch (e) {
-    console.warn(`  ⚠️ Error removing ${targetFile}: ${e.message}`);
-  }
-}
-
-function buildCopilotGlobalContent() {
-  return [
-    `---`,
-    `description: "Harness OS Guidance (Advisory)"`,
-    `applyTo: "**"`,
-    `---`,
-    `# Copilot Instructions`,
-    ``,
-    advisoryInstructions.replace(/^\n/, '')
-  ].join('\n');
-}
-
-function buildCodexGlobalContent() {
-  return [
-    `---`,
-    `description: "Harness OS Guidance - Global custom agent for orchestrating multi-agent workflows"`,
-    `name: "Harness"`,
-    `user-invocable: true`,
-    `---`,
-    `# AGENTS.md`,
-    ``,
-    `This file is advisory only - this platform has no hook/execution mechanism to`,
-    `enforce it mechanically (unlike Claude Code's hook-based circuit breaker). Treat`,
-    `these as strong defaults, not guarantees.`,
-    ``,
-    `- Discover the environment (OS, shell, package manager) before running commands - don't assume.`,
-    `- Triage tasks: trivial fixes need no plan; standard features need tests; large refactors need`,
-    `  an explicit plan reviewed with the human before implementation.`,
-    `- If the same error repeats 3 times in a row, STOP retrying. Explain what's failing and ask the`,
-    `  human for direction instead of continuing to guess.`,
-    `- Prefer editing over rewriting; commit logically complete chunks rather than one giant diff.`,
-    ``
-  ].join('\n');
-}
-
-module.exports = {
-  MARKER,
-  advisoryInstructions,
-  injectAdvisoryText,
-  removeAdvisoryText,
-  installContinueRule,
-  removeContinueRule,
-  buildCopilotGlobalContent,
-  buildCodexGlobalContent,
-};
+// Prompt-injection-only guidance for platforms with no hook/execution
+// mechanism (Cursor, Copilot, Codex, Continue, Hermes). Single source of
+// truth for the advisory block - it used to be duplicated verbatim inside
+// installer.js's top level and again inside main().
+const fs = require('fs');
+const path = require('path');
+
+const MARKER = "Harness OS Guidance (Advisory)";
+
+const advisoryInstructions = [
+  `\n# ${MARKER}`,
+  `This file is advisory only - this platform has no hook/execution mechanism to`,
+  `enforce it mechanically (unlike Claude Code's hook-based circuit breaker). Treat`,
+  `these as strong defaults, not guarantees.`,
+  ``,
+  `## 🚦 MANDATORY ENTRY TRIAGE & ROUTING (ALWAYS RUN FIRST)`,
+  `Every time you receive a new prompt, you MUST load the \`harness-everything\` skill and immediately do the following:`,
+  `1. Run \`npx github:dyphn1/Harness-everything next "<Brief summary of user's prompt>"\` (this prints the same routing recommendation tier-router.js produces - it works from any directory and does not depend on where a local copy of the skill was installed). If the terminal is not available yet, simulate its routing logic from the rules below instead of skipping this step.`,
+  `2. Output a clear, stylized routing checkpoint block at the VERY BEGINNING of your response to the user:`,
+  `   \`\`\`markdown`,
+  `   ## 🚦 Harness OS Routing Checkpoint`,
+  `   - **Active Tier**: Tier 1 (Trivial) | Tier 2 (Standard) | Tier 3 (Macro)`,
+  `   - **Rationale**: <1-sentence rationale from the tier router output>`,
+  `   - **Routed Skills, Guides & Actions**:`,
+  `     - \`path/to/skill/or/guide.md\` (<Brief reason why this guide/skill is loaded/used>)`,
+  `   \`\`\``,
+  ``,
+  `## 🤖 COGNITIVE COMPLIANCE (NO SILENT DEGRADES FOR NEW FEATURES)`,
+  `- **Newly Added Features / Extensions**: Copilot is highly prone to treating new feature requests as Tier 1 direct edits. If a task introduces *any* new logic, a new API endpoint, or a new file/module, you **MUST NOT** treat it as Tier 1. It **MUST** be treated as a **Tier 2 (Standard Task)** or **Tier 3 (Macro Task)**.`,
+  `- **Tier 2 Activation**: Initialize the \`todo-driven-workflow\` checklist first. Summon Domain Experts based on tech stack. Load and execute the \`tdd\` (Test-Driven Development) skill (write tests first, implement, refactor).`,
+  `- **Tier 3 Activation**: Initialize the \`todo-driven-workflow\` checklist, load \`fable-mode\` and \`fable-discipline\`, run sub-agents via \`multi-agent-workspace\`, and write global docs using \`repo-docs\`.`,
+  `- **Pre-Completion Verification Gate**: Before telling the human the task is done, run \`npx github:dyphn1/Harness-everything verify\` in the project root. If it exits non-zero, fix the failures and run it again before declaring completion. On Claude Code this same check is mechanically enforced by a stop hook; here nothing blocks you from skipping it, so treat it as a real requirement, not a suggestion.`,
+  `- **Memory Summarization (Self-Evolve)**: Upon task completion, you **MUST** run the \`self-evolve\` skill (running \`node self-evolve/scripts/self-regression.js\` or writing memories) to record key insights, lessons learned, and error boundaries so your context builds across sessions.`,
+  `- **Environment Discovery**: Discover the environment (OS, shell, package manager) before running commands - don't assume.`,
+  `- **Rule of 3**: If the same error repeats 3 times in a row, STOP retrying. Explain what's failing and ask the human for direction instead of continuing to guess.`,
+  `- **Prefer Editing**: Prefer editing over rewriting; commit logically complete chunks rather than one giant diff.`,
+  ``
+].join('\n');
+
+function injectAdvisoryText(targetFile, header, label) {
+  const dir = path.dirname(targetFile);
+  if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
+
+  if (fs.existsSync(targetFile)) {
+    const content = fs.readFileSync(targetFile, 'utf8');
+    if (!content.includes(MARKER)) {
+      fs.appendFileSync(targetFile, advisoryInstructions, 'utf8');
+      console.log(`  ✅ Augmented existing ${label} with Harness guidance (advisory-only)`);
+    }
+  } else {
+    fs.writeFileSync(targetFile, `${header}\n${advisoryInstructions}`, 'utf8');
+    console.log(`  ✅ Created ${label} with Harness guidance (advisory-only)`);
+  }
+}
+
+function removeAdvisoryText(targetFile) {
+  if (!fs.existsSync(targetFile)) return;
+  try {
+    let content = fs.readFileSync(targetFile, 'utf8');
+    const markerIndex = content.indexOf(MARKER);
+    if (markerIndex !== -1) {
+      let cleanContent = content;
+      const hashMarkerIndex = content.lastIndexOf('#', markerIndex);
+      if (hashMarkerIndex !== -1) {
+        cleanContent = content.substring(0, hashMarkerIndex).trim() + '\n';
+      } else {
+        cleanContent = content.substring(0, markerIndex).trim() + '\n';
+      }
+
+      const lines = cleanContent.trim().split('\n').map(l => l.trim()).filter(l => l !== '');
+      if (lines.length === 0 || (lines.length === 1 && (lines[0] === '# Cursor Project Rules' || lines[0] === '# AGENTS.md' || lines[0] === '# Copilot Instructions' || lines[0] === '# .hermes.md'))) {
+        fs.unlinkSync(targetFile);
+        console.log(`  ✅ Removed empty advisory file: ${targetFile}`);
+      } else {
+        fs.writeFileSync(targetFile, cleanContent.trim() + '\n', 'utf8');
+        console.log(`  ✅ Removed Harness guidance from: ${targetFile}`);
+      }
+    }
+  } catch (e) {
+    console.warn(`  ⚠️ Error removing advisory text from ${targetFile}: ${e.message}`);
+  }
+}
+
+// Continue.dev reads project rules as individual Markdown files (with YAML
+// frontmatter) from a `.continue/rules/` folder rather than one shared file,
+// so - unlike the shared-file platforms above - Harness gets its own
+// dedicated `harness.md` rule file instead of appending into an arbitrary
+// pre-existing one.
+function installContinueRule(targetFile, label) {
+  const dir = path.dirname(targetFile);
+  if (!fs.existsSync(dir)) fs.mkdirSync(dir, { recursive: true });
+  if (fs.existsSync(targetFile) && fs.readFileSync(targetFile, 'utf8').includes(MARKER)) {
+    return;
+  }
+  const content = [
+    `---`,
+    `name: Harness OS Guidance`,
+    `alwaysApply: true`,
+    `description: "Harness OS routing, circuit-breaker awareness, and environment-discovery guidance (advisory only on Continue - no hook mechanism)"`,
+    `---`,
+    advisoryInstructions.replace(/^\n/, '')
+  ].join('\n');
+  fs.writeFileSync(targetFile, content, 'utf8');
+  console.log(`  ✅ Installed Continue rule file with Harness guidance (advisory-only): ${label}`);
+}
+
+function removeContinueRule(targetFile) {
+  if (!fs.existsSync(targetFile)) return;
+  try {
+    const content = fs.readFileSync(targetFile, 'utf8');
+    if (content.includes(MARKER)) {
+      fs.unlinkSync(targetFile);
+      console.log(`  ✅ Removed Harness rule file: ${targetFile}`);
+    }
+  } catch (e) {
+    console.warn(`  ⚠️ Error removing ${targetFile}: ${e.message}`);
+  }
+}
+
+function buildCopilotGlobalContent() {
+  return [
+    `---`,
+    `description: "Harness OS Guidance (Advisory)"`,
+    `applyTo: "**"`,
+    `---`,
+    `# Copilot Instructions`,
+    ``,
+    advisoryInstructions.replace(/^\n/, '')
+  ].join('\n');
+}
+
+function buildCodexGlobalContent() {
+  return [
+    `---`,
+    `description: "Harness OS Guidance - Global custom agent for orchestrating multi-agent workflows"`,
+    `name: "Harness"`,
+    `user-invocable: true`,
+    `---`,
+    `# AGENTS.md`,
+    ``,
+    `This file is advisory only - this platform has no hook/execution mechanism to`,
+    `enforce it mechanically (unlike Claude Code's hook-based circuit breaker). Treat`,
+    `these as strong defaults, not guarantees.`,
+    ``,
+    `- Discover the environment (OS, shell, package manager) before running commands - don't assume.`,
+    `- Triage tasks: run \`npx github:dyphn1/Harness-everything next "<summary>"\` for a routing recommendation`,
+    `  (trivial fixes need no plan; standard features need tests; large refactors need an explicit plan`,
+    `  reviewed with the human before implementation).`,
+    `- Before declaring a task done, run \`npx github:dyphn1/Harness-everything verify\` and fix any failures`,
+    `  it reports - nothing here blocks you from skipping this, so treat it as a real requirement.`,
+    `- If the same error repeats 3 times in a row, STOP retrying. Explain what's failing and ask the`,
+    `  human for direction instead of continuing to guess.`,
+    `- Prefer editing over rewriting; commit logically complete chunks rather than one giant diff.`,
+    ``
+  ].join('\n');
+}
+
+module.exports = {
+  MARKER,
+  advisoryInstructions,
+  injectAdvisoryText,
+  removeAdvisoryText,
+  installContinueRule,
+  removeContinueRule,
+  buildCopilotGlobalContent,
+  buildCodexGlobalContent,
+};

package/scripts/lib/claude-hooks.js

@@ -1,71 +1,84 @@
-// Merge/remove Harness's hook entries in a Claude Code settings.json without
-// disturbing anything else a user (or another tool) put there.
-const fs = require('fs');
-
-// Every hook this package ships is namespaced "harness:<phase>:<name>" (see
-// hooks/hooks.json) specifically so removal can match on that prefix alone -
-// never on loose text like "does the command mention harness", which could
-// false-positive on someone else's unrelated hook (e.g. a script whose path
-// or name happens to contain "harness").
-function isHarnessHook(hook) {
-  return !!(hook && hook.id && hook.id.startsWith('harness:'));
-}
-
-function mergeHarnessHooks(claudeConfig, resolvedHooks) {
-  claudeConfig.hooks = claudeConfig.hooks || {};
-  for (const [hookType, hookList] of Object.entries(resolvedHooks)) {
-    const existingList = claudeConfig.hooks[hookType] || [];
-    const mergedList = [...existingList];
-    hookList.forEach(newHook => {
-      const existsIdx = mergedList.findIndex(h => h.id === newHook.id);
-      if (existsIdx !== -1) {
-        mergedList[existsIdx] = newHook;
-      } else {
-        mergedList.push(newHook);
-      }
-    });
-    claudeConfig.hooks[hookType] = mergedList;
-  }
-  return claudeConfig;
-}
-
-function removeHarnessHooks(claudeSettingsFile) {
-  if (!fs.existsSync(claudeSettingsFile)) return false;
-  try {
-    const content = fs.readFileSync(claudeSettingsFile, 'utf8');
-    let config = JSON.parse(content);
-    if (!config.hooks) return false;
-
-    let modified = false;
-    for (const [hookType, hookList] of Object.entries(config.hooks)) {
-      if (!Array.isArray(hookList)) continue;
-      const originalLength = hookList.length;
-      config.hooks[hookType] = hookList.filter(hook => !isHarnessHook(hook));
-      if (config.hooks[hookType].length !== originalLength) {
-        modified = true;
-      }
-      if (config.hooks[hookType].length === 0) {
-        delete config.hooks[hookType];
-      }
-    }
-    if (Object.keys(config.hooks || {}).length === 0) {
-      delete config.hooks;
-    }
-
-    if (modified) {
-      if (Object.keys(config).length === 0) {
-        fs.unlinkSync(claudeSettingsFile);
-        console.log(`  ✅ Cleaned up and removed empty Claude settings file: ${claudeSettingsFile}`);
-      } else {
-        fs.writeFileSync(claudeSettingsFile, JSON.stringify(config, null, 2), 'utf8');
-        console.log(`  ✅ Safely removed Harness hooks from Claude settings: ${claudeSettingsFile}`);
-      }
-      return true;
-    }
-  } catch (e) {
-    console.warn(`  ⚠️ Error cleaning Claude settings file ${claudeSettingsFile}: ${e.message}`);
-  }
-  return false;
-}
-
-module.exports = { isHarnessHook, mergeHarnessHooks, removeHarnessHooks };
+// Merge/remove Harness's hook entries in a Claude Code settings.json without
+// disturbing anything else a user (or another tool) put there.
+const fs = require('fs');
+
+// Every hook this package ships is namespaced "harness:<phase>:<name>" (see
+// hooks/hooks.json) specifically so removal can match on that prefix alone.
+// To handle legacy installations (pre-0.3.0 or older) where hooks were installed
+// without an "id" field, we also check if any command contains keywords like
+// "harness-everything" or "harness-skills".
+function isHarnessHook(hook) {
+  if (!hook) return false;
+  if (hook.id && hook.id.startsWith('harness:')) {
+    return true;
+  }
+  if (Array.isArray(hook.hooks)) {
+    return hook.hooks.some(h => {
+      return h && typeof h.command === 'string' && (
+        h.command.includes('harness-everything') ||
+        h.command.includes('harness-skills') ||
+        h.command.includes('harness-state')
+      );
+    });
+  }
+  return false;
+}
+
+function mergeHarnessHooks(claudeConfig, resolvedHooks) {
+  claudeConfig.hooks = claudeConfig.hooks || {};
+  for (const [hookType, hookList] of Object.entries(resolvedHooks)) {
+    const existingList = claudeConfig.hooks[hookType] || [];
+    const mergedList = [...existingList];
+    hookList.forEach(newHook => {
+      const existsIdx = mergedList.findIndex(h => h.id === newHook.id);
+      if (existsIdx !== -1) {
+        mergedList[existsIdx] = newHook;
+      } else {
+        mergedList.push(newHook);
+      }
+    });
+    claudeConfig.hooks[hookType] = mergedList;
+  }
+  return claudeConfig;
+}
+
+function removeHarnessHooks(claudeSettingsFile) {
+  if (!fs.existsSync(claudeSettingsFile)) return false;
+  try {
+    const content = fs.readFileSync(claudeSettingsFile, 'utf8');
+    let config = JSON.parse(content);
+    if (!config.hooks) return false;
+
+    let modified = false;
+    for (const [hookType, hookList] of Object.entries(config.hooks)) {
+      if (!Array.isArray(hookList)) continue;
+      const originalLength = hookList.length;
+      config.hooks[hookType] = hookList.filter(hook => !isHarnessHook(hook));
+      if (config.hooks[hookType].length !== originalLength) {
+        modified = true;
+      }
+      if (config.hooks[hookType].length === 0) {
+        delete config.hooks[hookType];
+      }
+    }
+    if (Object.keys(config.hooks || {}).length === 0) {
+      delete config.hooks;
+    }
+
+    if (modified) {
+      if (Object.keys(config).length === 0) {
+        fs.unlinkSync(claudeSettingsFile);
+        console.log(`  ✅ Cleaned up and removed empty Claude settings file: ${claudeSettingsFile}`);
+      } else {
+        fs.writeFileSync(claudeSettingsFile, JSON.stringify(config, null, 2), 'utf8');
+        console.log(`  ✅ Safely removed Harness hooks from Claude settings: ${claudeSettingsFile}`);
+      }
+      return true;
+    }
+  } catch (e) {
+    console.warn(`  ⚠️ Error cleaning Claude settings file ${claudeSettingsFile}: ${e.message}`);
+  }
+  return false;
+}
+
+module.exports = { isHarnessHook, mergeHarnessHooks, removeHarnessHooks };