hardhat 3.4.3 → 3.4.4

package/src/internal/cli/telemetry/sentry/anonymizer.ts

@@ -153,174 +153,6 @@ export class Anonymizer {
     );
   }
 
-  public filterOutEventsWithExceptionsNotRaisedByHardhat(
-    envelope: Envelope,
-  ): Envelope {
-    /* eslint-disable-next-line @typescript-eslint/consistent-type-assertions --
-      We are just filtering events in place, not changing any type */
-    envelope[1] = envelope[1].filter((item) => {
-      if (item[0].type !== "event") {
-        return true;
-      }
-
-      /* eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-          -- We know that the item is an event item */
-      const eventItem = item as EventItem;
-
-      return this.raisedByHardhat(eventItem[1]);
-    }) as any;
-
-    return envelope;
-  }
-
-  public raisedByHardhat(event: Event): boolean {
-    const exceptions = event?.exception?.values;
-
-    if (exceptions === undefined) {
-      // if we can't prove that the exception doesn't come from hardhat,
-      // we err on the side of reporting the error
-      return true;
-    }
-
-    const originalException = exceptions[exceptions.length - 1];
-
-    if (!this.#isErrorMessageAllowed(originalException)) {
-      return false;
-    }
-
-    const frames = originalException?.stacktrace?.frames;
-
-    if (frames === undefined) {
-      return true;
-    }
-
-    for (const frame of frames.slice().reverse()) {
-      if (frame.filename === undefined) {
-        continue;
-      }
-
-      // We don't report errors from the Hardhat.config file
-      if (
-        this.#configPath !== undefined &&
-        this.#configPath.includes(frame.filename)
-      ) {
-        return false;
-      }
-
-      if (this.#isPackageFile(frame.filename)) {
-        // We don't report errors from the ignored package list e.g. `ethers`
-        // even when buried as a subpackage of a hardhat package
-        if (this.#errorRaisedByPackageToIgnore(frame.filename)) {
-          return false;
-        }
-
-        // We report errors from Hardhat packages, we exclude
-        // those from non-hardhat packages
-        return this.#isHardhatFile(frame.filename);
-      }
-
-      // Error originating not in packages, but in the user project
-      // should be filtered.
-      if (this.#isUserProjectFile(frame.filename)) {
-        return false;
-      }
-
-      // Otherwise look at the next frame up
-    }
-
-    // if we didn't find any hardhat frame, we don't report the error
-    return false;
-  }
-
-  #isErrorMessageAllowed(originalException: Exception): boolean {
-    const exceptionType = originalException.type;
-    const exceptionMessage = originalException.value;
-
-    // Without an exception message, we can't filter so allow it
-    if (exceptionMessage === undefined) {
-      return true;
-    }
-
-    // Filter out required not defined in ES Modules errors
-    if (
-      exceptionType === "ReferenceError" &&
-      exceptionMessage ===
-        "require is not defined in ES module scope, you can use import instead"
-    ) {
-      return false;
-    }
-
-    // Filter out cannot find package when importing errors
-    if (
-      exceptionType === "Error" &&
-      /^Cannot find package '([^']+)' imported from .+$/.test(exceptionMessage)
-    ) {
-      return false;
-    }
-
-    // Filter out cannot find module errors
-    if (
-      exceptionType === "Error" &&
-      /^Cannot find module '([^']+)'/.test(exceptionMessage)
-    ) {
-      return false;
-    }
-
-    // Filter out "require() cannot be sued on an ESM graph"
-    if (
-      exceptionType === "Error" &&
-      exceptionMessage.startsWith(
-        "require() cannot be used on an ESM graph with top-level await. Use import() instead.",
-      )
-    ) {
-      return false;
-    }
-
-    return true;
-  }
-
-  #errorRaisedByPackageToIgnore(filename: string): boolean {
-    // List of external packages that we don't want to report errors from
-    const pkgsToIgnore: string[] = [
-      path.join("node_modules", "@ethersproject"),
-    ];
-
-    // Match path separators both for Windows and Unix
-    const pkgs = filename.match(/node_modules[\/\\][^\/\\]+/g);
-
-    if (pkgs === null) {
-      return false;
-    }
-
-    const errorSourcePkg = pkgs[pkgs.length - 1];
-
-    return pkgsToIgnore.includes(errorSourcePkg);
-  }
-
-  #isHardhatFile(filename: string): boolean {
-    const nomicFoundationPath = path.join("node_modules", "@nomicfoundation");
-    const ignoredOrgPath = path.join("node_modules", "@ignored");
-    const hardhatPath = path.join("node_modules", "hardhat");
-
-    filename = filename.toLowerCase();
-
-    return (
-      filename.includes(nomicFoundationPath) ||
-      filename.includes(ignoredOrgPath) ||
-      filename.includes(hardhatPath)
-    );
-  }
-
-  #isPackageFile(filename: string): boolean {
-    return filename.includes("node_modules");
-  }
-
-  #isUserProjectFile(filename: string): boolean {
-    const anonymizedUserPath = anonymizeUserPaths(filename);
-
-    return anonymizedUserPath === ANONYMIZED_PATH;
-  }
-
   async #anonymizeExceptions(exceptions: Exception[]): Promise<Exception[]> {
     const anonymizedExceptions = await Promise.all(
       exceptions.map((exception) => this.#anonymizeException(exception)),

package/src/internal/cli/telemetry/sentry/init.ts

@@ -3,9 +3,10 @@
 import type { ServerRuntimeClientOptions, Transport } from "@sentry/core";
 
 import os from "node:os";
-import path from "node:path";
 
+import { getRuntimeInfo } from "@nomicfoundation/hardhat-utils/runtime";
 import {
+  applySdkMetadata,
   createStackParser,
   functionToStringIntegration,
   initAndBind,
@@ -61,40 +62,48 @@ interface GlobalCustomSentryReporterOptions {
  * errors integration.
  */
 export function init(options: GlobalCustomSentryReporterOptions): void {
-  initAndBind<ServerRuntimeClient, ServerRuntimeClientOptions>(
-    ServerRuntimeClient,
-    {
-      dsn: options.dsn,
-      environment: options.environment,
-      serverName: GENERIC_SERVER_NAME,
-      release: options.release,
-      initialScope: {
-        contexts: {
-          os: {
-            name: os.type(),
-            build: os.release(),
-            version: os.version(),
-          },
-          device: {
-            arch: os.arch(),
-          },
-          runtime: {
-            name: path.basename(process.title),
-            version: process.version,
-          },
+  const runtimeInfo = getRuntimeInfo();
+  const runtime = {
+    name: runtimeInfo?.runtime ?? "unknown",
+    version: runtimeInfo?.version ?? "unknown",
+  };
+
+  const sentryOptions: ServerRuntimeClientOptions = {
+    dsn: options.dsn,
+    environment: options.environment,
+    serverName: GENERIC_SERVER_NAME,
+    release: options.release,
+    runtime,
+    initialScope: {
+      contexts: {
+        os: {
+          name: os.type(),
+          build: os.release(),
+          version: os.version(),
+        },
+        device: {
+          arch: os.arch(),
         },
+        runtime,
       },
-      transport: () => options.transport,
-      integrations: [
-        functionToStringIntegration(),
-        contextLinesIntegration(),
-        linkedErrorsIntegration(),
-        nodeContextIntegration(),
-      ],
-      platform: process.platform,
-      stackParser: stackParserFromStackParserOptions(
-        createStackParser(nodeStackLineParser(createGetModuleFromFilename())),
-      ),
     },
+    transport: () => options.transport,
+    integrations: [
+      functionToStringIntegration(),
+      contextLinesIntegration(),
+      linkedErrorsIntegration(),
+      nodeContextIntegration(),
+    ],
+    platform: "javascript",
+    stackParser: stackParserFromStackParserOptions(
+      createStackParser(nodeStackLineParser(createGetModuleFromFilename())),
+    ),
+  };
+
+  applySdkMetadata(sentryOptions, "core");
+
+  initAndBind<ServerRuntimeClient, ServerRuntimeClientOptions>(
+    ServerRuntimeClient,
+    sentryOptions,
   );
 }

package/src/internal/cli/telemetry/sentry/reporter.ts

@@ -1,14 +1,5 @@
-import {
-  HardhatError,
-  HardhatPluginError,
-} from "@nomicfoundation/hardhat-errors";
 import { createDebug } from "@nomicfoundation/hardhat-utils/debug";
 
-import {
-  ProviderError,
-  UnknownError,
-} from "../../../builtin-plugins/network-manager/provider-errors.js";
-import { UsingHardhat2PluginError } from "../../../using-hardhat2-plugin-errors.js";
 import { getHardhatVersion } from "../../../utils/package.js";
 import { isTelemetryAllowed } from "../telemetry-permissions.js";
 
@@ -110,11 +101,9 @@ class Reporter {
     error: Error,
     hint?: { unhandled?: boolean; mechanismType?: string },
   ): Promise<boolean> {
-    if (!(await this.#shouldBeReported(error))) {
-      log("Error not send: this type of error should not be reported");
+    if (!this.#telemetryEnabled) {
       return false;
     }
-
     const { captureException, flush } = await import("@sentry/core");
 
     log("Capturing exception");
@@ -134,36 +123,4 @@ class Reporter {
 
     return true;
   }
-
-  async #shouldBeReported(error: Error): Promise<boolean> {
-    if (!this.#telemetryEnabled) {
-      return false;
-    }
-
-    if (
-      HardhatError.isHardhatError(error) &&
-      !error.descriptor.shouldBeReported
-    ) {
-      return false;
-    }
-
-    if (error instanceof UsingHardhat2PluginError) {
-      return false;
-    }
-
-    if (HardhatPluginError.isHardhatPluginError(error)) {
-      // Don't log errors from third-party plugins
-      return false;
-    }
-
-    if (
-      ProviderError.isProviderError(error) &&
-      error.code !== UnknownError.CODE
-    ) {
-      // We don't report known network related errors
-      return false;
-    }
-
-    return true;
-  }
 }

package/src/internal/cli/telemetry/sentry/subprocess.ts

@@ -38,30 +38,22 @@ const envelope = JSON.parse(serializedEnvelope);
 
 const anonymizer = new Anonymizer(configPath);
 
-const filteredEnvelope =
-  anonymizer.filterOutEventsWithExceptionsNotRaisedByHardhat(envelope);
+const anonymizeResult = await anonymizer.anonymizeEventsFromEnvelope(envelope);
 
-if (filteredEnvelope[1].length === 0) {
-  log("The events weren't raised by Hardhat, so we don't report them");
+if (!anonymizeResult.success) {
+  log("Failed to anonymize envelope", anonymizeResult.error);
+  captureMessage(anonymizeResult.error);
 } else {
-  const anonymizeResult =
-    await anonymizer.anonymizeEventsFromEnvelope(filteredEnvelope);
+  try {
+    log("Sending received envelope to Sentry");
 
-  if (!anonymizeResult.success) {
-    log("Failed to anonymize envelope", anonymizeResult.error);
-    captureMessage(anonymizeResult.error);
-  } else {
-    try {
-      log("Sending received envelope to Sentry");
+    await sendEnvelopeToSentryBackend(dsn, anonymizeResult.envelope);
 
-      await sendEnvelopeToSentryBackend(dsn, anonymizeResult.envelope);
+    log("Successfully sent received envelope to Sentry");
+  } catch (e) {
+    log("Failed to send received envelope to Sentry", e);
 
-      log("Successfully sent received envelope to Sentry");
-    } catch (e) {
-      log("Failed to send received envelope to Sentry", e);
-
-      captureException(e);
-    }
+    captureException(e);
   }
 }
 

package/templates/hardhat-3/01-node-test-runner-viem/package.json

@@ -5,7 +5,7 @@
   "description": "A TypeScript Hardhat project using Node Test Runner and Viem",
   "type": "module",
   "devDependencies": {
-    "hardhat": "workspace:^3.4.3",
+    "hardhat": "workspace:^3.4.4",
     "@nomicfoundation/hardhat-toolbox-viem": "workspace:^5.0.4",
     "@nomicfoundation/hardhat-ignition": "workspace:^3.1.4",
     "@types/node": "^22.8.5",
@@ -19,7 +19,7 @@
     "@nomicfoundation/hardhat-network-helpers": "workspace:^3.0.7",
     "@nomicfoundation/hardhat-node-test-runner": "workspace:^3.0.14",
     "@nomicfoundation/hardhat-viem": "workspace:^3.0.6",
-    "@nomicfoundation/hardhat-viem-assertions": "workspace:^3.0.9",
+    "@nomicfoundation/hardhat-viem-assertions": "workspace:^3.0.10",
     "@nomicfoundation/hardhat-verify": "workspace:^3.0.16",
     "@nomicfoundation/ignition-core": "workspace:^3.1.4"
   }

package/templates/hardhat-3/02-mocha-ethers/package.json

@@ -5,7 +5,7 @@
   "description": "A TypeScript Hardhat project using Mocha and Ethers.js",
   "type": "module",
   "devDependencies": {
-    "hardhat": "workspace:^3.4.3",
+    "hardhat": "workspace:^3.4.4",
     "@nomicfoundation/hardhat-toolbox-mocha-ethers": "workspace:^3.0.4",
     "@nomicfoundation/hardhat-ethers": "workspace:^4.0.10",
     "@nomicfoundation/hardhat-ignition": "workspace:^3.1.4",

package/templates/hardhat-3/03-minimal/package.json

@@ -5,7 +5,7 @@
   "description": "A minimal Hardhat project",
   "type": "module",
   "devDependencies": {
-    "hardhat": "workspace:^3.4.3",
+    "hardhat": "workspace:^3.4.4",
     "@types/node": "^22.8.5",
     "typescript": "~5.8.0"
   }