hardhat 2.7.0 → 2.7.1

package/src/internal/cli/bootstrap.ts

@@ -34,5 +34,5 @@ const childProcess = fork(`${__dirname}/cli`, process.argv.slice(2), {
 });
 
 childProcess.once("close", (status) => {
-  process.exit(status);
+  process.exit(status as number);
 });

package/src/internal/cli/cli.ts

@@ -234,7 +234,7 @@ async function main() {
     console.log("");
 
     try {
-      Reporter.reportError(error);
+      Reporter.reportError(error as Error);
     } catch (e) {
       log("Couldn't report error to sentry: %O", e);
     }

package/src/internal/cli/project-creation.ts

@@ -69,11 +69,11 @@ const ADVANCED_TYPESCRIPT_SAMPLE_PROJECT_DEPENDENCIES: Dependencies = {
   "@typescript-eslint/eslint-plugin": "^4.29.1",
   "@typescript-eslint/parser": "^4.29.1",
   "@types/chai": "^4.2.21",
-  "@types/node": "^16.4.13",
+  "@types/node": "^12.0.0",
   "@types/mocha": "^9.0.0",
   "ts-node": "^10.1.0",
   typechain: "^5.1.2", // a workaround. see https://github.com/nomiclabs/hardhat/issues/1672#issuecomment-894497156
-  typescript: "^4.3.5",
+  typescript: "^4.5.2",
 };
 
 const SAMPLE_PROJECT_DEPENDENCIES: {

package/src/internal/constants.ts

@@ -18,6 +18,7 @@ export const HARDHAT_NETWORK_SUPPORTED_HARDFORKS = [
   "muirGlacier",
   "berlin",
   "london",
+  "arrowGlacier",
 ];
 
 export const HARDHAT_MEMPOOL_SUPPORTED_ORDERS = <const>["fifo", "priority"];

package/src/internal/context.ts

@@ -10,7 +10,7 @@ import { ERRORS } from "./core/errors-list";
 import { TasksDSL } from "./core/tasks/dsl";
 import { getRequireCachedFiles } from "./util/platform";
 
-export type GlobalWithHardhatContext = NodeJS.Global & {
+export type GlobalWithHardhatContext = typeof global & {
   __hardhatContext: HardhatContext;
 };
 

package/src/internal/core/config/config-loading.ts

@@ -215,7 +215,7 @@ function readPackageJson(packageName: string): PackageJson | undefined {
     );
 
     return require(packageJsonPath);
-  } catch (error) {
+  } catch {
     return undefined;
   }
 }

package/src/internal/core/config/default-config.ts

@@ -35,7 +35,7 @@ export const defaultHardhatNetworkParams: Omit<
   HardhatNetworkConfig,
   "gas" | "initialDate"
 > = {
-  hardfork: "london",
+  hardfork: "arrowGlacier",
   blockGasLimit: 30_000_000,
   gasPrice: HARDHAT_NETWORK_DEFAULT_GAS_PRICE,
   chainId: 31337,

package/src/internal/core/execution-mode.ts

@@ -22,7 +22,7 @@ export function isHardhatInstalledLocallyOrLinked(configPath?: string) {
     return (
       fs.realpathSync(resolvedPackageJson) === fs.realpathSync(thisPackageJson)
     );
-  } catch (_) {
+  } catch {
     return false;
   }
 }

package/src/internal/core/params/argumentTypes.ts

@@ -185,14 +185,19 @@ export const inputFile: CLIArgumentType<string> = {
         throw new Error(`${strValue} is a directory, not a file`);
       }
     } catch (error) {
-      throw new HardhatError(
-        ERRORS.ARGUMENTS.INVALID_INPUT_FILE,
-        {
-          name: argName,
-          value: strValue,
-        },
-        error
-      );
+      if (error instanceof Error) {
+        throw new HardhatError(
+          ERRORS.ARGUMENTS.INVALID_INPUT_FILE,
+          {
+            name: argName,
+            value: strValue,
+          },
+          error
+        );
+      }
+
+      // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+      throw error;
     }
 
     return strValue;
@@ -212,15 +217,20 @@ export const inputFile: CLIArgumentType<string> = {
       inputFile.parse(argName, value);
     } catch (error) {
       // the input value is considered invalid, throw error.
-      throw new HardhatError(
-        ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE,
-        {
-          value,
-          name: argName,
-          type: inputFile.name,
-        },
-        error
-      );
+      if (error instanceof Error) {
+        throw new HardhatError(
+          ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE,
+          {
+            value,
+            name: argName,
+            type: inputFile.name,
+          },
+          error
+        );
+      }
+
+      // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+      throw error;
     }
   },
 };
@@ -231,14 +241,19 @@ export const json: CLIArgumentType<any> = {
     try {
       return JSON.parse(strValue);
     } catch (error) {
-      throw new HardhatError(
-        ERRORS.ARGUMENTS.INVALID_JSON_ARGUMENT,
-        {
-          param: argName,
-          error: error.message,
-        },
-        error
-      );
+      if (error instanceof Error) {
+        throw new HardhatError(
+          ERRORS.ARGUMENTS.INVALID_JSON_ARGUMENT,
+          {
+            param: argName,
+            error: error.message,
+          },
+          error
+        );
+      }
+
+      // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+      throw error;
     }
   },
 

package/src/internal/core/params/env-variables.ts

@@ -48,14 +48,19 @@ export function getEnvHardhatArguments(
       try {
         envArgs[paramName] = definition.type.parse(paramName, rawValue);
       } catch (error) {
-        throw new HardhatError(
-          ERRORS.ARGUMENTS.INVALID_ENV_VAR_VALUE,
-          {
-            varName: envVarName,
-            value: rawValue,
-          },
-          error
-        );
+        if (error instanceof Error) {
+          throw new HardhatError(
+            ERRORS.ARGUMENTS.INVALID_ENV_VAR_VALUE,
+            {
+              varName: envVarName,
+              value: rawValue,
+            },
+            error
+          );
+        }
+
+        // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+        throw error;
       }
     } else {
       envArgs[paramName] = definition.defaultValue;

package/src/internal/core/providers/accounts.ts

@@ -104,7 +104,7 @@ export class LocalAccountsProvider extends ProviderWrapperWithChainId {
       if (typeof data === "string") {
         try {
           typedMessage = JSON.parse(data);
-        } catch (error) {
+        } catch {
           throw new HardhatError(
             ERRORS.NETWORK.ETHSIGN_TYPED_DATA_V4_INVALID_DATA_PARAM
           );
@@ -219,7 +219,7 @@ export class LocalAccountsProvider extends ProviderWrapperWithChainId {
   private _getPrivateKeyForAddressOrNull(address: Buffer): Buffer | null {
     try {
       return this._getPrivateKeyForAddress(address);
-    } catch (e) {
+    } catch {
       return null;
     }
   }
@@ -253,6 +253,7 @@ export class LocalAccountsProvider extends ProviderWrapperWithChainId {
       gasLimit: transactionRequest.gas,
     };
 
+    // TODO: consider changing instances of "london" below to ["latest hardfork"]
     const common =
       chains.names[chainId] !== undefined
         ? new Common({ chain: chainId, hardfork: "london" })
@@ -347,7 +348,7 @@ abstract class SenderProvider extends ProviderWrapper {
     return this._wrappedProvider.request(args);
   }
 
-  protected abstract async _getSender(): Promise<string | undefined>;
+  protected abstract _getSender(): Promise<string | undefined>;
 }
 
 export class AutomaticSenderProvider extends SenderProvider {

package/src/internal/core/providers/backwards-compatibility.ts

@@ -56,7 +56,7 @@ export class BackwardsCompatibilityProviderAdapter
         method: request.method,
         params: request.params,
       });
-    } catch (error) {
+    } catch (error: any) {
       if (error.code === undefined) {
         // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
         throw error;

package/src/internal/core/providers/chainId.ts

@@ -12,7 +12,7 @@ export abstract class ProviderWrapperWithChainId extends ProviderWrapper {
     if (this._chainId === undefined) {
       try {
         this._chainId = await this._getChainIdFromEthChainId();
-      } catch (error) {
+      } catch {
         // If eth_chainId fails we default to net_version
         this._chainId = await this._getChainIdFromEthNetVersion();
       }

package/src/internal/core/providers/gas-providers.ts

@@ -86,9 +86,11 @@ abstract class MultipliedGasEstimationProvider extends ProviderWrapper {
 
       return numberToRpcQuantity(gas);
     } catch (error) {
-      if (error.message.toLowerCase().includes("execution error")) {
-        const blockGasLimit = await this._getBlockGasLimit();
-        return numberToRpcQuantity(blockGasLimit);
+      if (error instanceof Error) {
+        if (error.message.toLowerCase().includes("execution error")) {
+          const blockGasLimit = await this._getBlockGasLimit();
+          return numberToRpcQuantity(blockGasLimit);
+        }
       }
 
       // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
@@ -277,7 +279,7 @@ export class AutomaticGasPriceProvider extends ProviderWrapper {
 
         maxPriorityFeePerGas: rpcQuantityToBN(response.reward[0][0]),
       };
-    } catch (_error) {
+    } catch {
       this._nodeHasFeeHistory = false;
 
       return undefined;

package/src/internal/core/providers/http.ts

@@ -171,7 +171,7 @@ export class HttpProvider extends EventEmitter implements EIP1193Provider {
       }
 
       return parseJsonResponse(await response.text());
-    } catch (error) {
+    } catch (error: any) {
       if (error.code === "ECONNREFUSED") {
         throw new HardhatError(
           ERRORS.NETWORK.NODE_IS_NOT_RUNNING,

package/src/internal/core/providers/wrapper.ts

@@ -11,7 +11,7 @@ export abstract class ProviderWrapper
     super(_wrappedProvider);
   }
 
-  public abstract async request(args: RequestArguments): Promise<unknown>;
+  public abstract request(args: RequestArguments): Promise<unknown>;
 
   protected _getParams<ParamsT extends any[] = any[]>(
     args: RequestArguments

package/src/internal/core/runtime-environment.ts

@@ -266,7 +266,9 @@ export class Environment implements HardhatRuntimeEnvironment {
             values[paramName] = resolvedArgumentValue;
           }
         } catch (error) {
-          errors.push(error);
+          if (HardhatError.isHardhatError(error)) {
+            errors.push(error);
+          }
         }
         return { errors, values };
       },

package/src/internal/core/typescript-support.ts

@@ -41,13 +41,13 @@ export function isTypescriptSupported() {
 export function loadTsNode(tsConfigPath?: string) {
   try {
     require.resolve("typescript");
-  } catch (error) {
+  } catch {
     throw new HardhatError(ERRORS.GENERAL.TYPESCRIPT_NOT_INSTALLED);
   }
 
   try {
     require.resolve("ts-node");
-  } catch (error) {
+  } catch {
     throw new HardhatError(ERRORS.GENERAL.TS_NODE_NOT_INSTALLED);
   }
 

package/src/internal/hardhat-network/jsonrpc/client.ts

@@ -317,7 +317,7 @@ export class JsonRpcClient {
   ): Promise<any> {
     try {
       return await this._httpProvider.request({ method, params });
-    } catch (err) {
+    } catch (err: any) {
       if (this._shouldRetry(isRetryCall, err)) {
         return this._send(method, params, true);
       }
@@ -429,7 +429,7 @@ export class JsonRpcClient {
           encoding: "utf8",
         }
       );
-    } catch (error) {
+    } catch (error: any) {
       if (error.code === "ENOENT") {
         return undefined;
       }

package/src/internal/hardhat-network/jsonrpc/handler.ts

@@ -207,7 +207,12 @@ const _readJsonHttpRequest = async (req: IncomingMessage): Promise<any> => {
 
     json = JSON.parse(text);
   } catch (error) {
-    throw new InvalidJsonInputError(`Parse error: ${error.message}`);
+    if (error instanceof Error) {
+      throw new InvalidJsonInputError(`Parse error: ${error.message}`);
+    }
+
+    // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+    throw error;
   }
 
   return json;
@@ -218,7 +223,12 @@ const _readWsRequest = (msg: string): JsonRpcRequest => {
   try {
     json = JSON.parse(msg);
   } catch (error) {
-    throw new InvalidJsonInputError(`Parse error: ${error.message}`);
+    if (error instanceof Error) {
+      throw new InvalidJsonInputError(`Parse error: ${error.message}`);
+    }
+
+    // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+    throw error;
   }
 
   return json;

package/src/internal/hardhat-network/jsonrpc/server.ts

@@ -72,7 +72,7 @@ export class JsonRpcServer implements IJsonRpcServer {
 
   public close = async () => {
     await Promise.all([
-      new Promise((resolve, reject) => {
+      new Promise<void>((resolve, reject) => {
         log("Closing JSON-RPC server");
         this._httpServer.close((err) => {
           if (err !== null && err !== undefined) {
@@ -85,7 +85,7 @@ export class JsonRpcServer implements IJsonRpcServer {
           resolve();
         });
       }),
-      new Promise((resolve, reject) => {
+      new Promise<void>((resolve, reject) => {
         log("Closing websocket server");
         this._wsServer.close((err) => {
           if (err !== null && err !== undefined) {

package/src/internal/hardhat-network/provider/TxPool.ts

@@ -332,7 +332,7 @@ export class TxPool {
   private _getSenderAddress(tx: TypedTransaction): Address {
     try {
       return tx.getSenderAddress(); // verifies signature
-    } catch (e) {
+    } catch (e: any) {
       if (!tx.isSigned()) {
         throw new InvalidInputError("Invalid Signature");
       }

package/src/internal/hardhat-network/provider/fork/ForkBlockchain.ts

@@ -272,7 +272,7 @@ export class ForkBlockchain implements HardhatBlockchainInterface {
     // one for London.
     const common = this._common.copy();
     if (rpcBlock.baseFeePerGas !== undefined) {
-      common.setHardfork("london");
+      common.setHardfork("london"); // TODO: consider changing this to "latest hardfork"
     } else {
       common.setHardfork("berlin");
     }

package/src/internal/hardhat-network/provider/modules/eth.ts

@@ -959,29 +959,31 @@ export class EthModule {
       // AccessListEIP2930Transaction.fromSerializedTx and Transaction.fromSerializedTx
       // Please keep it updated.
 
-      if (error.message === "invalid remainder") {
-        throw new InvalidArgumentsError("Invalid transaction", error);
-      }
+      if (error instanceof Error) {
+        if (error.message === "invalid remainder") {
+          throw new InvalidArgumentsError("Invalid transaction", error);
+        }
 
-      if (error.message.includes("Incompatible EIP155")) {
-        throw new InvalidArgumentsError(
-          "Trying to send an incompatible EIP-155 transaction, signed for another chain.",
-          error
-        );
-      }
+        if (error.message.includes("Incompatible EIP155")) {
+          throw new InvalidArgumentsError(
+            "Trying to send an incompatible EIP-155 transaction, signed for another chain.",
+            error
+          );
+        }
 
-      if (
-        error.message.includes("TypedTransaction with ID") &&
-        error.message.includes(" unknown")
-      ) {
-        throw new InvalidArgumentsError(`Invalid transaction`, error);
-      }
+        if (
+          error.message.includes("TypedTransaction with ID") &&
+          error.message.includes(" unknown")
+        ) {
+          throw new InvalidArgumentsError(`Invalid transaction`, error);
+        }
 
-      if (error.message.includes("The chain ID does not match")) {
-        throw new InvalidArgumentsError(
-          `Trying to send a raw transaction with an invalid chainId. The expected chainId is ${this._common.chainIdBN()}`,
-          error
-        );
+        if (error.message.includes("The chain ID does not match")) {
+          throw new InvalidArgumentsError(
+            `Trying to send a raw transaction with an invalid chainId. The expected chainId is ${this._common.chainIdBN()}`,
+            error
+          );
+        }
       }
 
       throw error;
@@ -1065,7 +1067,7 @@ export class EthModule {
     if (typeof typedData === "string") {
       try {
         typedMessage = JSON.parse(typedData);
-      } catch (error) {
+      } catch {
         throw new InvalidInputError(
           `The message parameter is an invalid JSON. Either pass a valid JSON or a plain object conforming to EIP712 TypedData schema.`
         );

package/src/internal/hardhat-network/provider/modules/hardhat.ts

@@ -245,7 +245,7 @@ export class HardhatModule {
 
     if (this._node.isEip1559Active()) {
       throw new InvalidInputError(
-        "hardhat_setMinGasPrice is not support when EIP-1559 is active"
+        "hardhat_setMinGasPrice is not supported when EIP-1559 is active"
       );
     }
 

package/src/internal/hardhat-network/provider/node.ts

@@ -268,7 +268,7 @@ The hardfork must be at least spuriousDragon, but ${common.hardfork()} was given
       let upstreamCommon: Common;
       try {
         upstreamCommon = new Common({ chain: remoteChainId });
-      } catch (error) {
+      } catch {
         // If ethereumjs doesn't have a common it will throw and we won't have
         // info about the activation block of each hardfork, so we don't run
         // this validation.
@@ -369,7 +369,9 @@ Hardhat Network's forking functionality only works with blocks from at least spu
         error
       );
 
-      Reporter.reportError(error);
+      if (error instanceof Error) {
+        Reporter.reportError(error);
+      }
     }
   }
 
@@ -436,16 +438,21 @@ Hardhat Network's forking functionality only works with blocks from at least spu
     try {
       result = await this._mineBlockWithPendingTxs(blockTimestamp);
     } catch (err) {
-      if (err?.message.includes("sender doesn't have enough funds")) {
-        throw new InvalidInputError(err.message, err);
-      }
+      if (err instanceof Error) {
+        if (err?.message.includes("sender doesn't have enough funds")) {
+          throw new InvalidInputError(err.message, err);
+        }
+
+        // Some network errors are HardhatErrors, and can end up here when forking
+        if (HardhatError.isHardhatError(err)) {
+          throw err;
+        }
 
-      // Some network errors are HardhatErrors, and can end up here when forking
-      if (HardhatError.isHardhatError(err)) {
-        throw err;
+        throw new TransactionExecutionError(err);
       }
 
-      throw new TransactionExecutionError(err);
+      // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+      throw err;
     }
 
     await this._saveBlockAsSuccessfullyRun(result.block, result.blockResult);
@@ -1508,7 +1515,12 @@ Hardhat Network's forking functionality only works with blocks from at least spu
     try {
       sender = tx.getSenderAddress(); // verifies signature as a side effect
     } catch (e) {
-      throw new InvalidInputError(e.message);
+      if (e instanceof Error) {
+        throw new InvalidInputError(e.message);
+      }
+
+      // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
+      throw e;
     }
 
     // validate nonce
@@ -2336,7 +2348,7 @@ function getCommonForTracing(networkId: number, blockNumber: number): Common {
     common.setHardfork(common.activeHardfork(blockNumber));
 
     return common;
-  } catch (e) {
+  } catch {
     throw new InternalError(
       `Network id ${networkId} does not correspond to a network that Hardhat can trace`
     );

package/src/internal/hardhat-network/provider/provider.ts

@@ -164,7 +164,7 @@ export class HardhatNetworkProvider
       this._logger.printFailedMethod(method);
       this._logger.printLogs();
 
-      if (!this._logger.isLoggedError(err)) {
+      if (err instanceof Error && !this._logger.isLoggedError(err)) {
         if (ProviderError.isProviderError(err)) {
           this._logger.printEmptyLine();
           this._logger.printErrorMessage(err.message);

package/src/internal/hardhat-network/provider/transactions/ReadOnlyValidEIP1559Transaction.ts

@@ -57,7 +57,7 @@ export class ReadOnlyValidEIP1559Transaction extends FeeMarketEIP1559Transaction
   constructor(sender: Address, data: FeeMarketEIP1559TxData = {}) {
     const fakeCommon = new Common({
       chain: "mainnet",
-      hardfork: "london",
+      hardfork: "london", // TODO: consider chaning this to ["latest hardfork"]
     });
 
     // this class should only be used with txs in a hardfork that

package/src/internal/hardhat-network/stack-traces/solidity-errors.ts

@@ -36,7 +36,7 @@ export async function wrapWithSolidityErrorsCorrection(
 
   try {
     return await f();
-  } catch (error) {
+  } catch (error: any) {
     if (error.stackTrace === undefined) {
       // eslint-disable-next-line @nomiclabs/hardhat-internal-rules/only-hardhat-error
       throw error;

package/src/internal/hardhat-network/stack-traces/vm-tracer.ts

@@ -160,7 +160,7 @@ export class VMTracer {
       if (this._throwErrors) {
         next(error);
       } else {
-        this._lastError = error;
+        this._lastError = error as Error;
         next();
       }
     }
@@ -187,7 +187,7 @@ export class VMTracer {
       if (this._throwErrors) {
         next(error);
       } else {
-        this._lastError = error;
+        this._lastError = error as Error;
         next();
       }
     }
@@ -219,7 +219,7 @@ export class VMTracer {
       if (this._throwErrors) {
         next(error);
       } else {
-        this._lastError = error;
+        this._lastError = error as Error;
         next();
       }
     }

package/src/internal/reset.ts

@@ -29,7 +29,7 @@ export function resetHardhatContext() {
 function unloadModule(path: string) {
   try {
     delete require.cache[require.resolve(path)];
-  } catch (err) {
+  } catch {
     // module wasn't loaded
   }
 }

package/src/internal/sentry/subprocess.ts

@@ -36,7 +36,7 @@ async function main() {
   let event: any;
   try {
     event = JSON.parse(serializedEvent);
-  } catch (error) {
+  } catch {
     log(
       "HARDHAT_SENTRY_EVENT env variable doesn't have a valid JSON, exiting: %o",
       serializedEvent
@@ -62,7 +62,7 @@ async function main() {
         `There was an error anonymizing an event: ${anonymizedEvent.value}`
       );
     }
-  } catch (error) {
+  } catch (error: any) {
     log("Couldn't capture event %o, got error %O", event, error);
     Sentry.captureMessage(
       `There was an error capturing an event: ${error.message}`