hardhat 2.22.2 → 2.23.0-dev.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "hardhat",
-  "version": "2.22.2",
+  "version": "2.23.0-dev.0",
   "author": "Nomic Labs LLC",
   "license": "MIT",
   "homepage": "https://hardhat.org",
@@ -68,7 +68,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "ethers": "^6.1.0",
     "ethers-v5": "npm:ethers@5",
@@ -85,7 +85,7 @@
   "dependencies": {
     "@ethersproject/abi": "^5.1.2",
     "@metamask/eth-sig-util": "^4.0.0",
-    "@nomicfoundation/edr": "^0.3.1",
+    "@nomicfoundation/edr": "^0.3.7",
     "@nomicfoundation/ethereumjs-common": "4.0.4",
     "@nomicfoundation/ethereumjs-tx": "5.0.4",
     "@nomicfoundation/ethereumjs-util": "9.0.4",
@@ -168,11 +168,11 @@
     "eslint": "eslint 'src/**/*.ts' 'test/**/*.ts'",
     "prettier": "prettier \"**/*.{js,md,json}\"",
     "pretest": "cd ../.. && pnpm build",
-    "test": "mocha --recursive \"test/**/*.ts\" --exit",
-    "test:except-provider": "mocha --recursive \"test/**/*.ts\" --exclude \"test/internal/hardhat-network/provider/**/*.ts\" --exit",
-    "test:except-tracing": "mocha --recursive \"test/**/*.ts\" --exclude \"test/internal/hardhat-network/stack-traces/**/*.ts\" --exit",
-    "test:provider": "mocha --recursive \"test/internal/hardhat-network/provider/**/*.ts\" --exit",
-    "test:tracing": "mocha --recursive \"test/internal/hardhat-network/stack-traces/**/*.ts\" --exit",
+    "test": "mocha --recursive \"test/**/*.ts\"",
+    "test:except-provider": "mocha --recursive \"test/**/*.ts\" --exclude \"test/internal/hardhat-network/provider/**/*.ts\"",
+    "test:except-tracing": "mocha --recursive \"test/**/*.ts\" --exclude \"test/internal/hardhat-network/stack-traces/**/*.ts\"",
+    "test:provider": "mocha --recursive \"test/internal/hardhat-network/provider/**/*.ts\"",
+    "test:tracing": "mocha --recursive \"test/internal/hardhat-network/stack-traces/**/*.ts\"",
     "pretest:provider": "cd ../../crates/edr_napi && pnpm build",
     "pretest:except-provider": "cd ../../crates/edr_napi && pnpm build",
     "pretest:tracing": "cd ../../crates/edr_napi && pnpm build",

package/recommended-gitignore.txt

@@ -12,3 +12,6 @@ node_modules
 # solidity-coverage files
 /coverage
 /coverage.json
+
+# Hardhat Ignition default folder for deployments against a local node
+ignition/deployments/chain-31337

package/src/builtin-tasks/compile.ts

@@ -345,7 +345,7 @@ subtask(TASK_COMPILE_SOLIDITY_GET_COMPILATION_JOBS)
  * Receives a list of compilation jobs and returns a new list where some of
  * the compilation jobs might've been removed.
  *
- * This task can be overriden to change the way the cache is used, or to use
+ * This task can be overridden to change the way the cache is used, or to use
  * a different approach to filtering out compilation jobs.
  */
 subtask(TASK_COMPILE_SOLIDITY_FILTER_COMPILATION_JOBS)
@@ -1152,7 +1152,7 @@ subtask(TASK_COMPILE_SOLIDITY_GET_COMPILATION_JOBS_FAILURE_REASONS)
           const { versionPragmas } = error.file.content;
           const versionsRange = versionPragmas.join(" ");
 
-          log(`File ${sourceName} has an incompatible overriden compiler`);
+          log(`File ${sourceName} has an incompatible overridden compiler`);
 
           errorMessage += `  * ${sourceName} (${versionsRange})\n`;
         }

package/src/common/napi-rs.ts

@@ -0,0 +1,15 @@
+import { HardhatError } from "../internal/core/errors";
+import { ERRORS } from "../internal/core/errors-list";
+
+export function requireNapiRsModule(id: string): unknown {
+  try {
+    return require(id);
+  } catch (e: any) {
+    if (e.code === "MODULE_NOT_FOUND") {
+      throw new HardhatError(ERRORS.GENERAL.CORRUPTED_LOCKFILE);
+    }
+
+    // eslint-disable-next-line @nomicfoundation/hardhat-internal-rules/only-hardhat-error
+    throw e;
+  }
+}

package/src/internal/core/errors-list.ts

@@ -251,7 +251,7 @@ This bug can only affect you if you, or someone at your team, installed the proj
 To avoid it, please delete both your node_modules and package-lock.json, and reinstall your project.
 
 Note that you don't need to do this every time you install a new dependency, but please make sure to delete your node_modules every time you delete your package-lock.json.`,
-      shouldBeReported: false,
+      shouldBeReported: true,
     },
     ESM_PROJECT_WITHOUT_CJS_CONFIG: {
       number: 19,

package/src/internal/core/params/argumentTypes.ts

@@ -121,6 +121,50 @@ export const int: CLIArgumentType<number> = {
   },
 };
 
+/**
+ * BigInt type.
+ * Accepts either a decimal string integer or hexadecimal string integer.
+ * @throws HH301
+ */
+export const bigint: CLIArgumentType<bigint> = {
+  name: "bigint",
+  parse: (argName, strValue) => {
+    const decimalPattern = /^\d+(?:n)?$/;
+    const hexPattern = /^0[xX][\dABCDEabcde]+$/;
+
+    if (
+      strValue.match(decimalPattern) === null &&
+      strValue.match(hexPattern) === null
+    ) {
+      throw new HardhatError(ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE, {
+        value: strValue,
+        name: argName,
+        type: bigint.name,
+      });
+    }
+
+    return BigInt(strValue.replace("n", ""));
+  },
+  /**
+   * Check if argument value is of type "bigint".
+   *
+   * @param argName {string} argument's name - used for context in case of error.
+   * @param value {any} argument's value to validate.
+   *
+   * @throws HH301 if value is not of type "bigint"
+   */
+  validate: (argName: string, value: any): void => {
+    const isBigInt = typeof value === "bigint";
+    if (!isBigInt) {
+      throw new HardhatError(ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE, {
+        value,
+        name: argName,
+        type: bigint.name,
+      });
+    }
+  },
+};
+
 /**
  * Float type.
  * Accepts either a decimal string number or hexadecimal string number.

package/src/internal/core/tasks/task-definitions.ts

@@ -613,7 +613,7 @@ export class OverriddenTaskDefinition implements TaskDefinition {
   }
 
   /**
-   * Retrieves, if defined, the description of the overriden task,
+   * Retrieves, if defined, the description of the overridden task,
    * otherwise retrieves the description of the parent task.
    */
   public get description() {
@@ -625,7 +625,7 @@ export class OverriddenTaskDefinition implements TaskDefinition {
   }
 
   /**
-   * Retrieves, if defined, the action of the overriden task,
+   * Retrieves, if defined, the action of the overridden task,
    * otherwise retrieves the action of the parent task.
    */
   public get action() {

package/src/internal/hardhat-network/provider/provider.ts

@@ -9,7 +9,7 @@ import type {
   RequestArguments,
 } from "../../../types";
 
-import {
+import type {
   EdrContext,
   Provider as EdrProviderT,
   ExecutionResult,
@@ -27,6 +27,7 @@ import fsExtra from "fs-extra";
 import * as t from "io-ts";
 import semver from "semver";
 
+import { requireNapiRsModule } from "../../../common/napi-rs";
 import {
   HARDHAT_NETWORK_RESET_EVENT,
   HARDHAT_NETWORK_REVERT_SNAPSHOT_EVENT,
@@ -87,6 +88,10 @@ let _globalEdrContext: EdrContext | undefined;
 
 // Lazy initialize the global EDR context.
 export function getGlobalEdrContext(): EdrContext {
+  const { EdrContext } = requireNapiRsModule(
+    "@nomicfoundation/edr"
+  ) as typeof import("@nomicfoundation/edr");
+
   if (_globalEdrContext === undefined) {
     // Only one is allowed to exist
     _globalEdrContext = new EdrContext();
@@ -197,8 +202,9 @@ export class EdrProviderWrapper
     rawTraceCallbacks: RawTraceCallbacks,
     tracingConfig?: TracingConfig
   ): Promise<EdrProviderWrapper> {
-    const { Provider } =
-      require("@nomicfoundation/edr") as typeof import("@nomicfoundation/edr");
+    const { Provider } = requireNapiRsModule(
+      "@nomicfoundation/edr"
+    ) as typeof import("@nomicfoundation/edr");
 
     const coinbase = config.coinbase ?? DEFAULT_COINBASE;
 
@@ -362,41 +368,49 @@ export class EdrProviderWrapper
     );
     const response = JSON.parse(responseObject.json);
 
-    const rawTraces = responseObject.traces;
-    for (const rawTrace of rawTraces) {
-      const trace = rawTrace.trace();
-      for (const traceItem of trace) {
-        if ("pc" in traceItem) {
-          if (this._node._vm.evm.events.listenerCount("step") > 0) {
-            this._node._vm.evm.events.emit(
-              "step",
-              edrTracingStepToMinimalInterpreterStep(traceItem)
-            );
-          }
-          if (this._rawTraceCallbacks.onStep !== undefined) {
-            await this._rawTraceCallbacks.onStep(traceItem);
-          }
-        } else if ("executionResult" in traceItem) {
-          if (this._node._vm.evm.events.listenerCount("afterMessage") > 0) {
-            this._node._vm.evm.events.emit(
-              "afterMessage",
-              edrTracingMessageResultToMinimalEVMResult(traceItem)
-            );
-          }
-          if (this._rawTraceCallbacks.onAfterMessage !== undefined) {
-            await this._rawTraceCallbacks.onAfterMessage(
-              traceItem.executionResult
-            );
-          }
-        } else {
-          if (this._node._vm.evm.events.listenerCount("beforeMessage") > 0) {
-            this._node._vm.evm.events.emit(
-              "beforeMessage",
-              edrTracingMessageToMinimalMessage(traceItem)
-            );
-          }
-          if (this._rawTraceCallbacks.onBeforeMessage !== undefined) {
-            await this._rawTraceCallbacks.onBeforeMessage(traceItem);
+    const needsTraces =
+      this._node._vm.evm.events.eventNames().length > 0 ||
+      this._rawTraceCallbacks.onStep !== undefined ||
+      this._rawTraceCallbacks.onAfterMessage !== undefined ||
+      this._rawTraceCallbacks.onBeforeMessage !== undefined;
+
+    if (needsTraces) {
+      const rawTraces = responseObject.traces;
+      for (const rawTrace of rawTraces) {
+        const trace = rawTrace.trace();
+        for (const traceItem of trace) {
+          if ("pc" in traceItem) {
+            if (this._node._vm.evm.events.listenerCount("step") > 0) {
+              this._node._vm.evm.events.emit(
+                "step",
+                edrTracingStepToMinimalInterpreterStep(traceItem)
+              );
+            }
+            if (this._rawTraceCallbacks.onStep !== undefined) {
+              await this._rawTraceCallbacks.onStep(traceItem);
+            }
+          } else if ("executionResult" in traceItem) {
+            if (this._node._vm.evm.events.listenerCount("afterMessage") > 0) {
+              this._node._vm.evm.events.emit(
+                "afterMessage",
+                edrTracingMessageResultToMinimalEVMResult(traceItem)
+              );
+            }
+            if (this._rawTraceCallbacks.onAfterMessage !== undefined) {
+              await this._rawTraceCallbacks.onAfterMessage(
+                traceItem.executionResult
+              );
+            }
+          } else {
+            if (this._node._vm.evm.events.listenerCount("beforeMessage") > 0) {
+              this._node._vm.evm.events.emit(
+                "beforeMessage",
+                edrTracingMessageToMinimalMessage(traceItem)
+              );
+            }
+            if (this._rawTraceCallbacks.onBeforeMessage !== undefined) {
+              await this._rawTraceCallbacks.onBeforeMessage(traceItem);
+            }
           }
         }
       }

package/src/internal/hardhat-network/provider/utils/convertToEdr.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   SpecId,
   MineOrdering,
   IntervalRange,
@@ -9,6 +9,7 @@ import {
 } from "@nomicfoundation/edr";
 import { Address } from "@nomicfoundation/ethereumjs-util";
 
+import { requireNapiRsModule } from "../../../../common/napi-rs";
 import { HardforkName } from "../../../util/hardforks";
 import { IntervalMiningConfig, MempoolOrder } from "../node-types";
 import { RpcDebugTraceOutput, RpcStructLog } from "../output";
@@ -21,6 +22,10 @@ import {
 /* eslint-disable @nomicfoundation/hardhat-internal-rules/only-hardhat-error */
 
 export function ethereumsjsHardforkToEdrSpecId(hardfork: HardforkName): SpecId {
+  const { SpecId } = requireNapiRsModule(
+    "@nomicfoundation/edr"
+  ) as typeof import("@nomicfoundation/edr");
+
   switch (hardfork) {
     case HardforkName.FRONTIER:
       return SpecId.Frontier;
@@ -65,6 +70,10 @@ export function ethereumsjsHardforkToEdrSpecId(hardfork: HardforkName): SpecId {
 }
 
 export function edrSpecIdToEthereumHardfork(specId: SpecId): HardforkName {
+  const { SpecId } = requireNapiRsModule(
+    "@nomicfoundation/edr"
+  ) as typeof import("@nomicfoundation/edr");
+
   switch (specId) {
     case SpecId.Frontier:
       return HardforkName.FRONTIER;
@@ -128,6 +137,10 @@ export function ethereumjsIntervalMiningConfigToEdr(
 export function ethereumjsMempoolOrderToEdrMineOrdering(
   mempoolOrder: MempoolOrder
 ): MineOrdering {
+  const { MineOrdering } = requireNapiRsModule(
+    "@nomicfoundation/edr"
+  ) as typeof import("@nomicfoundation/edr");
+
   switch (mempoolOrder) {
     case "fifo":
       return MineOrdering.Fifo;

package/src/internal/hardhat-network/provider/vm/exit.ts

@@ -1,4 +1,6 @@
-import { ExceptionalHalt, SuccessReason } from "@nomicfoundation/edr";
+import type { ExceptionalHalt, SuccessReason } from "@nomicfoundation/edr";
+
+import { requireNapiRsModule } from "../../../../common/napi-rs";
 
 export enum ExitCode {
   SUCCESS,
@@ -14,6 +16,10 @@ export enum ExitCode {
 
 export class Exit {
   public static fromEdrSuccessReason(reason: SuccessReason): Exit {
+    const { SuccessReason } = requireNapiRsModule(
+      "@nomicfoundation/edr"
+    ) as typeof import("@nomicfoundation/edr");
+
     switch (reason) {
       case SuccessReason.Stop:
       case SuccessReason.Return:
@@ -25,6 +31,10 @@ export class Exit {
   }
 
   public static fromEdrExceptionalHalt(halt: ExceptionalHalt): Exit {
+    const { ExceptionalHalt } = requireNapiRsModule(
+      "@nomicfoundation/edr"
+    ) as typeof import("@nomicfoundation/edr");
+
     switch (halt) {
       case ExceptionalHalt.OutOfGas:
         return new Exit(ExitCode.OUT_OF_GAS);
@@ -83,6 +93,10 @@ export class Exit {
   }
 
   public getEdrExceptionalHalt(): ExceptionalHalt {
+    const { ExceptionalHalt } = requireNapiRsModule(
+      "@nomicfoundation/edr"
+    ) as typeof import("@nomicfoundation/edr");
+
     switch (this.kind) {
       case ExitCode.OUT_OF_GAS:
         return ExceptionalHalt.OutOfGas;

package/src/internal/hardhat-network/stack-traces/vm-tracer.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   CreateOutput,
   ExecutionResult,
   TracingMessage,

package/src/internal/solidity/parse.ts

@@ -1,8 +1,7 @@
 import type SolidityAnalyzerT from "@nomicfoundation/solidity-analyzer";
 
 import { SolidityFilesCache } from "../../builtin-tasks/utils/solidity-files-cache";
-import { HardhatError } from "../core/errors";
-import { ERRORS } from "../core/errors-list";
+import { requireNapiRsModule } from "../../common/napi-rs";
 
 interface ParsedData {
   imports: string[];
@@ -29,22 +28,14 @@ export class Parser {
       return cacheResult;
     }
 
-    try {
-      const { analyze } =
-        require("@nomicfoundation/solidity-analyzer") as typeof SolidityAnalyzerT;
-      const result = analyze(fileContent);
+    const { analyze } = requireNapiRsModule(
+      "@nomicfoundation/solidity-analyzer"
+    ) as typeof SolidityAnalyzerT;
+    const result = analyze(fileContent);
 
-      this._cache.set(contentHash, result);
+    this._cache.set(contentHash, result);
 
-      return result;
-    } catch (e: any) {
-      if (e.code === "MODULE_NOT_FOUND") {
-        throw new HardhatError(ERRORS.GENERAL.CORRUPTED_LOCKFILE);
-      }
-
-      // eslint-disable-next-line @nomicfoundation/hardhat-internal-rules/only-hardhat-error
-      throw e;
-    }
+    return result;
   }
 
   /**