hardhat 2.12.4 → 2.12.5

package/src/internal/core/providers/gas-providers.ts

@@ -143,7 +143,7 @@ export class AutomaticGasPriceProvider extends ProviderWrapper {
     3n;
 
   // See eth_feeHistory for an explanation of what this means
-  public static readonly EIP1559_REWARD_PERCENTILE: bigint = 50n;
+  public static readonly EIP1559_REWARD_PERCENTILE = 50;
 
   private _nodeHasFeeHistory?: boolean;
   private _nodeSupportsEIP1559?: boolean;

package/src/internal/hardhat-network/jsonrpc/client.ts

@@ -359,7 +359,8 @@ export class JsonRpcClient {
       }
 
       // This is a workaround for this TurboGeth bug: https://github.com/ledgerwatch/turbo-geth/issues/1645
-      if (err.code === -32000 && err.message.includes("not found")) {
+      const errMessage: string = err.message;
+      if (err.code === -32000 && errMessage.includes("not found")) {
         return null;
       }
 
@@ -383,10 +384,12 @@ export class JsonRpcClient {
     }
   }
 
-  private _shouldRetry(isRetryCall: boolean, err: any) {
+  private _shouldRetry(isRetryCall: boolean, err: any): boolean {
+    const errMessage: string = err.message;
+
     const isRetriableError =
-      err.message.includes("header not found") ||
-      err.message.includes("connect ETIMEDOUT");
+      errMessage.includes("header not found") ||
+      errMessage.includes("connect ETIMEDOUT");
 
     const isServiceUrl =
       this._httpProvider.url.includes("infura") ||

package/src/internal/hardhat-network/provider/modules/eth.ts

@@ -1683,7 +1683,7 @@ export class EthModule {
         rpcRequest.maxPriorityFeePerGas !== undefined) &&
       !this._common.gteHardfork(EIP1559_MIN_HARDFORK)
     ) {
-      throw new InvalidArgumentsError(`EIP-1559 style fee params (maxFeePerGas or maxPriorityFeePerGas) received but they are not supported by the current hardfork. 
+      throw new InvalidArgumentsError(`EIP-1559 style fee params (maxFeePerGas or maxPriorityFeePerGas) received but they are not supported by the current hardfork.
 
 You can use them by running Hardhat Network with 'hardfork' ${EIP1559_MIN_HARDFORK} or later.`);
     }
@@ -1694,8 +1694,8 @@ You can use them by running Hardhat Network with 'hardfork' ${EIP1559_MIN_HARDFO
       rpcRequest.accessList !== undefined &&
       !this._common.gteHardfork(ACCESS_LIST_MIN_HARDFORK)
     ) {
-      throw new InvalidArgumentsError(`Access list received but is not supported by the current hardfork. 
-      
+      throw new InvalidArgumentsError(`Access list received but is not supported by the current hardfork.
+
 You can use them by running Hardhat Network with 'hardfork' ${ACCESS_LIST_MIN_HARDFORK} or later.`);
     }
 
@@ -1736,7 +1736,7 @@ You can use them by running Hardhat Network with 'hardfork' ${ACCESS_LIST_MIN_HA
     }
 
     if (!this._common.gteHardfork(EIP155_MIN_HARDFORK)) {
-      throw new InvalidArgumentsError(`Trying to send an EIP-155 transaction, but they are not supported by the current hardfork.  
+      throw new InvalidArgumentsError(`Trying to send an EIP-155 transaction, but they are not supported by the current hardfork.
 
 You can use them by running Hardhat Network with 'hardfork' ${EIP155_MIN_HARDFORK} or later.`);
     }

package/src/internal/hardhat-network/stack-traces/compiler-to-model.ts

@@ -539,7 +539,7 @@ function astFunctionDefinitionToSelector(functionDefinition: any): Buffer {
   return abi.methodID(functionDefinition.name, paramTypes);
 }
 
-function isContractType(param: any) {
+function isContractType(param: any): boolean {
   return (
     (param.typeName?.nodeType === "UserDefinedTypeName" ||
       param?.nodeType === "UserDefinedTypeName") &&
@@ -548,7 +548,7 @@ function isContractType(param: any) {
   );
 }
 
-function isEnumType(param: any) {
+function isEnumType(param: any): boolean {
   return (
     (param.typeName?.nodeType === "UserDefinedTypeName" ||
       param?.nodeType === "UserDefinedTypeName") &&

package/src/internal/hardhat-network/stack-traces/error-inferrer.ts

@@ -519,12 +519,8 @@ export class ErrorInferrer {
       return;
     }
 
-    let errorMessage = "reverted with an unrecognized custom error";
-
-    const selector = returnData.getSelector();
-    if (selector !== undefined) {
-      errorMessage += ` with selector ${selector}`;
-    }
+    const rawReturnData = returnData.value.toString("hex");
+    let errorMessage = `reverted with an unrecognized custom error (return data: 0x${rawReturnData})`;
 
     for (const customError of trace.bytecode.contract.customErrors) {
       if (returnData.matchesSelector(customError.selector)) {

package/src/internal/hardhat-network/stack-traces/solidity-errors.ts

@@ -271,7 +271,9 @@ function getMessageFromLastStackTraceEntry(
       }
 
       if (!stackTraceEntry.message.isEmpty()) {
-        return `VM Exception while processing transaction: reverted with an unrecognized custom error`;
+        const returnData = stackTraceEntry.message.value.toString("hex");
+
+        return `VM Exception while processing transaction: reverted with an unrecognized custom error (return data: 0x${returnData})`;
       }
 
       if (stackTraceEntry.isInvalidOpcodeError) {

package/src/internal/solidity/compiler/downloader.ts

@@ -347,7 +347,7 @@ export class CompilerDownloader implements ICompilerDownloader {
     await fsExtra.createFile(this._getCompilerDoesntWorkFile(build));
   }
 
-  private async _checkNativeSolc(build: CompilerBuild) {
+  private async _checkNativeSolc(build: CompilerBuild): Promise<boolean> {
     const solcPath = this._getCompilerBinaryPathFromBuild(build);
     const execFileP = promisify(execFile);
 

package/src/internal/solidity/dependencyGraph.ts

@@ -9,6 +9,7 @@ export class DependencyGraph implements taskTypes.DependencyGraph {
   ): Promise<DependencyGraph> {
     const graph = new DependencyGraph();
 
+    // TODO refactor this to make the results deterministic
     await Promise.all(
       resolvedFiles.map((resolvedFile) =>
         graph._addDependenciesFrom(resolver, resolvedFile)
@@ -169,6 +170,7 @@ export class DependencyGraph implements taskTypes.DependencyGraph {
     this._resolvedFiles.set(file.sourceName, file);
     this._dependenciesPerFile.set(file.sourceName, dependencies);
 
+    // TODO refactor this to make the results deterministic
     await Promise.all(
       file.content.imports.map(async (imp) => {
         const dependency = await resolver.resolveImport(file, imp);

package/src/internal/util/console.ts

@@ -1,3 +1,5 @@
+import type ReplT from "repl";
+
 export function isNodeCalledWithoutAScript() {
   const script = process.argv[1];
   return script === undefined || script.trim() === "";
@@ -9,9 +11,9 @@ export function isNodeCalledWithoutAScript() {
  * so we disable it in hardhat/register.
  */
 export function disableReplWriterShowProxy() {
-  const repl = require("repl");
+  const repl = require("repl") as typeof ReplT;
 
-  if (repl.writer.options) {
+  if (repl.writer.options !== undefined) {
     Object.defineProperty(repl.writer.options, "showProxy", {
       value: false,
       writable: false,

package/src/internal/util/download.ts

@@ -20,7 +20,8 @@ function resolveTempFileName(filePath: string): string {
 export async function download(
   url: string,
   filePath: string,
-  timeoutMillis = 10000
+  timeoutMillis = 10000,
+  extraHeaders: { [name: string]: string } = {}
 ) {
   const { pipeline } = await import("stream");
   const { getGlobalDispatcher, ProxyAgent, request } = await import("undici");
@@ -47,6 +48,7 @@ export async function download(
     maxRedirections: 10,
     method: "GET",
     headers: {
+      ...extraHeaders,
       "User-Agent": `hardhat ${hardhatVersion ?? "(unknown version)"}`,
     },
   });