haraka-plugin-karma 1.0.12 → 2.0.0

package/test/karma.js

@@ -1,777 +1,809 @@
-'use strict';
-
-const Address      = require('address-rfc2821').Address;
-const fixtures     = require('haraka-test-fixtures');
-const constants    = require('haraka-constants');
-
-const stub         = fixtures.stub.stub;
-
-const _set_up = function (done) {
-
-  this.plugin = new fixtures.plugin('karma');
-
-  this.plugin.cfg = { main: {} };
-  this.plugin.deny_hooks = {'connect': true};
-  this.plugin.tarpit_hooks = ['connect'];
-
-  this.connection = fixtures.connection.createConnection({}, { notes: {} });
-
-  this.connection.transaction = fixtures.transaction.createTransaction();
-  this.connection.transaction.results = new fixtures.result_store(this.plugin);
-
-  done();
-};
-
-exports.karma_init = {
-  setUp : _set_up,
-  'load_karma_ini': function (test) {
-    test.expect(2);
-    this.plugin.inherits('haraka-plugin-redis');
-    this.plugin.load_karma_ini();
-    test.ok(this.plugin.cfg.asn);
-    test.ok(this.plugin.deny_hooks);
-    test.done();
-  },
-};
-
-exports.results_init = {
-  setUp : _set_up,
-  'init, pre': function (test) {
-    test.expect(1);
-    const r = this.connection.results.get('karma');
-    test.equal(undefined, r);
-    test.done();
-  },
-  'init, empty cfg': function (test) {
-    this.plugin.results_init(stub, this.connection);
-    const r = this.connection.results.get('karma');
-    test.expect(1);
-    test.ok(r);
-    test.done();
-  },
-  'init, cfg': function (test) {
-    this.plugin.cfg.awards = { test: 1 };
-    this.plugin.results_init(stub, this.connection);
-    const r = this.connection.results.get('karma');
-    test.expect(2);
-    test.ok(r);
-    test.ok(r.todo);
-    test.done();
-  },
-  'init, skip': function (test) {
-    this.connection.remote.is_private = true;
-    this.plugin.results_init(stub, this.connection);
-    const r = this.connection.results.get('karma');
-    test.expect(1);
-    test.equal(undefined, r);
-    test.done();
-  },
-  'init, private skip': function (test) {
-    this.connection.notes.disable_karma = true;
-    this.plugin.results_init(stub, this.connection);
-    const r = this.connection.results.get('karma');
-    test.expect(1);
-    test.equal(undefined, r);
-    test.done();
-  },
-};
-
-exports.assemble_note_obj = {
-  setUp : _set_up,
-  'no auth fails': function (test) {
-    test.expect(1);
-    const obj = this.plugin.assemble_note_obj(this.connection, 'notes.auth_fails');
-    test.equal(undefined, obj);
-    test.done();
-  },
-  'has auth fails': function (test) {
-    test.expect(1);
-    this.connection.notes.auth_fails=[1,2];
-    const obj = this.plugin.assemble_note_obj(this.connection, 'notes.auth_fails');
-    test.deepEqual([1,2], obj);
-    test.done();
-  },
-};
-
-exports.hook_deny = {
-  setUp : _set_up,
-  'no params': function (test) {
-    test.expect(1);
+'use strict'
+
+const assert       = require('assert')
+
+const Address      = require('address-rfc2821').Address
+const fixtures     = require('haraka-test-fixtures')
+const constants    = require('haraka-constants')
+
+const stub         = fixtures.stub.stub
+
+function _set_up (done) {
+
+  this.plugin = new fixtures.plugin('karma')
+
+  this.plugin.cfg = { main: {} }
+  this.plugin.deny_hooks = {'connect': true}
+  this.plugin.tarpit_hooks = ['connect']
+
+  this.connection = fixtures.connection.createConnection({}, { notes: {} })
+  this.connection.transaction = fixtures.transaction.createTransaction()
+
+  done()
+}
+
+
+describe('karma_init', function () {
+  beforeEach(function (done) {
+    this.plugin = new fixtures.plugin('karma')
+    done()
+  })
+
+  it('load_karma_ini', function (done) {
+    this.plugin.inherits('haraka-plugin-redis')
+    this.plugin.load_karma_ini()
+    assert.ok(this.plugin.cfg.asn)
+    assert.ok(this.plugin.deny_hooks)
+    done()
+  })
+})
+
+describe('results_init', function () {
+  beforeEach(_set_up)
+
+  it('init, pre', function (done) {
+    const r = this.connection.results.get('karma')
+    assert.equal(undefined, r)
+    done()
+  })
+
+  it('init, empty cfg', function (done) {
+    this.plugin.results_init(stub, this.connection)
+    const r = this.connection.results.get('karma')
+    assert.ok(r)
+    done()
+  })
+
+  it('init, cfg', function (done) {
+    this.plugin.cfg.awards = { test: 1 }
+    this.plugin.results_init(stub, this.connection)
+    const r = this.connection.results.get('karma')
+    assert.ok(r)
+    assert.ok(r.todo)
+    done()
+  })
+
+  it('init, skip', function (done) {
+    this.connection.remote.is_private = true
+    this.plugin.results_init(stub, this.connection)
+    const r = this.connection.results.get('karma')
+    assert.equal(undefined, r)
+    done()
+  })
+
+  it('init, private skip', function (done) {
+    this.connection.notes.disable_karma = true
+    this.plugin.results_init(stub, this.connection)
+    const r = this.connection.results.get('karma')
+    assert.equal(undefined, r)
+    done()
+  })
+})
+
+describe('assemble_note_obj', function () {
+  beforeEach(_set_up)
+
+  it('no auth fails', function (done) {
+    const obj = this.plugin.assemble_note_obj(this.connection, 'notes.auth_fails')
+    assert.equal(undefined, obj)
+    done()
+  })
+
+  it('has auth fails', function (done) {
+    this.connection.notes.auth_fails=[1,2]
+    const obj = this.plugin.assemble_note_obj(this.connection, 'notes.auth_fails')
+    assert.deepEqual([1,2], obj)
+    done()
+  })
+})
+
+describe('hook_deny', function () {
+  beforeEach(_set_up)
+
+  it('no params', function (done) {
     const next = function (rc) {
-      test.equal(constants.OK, rc, rc);
-      test.done();
-    };
-    this.plugin.hook_deny(next, this.connection, ['','','','']);
-  },
-  'pi_name=karma': function (test) {
-    test.expect(1);
+      assert.equal(constants.OK, rc, rc)
+      done()
+    }
+    this.plugin.hook_deny(next, this.connection, ['','','',''])
+  })
+
+  it('pi_name=karma', function (done) {
     const next = function (rc) {
-      test.equal(undefined, rc);
-      test.done();
-    };
-    this.plugin.hook_deny(next, this.connection, ['','','karma','']);
-  },
-  'pi_name=access': function (test) {
-    test.expect(1);
+      assert.equal(undefined, rc)
+      done()
+    }
+    this.plugin.hook_deny(next, this.connection, ['','','karma',''])
+  })
+
+  it('pi_name=access', function (done) {
     const next = function (rc) {
-      test.equal(undefined, rc);
-      test.done();
-    };
-    this.plugin.deny_exclude_plugins = { access: true };
-    this.plugin.hook_deny(next, this.connection, ['','','access','']);
-  },
-  'pi_hook=rcpt_to': function (test) {
-    test.expect(1);
+      assert.equal(undefined, rc)
+      done()
+    }
+    this.plugin.deny_exclude_plugins = { access: true }
+    this.plugin.hook_deny(next, this.connection, ['','','access',''])
+  })
+
+  it('pi_hook=rcpt_to', function (done) {
     const next = function (rc) {
-      test.equal(undefined, rc);
-      test.done();
-    };
-    this.plugin.deny_exclude_hooks = { rcpt_to: true };
+      assert.equal(undefined, rc)
+      done()
+    }
+    this.plugin.deny_exclude_hooks = { rcpt_to: true }
     this.plugin.hook_deny(next, this.connection,
-      ['','','','','','rcpt_to']);
-  },
-  'pi_hook=queue': function (test) {
-    test.expect(1);
+      ['','','','','','rcpt_to'])
+  })
+
+  it('pi_hook=queue', function (done) {
     const next = function (rc) {
-      test.equal(undefined, rc);
-      test.done();
-    };
-    this.plugin.deny_exclude_hooks = { queue: true };
-    this.plugin.hook_deny(next, this.connection, ['','','','','','queue']);
-  },
-  'denysoft': function (test) {
-    test.expect(1);
+      assert.equal(undefined, rc)
+      done()
+    }
+    this.plugin.deny_exclude_hooks = { queue: true }
+    this.plugin.hook_deny(next, this.connection, ['','','','','','queue'])
+  })
+
+  it('denysoft', function (done) {
     const next = function (rc) {
-      test.equal(constants.OK, rc);
-      test.done();
-    };
-    this.plugin.hook_deny(next, this.connection, [constants.DENYSOFT,'','','','','']);
-  },
-};
-
-exports.get_award_location = {
-  setUp : _set_up,
-  'relaying=false': function (test) {
-    test.expect(1);
-    this.connection.relaying=false;
-    const r = this.plugin.get_award_location(this.connection, 'relaying');
-    test.equal(false, r);
-    test.done();
-  },
-  'relaying=true': function (test) {
-    test.expect(1);
-    this.connection.relaying=true;
-    const r = this.plugin.get_award_location(this.connection, 'relaying');
-    test.equal(true, r);
-    test.done();
-  },
-  'notes.undef=2': function (test) {
-    test.expect(1);
-    const r = this.plugin.get_award_location(this.connection, 'notes.undef');
-    test.equal(undefined, r);
-    test.done();
-  },
-  'notes.tarpit=2': function (test) {
-    test.expect(1);
-    this.connection.notes = { tarpit: 2 };
-    const r = this.plugin.get_award_location(this.connection, 'notes.tarpit');
-    test.equal(2, r);
-    test.done();
-  },
-  'results.geoip': function (test) {
-    test.expect(1);
-    this.connection.results.add('geoip', { country: 'US' });
-    const r = this.plugin.get_award_location(this.connection, 'results.geoip');
+      assert.equal(constants.OK, rc)
+      done()
+    }
+    this.plugin.hook_deny(next, this.connection, [constants.DENYSOFT,'','','','',''])
+  })
+})
+
+describe('get_award_location', function () {
+  beforeEach(_set_up)
+
+  it('relaying=false', function (done) {
+    this.connection.relaying=false
+    const r = this.plugin.get_award_location(this.connection, 'relaying')
+    assert.equal(false, r)
+    done()
+  })
+
+  it('relaying=true', function (done) {
+    this.connection.relaying=true
+    const r = this.plugin.get_award_location(this.connection, 'relaying')
+    assert.equal(true, r)
+    done()
+  })
+
+  it('notes.undef=2', function (done) {
+    const r = this.plugin.get_award_location(this.connection, 'notes.undef')
+    assert.equal(undefined, r)
+    done()
+  })
+
+  it('notes.tarpit=2', function (done) {
+    this.connection.notes = { tarpit: 2 }
+    const r = this.plugin.get_award_location(this.connection, 'notes.tarpit')
+    assert.equal(2, r)
+    done()
+  })
+
+  it('results.geoip', function (done) {
+    this.connection.results.add('geoip', { country: 'US' })
+    const r = this.plugin.get_award_location(this.connection, 'results.geoip')
     // console.log(r);
-    test.equal('US', r.country);
-    test.done();
-  },
-  'results.karma': function (test) {
-    test.expect(1);
-    this.connection.results.add('karma', { score: -1 });
-    const r = this.plugin.get_award_location(this.connection, 'results.karma');
+    assert.equal('US', r.country)
+    done()
+  })
+
+  it('results.karma', function (done) {
+    this.connection.results.add('karma', { score: -1 })
+    const r = this.plugin.get_award_location(this.connection, 'results.karma')
     // console.log(r);
-    test.equal(-1, r.score);
-    test.done();
-  },
-  'results.karma, txn': function (test) {
+    assert.equal(-1, r.score)
+    done()
+  })
+
+  it('results.karma, txn', function (done) {
     // results should be found in conn or txn
-    test.expect(1);
-    this.connection.transaction.results.add('karma', { score: -1 });
-    const r = this.plugin.get_award_location(this.connection, 'results.karma');
+    this.connection.transaction.results.add('karma', { score: -1 })
+    const r = this.plugin.get_award_location(this.connection, 'results.karma')
     // console.log(r);
-    test.equal(-1, r.score);
-    test.done();
-  },
-  'txn.results.karma': function (test) {
+    assert.equal(-1, r.score)
+    done()
+  })
+
+  it('txn.results.karma', function (done) {
     // these results shouldn't be found, b/c txn specified
-    test.expect(1);
-    this.connection.results.add('karma', { score: -1 });
-    const r = this.plugin.get_award_location(this.connection, 'transaction.results.karma');
+    this.connection.results.add('karma', { score: -1 })
+    const r = this.plugin.get_award_location(this.connection, 'transaction.results.karma')
     // console.log(r);
-    test.equal(undefined, r);
-    test.done();
-  },
-  'results.auth/auth_base': function (test) {
-    test.expect(1);
-    this.connection.results.add('auth/auth_base', { fail: 'PLAIN' });
-    const r = this.plugin.get_award_location(this.connection, 'results.auth/auth_base');
-    test.equal('PLAIN', r.fail[0]);
-    test.done();
-  },
-};
-
-exports.get_award_condition = {
-  setUp : _set_up,
-  'geoip.distance': function (test) {
-    test.expect(2);
-    test.equal(4000, this.plugin.get_award_condition(
+    assert.equal(undefined, r)
+    done()
+  })
+
+  it('results.auth/auth_base', function (done) {
+    this.connection.results.add('auth/auth_base', { fail: 'PLAIN' })
+    const r = this.plugin.get_award_location(this.connection, 'results.auth/auth_base')
+    assert.equal('PLAIN', r.fail[0])
+    done()
+  })
+})
+
+describe('get_award_condition', function () {
+  beforeEach(_set_up)
+  it('geoip.distance', function (done) {
+    assert.equal(4000, this.plugin.get_award_condition(
       'results.geoip.distance@4000', '-1 if gt'
-    ));
-    test.equal(4000, this.plugin.get_award_condition(
+    ))
+    assert.equal(4000, this.plugin.get_award_condition(
       'results.geoip.distance@uniq', '-1 if gt 4000'
-    ));
-    test.done();
-  },
-  'auth/auth_base': function (test) {
-    test.expect(1);
-    test.equal('plain', this.plugin.get_award_condition(
+    ))
+    done()
+  })
+
+  it('auth/auth_base', function (done) {
+    assert.equal('plain', this.plugin.get_award_condition(
       'results.auth/auth_base.fail@plain', '-1 if in'
-    ));
-    test.done();
-  },
-};
-
-exports.check_awards = {
-  setUp : _set_up,
-  'no results': function (test) {
-    test.expect(1);
-    const r = this.plugin.check_awards(this.connection);
-    test.equal(undefined, r);
-    test.done();
-  },
-  'no todo': function (test) {
-    test.expect(1);
-    this.connection.results.add('karma', { todo: { } });
-    const r = this.plugin.check_awards(this.connection);
-    test.equal(undefined, r);
-    test.done();
-  },
-  'geoip gt': function (test) {
-    test.expect(2);
+    ))
+    done()
+  })
+})
+
+describe('check_awards', function () {
+  beforeEach(_set_up)
+
+  it('no results', function (done) {
+    const r = this.plugin.check_awards(this.connection)
+    assert.equal(undefined, r)
+    done()
+  })
+
+  it('no todo', function (done) {
+    this.connection.results.add('karma', { todo: { } })
+    const r = this.plugin.check_awards(this.connection)
+    assert.equal(undefined, r)
+    done()
+  })
+
+  it('geoip gt', function (done) {
 
     // populate the karma result with a todo item
     this.connection.results.add('karma', {
       todo: { 'results.geoip.distance@4000': '-1 if gt 4000' }
-    });
+    })
     // test a non-matching criteria
-    this.connection.results.add('geoip', { distance: 4000 });
+    this.connection.results.add('geoip', { distance: 4000 })
     // check awards
-    this.plugin.check_awards(this.connection);
-    test.equal(undefined, this.connection.results.get('karma').fail[0]);
+    this.plugin.check_awards(this.connection)
+    assert.equal(undefined, this.connection.results.get('karma').fail[0])
 
     // test a matching criteria
-    this.connection.results.add('geoip', { distance: 4001 });
+    this.connection.results.add('geoip', { distance: 4001 })
     // check awards
-    this.plugin.check_awards(this.connection);
+    this.plugin.check_awards(this.connection)
     // test that the award was applied
-    test.equal('geoip.distance', this.connection.results.get('karma').fail[0]);
+    assert.equal('geoip.distance', this.connection.results.get('karma').fail[0])
+
+    done()
+  })
 
-    test.done();
-  },
-  'auth failure': function (test) {
-    test.expect(2);
+  it('auth failure', function (done) {
     this.connection.results.add('karma', {
       todo: { 'results.auth/auth_base.fail@PLAIN': '-1 if in' }
-    });
+    })
     this.connection.results.add('auth/auth_base',
-      {fail: 'PLAIN'});
-    const r = this.plugin.check_awards(this.connection);
-    test.equal(undefined, r);
-    test.equal('auth/auth_base.fail', this.connection.results.get('karma').fail[0]);
-    test.done();
-  },
-  'valid recipient': function (test) {
-    test.expect(2);
+      {fail: 'PLAIN'})
+    const r = this.plugin.check_awards(this.connection)
+    assert.equal(undefined, r)
+    assert.equal('auth/auth_base.fail', this.connection.results.get('karma').fail[0])
+    done()
+  })
+
+  it('valid recipient', function (done) {
     this.connection.results.add('karma', {
       todo: { 'results.rcpt_to.qmd.pass@exist': '1 if in' }
-    });
-    this.connection.results.add('rcpt_to.qmd', {pass: 'exist'});
-    const r = this.plugin.check_awards(this.connection);
-    test.equal(undefined, r);
-    test.equal('qmd.pass', this.connection.results.get('karma').pass[0]);
-    test.done();
-  },
-};
-
-exports.apply_tarpit = {
-  setUp : _set_up,
-  'tarpit=false': function (test) {
-    test.expect(2);
+    })
+    this.connection.results.add('rcpt_to.qmd', {pass: 'exist'})
+    const r = this.plugin.check_awards(this.connection)
+    assert.equal(undefined, r)
+    assert.equal('qmd.pass', this.connection.results.get('karma').pass[0])
+    done()
+  })
+})
+
+describe('apply_tarpit', function () {
+  beforeEach(_set_up)
+
+  it('tarpit=false', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.plugin.apply_tarpit(this.connection, 'connect', 0, next);
-  },
-  'tarpit=true, score=0': function (test) {
-    test.expect(2);
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.plugin.apply_tarpit(this.connection, 'connect', 0, next)
+  })
+
+  it('tarpit=true, score=0', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.plugin.apply_tarpit(this.connection, 'connect', 0, next);
-  },
-  'tarpit=true, score=1': function (test) {
-    test.expect(2);
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.plugin.apply_tarpit(this.connection, 'connect', 0, next)
+  })
+
+  it('tarpit=true, score=1', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.plugin.apply_tarpit(this.connection, 'connect', 1, next);
-  },
-  'tarpit=true, score=-1': function (test) {
-    test.expect(3);
-    const before = Date.now();
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.plugin.apply_tarpit(this.connection, 'connect', 1, next)
+  })
+
+  it('tarpit=true, score=-1', function (done) {
+    const before = Date.now()
     const next = function (rc, msg) {
-      test.ok(Date.now() >= before + 1);
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.plugin.apply_tarpit(this.connection, 'connect', -1, next);
-  },
-  'tarpit=true, score=-2, max=1': function (test) {
-    test.expect(3);
-    const before = Date.now();
+      assert.ok(Date.now() >= before + 1)
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.plugin.apply_tarpit(this.connection, 'connect', -1, next)
+  })
+
+  it('tarpit=true, score=-2, max=1', function (done) {
+    const before = Date.now()
     const next = function (rc, msg) {
-      test.ok(Date.now() >= before + 1);
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.plugin.apply_tarpit(this.connection, 'connect', -2, next);
-  },
-  'tarpit=true, score=connect, max=1': function (test) {
-    test.expect(3);
-    const before = Date.now();
+      assert.ok(Date.now() >= before + 1)
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.plugin.apply_tarpit(this.connection, 'connect', -2, next)
+  })
+
+  it('tarpit=true, score=connect, max=1', function (done) {
+    const before = Date.now()
     const next = function (rc, msg) {
-      test.ok(Date.now() >= before + 1);
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.connection.results.add(this.plugin, { score: -2 });
-    this.plugin.apply_tarpit(this.connection, 'connect', -2, next);
-  },
-};
-
-exports.should_we_deny = {
-  setUp : _set_up,
-  'no results': function (test) {
-    test.expect(2);
+      assert.ok(Date.now() >= before + 1)
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.connection.results.add(this.plugin, { score: -2 })
+    this.plugin.apply_tarpit(this.connection, 'connect', -2, next)
+  })
+})
+
+describe('should_we_deny', function () {
+  beforeEach(_set_up)
+
+  it('no results', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.plugin.should_we_deny(next, this.connection, 'connect');
-  },
-  'no score': function (test) {
-    test.expect(2);
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.plugin.should_we_deny(next, this.connection, 'connect')
+  })
+
+  it('no score', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.connection.results.add(this.plugin, { test: 'blah' });
-    this.plugin.should_we_deny(next, this.connection, 'connect');
-  },
-  'invalid score': function (test) {
-    test.expect(2);
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.connection.results.add(this.plugin, { test: 'blah' })
+    this.plugin.should_we_deny(next, this.connection, 'connect')
+  })
+
+  it('invalid score', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    };
-    this.connection.results.add(this.plugin, { score: 'blah' });
-    this.plugin.should_we_deny(next, this.connection, 'connect');
-  },
-  'valid score, okay': function (test) {
-    test.expect(2);
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }
+    this.connection.results.add(this.plugin, { score: 'blah' })
+    this.plugin.should_we_deny(next, this.connection, 'connect')
+  })
+
+  it('valid score, okay', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    }.bind(this);
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.connection.results.add(this.plugin, { score: -1 });
-    this.plugin.should_we_deny(next, this.connection, 'connect');
-  },
-  'valid score, -6, deny_hook': function (test) {
-    test.expect(2);
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }.bind(this)
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.connection.results.add(this.plugin, { score: -1 })
+    this.plugin.should_we_deny(next, this.connection, 'connect')
+  })
+
+  it('valid score, -6, deny_hook', function (done) {
     const next = function (rc, msg) {
-      test.equal(constants.DENY, rc);
-      test.ok(msg);
-      test.done();
-    }.bind(this);
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.plugin.deny_hooks = { connect: true};
-    this.connection.results.add(this.plugin, { score: -6 });
-    this.plugin.should_we_deny(next, this.connection, 'connect');
-  },
-  'valid score, -6, pass_hook': function (test) {
-    test.expect(2);
+      assert.equal(constants.DENY, rc)
+      assert.ok(msg)
+      done()
+    }.bind(this)
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.plugin.deny_hooks = { connect: true}
+    this.connection.results.add(this.plugin, { score: -6 })
+    this.plugin.should_we_deny(next, this.connection, 'connect')
+  })
+
+  it('valid score, -6, pass_hook', function (done) {
     const next = function (rc, msg) {
-      test.equal(undefined, rc);
-      test.equal(undefined, msg);
-      test.done();
-    }.bind(this);
-    this.plugin.cfg.tarpit = { max: 1, delay: 0 };
-    this.plugin.deny_hooks = { helo: true };
-    this.connection.results.add(this.plugin, { score: -6 });
-    this.plugin.should_we_deny(next, this.connection, 'connect');
-  },
-};
-
-exports.check_result_equal = {
-  setUp : _set_up,
-  'equal match is scored': function (test) {
-    test.expect(2);
+      assert.equal(undefined, rc)
+      assert.equal(undefined, msg)
+      done()
+    }.bind(this)
+    this.plugin.cfg.tarpit = { max: 1, delay: 0 }
+    this.plugin.deny_hooks = { helo: true }
+    this.connection.results.add(this.plugin, { score: -6 })
+    this.plugin.should_we_deny(next, this.connection, 'connect')
+  })
+})
+
+describe('check_result_equal', function () {
+  beforeEach(_set_up)
+
+  it('equal match is scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'equals',    value      : 'clean',
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_equal(['clean'], award, this.connection);
-    test.equals(this.connection.results.store.karma.score, 2);
-    test.equals(this.connection.results.store.karma.awards[0], 1);
-    test.done();
-  },
-  'not equal match is not scored': function (test) {
-    test.expect(1);
+    }
+    this.plugin.check_result_equal(['clean'], award, this.connection)
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 1)
+    done()
+  })
+
+  it('not equal match is not scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'equals',    value      : 'dirty',
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_equal(['clean'], award, this.connection);
-    test.equals(this.connection.results.store.karma, undefined);
-    test.done();
-  }
-};
-
-exports.check_result_gt = {
-  setUp : _set_up,
-  'gt match is scored': function (test) {
-    test.expect(2);
+    }
+    this.plugin.check_result_equal(['clean'], award, this.connection)
+    assert.equal(this.connection.results.store.karma, undefined)
+    done()
+  })
+})
+
+describe('check_result_gt', function () {
+  beforeEach(_set_up)
+
+  it('gt match is scored', function (done) {
     const award = {
       id         : 5,           award      : 3,
       operator   : 'gt',        value      : 3,
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_gt([4], award, this.connection);
+    }
+    this.plugin.check_result_gt([4], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 3);
-    test.equals(this.connection.results.store.karma.awards[0], 5);
-    test.done();
-  }
-};
-
-exports.check_result_lt = {
-  setUp : _set_up,
-  'lt match is scored': function (test) {
-    test.expect(2);
+    assert.equal(this.connection.results.store.karma.score, 3)
+    assert.equal(this.connection.results.store.karma.awards[0], 5)
+    done()
+  })
+})
+
+describe('check_result_lt', function () {
+  beforeEach(_set_up)
+
+  it('lt match is scored', function (done) {
     const award = {
       id         : 2,           award      : 3,
       operator   : 'lt',        value      : 5,
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_lt([4], award, this.connection);
+    }
+    this.plugin.check_result_lt([4], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 3);
-    test.equals(this.connection.results.store.karma.awards[0], 2);
-    test.done();
-  },
-  'lt match not scored': function (test) {
-    test.expect(1);
+    assert.equal(this.connection.results.store.karma.score, 3)
+    assert.equal(this.connection.results.store.karma.awards[0], 2)
+    done()
+  })
+
+  it('lt match not scored', function (done) {
     const award = {
       id         : 3,           award      : 3,
       operator   : 'lt',        value      : 3,
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_lt([4], award, this.connection);
+    }
+    this.plugin.check_result_lt([4], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma, undefined);
-    test.done();
-  }
-};
-
-exports.check_result_match = {
-  setUp : _set_up,
-  'match pattern is scored': function (test) {
-    test.expect(2);
+    assert.equal(this.connection.results.store.karma, undefined)
+    done()
+  })
+})
+
+describe('check_result_match', function () {
+  beforeEach(_set_up)
+
+  it('match pattern is scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'match',     value      : 'phish',
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_match(['isphishing'], award, this.connection);
+    }
+    this.plugin.check_result_match(['isphishing'], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 2);
-    test.equals(this.connection.results.store.karma.awards[0], 1);
-    test.done();
-  },
-  'mismatch is not scored': function (test) {
-    test.expect(1);
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 1)
+    done()
+  })
+
+  it('mismatch is not scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'match',     value      : 'dirty',
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_match(['clean'], award, this.connection);
+    }
+    this.plugin.check_result_match(['clean'], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma, undefined);
-    test.done();
-  },
-  'FCrDNS match is scored': function (test) {
-    test.expect(2);
+    assert.equal(this.connection.results.store.karma, undefined)
+    done()
+  })
+
+  it('FCrDNS match is scored', function (done) {
     const award = {
       id         : 89,         award      : 2,
       operator   : 'match',     value      : 'google.com',
       reason     : 'testing',   resolution : 'never',
-    };
-    this.plugin.check_result_match(['mail-yk0-f182.google.com'], award, this.connection);
+    }
+    this.plugin.check_result_match(['mail-yk0-f182.google.com'], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 2);
-    test.equals(this.connection.results.store.karma.awards[0], 89);
-    test.done();
-  },
-};
-
-exports.check_result_length = {
-  setUp : _set_up,
-  'eq pattern is scored': function (test) {
-    test.expect(2);
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 89)
+    done()
+  })
+})
+
+describe('check_result_length', function () {
+  beforeEach(_set_up)
+  it('eq pattern is scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'length',    value      : 'eq 3',
       reason     : 'testing',   resolution : 'hah',
-    };
-    this.plugin.check_result_length(['3'], award, this.connection);
+    }
+    this.plugin.check_result_length(['3'], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 2);
-    test.equals(this.connection.results.store.karma.awards[0], 1);
-    test.done();
-  },
-  'eq pattern is not scored': function (test) {
-    test.expect(1);
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 1)
+    done()
+  })
+
+  it('eq pattern is not scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'length',    value      : 'eq 3',
       reason     : 'testing',   resolution : 'hah',
-    };
-    this.plugin.check_result_length(['4'], award, this.connection);
+    }
+    this.plugin.check_result_length(['4'], award, this.connection)
     // console.log(this.connection.results.store.karma);
-    test.deepEqual(this.connection.results.store.karma, undefined);
-    test.done();
-  },
-  'gt pattern is scored': function (test) {
-    test.expect(2);
+    assert.deepEqual(this.connection.results.store.karma, undefined)
+    done()
+  })
+
+  it('gt pattern is scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'length',    value      : 'gt 3',
       reason     : 'testing',   resolution : 'hah',
-    };
-    this.plugin.check_result_length(['5'], award, this.connection);
+    }
+    this.plugin.check_result_length(['5'], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 2);
-    test.equals(this.connection.results.store.karma.awards[0], 1);
-    test.done();
-  },
-  'gt pattern is not scored': function (test) {
-    test.expect(1);
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 1)
+    done()
+  })
+
+  it('gt pattern is not scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'length',    value      : 'gt 3',
       reason     : 'testing',   resolution : 'hah',
-    };
-    this.plugin.check_result_length(['3'], award, this.connection);
+    }
+    this.plugin.check_result_length(['3'], award, this.connection)
     // console.log(this.connection.results.store.karma);
-    test.deepEqual(this.connection.results.store.karma, undefined);
-    test.done();
-  },
-  'lt pattern is scored': function (test) {
-    test.expect(2);
+    assert.deepEqual(this.connection.results.store.karma, undefined)
+    done()
+  })
+
+  it('lt pattern is scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'length',    value      : 'lt 3',
       reason     : 'testing',   resolution : 'hah',
-    };
-    this.plugin.check_result_length(['2'], award, this.connection);
+    }
+    this.plugin.check_result_length(['2'], award, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 2);
-    test.equals(this.connection.results.store.karma.awards[0], 1);
-    test.done();
-  },
-  'lt pattern is not scored': function (test) {
-    test.expect(1);
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 1)
+    done()
+  })
+
+  it('lt pattern is not scored', function (done) {
     const award = {
       id         : 1,           award      : 2,
       operator   : 'length',    value      : 'lt 3',
       reason     : 'testing',   resolution : 'hah',
-    };
-    this.plugin.check_result_length(['3'], award, this.connection);
+    }
+    this.plugin.check_result_length(['3'], award, this.connection)
     // console.log(this.connection.results.store.karma);
-    test.deepEqual(this.connection.results.store.karma, undefined);
-    test.done();
-  },
-};
-
-exports.check_result = {
-  setUp : _set_up,
-  'geoip country is scored': function (test) {
-    test.expect(2);
+    assert.deepEqual(this.connection.results.store.karma, undefined)
+    done()
+  })
+})
+
+describe('check_result_exists', function () {
+  beforeEach(_set_up)
+
+  it('exists pattern is scored', function (done) {
+    const award = {
+      id         : 1,           award      : 2,
+      operator   : 'exists',    value      : 'any',
+      reason     : 'testing',   resolution : 'high five',
+    }
+    this.plugin.check_result_exists(['3'], award, this.connection)
+    // console.log(this.connection.results.store);
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 1)
+    done()
+  })
+
+  it('not exists pattern is not scored', function (done) {
+    const award = {
+      id         : 1,           award      : 3,
+      operator   : 'exists',    value      : '',
+      reason     : 'testing',   resolution : 'misses',
+    }
+    this.plugin.check_result_exists([], award, this.connection)
+    // console.log(this.connection.results.store);
+    assert.equal(this.connection.results.store.karma, undefined)
+    assert.equal(this.connection.results.store.karma, undefined)
+    done()
+  })
+})
+
+describe('check_result', function () {
+  beforeEach(_set_up)
+
+  it('geoip country is scored', function (done) {
     this.plugin.cfg.result_awards = {
       1: 'geoip | country | equals | CN | 2',
-    };
-    this.plugin.preparse_result_awards();
-    this.connection.results.add({name: 'geoip'}, {country: 'CN'});
+    }
+    this.plugin.preparse_result_awards()
+    this.connection.results.add({name: 'geoip'}, {country: 'CN'})
     this.plugin.check_result(this.connection,
-      '{"plugin":"geoip","result":{"country":"CN"}}');
+      '{"plugin":"geoip","result":{"country":"CN"}}')
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, 2);
-    test.equals(this.connection.results.store.karma.awards[0], 1);
-    test.done();
-  },
-  'dnsbl listing is scored': function (test) {
-    test.expect(2);
+    assert.equal(this.connection.results.store.karma.score, 2)
+    assert.equal(this.connection.results.store.karma.awards[0], 1)
+    done()
+  })
+
+  it('dnsbl listing is scored', function (done) {
     this.plugin.cfg.result_awards = {
       2: 'dnsbl | fail | equals | dnsbl.sorbs.net | -5',
-    };
-    this.plugin.preparse_result_awards();
-    this.connection.results.add({name: 'dnsbl'}, {fail: 'dnsbl.sorbs.net'});
+    }
+    this.plugin.preparse_result_awards()
+    this.connection.results.add({name: 'dnsbl'}, {fail: 'dnsbl.sorbs.net'})
     this.plugin.check_result(this.connection,
-      '{"plugin":"dnsbl","result":{"fail":"dnsbl.sorbs.net"}}');
+      '{"plugin":"dnsbl","result":{"fail":"dnsbl.sorbs.net"}}')
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, -5);
-    test.equals(this.connection.results.store.karma.awards[0], 2);
-    test.done();
-  },
-};
-
-exports.check_spammy_tld = {
-  setUp : _set_up,
-  'spammy TLD is scored: top': function (test) {
-    test.expect(2);
-    this.plugin.cfg.spammy_tlds = { top: -3 };
-    const mfrom = new Address('spamy@er7diogt.rrnsale.top');
-    this.plugin.check_spammy_tld(mfrom, this.connection);
+    assert.equal(this.connection.results.store.karma.score, -5)
+    assert.equal(this.connection.results.store.karma.awards[0], 2)
+    done()
+  })
+})
+
+describe('check_spammy_tld', function () {
+  beforeEach(_set_up)
+
+  it('spammy TLD is scored: top', function (done) {
+    this.plugin.cfg.spammy_tlds = { top: -3 }
+    const mfrom = new Address('spamy@er7diogt.rrnsale.top')
+    this.plugin.check_spammy_tld(mfrom, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, -3);
-    test.equals(this.connection.results.store.karma.fail[0], 'spammy.TLD');
-    test.done();
-  },
-  'spammy TLD is scored: rocks': function (test) {
-    test.expect(2);
-    this.plugin.cfg.spammy_tlds = { rocks: '-2' };
-    const mfrom = new Address('spamy@foo.rocks');
-    this.plugin.check_spammy_tld(mfrom, this.connection);
+    assert.equal(this.connection.results.store.karma.score, -3)
+    assert.equal(this.connection.results.store.karma.fail[0], 'spammy.TLD')
+    done()
+  })
+
+  it('spammy TLD is scored: rocks', function (done) {
+    this.plugin.cfg.spammy_tlds = { rocks: '-2' }
+    const mfrom = new Address('spamy@foo.rocks')
+    this.plugin.check_spammy_tld(mfrom, this.connection)
     // console.log(this.connection.results.store);
-    test.equals(this.connection.results.store.karma.score, -2);
-    test.equals(this.connection.results.store.karma.fail[0], 'spammy.TLD');
-    test.done();
-  },
-}
+    assert.equal(this.connection.results.store.karma.score, -2)
+    assert.equal(this.connection.results.store.karma.fail[0], 'spammy.TLD')
+    done()
+  })
+})
+
+describe('tls', function () {
+  beforeEach(_set_up)
 
-exports.tls = {
-  setUp : _set_up,
-  'unconfigured TLS does nothing': function (test) {
-    test.expect(1);
-    this.connection.tls.enabled=true;
-    const mfrom = new Address('spamy@er7diogt.rrnsale.top');
-    this.connection.current_line="MAIL FROM:<foo@test.com>";
+  it('unconfigured TLS does nothing', function (done) {
+    this.connection.tls.enabled=true
+    const mfrom = new Address('spamy@er7diogt.rrnsale.top')
+    this.connection.current_line="MAIL FROM:<foo@test.com>"
     this.plugin.hook_mail(() => {
-      test.equals(this.connection.results.store.karma, undefined);
-      test.done();
-    }, this.connection, [mfrom]);
-  },
-  'TLS is scored': function (test) {
-    test.expect(1);
-    this.plugin.cfg.tls = { set: 2, unset: -4 };
-    this.connection.tls.enabled=true;
-    const mfrom = new Address('spamy@er7diogt.rrnsale.top');
-    this.connection.current_line="MAIL FROM:<foo@test.com>";
+      assert.equal(this.connection.results.store.karma, undefined)
+      done()
+    }, this.connection, [mfrom])
+  })
+
+  it('TLS is scored', function (done) {
+    this.plugin.cfg.tls = { set: 2, unset: -4 }
+    this.connection.tls.enabled=true
+    const mfrom = new Address('spamy@er7diogt.rrnsale.top')
+    this.connection.current_line="MAIL FROM:<foo@test.com>"
     this.plugin.hook_mail(() => {
       // console.log(this.connection.results.store);
-      test.equals(this.connection.results.store.karma.score, 2);
-      test.done();
-    }, this.connection, [mfrom]);
-  },
-  'no TLS is scored': function (test) {
-    test.expect(1);
-    this.plugin.cfg.tls = { set: 2, unset: -4 };
-    this.connection.tls.enabled=false;
-    const mfrom = new Address('spamy@er7diogt.rrnsale.top');
-    this.connection.current_line="MAIL FROM:<foo@test.com>";
+      assert.equal(this.connection.results.store.karma.score, 2)
+      done()
+    }, this.connection, [mfrom])
+  })
+
+  it('no TLS is scored', function (done) {
+    this.plugin.cfg.tls = { set: 2, unset: -4 }
+    this.connection.tls.enabled=false
+    const mfrom = new Address('spamy@er7diogt.rrnsale.top')
+    this.connection.current_line="MAIL FROM:<foo@test.com>"
     this.plugin.hook_mail(() => {
       // console.log(this.connection.results.store);
-      test.equals(this.connection.results.store.karma.score, -4);
-      test.done();
-    }, this.connection, [mfrom]);
-  },
-}
+      assert.equal(this.connection.results.store.karma.score, -4)
+      done()
+    }, this.connection, [mfrom])
+  })
+})
 
-exports.skiping_hooks = {
-  setUp : _set_up,
-  'notes.disable_karma': function (test) {
-    test.expect(9);
-    const next = function (rc) {
-      test.equal(undefined, rc);
-    };
-    const last = function (rc) {
-      test.equal(undefined, rc);
-      test.done();
-    };
-    this.connection.notes.disable_karma = true;
-
-    this.plugin.hook_deny(next, this.connection);
-    this.plugin.hook_connect(next, this.connection);
-    this.plugin.hook_ehlo(next, this.connection);
-    this.plugin.hook_vrfy(next, this.connection);
-    this.plugin.hook_noop(next, this.connection);
-    this.plugin.hook_data(next, this.connection);
-    this.plugin.hook_queue(next, this.connection);
-    this.plugin.hook_reset_transaction(next, this.connection);
-    this.plugin.hook_unrecognized_command(last, this.connection);
-  },
-  'private skip': function (test) {
-    test.expect(9);
-    const next = function (rc) {
-      test.equal(undefined, rc);
-    };
-    const last = function (rc) {
-      test.equal(undefined, rc);
-      test.done();
-    };
-    this.connection.remote.is_private = true;
-
-    this.plugin.hook_deny(next, this.connection);
-    this.plugin.hook_connect(next, this.connection);
-    this.plugin.hook_ehlo(next, this.connection);
-    this.plugin.hook_vrfy(next, this.connection);
-    this.plugin.hook_noop(next, this.connection);
-    this.plugin.hook_data(next, this.connection);
-    this.plugin.hook_queue(next, this.connection);
-    this.plugin.hook_reset_transaction(next, this.connection);
-    this.plugin.hook_unrecognized_command(last, this.connection);
-  },
-};
+describe('skiping_hooks', function () {
+  beforeEach(_set_up)
+
+  it('notes.disable_karma', function (done) {
+    function next (rc) {
+      assert.equal(undefined, rc)
+    }
+    function last (rc) {
+      assert.equal(undefined, rc)
+      done()
+    }
+    this.connection.notes.disable_karma = true
+
+    this.plugin.hook_deny(next, this.connection)
+    this.plugin.hook_connect(next, this.connection)
+    this.plugin.hook_ehlo(next, this.connection)
+    this.plugin.hook_vrfy(next, this.connection)
+    this.plugin.hook_noop(next, this.connection)
+    this.plugin.hook_data(next, this.connection)
+    this.plugin.hook_queue(next, this.connection)
+    this.plugin.hook_reset_transaction(next, this.connection)
+    this.plugin.hook_unrecognized_command(last, this.connection)
+  })
+
+  it('private skip', function (done) {
+    function next (rc) {
+      assert.equal(undefined, rc)
+    }
+    function last (rc) {
+      assert.equal(undefined, rc)
+      done()
+    }
+    this.connection.remote.is_private = true
+
+    this.plugin.hook_deny(next, this.connection)
+    this.plugin.hook_connect(next, this.connection)
+    this.plugin.hook_ehlo(next, this.connection)
+    this.plugin.hook_vrfy(next, this.connection)
+    this.plugin.hook_noop(next, this.connection)
+    this.plugin.hook_data(next, this.connection)
+    this.plugin.hook_queue(next, this.connection)
+    this.plugin.hook_reset_transaction(next, this.connection)
+    this.plugin.hook_unrecognized_command(last, this.connection)
+  })
+})