happyskills 1.7.0 → 1.7.1

package/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [1.7.1] - 2026-06-04
+
+### Fixed
+
+- Stop double-counting a single install. The install pipeline tries an archive download first and falls back to a JSON clone when the archive is missing or unusable; both hit the clone endpoint, which counts (`repo.clone` + `download_count`) per request. The fallback now sends `?no_count=1` so one install registers exactly once. Only the install fallback sets it — `fork`, `pull`, and normal installs are unchanged. Takes effect against API v5.4.1+ (older APIs ignore the flag and still count both); forward-only.
+
 ## [1.7.0] - 2026-06-04
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "happyskills",
-	"version": "1.7.0",
+	"version": "1.7.1",
 	"description": "Package manager for AI agent skills",
 	"license": "SEE LICENSE IN LICENSE",
 	"author": "Nicolas Dao <nic@cloudlesslabs.com> (https://cloudlesslabs.com)",

package/src/api/repos.js

@@ -61,6 +61,9 @@ const clone = (owner, repo, ref, options = {}) => catch_errors(`Clone ${owner}/$
 	if (options.commit) params.set('commit', options.commit)
 	else if (ref) params.set('ref', ref)
 	if (options.format) params.set('format', options.format)
+	// Fallback retries (install archive→JSON) mark themselves so the server
+	// counts the install only once (the primary attempt already counted).
+	if (options.no_count) params.set('no_count', '1')
 	const qs = params.toString() ? `?${params}` : ''
 	const [errors, data] = await client.get(`/repos/${owner}/${repo}/clone${qs}`)
 	if (errors) throw errors[errors.length - 1]

package/src/api/repos.test.js

@@ -217,3 +217,19 @@ describe('repos.star / repos.unstar — endpoint + path', () => {
 		assert.strictEqual(calls[0][1], `/repos/${encodeURIComponent('acme corp')}/${encodeURIComponent('deploy/aws')}/star`)
 	})
 })
+
+// Bug B fix: a fallback retry marks itself no_count so the server counts the
+// install only once (the primary archive attempt already counted).
+describe('repos.clone — no_count flag (double-count prevention)', () => {
+	afterEach(restore)
+
+	it('adds ?no_count=1 only when options.no_count is set', async () => {
+		const { repos, calls } = stub_client_capture()
+		await repos.clone('acme', 'deploy', 'refs/tags/v1.0.0', { no_count: true })
+		await repos.clone('acme', 'deploy', 'refs/tags/v1.0.0', {})
+		await repos.clone('acme', 'deploy', 'refs/tags/v1.0.0', { format: 'archive' })
+		assert.match(calls[0][1], /[?&]no_count=1/)
+		assert.doesNotMatch(calls[1][1], /no_count/)
+		assert.doesNotMatch(calls[2][1], /no_count/) // archive is the primary attempt — counts
+	})
+})

package/src/engine/downloader.js

@@ -1,8 +1,8 @@
 const { error: { catch_errors, wrap_errors: e } } = require('puffy-core')
 const repos_api = require('../api/repos')
 
-const download = (owner, repo, ref) => catch_errors(`Download ${owner}/${repo} failed`, async () => {
-	const [errors, data] = await repos_api.clone(owner, repo, ref)
+const download = (owner, repo, ref, options = {}) => catch_errors(`Download ${owner}/${repo} failed`, async () => {
+	const [errors, data] = await repos_api.clone(owner, repo, ref, options)
 	if (errors) throw e(`Failed to clone ${owner}/${repo}`, errors)
 	return data
 })

package/src/engine/installer.js

@@ -204,8 +204,11 @@ const install = (skill, options = {}) => catch_errors('Install failed', async ()
 				clone_ref = arch_result.ref
 				clone_commit = arch_result.commit
 			} else {
-				// Fall back to JSON clone
-				const [dl_errors, clone_data] = await download(owner, name, pkg.ref)
+				// Fall back to JSON clone. The archive attempt above already hit the
+				// clone endpoint (and counted the install), so mark this retry
+				// no_count to avoid double-counting one install (download_count +
+				// repo.clone). See repos.js clone handler.
+				const [dl_errors, clone_data] = await download(owner, name, pkg.ref, { no_count: true })
 				if (dl_errors) { spinner.fail(`Download failed: ${pkg.skill}`); throw e(`Download ${pkg.skill} failed`, dl_errors) }
 
 				const [ext_errors] = await extract(clone_data, pkg_tmp)