happyskills 1.16.3 → 1.18.0

package/src/validation/skill_json_rules.test.js

@@ -334,3 +334,133 @@ describe('validate_skill_json — systemDependencies', () => {
 		assert.strictEqual(check.severity, 'pass')
 	})
 })
+
+describe('validate_skill_json — config schema', () => {
+	it('errors when config is an array', async () => {
+		write_json(tmp, { name: 'my-skill', version: '1.0.0', config: [] })
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'config' && r.rule === 'type')
+		assert.strictEqual(check.severity, 'error')
+	})
+
+	it('errors when a config field has an unknown type', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			config: { channel: { type: 'colour', default: '#general' } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'config' && r.rule === 'type_value')
+		assert.strictEqual(check.severity, 'error')
+		assert.ok(check.message.includes('colour'))
+	})
+
+	it('errors when a config field omits type', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			config: { channel: { default: '#general' } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'config' && r.rule === 'type_value')
+		assert.strictEqual(check.severity, 'error')
+	})
+
+	it('errors when a config field required flag is non-boolean', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			config: { channel: { type: 'string', required: 'yes' } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'config' && r.rule === 'required_flag')
+		assert.strictEqual(check.severity, 'error')
+	})
+})
+
+describe('validate_skill_json — env schema', () => {
+	it('errors when env is an array', async () => {
+		write_json(tmp, { name: 'my-skill', version: '1.0.0', env: [] })
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'env' && r.rule === 'type')
+		assert.strictEqual(check.severity, 'error')
+	})
+
+	it('errors when required is non-boolean', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			env: { SLACK_BOT_TOKEN: { required: 'true', secret: true } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'env' && r.rule === 'required_flag')
+		assert.strictEqual(check.severity, 'error')
+	})
+
+	it('errors when secret is non-boolean', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			env: { SLACK_BOT_TOKEN: { required: true, secret: 'yes' } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'env' && r.rule === 'secret_flag')
+		assert.strictEqual(check.severity, 'error')
+	})
+
+	it('warns when a secret env var carries an inline default', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			env: { SLACK_BOT_TOKEN: { required: true, secret: true, default: 'xoxb-hardcoded' } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'env' && r.rule === 'secret_default')
+		assert.strictEqual(check.severity, 'warning')
+	})
+
+	it('errors when a validate regex does not compile', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			env: { DEPLOY_TIMEOUT: { type: 'integer', validate: '([0-9' } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'env' && r.rule === 'validate_regex')
+		assert.strictEqual(check.severity, 'error')
+	})
+
+	it('errors when two env vars differ only by case', async () => {
+		write_json(tmp, {
+			name: 'my-skill', version: '1.0.0',
+			env: { TOKEN: { required: true }, token: { required: false } }
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const check = data.results.find(r => r.field === 'env' && r.rule === 'case_collision')
+		assert.strictEqual(check.severity, 'error')
+	})
+})
+
+describe('validate_skill_json — well-formed config + env', () => {
+	it('emits no error or warning results for a well-formed config + env block', async () => {
+		write_json(tmp, {
+			name: 'slack-notify', version: '1.0.0',
+			config: {
+				channel: { type: 'string', default: '#general', description: 'Channel to post to' },
+				max_chars: { type: 'integer', default: 500, description: 'Truncate longer messages' }
+			},
+			env: {
+				SLACK_BOT_TOKEN: { required: true, secret: true, description: 'Slack bot token' },
+				DEPLOY_TIMEOUT: { required: false, secret: false, type: 'integer', default: 300, validate: '^[0-9]+$' }
+			}
+		})
+		const [err, data] = await validate_skill_json(tmp)
+		assert.ifError(err)
+		const config_env_problems = data.results.filter(r =>
+			(r.field === 'config' || r.field === 'env') && (r.severity === 'error' || r.severity === 'warning'))
+		assert.deepStrictEqual(config_env_problems, [])
+	})
+})