happyskills 0.9.0 → 0.9.1

package/CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [0.9.1] - 2026-03-10
+
+### Changed
+- Change `publish` to run full skill validation (SKILL.md + skill.json + cross-file rules) before publishing, blocking on errors with structured `VALIDATION_FAILED` output in JSON mode — replaces the previous ad-hoc manifest validation and frontmatter warnings
+
 ## [0.9.0] - 2026-03-10
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "happyskills",
-	"version": "0.9.0",
+	"version": "0.9.1",
 	"description": "Package manager for AI agent skills",
 	"license": "SEE LICENSE IN LICENSE",
 	"author": "Nicolas Dao <nic@cloudlesslabs.com> (https://cloudlesslabs.com)",

package/src/commands/publish.js

@@ -1,9 +1,7 @@
-const fs = require('fs')
 const path = require('path')
 const { error: { catch_errors, wrap_errors: e } } = require('puffy-core')
 const { read_manifest } = require('../manifest/reader')
 const { write_manifest } = require('../manifest/writer')
-const { validate_manifest } = require('../manifest/validator')
 const { require_token } = require('../auth/token_store')
 const repos_api = require('../api/repos')
 const workspaces_api = require('../api/workspaces')
@@ -15,11 +13,13 @@ const { find_project_root } = require('../config/paths')
 const { read_lock, get_all_locked_skills } = require('../lock/reader')
 const { write_lock, update_lock_skills } = require('../lock/writer')
 const { hash_directory } = require('../lock/integrity')
-const { parse_frontmatter } = require('../utils/skill_scanner')
+const { validate_skill_md } = require('../validation/skill_md_rules')
+const { validate_skill_json } = require('../validation/skill_json_rules')
+const { validate_cross } = require('../validation/cross_rules')
 const { create_spinner } = require('../ui/spinner')
 const { print_help, print_success, print_error, print_warn, print_hint, print_json, code } = require('../ui/output')
 const { exit_with_error, UsageError, CliError } = require('../utils/errors')
-const { EXIT_CODES, SKILL_MD } = require('../constants')
+const { EXIT_CODES } = require('../constants')
 
 const HELP_TEXT = `Usage: happyskills publish <skill-name> [options]
 
@@ -85,34 +85,39 @@ const run = (args) => catch_errors('Publish failed', async () => {
 		if (write_err) throw e('Failed to update manifest version', write_err)
 	}
 
-	const validation = validate_manifest(manifest)
-	if (!validation.valid) {
-		throw new CliError(`Invalid skill.json: ${validation.errors.join(', ')}`, EXIT_CODES.ERROR)
-	}
-
-	// Validate SKILL.md frontmatter — warn about missing name/description
-	const frontmatter_warnings = []
-	try {
-		const skill_md_content = await fs.promises.readFile(path.join(dir, SKILL_MD), 'utf-8')
-		const frontmatter = parse_frontmatter(skill_md_content)
-		if (!frontmatter) {
-			frontmatter_warnings.push('SKILL.md has no YAML frontmatter (---). Without frontmatter, Claude cannot auto-invoke this skill.')
-		} else {
-			if (!frontmatter.name) {
-				frontmatter_warnings.push('SKILL.md frontmatter is missing "name". Add name: <skill-name> to the frontmatter.')
-			}
-			if (!frontmatter.description) {
-				frontmatter_warnings.push('SKILL.md frontmatter is missing "description". The description is the #1 factor for Claude auto-invocation quality. Without it, the skill will not be auto-invoked.')
-			}
+	// Run full validation — block on errors, show warnings
+	const dir_name = path.basename(dir)
+	const [md_err, md_data] = await validate_skill_md(dir, dir_name)
+	if (md_err) throw md_err
+	const [json_err, json_data] = await validate_skill_json(dir)
+	if (json_err) throw json_err
+	const [cross_err, cross_results] = await validate_cross(dir, md_data.frontmatter, json_data.manifest, md_data.content)
+	if (cross_err) throw cross_err
+
+	const all_results = [...md_data.results, ...json_data.results, ...cross_results]
+	const validation_errors = all_results.filter(r => r.severity === 'error')
+	const validation_warnings = all_results.filter(r => r.severity === 'warning')
+
+	if (validation_errors.length > 0) {
+		const { is_json_mode } = require('../state')
+		if (is_json_mode()) {
+			const structured_errors = validation_errors.map(({ severity, ...rest }) => rest)
+			print_json({
+				error: {
+					code: 'VALIDATION_FAILED',
+					message: `Skill failed validation with ${validation_errors.length} error(s). Fix these issues and try again.`,
+					exit_code: EXIT_CODES.ERROR,
+					validation_errors: structured_errors
+				}
+			})
+			return process.exit(EXIT_CODES.ERROR)
 		}
-	} catch {
-		frontmatter_warnings.push(`No ${SKILL_MD} found. The skill may not work correctly.`)
+		const error_msgs = validation_errors.map(r => `${r.file || 'General'}${r.field ? ` (${r.field})` : ''}: ${r.message}`)
+		throw new CliError(`Skill failed validation with ${validation_errors.length} error(s):\n  ${error_msgs.join('\n  ')}\n\nRun \`happyskills validate ${skill_name}\` for full details.`, EXIT_CODES.ERROR)
 	}
 
-	if (frontmatter_warnings.length > 0) {
-		for (const warning of frontmatter_warnings) {
-			print_warn(warning)
-		}
+	for (const w of validation_warnings) {
+		print_warn(`${w.file || 'General'}${w.field ? ` (${w.field})` : ''}: ${w.message}`)
 	}
 
 	const spinner = create_spinner('Preparing to publish...')
@@ -199,7 +204,7 @@ const run = (args) => catch_errors('Publish failed', async () => {
 			commit: push_data?.commit || null,
 			bumped_from
 		}
-		if (frontmatter_warnings.length > 0) json_data.warnings = frontmatter_warnings
+		if (validation_warnings.length > 0) json_data.warnings = validation_warnings.map(w => w.message)
 		print_json({ data: json_data })
 		return
 	}