happyskills 0.46.0 → 0.46.1

package/CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [0.46.1] - 2026-05-20
+
+### Fixed
+- Fix `happyskills agents add` ignoring two categories of skills that should be mirrored into the newly added agent's folder: **kits** (skills with `type: kit` in the lock file — previously excluded by a copy-pasted "not agent-invocable" filter that conflated *invocation routing* with *filesystem presence*) and **locally-authored skills that were never published** (skills scaffolded via `happyskills init` and kept under source control but not pushed to the registry — they exist on disk in `.agents/skills/<name>/` but have no lock entry, so the lock-based enumeration missed them). The `add` subcommand now enumerates `.agents/skills/<name>/` directories directly, so anything physically present in the canonical location — regardless of whether it's lock-managed, a kit, or a private local-only skill — is symlinked into the new agent's folder.
+- Fix `happyskills agents remove` ignoring the same two categories — it previously read short names from the lock file, so a project containing kits or unpublished skills would leave dangling symlinks in the removed agent's folder. The subcommand now reads canonical names from `.agents/skills/<name>/` so every skill that could have been mirrored can also be unlinked.
+- Fix `happyskills agents list` undercounting the `Linked` column for the same reason — count is now against the canonical on-disk list so kits and unpublished skills are included.
+
 ## [0.46.0] - 2026-05-20
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "happyskills",
-	"version": "0.46.0",
+	"version": "0.46.1",
 	"description": "Package manager for AI agent skills",
 	"license": "SEE LICENSE IN LICENSE",
 	"author": "Nicolas Dao <nic@cloudlesslabs.com> (https://cloudlesslabs.com)",

package/src/commands/agents.js

@@ -11,7 +11,7 @@ const { find_project_root, lock_root, skills_dir, skill_install_dir, agent_skill
 const { print_help, print_json, print_success, print_warn, print_info, print_table, code } = require('../ui/output')
 const { green, dim } = require('../ui/colors')
 const { exit_with_error, UsageError } = require('../utils/errors')
-const { EXIT_CODES, SKILL_TYPES } = require('../constants')
+const { EXIT_CODES } = require('../constants')
 
 const HELP_TEXT = `Usage: happyskills agents <subcommand> [args] [options]
 
@@ -63,26 +63,70 @@ const _parse_agent_ids = (raw_args) => {
 }
 
 /**
- * For each installed skill, decide whether it should be mirrored into the
- * newly added agent. A skill is mirrored when it is currently enabled — i.e.,
- * a symlink for it exists in at least one *other* already-configured agent.
+ * Enumerate every skill physically present in the canonical .agents/skills/
+ * directory for the given scope. Covers all three categories of "skill that
+ * lives in this project":
+ *   1. Lock-managed skills (installed from the registry)
+ *   2. Kits (lock-managed or not — kits have a SKILL.md without frontmatter,
+ *      so a frontmatter-aware scan would miss them; we enumerate directories
+ *      directly to catch them)
+ *   3. Locally-authored skills that were created via `happyskills init` but
+ *      never published — they exist on disk but have no lock entry
  *
- * When no other agent folders exist yet (fresh project bootstrap), every
- * non-kit installed skill is mirrored.
+ * Returns short directory names (e.g. "deploy-aws"), not owner-qualified names.
+ */
+const _list_canonical_skill_names = async (is_global, project_root) => {
+	const base_dir = skills_dir(is_global, project_root)
+	try {
+		const entries = await fs.promises.readdir(base_dir, { withFileTypes: true })
+		return entries
+			.filter(e => (e.isDirectory() || e.isSymbolicLink()) && !e.name.startsWith('.'))
+			.map(e => e.name)
+	} catch {
+		return []
+	}
+}
+
+/**
+ * Build a short-name → display-name map from the lock file so on-disk skills
+ * that happen to be lock-managed are shown with their owner-qualified name.
+ * Skills not in the lock fall back to their short directory name.
+ */
+const _build_display_name_map = (lock_data) => {
+	const lock_skills = get_all_locked_skills(lock_data)
+	const map = new Map()
+	for (const full_name of Object.keys(lock_skills)) {
+		const short = full_name.split('/')[1] || full_name
+		map.set(short, full_name)
+	}
+	return map
+}
+
+/**
+ * For each skill physically present in the canonical .agents/skills/ directory,
+ * decide whether it should be mirrored into the newly added agent. A skill is
+ * mirrored when it is currently enabled — i.e., a symlink for it exists in at
+ * least one *other* already-configured agent.
+ *
+ * When no other agent folders exist yet (fresh project bootstrap), every skill
+ * present on disk is mirrored.
+ *
+ * Includes kits (which have SKILL.md without frontmatter — still need agent
+ * symlinks for filesystem parity) AND locally-authored skills that were never
+ * published (no lock entry, but legitimate project skills).
  */
 const _select_skills_to_mirror = async (lock_data, is_global, project_root, new_agent) => {
-	const all = get_all_locked_skills(lock_data)
-	const installed = Object.entries(all).filter(([, data]) => data && data.type !== SKILL_TYPES.KIT)
+	const display_names = _build_display_name_map(lock_data)
+	const candidates = await _list_canonical_skill_names(is_global, project_root)
 
-	// Find any *other* agents that are already configured in this scope
 	const [, all_detected] = await detect_agents({ global: is_global, project_root })
 	const other_detected = (all_detected || []).filter(a => a.id !== new_agent.id)
 
 	const selected = []
 	const skipped_disabled = []
 
-	for (const [full_name, data] of installed) {
-		const short = full_name.split('/')[1] || full_name
+	for (const short of candidates) {
+		const full_name = display_names.get(short) || short
 
 		if (other_detected.length === 0) {
 			selected.push({ full_name, short })
@@ -105,7 +149,6 @@ const _add = async (raw_args, args) => {
 	const base_dir = skills_dir(is_global, project_root)
 
 	const [, lock_data] = await read_lock(lock_root(is_global, project_root))
-	const has_lock = !!(lock_data && lock_data.skills && Object.keys(lock_data.skills).length > 0)
 
 	const per_agent = []
 
@@ -113,11 +156,6 @@ const _add = async (raw_args, args) => {
 		const target_root = agent_skills_dir(agent, is_global, project_root)
 		await fs.promises.mkdir(target_root, { recursive: true })
 
-		if (!has_lock) {
-			per_agent.push({ agent_id: agent.id, status: 'configured', linked: [], skipped_disabled: [] })
-			continue
-		}
-
 		const { selected, skipped_disabled } = await _select_skills_to_mirror(lock_data, is_global, project_root, agent)
 		const linked = []
 
@@ -160,9 +198,7 @@ const _remove = async (raw_args, args) => {
 	const project_root = find_project_root()
 	const is_json = args.flags.json || false
 
-	const [, lock_data] = await read_lock(lock_root(is_global, project_root))
-	const all = get_all_locked_skills(lock_data)
-	const short_names = Object.keys(all).map(k => k.split('/')[1] || k)
+	const short_names = await _list_canonical_skill_names(is_global, project_root)
 
 	const per_agent = []
 
@@ -235,9 +271,7 @@ const _list = async (args) => {
 	const [, detected] = await detect_agents({ global: is_global, project_root })
 	const detected_ids = new Set((detected || []).map(a => a.id))
 
-	const [, lock_data] = await read_lock(lock_root(is_global, project_root))
-	const all = get_all_locked_skills(lock_data)
-	const short_names = Object.keys(all).map(k => k.split('/')[1] || k)
+	const short_names = await _list_canonical_skill_names(is_global, project_root)
 
 	const rows = []
 	for (const agent of AGENTS) {