happyskills 0.4.3 → 0.4.4

package/CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [0.4.4] - 2026-03-05
+
+### Fixed
+- Fix all commands (`install`, `list`, `setup`, `update`, `uninstall`, `check`, `bump`, `convert`) inheriting skills from a parent directory; `find_project_root()` now always uses the current working directory and never walks up the directory tree
+
 ## [0.4.3] - 2026-03-05
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "happyskills",
-	"version": "0.4.3",
+	"version": "0.4.4",
 	"description": "Package manager for AI agent skills",
 	"license": "SEE LICENSE IN LICENSE",
 	"author": "Nicolas Dao <nic@cloudlesslabs.com> (https://cloudlesslabs.com)",

package/src/config/paths.js

@@ -34,30 +34,7 @@ const lock_file_path = (project_root = process.cwd()) => path.join(project_root,
 
 const skill_install_dir = (base_skills_dir, name) => path.join(base_skills_dir, name)
 
-const find_project_root = (start_dir = process.cwd()) => {
-	let dir = path.resolve(start_dir)
-	while (true) {
-		// Never treat the home directory as a project root —
-		// ~/.claude/skills is the global skills dir, not a project,
-		// and ~/skills-lock.json is an artifact of old buggy behaviour.
-		if (dir !== home_dir) {
-			const skills = path.join(dir, '.claude', 'skills')
-			const lock = path.join(dir, 'skills-lock.json')
-			try {
-				fs.statSync(skills)
-				return dir
-			} catch {}
-			try {
-				fs.statSync(lock)
-				return dir
-			} catch {}
-		}
-		const parent = path.dirname(dir)
-		if (parent === dir) break
-		dir = parent
-	}
-	return start_dir
-}
+const find_project_root = (start_dir = process.cwd()) => path.resolve(start_dir)
 
 module.exports = {
 	home_dir,

package/src/config/paths.test.js

@@ -100,77 +100,47 @@ describe('paths', () => {
 	})
 
 	describe('find_project_root', () => {
-		it('finds project root by .claude/skills dir', () => {
+		it('returns the given directory as-is', () => {
 			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
 			try {
-				fs.mkdirSync(path.join(tmp, '.claude', 'skills'), { recursive: true })
 				assert.strictEqual(paths.find_project_root(tmp), tmp)
 			} finally {
 				fs.rmSync(tmp, { recursive: true })
 			}
 		})
 
-		it('finds project root by skills-lock.json', () => {
-			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
-			try {
-				fs.writeFileSync(path.join(tmp, 'skills-lock.json'), '{}')
-				assert.strictEqual(paths.find_project_root(tmp), tmp)
-			} finally {
-				fs.rmSync(tmp, { recursive: true })
-			}
-		})
-
-		it('walks up to find project root from nested dir', () => {
+		it('does not walk up to a parent with .claude/skills', () => {
 			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
 			try {
 				fs.mkdirSync(path.join(tmp, '.claude', 'skills'), { recursive: true })
-				const sub = path.join(tmp, 'src', 'deep')
+				const sub = path.join(tmp, 'sub')
 				fs.mkdirSync(sub, { recursive: true })
-				assert.strictEqual(paths.find_project_root(sub), tmp)
+				// should return sub, not tmp
+				assert.strictEqual(paths.find_project_root(sub), sub)
 			} finally {
 				fs.rmSync(tmp, { recursive: true })
 			}
 		})
 
-		it('falls back to start_dir when no project markers found', () => {
+		it('does not walk up to a parent with skills-lock.json', () => {
 			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
 			try {
+				fs.writeFileSync(path.join(tmp, 'skills-lock.json'), '{}')
 				const sub = path.join(tmp, 'sub')
 				fs.mkdirSync(sub, { recursive: true })
+				// should return sub, not tmp
 				assert.strictEqual(paths.find_project_root(sub), sub)
 			} finally {
 				fs.rmSync(tmp, { recursive: true })
 			}
 		})
 
-		it('does not treat ~/.claude/skills as a project marker', () => {
-			const global_skills = path.join(os.homedir(), '.claude', 'skills')
-			let global_exists = false
-			try { fs.statSync(global_skills); global_exists = true } catch {}
-			if (!global_exists) return // skip if global dir not present on this machine
-
-			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
-			try {
-				// tmp has no project markers — should fall back to tmp, not home dir
-				assert.strictEqual(paths.find_project_root(tmp), tmp)
-			} finally {
-				fs.rmSync(tmp, { recursive: true })
-			}
+		it('returns home dir only when explicitly called with it', () => {
+			assert.strictEqual(paths.find_project_root(os.homedir()), os.homedir())
 		})
 
-		it('does not treat ~/skills-lock.json as a project marker', () => {
-			// The home directory itself must never be returned as project root,
-			// even if a stale skills-lock.json exists there from old buggy behaviour.
-			// We verify this by running from a temp dir that has no project markers
-			// of its own — the result must be the temp dir, not the home dir.
-			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
-			try {
-				const result = paths.find_project_root(tmp)
-				assert.notStrictEqual(result, os.homedir())
-				assert.strictEqual(result, tmp)
-			} finally {
-				fs.rmSync(tmp, { recursive: true })
-			}
+		it('defaults to cwd when no argument given', () => {
+			assert.strictEqual(paths.find_project_root(), path.resolve(process.cwd()))
 		})
 	})
 })