happyskills 0.4.0 → 0.4.3

package/CHANGELOG.md

@@ -7,6 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+## [0.4.3] - 2026-03-05
+
+### Fixed
+- Fix `find_project_root()` still treating the home directory as a project root via `~/skills-lock.json`; the home directory is now fully excluded from all project root detection checks
+
+## [0.4.2] - 2026-03-05
+
+### Fixed
+- Fix `list`, `install`, `uninstall`, `update`, `setup`, and `convert` incorrectly treating the home directory as a project root when `~/.claude/skills/` exists; `find_project_root()` now excludes the global skills directory from its upward search
+
+## [0.4.1] - 2026-03-05
+
+### Fixed
+- Fix `setup` command still installing globally on npm-published v0.4.0 (re-release of the project-level default and `-g` flag)
+
 ## [0.4.0] - 2026-03-05
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "happyskills",
-	"version": "0.4.0",
+	"version": "0.4.3",
 	"description": "Package manager for AI agent skills",
 	"license": "SEE LICENSE IN LICENSE",
 	"author": "Nicolas Dao <nic@cloudlesslabs.com> (https://cloudlesslabs.com)",

package/src/config/paths.js

@@ -37,16 +37,21 @@ const skill_install_dir = (base_skills_dir, name) => path.join(base_skills_dir,
 const find_project_root = (start_dir = process.cwd()) => {
 	let dir = path.resolve(start_dir)
 	while (true) {
-		const skills = path.join(dir, '.claude', 'skills')
-		const lock = path.join(dir, 'skills-lock.json')
-		try {
-			fs.statSync(skills)
-			return dir
-		} catch {}
-		try {
-			fs.statSync(lock)
-			return dir
-		} catch {}
+		// Never treat the home directory as a project root —
+		// ~/.claude/skills is the global skills dir, not a project,
+		// and ~/skills-lock.json is an artifact of old buggy behaviour.
+		if (dir !== home_dir) {
+			const skills = path.join(dir, '.claude', 'skills')
+			const lock = path.join(dir, 'skills-lock.json')
+			try {
+				fs.statSync(skills)
+				return dir
+			} catch {}
+			try {
+				fs.statSync(lock)
+				return dir
+			} catch {}
+		}
 		const parent = path.dirname(dir)
 		if (parent === dir) break
 		dir = parent

package/src/config/paths.test.js

@@ -1,5 +1,6 @@
 const { describe, it, beforeEach, afterEach } = require('node:test')
 const assert = require('node:assert')
+const fs = require('fs')
 const path = require('path')
 const os = require('os')
 
@@ -97,4 +98,79 @@ describe('paths', () => {
 			assert.strictEqual(result, path.join('/base/skills', '.install.lock'))
 		})
 	})
+
+	describe('find_project_root', () => {
+		it('finds project root by .claude/skills dir', () => {
+			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
+			try {
+				fs.mkdirSync(path.join(tmp, '.claude', 'skills'), { recursive: true })
+				assert.strictEqual(paths.find_project_root(tmp), tmp)
+			} finally {
+				fs.rmSync(tmp, { recursive: true })
+			}
+		})
+
+		it('finds project root by skills-lock.json', () => {
+			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
+			try {
+				fs.writeFileSync(path.join(tmp, 'skills-lock.json'), '{}')
+				assert.strictEqual(paths.find_project_root(tmp), tmp)
+			} finally {
+				fs.rmSync(tmp, { recursive: true })
+			}
+		})
+
+		it('walks up to find project root from nested dir', () => {
+			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
+			try {
+				fs.mkdirSync(path.join(tmp, '.claude', 'skills'), { recursive: true })
+				const sub = path.join(tmp, 'src', 'deep')
+				fs.mkdirSync(sub, { recursive: true })
+				assert.strictEqual(paths.find_project_root(sub), tmp)
+			} finally {
+				fs.rmSync(tmp, { recursive: true })
+			}
+		})
+
+		it('falls back to start_dir when no project markers found', () => {
+			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
+			try {
+				const sub = path.join(tmp, 'sub')
+				fs.mkdirSync(sub, { recursive: true })
+				assert.strictEqual(paths.find_project_root(sub), sub)
+			} finally {
+				fs.rmSync(tmp, { recursive: true })
+			}
+		})
+
+		it('does not treat ~/.claude/skills as a project marker', () => {
+			const global_skills = path.join(os.homedir(), '.claude', 'skills')
+			let global_exists = false
+			try { fs.statSync(global_skills); global_exists = true } catch {}
+			if (!global_exists) return // skip if global dir not present on this machine
+
+			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
+			try {
+				// tmp has no project markers — should fall back to tmp, not home dir
+				assert.strictEqual(paths.find_project_root(tmp), tmp)
+			} finally {
+				fs.rmSync(tmp, { recursive: true })
+			}
+		})
+
+		it('does not treat ~/skills-lock.json as a project marker', () => {
+			// The home directory itself must never be returned as project root,
+			// even if a stale skills-lock.json exists there from old buggy behaviour.
+			// We verify this by running from a temp dir that has no project markers
+			// of its own — the result must be the temp dir, not the home dir.
+			const tmp = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'hs-test-')))
+			try {
+				const result = paths.find_project_root(tmp)
+				assert.notStrictEqual(result, os.homedir())
+				assert.strictEqual(result, tmp)
+			} finally {
+				fs.rmSync(tmp, { recursive: true })
+			}
+		})
+	})
 })